128995 2014-02-18 14:04:55 -0800 Use std::swap() in HashTable::swap() 2014-02-19 11:50:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan benjamin cmarcelo commit-queue oldest_to_newest 982084 0 zan 2014-02-18 14:04:55 -0800 Use std::swap() in HashTable::swap() 982085 1 224544 zan 2014-02-18 14:05:51 -0800 Created attachment 224544 Patch 982459 2 224544 bfulgham 2014-02-19 11:19:55 -0800 Comment on attachment 224544 Patch It's nice to not reinvent the wheel! Thanks for catching this. Do we know if this gives any tiny microptimization based on the compiler being able to do moves instead of all of the copying? We probably don't measure enough to tell. 982463 3 zan 2014-02-19 11:29:27 -0800 Using Clang, Parser/HTML5-8266-ParseOnly.html runs about ~1% faster when using libc++ (not substantial, but measurable) and regresses slightly when using libstdc++. Haven't tested with GCC. 982478 4 224544 commit-queue 2014-02-19 11:50:15 -0800 Comment on attachment 224544 Patch Clearing flags on attachment: 224544 Committed r164378: <http://trac.webkit.org/changeset/164378> 982479 5 commit-queue 2014-02-19 11:50:17 -0800 All reviewed patches have been landed. Closing bug. 224544 2014-02-18 14:05:51 -0800 2014-02-19 11:50:15 -0800 Patch bug-128995-20140218230549.patch text/plain 2148 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJkYjQxYzMxYmI2OTE5OGFhMmZjMzM0 YTY1MjA5ODM2YmI1NWNhOTYuLjdlMjdmOGEyZjgyNGFmNjE2NmZjNjM1NDBiZjdkZGU2ZTk4Y2E0 YmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDItMTggIFphbiBEb2JlcnNlayAgPHpkb2Jl cnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFVzZSBzdGQ6OnN3YXAoKSBpbiBIYXNoVGFibGU6 OnN3YXAoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI4OTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIHN0ZDo6c3dhcCgpIHRvIHN3YXAgdGhlIG1lbWJlciB2YXJpYWJsZSB2YWx1ZXMgb2YgdHdv IEhhc2hUYWJsZSBvYmplY3RzIGluIEhhc2hUYWJsZTo6c3dhcCgpLgorCisgICAgICAgICogd3Rm L0hhc2hUYWJsZS5oOgorICAgICAgICAoV1RGOjpLZXlUcmFpdHM+Ojpzd2FwKToKKwogMjAxNC0w Mi0xOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtp T1NdIFdlYiBJbnNwZWN0b3I6IEpTQ29udGV4dCBpbnNwZWN0aW9uIGNyYXNoZXMgaW4gaXNNYWlu VGhyZWFkLCB1bmluaXRpYWxpemVkIFdlYkNvcmVXZWJUaHJlYWRJc0xvY2tlZE9yRGlzYWJsZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0hhc2hUYWJsZS5oIGIvU291cmNlL1dURi93dGYv SGFzaFRhYmxlLmgKaW5kZXggODUxOWFlMzY0N2I2YTg1ZjZmMDMxNmZlYWVkZTc2M2YxYzdmNGYz OC4uNWExN2UwZWQ4MWYwZjMzZDdhOWY1YWJmNGEwOTUyYWVmNmUxOGFmNiAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvSGFzaFRhYmxlLmgKKysrIGIvU291cmNlL1dURi93dGYvSGFzaFRhYmxl LmgKQEAgLTExNTUsMjUgKzExNTUsMTEgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIGludmFs aWRhdGVJdGVyYXRvcnMoKTsKICAgICAgICAgb3RoZXIuaW52YWxpZGF0ZUl0ZXJhdG9ycygpOwog Ci0gICAgICAgIFZhbHVlVHlwZSogdG1wX3RhYmxlID0gbV90YWJsZTsKLSAgICAgICAgbV90YWJs ZSA9IG90aGVyLm1fdGFibGU7Ci0gICAgICAgIG90aGVyLm1fdGFibGUgPSB0bXBfdGFibGU7Ci0K LSAgICAgICAgaW50IHRtcF90YWJsZVNpemUgPSBtX3RhYmxlU2l6ZTsKLSAgICAgICAgbV90YWJs ZVNpemUgPSBvdGhlci5tX3RhYmxlU2l6ZTsKLSAgICAgICAgb3RoZXIubV90YWJsZVNpemUgPSB0 bXBfdGFibGVTaXplOwotCi0gICAgICAgIGludCB0bXBfdGFibGVTaXplTWFzayA9IG1fdGFibGVT aXplTWFzazsKLSAgICAgICAgbV90YWJsZVNpemVNYXNrID0gb3RoZXIubV90YWJsZVNpemVNYXNr OwotICAgICAgICBvdGhlci5tX3RhYmxlU2l6ZU1hc2sgPSB0bXBfdGFibGVTaXplTWFzazsKLQot ICAgICAgICBpbnQgdG1wX2tleUNvdW50ID0gbV9rZXlDb3VudDsKLSAgICAgICAgbV9rZXlDb3Vu dCA9IG90aGVyLm1fa2V5Q291bnQ7Ci0gICAgICAgIG90aGVyLm1fa2V5Q291bnQgPSB0bXBfa2V5 Q291bnQ7Ci0KLSAgICAgICAgaW50IHRtcF9kZWxldGVkQ291bnQgPSBtX2RlbGV0ZWRDb3VudDsK LSAgICAgICAgbV9kZWxldGVkQ291bnQgPSBvdGhlci5tX2RlbGV0ZWRDb3VudDsKLSAgICAgICAg b3RoZXIubV9kZWxldGVkQ291bnQgPSB0bXBfZGVsZXRlZENvdW50OworICAgICAgICBzdGQ6OnN3 YXAobV90YWJsZSwgb3RoZXIubV90YWJsZSk7CisgICAgICAgIHN0ZDo6c3dhcChtX3RhYmxlU2l6 ZSwgb3RoZXIubV90YWJsZVNpemUpOworICAgICAgICBzdGQ6OnN3YXAobV90YWJsZVNpemVNYXNr LCBvdGhlci5tX3RhYmxlU2l6ZU1hc2spOworICAgICAgICBzdGQ6OnN3YXAobV9rZXlDb3VudCwg b3RoZXIubV9rZXlDb3VudCk7CisgICAgICAgIHN0ZDo6c3dhcChtX2RlbGV0ZWRDb3VudCwgb3Ro ZXIubV9kZWxldGVkQ291bnQpOwogCiAjaWYgRFVNUF9IQVNIVEFCTEVfU1RBVFNfUEVSX1RBQkxF CiAgICAgICAgIG1fc3RhdHMuc3dhcChvdGhlci5tX3N0YXRzKTsK