128992 2014-02-18 13:44:38 -0800 Enable the Selector Compiler on Windows 2023-10-22 16:02:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 127827 1 benjamin benjamin achristensen ahmad.saleem792 bfulgham cmarcelo commit-queue don.olmstead fujii ian.grunert webkit-bug-importer oldest_to_newest 982069 0 benjamin 2014-02-18 13:44:38 -0800 Enable the Selector Compiler on Windows 982071 1 224539 benjamin 2014-02-18 13:45:53 -0800 Created attachment 224539 Patch 982075 2 benjamin 2014-02-18 13:48:28 -0800 This is 100% untested :) You need to enable the JS JIT, but not DFG nor FTL. Can one of you give this a shot? 994350 3 bfulgham 2014-03-25 14:51:19 -0700 The 64-bit Windows JIT is not enabled at the moment. This bug is on hold until that happens. :-( 994355 4 benjamin 2014-03-25 14:56:39 -0700 (In reply to comment #3) > The 64-bit Windows JIT is not enabled at the moment. This bug is on hold until that happens. :-( Oh, not even the baseline JIT :( 1012002 5 achristensen 2014-05-27 10:01:19 -0700 I assume this is correct based on http://msdn.microsoft.com/en-us/library/6t169e9c.aspx I tested the css jit by applying https://bugs.webkit.org/show_bug.cgi?id=130638 and it *seemed* to work but I did not do rigorous enough testing to use enough registers for problems to arise. Is there a good way to test using a lot of registers in the css jit? 1012548 6 achristensen 2014-05-29 18:40:06 -0700 This patch needs to be updated to apply cleanly with the changes since February, but the registers are correct. Without this change, these tests crash: fast/selectors/case-insensitive-value-matching.html fast/selectors/querySelector-rightmost-child-chain-attribute-matching.html fast/selectors/querySelector-long-attribute-match-with-child-backtracking.html fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html fast/selectors/querySelector-long-multiple-attribute-match-with-child-backtracking.html fast/selectors/tree-modifying-case-insensitive-selectors.html fast/selectors/nth-child-with-backtracking.html fast/selectors/tree-modifying-selectors.html fast/selectors/querySelector-multiple-attribute-match-with-child-backtracking.html With this change all fast/selectors tests run without crashing. 1986714 7 ian.grunert 2023-10-21 16:56:17 -0700 Pull request: https://github.com/WebKit/WebKit/pull/19395 1986751 8 ews-feeder 2023-10-22 16:01:09 -0700 Committed 269638@main (ebfdd1c36b09): <https://commits.webkit.org/269638@main> Reviewed commits have been landed. Closing PR #19395 and removing active labels. 1986752 9 webkit-bug-importer 2023-10-22 16:02:16 -0700 <rdar://problem/117329024> 224539 2014-02-18 13:45:53 -0800 2014-02-18 13:46:08 -0800 Patch bug-128992-20140218134553.patch text/plain 3557 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MzA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJkYjQxYzMxYmI2OTE5OGFhMmZjMzM0 YTY1MjA5ODM2YmI1NWNhOTYuLjE2M2U0OTY3OWY5ZjU1YTg0MDI2YjdjMDc1MDYxMzY4ZGFhM2I3 NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDItMTggIEJlbmphbWluIFBvdWxhaW4gIDxi cG91bGFpbkBhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIHRoZSBTZWxlY3RvciBDb21waWxl ciBvbiBXaW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjg5OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDE0LTAyLTE4ICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gV2ViIEluc3BlY3RvcjogSlNDb250 ZXh0IGluc3BlY3Rpb24gY3Jhc2hlcyBpbiBpc01haW5UaHJlYWQsIHVuaW5pdGlhbGl6ZWQgV2Vi Q29yZVdlYlRocmVhZElzTG9ja2VkT3JEaXNhYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDgwNjkxZWMxMWEy OTcwYTUzNmFjOGY5ZmI5YzMwZmM0MTBlOGExNDIuLjZkZDA0MzNjZjU4OTY2NTE0OTQzNzE1YzYy YTQyMTkyMmZjOGZmYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNC0wMi0xOCAg QmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KKworICAgICAgICBFbmFibGUg dGhlIFNlbGVjdG9yIENvbXBpbGVyIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODk5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogY3Nzaml0L1JlZ2lzdGVyQWxsb2NhdG9yLmg6Cisg ICAgICAgIFdpbmRvd3MgaGFzIHdlaXJkIGNhbGxpbmcgY29udmVudGlvbnMuIFNldHVwIHRoZSBh cHByb3ByaWF0ZSByZWdpc3RlcnMuCisgICAgICAgIFRoZXJlIGFyZSBleHRyYSBjYWxsZXItc2F2 ZWQgcmVnaXN0ZXJzIG5vdCBsaXN0ZWQgaGVyZS4gSSB3aWxsIGFkZCB0aGVtIG9ubHkgaWYgbmVj ZXNzYXJ5LgorCiAyMDE0LTAyLTE4ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KIAogICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgVXNlckFjdGlvbkVsZW1lbnRTZXQgY29u c3RydWN0b3IsIGRlc3RydWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt LmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IGE2YjY2YWY2NmNlZThkMDI4YmU2 MjhkMmVmN2RiZDY4NzgyZDcxMTQuLmVhNzIyOGRiMWY0YTZkOWIwMDJlYzNkNjkyZGU1OTA4MTlh YjI5ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNl L1dURi93dGYvUGxhdGZvcm0uaApAQCAtODM3LDcgKzgzNyw3IEBACiAKIC8qIENTUyBTZWxlY3Rv ciBKSVQgQ29tcGlsZXIgKi8KICNpZiAhZGVmaW5lZChFTkFCTEVfQ1NTX1NFTEVDVE9SX0pJVCkK LSNpZiBDUFUoWDg2XzY0KSAmJiBFTkFCTEUoSklUKSAmJiBPUyhEQVJXSU4pICYmICFQTEFURk9S TShFRkwpICYmICFQTEFURk9STShHVEspCisjaWYgQ1BVKFg4Nl82NCkgJiYgRU5BQkxFKEpJVCkg JiYgKE9TKERBUldJTikgfHwgT1MoV0lORE9XUykpICYmICFQTEFURk9STShFRkwpICYmICFQTEFU Rk9STShHVEspCiAjZGVmaW5lIEVOQUJMRV9DU1NfU0VMRUNUT1JfSklUIDEKICNlbHNlCiAjZGVm aW5lIEVOQUJMRV9DU1NfU0VMRUNUT1JfSklUIDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2Nzc2ppdC9SZWdpc3RlckFsbG9jYXRvci5oIGIvU291cmNlL1dlYkNvcmUvY3Nzaml0L1JlZ2lz dGVyQWxsb2NhdG9yLmgKaW5kZXggMTJlYzY3NGJkMGYxMjdjMWI3N2JjY2E2ZjMzZWJmZDY2NWE0 MTY4NC4uOGRiNGNjMzU5NzVlMmQ3OTVjMTUyMGRmYjJlN2U1NDBmYjRhNWZlNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3Nzaml0L1JlZ2lzdGVyQWxsb2NhdG9yLmgKKysrIGIvU291cmNl L1dlYkNvcmUvY3Nzaml0L1JlZ2lzdGVyQWxsb2NhdG9yLmgKQEAgLTM2LDYgKzM2LDcgQEAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogI2lmIENQVShYODZfNjQpCisjaWYgIU9TKFdJTkRPV1MpCiBz dGF0aWMgY29uc3QgSlNDOjpNYWNyb0Fzc2VtYmxlcjo6UmVnaXN0ZXJJRCBjYWxsZXJTYXZlZFJl Z2lzdGVyc1tdID0gewogICAgIEpTQzo6WDg2UmVnaXN0ZXJzOjplYXgsCiAgICAgSlNDOjpYODZS ZWdpc3RlcnM6OmVjeCwKQEAgLTUyLDEwICs1MywyOSBAQCBzdGF0aWMgY29uc3QgSlNDOjpNYWNy b0Fzc2VtYmxlcjo6UmVnaXN0ZXJJRCBjYWxsZWVTYXZlZFJlZ2lzdGVyc1tdID0gewogICAgIEpT Qzo6WDg2UmVnaXN0ZXJzOjpyMTQsCiAgICAgSlNDOjpYODZSZWdpc3RlcnM6OnIxNQogfTsKLXN0 YXRpYyBjb25zdCB1bnNpZ25lZCByZWdpc3RlckNvdW50ID0gV1RGX0FSUkFZX0xFTkdUSChjYWxs ZXJTYXZlZFJlZ2lzdGVycykgKyBXVEZfQVJSQVlfTEVOR1RIKGNhbGxlZVNhdmVkUmVnaXN0ZXJz KTsKKyNlbHNlCitzdGF0aWMgY29uc3QgSlNDOjpNYWNyb0Fzc2VtYmxlcjo6UmVnaXN0ZXJJRCBj YWxsZXJTYXZlZFJlZ2lzdGVyc1tdID0geworICAgIEpTQzo6WDg2UmVnaXN0ZXJzOjplYXgsCisg ICAgSlNDOjpYODZSZWdpc3RlcnM6OmVjeCwKKyAgICBKU0M6Olg4NlJlZ2lzdGVyczo6ZWR4LAor ICAgIEpTQzo6WDg2UmVnaXN0ZXJzOjpyOCwKKyAgICBKU0M6Olg4NlJlZ2lzdGVyczo6cjksCisg ICAgSlNDOjpYODZSZWdpc3RlcnM6OnIxMCwKKyAgICBKU0M6Olg4NlJlZ2lzdGVyczo6cjExCit9 Oworc3RhdGljIGNvbnN0IEpTQzo6TWFjcm9Bc3NlbWJsZXI6OlJlZ2lzdGVySUQgY2FsbGVlU2F2 ZWRSZWdpc3RlcnNbXSA9IHsKKyAgICBKU0M6Olg4NlJlZ2lzdGVyczo6ZWRpLAorICAgIEpTQzo6 WDg2UmVnaXN0ZXJzOjpyMTIsCisgICAgSlNDOjpYODZSZWdpc3RlcnM6OnIxMywKKyAgICBKU0M6 Olg4NlJlZ2lzdGVyczo6cjE0LAorICAgIEpTQzo6WDg2UmVnaXN0ZXJzOjpyMTUKK307CisjZW5k aWYKKwogI2Vsc2UKICNlcnJvciBSZWdpc3RlckFsbG9jYXRvciBoYXMgbm8gZGVmaW5lZCByZWdp c3RlcnMgZm9yIHRoZSBhcmNoaXRlY3R1cmUuCiAjZW5kaWYKK3N0YXRpYyBjb25zdCB1bnNpZ25l ZCByZWdpc3RlckNvdW50ID0gV1RGX0FSUkFZX0xFTkdUSChjYWxsZXJTYXZlZFJlZ2lzdGVycykg KyBXVEZfQVJSQVlfTEVOR1RIKGNhbGxlZVNhdmVkUmVnaXN0ZXJzKTsKIAogY2xhc3MgUmVnaXN0 ZXJBbGxvY2F0b3IgewogcHVibGljOgo=