128991 2014-02-18 13:23:05 -0800 Rename RenderBlockFlow::clearFloats and RenderBlockFlow::newLine to be more accurate 2014-02-20 11:35:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bjonesbe bjonesbe commit-queue d-r esprehn+autocc fmalita glenn gyuyoung.kim kondapallykalyan pdr schenney sergio oldest_to_newest 982062 0 bjonesbe 2014-02-18 13:23:05 -0800 Rename RenderBlockFlow::clearFloats and RenderBlockFlow::newLine to be more accurate 982063 1 224538 bjonesbe 2014-02-18 13:28:02 -0800 Created attachment 224538 Patch 982905 2 224538 hyatt 2014-02-20 11:27:31 -0800 Comment on attachment 224538 Patch r=me 982912 3 224538 commit-queue 2014-02-20 11:35:21 -0800 Comment on attachment 224538 Patch Clearing flags on attachment: 224538 Committed r164440: <http://trac.webkit.org/changeset/164440> 982913 4 commit-queue 2014-02-20 11:35:24 -0800 All reviewed patches have been landed. Closing bug. 224538 2014-02-18 13:28:02 -0800 2014-02-20 11:35:20 -0800 Patch bug-128991-20140218132801.patch text/plain 7292 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmExZDBlZTI4MGFmNDM3 NGRjNTk2ZmIzZmE2MDEzN2JiN2QxMzUxMS4uNmEwMGYxZWUyMmI3NDljNWVlNmNiZjNkZGM1ZGFl YmNmZjM4OWYxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDE0LTAyLTE4ICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFJlbmFtZSBSZW5kZXJC bG9ja0Zsb3c6OmNsZWFyRmxvYXRzIGFuZCBSZW5kZXJCbG9ja0Zsb3c6Om5ld0xpbmUgdG8gYmUg bW9yZSBhY2N1cmF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI4OTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVuYW1lIGNsZWFyRmxvYXRzIHRvIHJlYnVpbGRGbG9hdGluZ09iamVjdFNldEZyb21J bnRydWRpbmdGbG9hdHMKKyAgICAgICAgc2luY2UgaXQgZG9lcyBqdXN0IHRoYXQuCisKKyAgICAg ICAgUmVuYW1lIG5ld0xpbmUgdG8gY2xlYXJGbG9hdHMgYmVjYXVzZSBpdCBhY3R1YWxseSBkb2Vz IHdoYXQgdGhlIENTUworICAgICAgICBzcGVjIGNhbGxzIGNsZWFyaW5nIGZsb2F0cy4gVGhpcyBh bHNvIG1hdGNoZXMgY2xlYXJGbG9hdHNJZk5lZWRlZC4KKworICAgICAgICBUaGlzIGFsc28gcmVt b3ZlcyBhIEZJWE1FIGNvbW1lbnQgdGhhdCBwb2ludHMgdG8gYSBidWcgdGhhdCBoYXMKKyAgICAg ICAgYWxyZWFkeSBiZWVuIGZpeGVkLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaXMgYmFzZWQgb24g YSBCbGluayBwYXRjaCBieSBsZXZpdzoKKyAgICAgICAgaHR0cHM6Ly9zcmMuY2hyb21pdW0ub3Jn L3ZpZXd2Yy9ibGluaz9yZXZpc2lvbj0xNTg1OTgmdmlldz1yZXZpc2lvbgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckJsb2NrRmxvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OnJl YnVpbGRGbG9hdGluZ09iamVjdFNldEZyb21JbnRydWRpbmdGbG9hdHMpOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyQmxvY2tGbG93OjpsYXlvdXRCbG9jayk6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJCbG9ja0Zsb3c6OmNsZWFyRmxvYXRzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy QmxvY2tGbG93Lmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OmxheW91dFJ1bnNBbmRGbG9h dHMpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93OjpsYXlvdXRSdW5zQW5kRmxv YXRzSW5SYW5nZSk6CisgICAgICAgICogcmVuZGVyaW5nL2xpbmUvQnJlYWtpbmdDb250ZXh0SW5s aW5lSGVhZGVycy5oOgorICAgICAgICAoV2ViQ29yZTo6QnJlYWtpbmdDb250ZXh0OjpoYW5kbGVG bG9hdCk6CisgICAgICAgICogcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdUZXh0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclNWR1RleHQ6OmxheW91dCk6CisKIDIwMTQtMDItMTggIE15bGVz IEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBDb252ZXJ0IHBv c2l0aW9uOnN0aWNreSB0byBwb3NpdGlvbjpzdGF0aWMgdXBvbiBjb3B5IGFuZCBwYXN0ZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcAppbmRleCBhMGU3NDY4 NzJjY2NkNjU3NDEzOTEwMzczZjQ4MDJlZDQyZGViZThjLi42YzNjMzE0YjBiY2ZlYjlhODEwNjVm YjE5Yjc5ZDUzOGY4YThhODQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2tGbG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QmxvY2tGbG93LmNwcApAQCAtMjAzLDcgKzIwMyw3IEBAIHZvaWQgUmVuZGVyQmxvY2tGbG93Ojp3 aWxsQmVEZXN0cm95ZWQoKQogICAgIFJlbmRlckJveDo6d2lsbEJlRGVzdHJveWVkKCk7CiB9CiAK LXZvaWQgUmVuZGVyQmxvY2tGbG93OjpjbGVhckZsb2F0cygpCit2b2lkIFJlbmRlckJsb2NrRmxv dzo6cmVidWlsZEZsb2F0aW5nT2JqZWN0U2V0RnJvbUludHJ1ZGluZ0Zsb2F0cygpCiB7CiAgICAg aWYgKG1fZmxvYXRpbmdPYmplY3RzKQogICAgICAgICBtX2Zsb2F0aW5nT2JqZWN0cy0+c2V0SG9y aXpvbnRhbFdyaXRpbmdNb2RlKGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpOwpAQCAtMzUxLDcg KzM1MSw3IEBAIHZvaWQgUmVuZGVyQmxvY2tGbG93OjpsYXlvdXRCbG9jayhib29sIHJlbGF5b3V0 Q2hpbGRyZW4sIExheW91dFVuaXQgcGFnZUxvZ2ljYWxICiAgICAgaWYgKHVwZGF0ZUxvZ2ljYWxX aWR0aEFuZENvbHVtbldpZHRoKCkpCiAgICAgICAgIHJlbGF5b3V0Q2hpbGRyZW4gPSB0cnVlOwog Ci0gICAgY2xlYXJGbG9hdHMoKTsKKyAgICByZWJ1aWxkRmxvYXRpbmdPYmplY3RTZXRGcm9tSW50 cnVkaW5nRmxvYXRzKCk7CiAKICAgICBMYXlvdXRVbml0IHByZXZpb3VzSGVpZ2h0ID0gbG9naWNh bEhlaWdodCgpOwogICAgIC8vIEZJWE1FOiBzaG91bGQgdGhpcyBzdGFydCBvdXQgYXMgYm9yZGVy QW5kUGFkZGluZ0xvZ2ljYWxIZWlnaHQoKSArIHNjcm9sbGJhckxvZ2ljYWxIZWlnaHQoKSwKQEAg LTIzNTEsNyArMjM1MSw3IEBAIGJvb2wgUmVuZGVyQmxvY2tGbG93Ojpwb3NpdGlvbk5ld0Zsb2F0 cygpCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKLXZvaWQgUmVuZGVyQmxvY2tGbG93OjpuZXdMaW5l KEVDbGVhciBjbGVhcikKK3ZvaWQgUmVuZGVyQmxvY2tGbG93OjpjbGVhckZsb2F0cyhFQ2xlYXIg Y2xlYXIpCiB7CiAgICAgcG9zaXRpb25OZXdGbG9hdHMoKTsKICAgICAvLyBzZXQgeSBwb3NpdGlv bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5o IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5oCmluZGV4IDMzYjkw ZDNhOGRkMDM4YjgwNjE1N2NmMWRmNzJiN2Q5YzZjMDdlYjQuLmQ1NDQ4Y2FjYTBlYWRjNjU1OWM2 MTk1YjI3M2I4OWYzN2U5YzFmZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9ja0Zsb3cuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QmxvY2tGbG93LmgKQEAgLTY3LDcgKzY3LDcgQEAgcHJvdGVjdGVkOgogICAgIC8vIHJlcG9wdWxh dGVzIHRoZSBsaXN0IHdpdGggYW55IGZsb2F0cyB0aGF0IGludHJ1ZGUgZnJvbSBwcmV2aW91cyBz aWJsaW5ncyBvciBwYXJlbnRzLiBGbG9hdHMgdGhhdCB3ZXJlIGFkZGVkIGJ5CiAgICAgLy8gZGVz Y2VuZGFudHMgYXJlIGdvbmUgd2hlbiB0aGlzIGNhbGwgY29tcGxldGVzIGFuZCB3aWxsIGdldCBh ZGRlZCBiYWNrIGxhdGVyIG9uIGFmdGVyIHRoZSBjaGlsZHJlbiBoYXZlIGdvdHRlbgogICAgIC8v IGEgcmVsYXlvdXQuCi0gICAgdm9pZCBjbGVhckZsb2F0cygpOworICAgIHZvaWQgcmVidWlsZEZs b2F0aW5nT2JqZWN0U2V0RnJvbUludHJ1ZGluZ0Zsb2F0cygpOwogCiAgICAgLy8gUmVuZGVyQmxv Y2tGbG93IGFsd2F5cyBjb250YWlucyBlaXRoZXIgbGluZXMgb3IgcGFyYWdyYXBocy4gV2hlbiB0 aGUgY2hpbGRyZW4gYXJlIGFsbCBibG9ja3MgKGUuZy4gcGFyYWdyYXBocyksIHdlIGNhbGwgbGF5 b3V0QmxvY2tDaGlsZHJlbi4KICAgICAvLyBXaGVuIHRoZSBjaGlsZHJlbiBhcmUgYXJlIGFsbCBp bmxpbmUgKGUuZy4sIGxpbmVzKSwgd2UgY2FsbCBsYXlvdXRJbmxpbmVDaGlsZHJlbi4KQEAgLTQ2 OCw3ICs0NjgsNyBAQCBwcml2YXRlOgogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiBhbmQgb25seSBp ZiBpdCBoYXMgcG9zaXRpb25lZCBhbnkgZmxvYXRzLgogICAgIGJvb2wgcG9zaXRpb25OZXdGbG9h dHMoKTsKIAotICAgIHZvaWQgbmV3TGluZShFQ2xlYXIpOworICAgIHZvaWQgY2xlYXJGbG9hdHMo RUNsZWFyKTsKIAogICAgIHZpcnR1YWwgTGF5b3V0VW5pdCBsb2dpY2FsUmlnaHRGbG9hdE9mZnNl dEZvckxpbmUoTGF5b3V0VW5pdCBsb2dpY2FsVG9wLCBMYXlvdXRVbml0IGZpeGVkT2Zmc2V0LCBM YXlvdXRVbml0IGxvZ2ljYWxIZWlnaHQpIGNvbnN0IG92ZXJyaWRlOwogICAgIHZpcnR1YWwgTGF5 b3V0VW5pdCBsb2dpY2FsTGVmdEZsb2F0T2Zmc2V0Rm9yTGluZShMYXlvdXRVbml0IGxvZ2ljYWxU b3AsIExheW91dFVuaXQgZml4ZWRPZmZzZXQsIExheW91dFVuaXQgbG9naWNhbEhlaWdodCkgY29u c3Qgb3ZlcnJpZGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QmxvY2tMaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j a0xpbmVMYXlvdXQuY3BwCmluZGV4IDY5YWM1NTNmMDg0ZmRmZTkzNzgxYzhlYzBkZDgzNDYwMGI4 ZTk0NzIuLjhlZGFjZmJkN2Y5Y2JjMGY2NGZjN2E3YTliZmExMTM3OTVmMzk2MzQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCkBA IC0xMDg1LDcgKzEwODUsNyBAQCB2b2lkIFJlbmRlckJsb2NrRmxvdzo6bGF5b3V0UnVuc0FuZEZs b2F0cyhMaW5lTGF5b3V0U3RhdGUmIGxheW91dFN0YXRlLCBib29sIGhhcwogICAgICAgICAgICAg aWYgKGxhc3RPYmplY3QtPmlzQlIoKSkgewogICAgICAgICAgICAgICAgIEVDbGVhciBjbGVhciA9 IGxhc3RPYmplY3QtPnN0eWxlKCkuY2xlYXIoKTsKICAgICAgICAgICAgICAgICBpZiAoY2xlYXIg IT0gQ05PTkUpCi0gICAgICAgICAgICAgICAgICAgIG5ld0xpbmUoY2xlYXIpOworICAgICAgICAg ICAgICAgICAgICBjbGVhckZsb2F0cyhjbGVhcik7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0K ICAgICB9CkBAIC0xNDIxLDcgKzE0MjEsNyBAQCB2b2lkIFJlbmRlckJsb2NrRmxvdzo6bGF5b3V0 UnVuc0FuZEZsb2F0c0luUmFuZ2UoTGluZUxheW91dFN0YXRlJiBsYXlvdXRTdGF0ZSwgSQogCiAg ICAgICAgIGlmICghbGF5b3V0U3RhdGUubGluZUluZm8oKS5pc0VtcHR5KCkpIHsKICAgICAgICAg ICAgIGxheW91dFN0YXRlLmxpbmVJbmZvKCkuc2V0Rmlyc3RMaW5lKGZhbHNlKTsKLSAgICAgICAg ICAgIG5ld0xpbmUobGluZUJyZWFrZXIuY2xlYXIoKSk7CisgICAgICAgICAgICBjbGVhckZsb2F0 cyhsaW5lQnJlYWtlci5jbGVhcigpKTsKICAgICAgICAgfQogCiAgICAgICAgIGlmIChtX2Zsb2F0 aW5nT2JqZWN0cyAmJiBsYXN0Um9vdEJveCgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvbGluZS9CcmVha2luZ0NvbnRleHRJbmxpbmVIZWFkZXJzLmggYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvbGluZS9CcmVha2luZ0NvbnRleHRJbmxpbmVIZWFkZXJzLmgKaW5k ZXggNzJhMTkyZDJhOGJiMTExODRhNDgyYmJlZWYxNjk2NzVjOTUzZTg3Ny4uNTg2ZDJkZjNkYWM2 ZDAzOTY3NDgxY2JmMzg3ZjVkNzBjMmE2NjU3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL2xpbmUvQnJlYWtpbmdDb250ZXh0SW5saW5lSGVhZGVycy5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9saW5lL0JyZWFraW5nQ29udGV4dElubGluZUhlYWRlcnMuaApA QCAtMzQxLDggKzM0MSw3IEBAIGlubGluZSB2b2lkIEJyZWFraW5nQ29udGV4dDo6aGFuZGxlRmxv YXQoKQogICAgIEZsb2F0aW5nT2JqZWN0KiBmbG9hdGluZ09iamVjdCA9IG1fbGluZUJyZWFrZXIu aW5zZXJ0RmxvYXRpbmdPYmplY3QoZmxvYXRCb3gpOwogICAgIC8vIGNoZWNrIGlmIGl0IGZpdHMg aW4gdGhlIGN1cnJlbnQgbGluZS4KICAgICAvLyBJZiBpdCBkb2VzLCBwb3NpdGlvbiBpdCBub3cs IG90aGVyd2lzZSwgcG9zaXRpb24KLSAgICAvLyBpdCBhZnRlciBtb3ZpbmcgdG8gbmV4dCBsaW5l IChpbiBuZXdMaW5lKCkgZnVuYykKLSAgICAvLyBGSVhNRTogQnVnIDExMDM3MjogUHJvcGVybHkg cG9zaXRpb24gbXVsdGlwbGUgc3RhY2tlZCBmbG9hdHMgd2l0aCBub24tcmVjdGFuZ3VsYXIgc2hh cGUgb3V0c2lkZS4KKyAgICAvLyBpdCBhZnRlciBtb3ZpbmcgdG8gbmV4dCBsaW5lIChpbiBjbGVh ckZsb2F0cygpIGZ1bmMpCiAgICAgaWYgKG1fZmxvYXRzRml0T25MaW5lICYmIG1fd2lkdGguZml0 c09uTGluZUV4Y2x1ZGluZ1RyYWlsaW5nV2hpdGVzcGFjZShtX2Jsb2NrLmxvZ2ljYWxXaWR0aEZv ckZsb2F0KGZsb2F0aW5nT2JqZWN0KSkpIHsKICAgICAgICAgbV9saW5lQnJlYWtlci5wb3NpdGlv bk5ld0Zsb2F0T25MaW5lKGZsb2F0aW5nT2JqZWN0LCBtX2xhc3RGbG9hdEZyb21QcmV2aW91c0xp bmUsIG1fbGluZUluZm8sIG1fd2lkdGgpOwogICAgICAgICBpZiAobV9saW5lQnJlYWsucmVuZGVy ZXIoKSA9PSBtX2N1cnJlbnQucmVuZGVyZXIoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdUZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zdmcvUmVuZGVyU1ZHVGV4dC5jcHAKaW5kZXggMjQyMDZiMWRiZDFkMzJhNTk2ZjZlYWM1 NGRmOWQ1ZjQ3MDk3YjY2Ni4uN2JmMGRiMTI1YzRiMDZjZjIzNmJhNjE5YTg5NjdlMTJhOTA5N2Yy ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdUZXh0 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1RleHQuY3Bw CkBAIC00MTEsNyArNDExLDcgQEAgdm9pZCBSZW5kZXJTVkdUZXh0OjpsYXlvdXQoKQogICAgIEFT U0VSVChjaGlsZHJlbklubGluZSgpKTsKICAgICBMYXlvdXRVbml0IHJlcGFpbnRMb2dpY2FsVG9w ID0gMDsKICAgICBMYXlvdXRVbml0IHJlcGFpbnRMb2dpY2FsQm90dG9tID0gMDsKLSAgICBjbGVh ckZsb2F0cygpOworICAgIHJlYnVpbGRGbG9hdGluZ09iamVjdFNldEZyb21JbnRydWRpbmdGbG9h dHMoKTsKICAgICBsYXlvdXRJbmxpbmVDaGlsZHJlbih0cnVlLCByZXBhaW50TG9naWNhbFRvcCwg cmVwYWludExvZ2ljYWxCb3R0b20pOwogCiAgICAgaWYgKG1fbmVlZHNSZW9yZGVyaW5nKQo=