128986 2014-02-18 11:37:14 -0800 AX: Searching for "immediate descendants only" can return unexpected results. 2014-02-18 14:34:33 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac (Intel) OS X 10.9 RESOLVED FIXED InRadar P2 Normal --- 1 samuel_white samuel_white aboxhall apinheiro cfleizach commit-queue dmazzoni eric.carlson glenn jcraig jdiggs jer.noble mario philipj sergio webkit-bug-importer oldest_to_newest 982016 0 samuel_white 2014-02-18 11:37:14 -0800 Distant descendant results are occasionally sneaking in. We are missing an application of the immediateDescendantsOnly flag during our DFS. 982018 1 webkit-bug-importer 2014-02-18 11:37:52 -0800 <rdar://problem/16100054> 982019 2 webkit-bug-importer 2014-02-18 11:37:53 -0800 <rdar://problem/16100055> 982020 3 samuel_white 2014-02-18 11:38:53 -0800 We should also update the test to ensure fast search results match traditional children results (when appropriate). 982021 4 webkit-bug-importer 2014-02-18 11:39:16 -0800 <rdar://problem/16100081> 982027 5 224529 samuel_white 2014-02-18 11:50:08 -0800 Created attachment 224529 Patch. 982061 6 224529 cfleizach 2014-02-18 13:23:01 -0800 Comment on attachment 224529 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=224529&action=review > Source/WebCore/ChangeLog:8 > + Missed an application of the immediateDescendantsOnly during the initial implementation. what was the application that was missed? 982079 7 224542 samuel_white 2014-02-18 13:51:59 -0800 Created attachment 224542 Updated patch. Updated the commit message to better address your question. Marking for review as the previous patch passed without issue (only ChangeLog changes here). Thanks for looking Chris. 982119 8 224542 commit-queue 2014-02-18 14:34:31 -0800 Comment on attachment 224542 Updated patch. Clearing flags on attachment: 224542 Committed r164321: <http://trac.webkit.org/changeset/164321> 982120 9 commit-queue 2014-02-18 14:34:33 -0800 All reviewed patches have been landed. Closing bug. 224529 2014-02-18 11:50:08 -0800 2014-02-18 13:51:59 -0800 Patch. search.patch text/plain 5724 samuel_white ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlYXJj aC1wcmVkaWNhdGUtaW1tZWRpYXRlLWRlc2NlbmRhbnRzLW9ubHktZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXByZWRpY2F0ZS1pbW1l ZGlhdGUtZGVzY2VuZGFudHMtb25seS1leHBlY3RlZC50eHQKaW5kZXggYmE2MWExYS4uMjlmZGI1 MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2Vh cmNoLXByZWRpY2F0ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXByZWRpY2F0 ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS1leHBlY3RlZC50eHQKQEAgLTMsOCArMyw5IEBA IFRoaXMgdGVzdHMgdGhhdCBzZWFyY2ggcHJlZGljYXRlIGltbWVkaWF0ZSBkZXNjZW5kYW50IG9u bHkgcmVzdWx0cyBhcmUgYWNjdXJhdGUuCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCiAKIAot UEFTUyBhbGxEZXNjZW5kYW50c0NvdW50IGlzIDYKLVBBU1MgaW1tZWRpYXRlRGVzY2VuZGFudHND b3VudCBpcyAzCitQQVNTIGFsbERlc2NlbmRhbnRzQ291bnQgaXMgMjUKK1BBU1MgaW1tZWRpYXRl RGVzY2VuZGFudHNDb3VudCBpcyA2CitQQVNTIGltbWVkaWF0ZURlc2NlbmRhbnRzQ291bnQgaXMg Y2hpbGRyZW5Db3VudAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENP TVBMRVRFCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0 eS9zZWFyY2gtcHJlZGljYXRlLWltbWVkaWF0ZS1kZXNjZW5kYW50cy1vbmx5Lmh0bWwgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9zZWFyY2gtcHJlZGljYXRlLWltbWVk aWF0ZS1kZXNjZW5kYW50cy1vbmx5Lmh0bWwKaW5kZXggMmRiY2YzYi4uYmEwNDQyYSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXByZWRp Y2F0ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS5odG1sCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlYXJjaC1wcmVkaWNhdGUtaW1tZWRpYXRlLWRlc2Nl bmRhbnRzLW9ubHkuaHRtbApAQCAtNyw5ICs3LDkgQEAKIDxib2R5PgogCiA8ZGl2IGlkPSJjb250 YWluZXIiPgotPHVsPjxsaT5pbW1lZGlhdGUgZGVzY2VuZGFudDwvbGk+PGxpPjx1bD48bGk+ZGlz dGFudCBkZXNjZW5kYW50PC9saT48L3VsPjwvbGk+PC91bD4KLTx1bD48bGk+aW1tZWRpYXRlIGRl c2NlbmRhbnQ8L2xpPjxsaT48dWw+PGxpPmRpc3RhbnQgZGVzY2VuZGFudDwvbGk+PC91bD48L2xp PjwvdWw+Ci08dWw+PGxpPmltbWVkaWF0ZSBkZXNjZW5kYW50PC9saT48bGk+PHVsPjxsaT5kaXN0 YW50IGRlc2NlbmRhbnQ8L2xpPjwvdWw+PC9saT48L3VsPgorPGgxPmhlYWRpbmc8aW1nIHNyYz0i cmVzb3VyY2VzL2Nha2UucG5nIiBhbHQ9IkNha2UiPjwvaDE+Cis8cD50ZXh0IDxhIGhyZWY9IiMi Pmxpbms8L2E+PC9wPgorPHVsPjxsaT5pdGVtPC9saT48bGk+PHVsPjxsaT5zdWJpdGVtPC9saT48 L3VsPjwvbGk+PC91bD4KIDwvZGl2PgogCiA8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KQEAgLTIz LDEyICsyMywxNiBAQAogICAgICAgICB2YXIgY29udGFpbmVyRWxlbWVudCA9IGFjY2Vzc2liaWxp dHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50OwogICAgICAgICAKICAgICAgICAgLy8gQWxsIGRl c2NlbmRhbnRzLgotICAgICAgICB2YXIgYWxsRGVzY2VuZGFudHNDb3VudCA9IGNvbnRhaW5lckVs ZW1lbnQudWlFbGVtZW50Q291bnRGb3JTZWFyY2hQcmVkaWNhdGUobnVsbCwgdHJ1ZSwgIkFYTGlz dFNlYXJjaEtleSIsICIiLCBmYWxzZSwgZmFsc2UpOwotICAgICAgICBzaG91bGRCZSgiYWxsRGVz Y2VuZGFudHNDb3VudCIsICI2Iik7CisgICAgICAgIHZhciBhbGxEZXNjZW5kYW50c0NvdW50ID0g Y29udGFpbmVyRWxlbWVudC51aUVsZW1lbnRDb3VudEZvclNlYXJjaFByZWRpY2F0ZShudWxsLCB0 cnVlLCAiQVhBbnlUeXBlU2VhcmNoS2V5IiwgIiIsIGZhbHNlLCBmYWxzZSk7CisgICAgICAgIHNo b3VsZEJlKCJhbGxEZXNjZW5kYW50c0NvdW50IiwgIjI1Iik7CiAgICAgICAgIAotICAgICAgICAv LyBJbW1lZGlhdGUgZGVzY2VuZGFudHMuCi0gICAgICAgIHZhciBpbW1lZGlhdGVEZXNjZW5kYW50 c0NvdW50ID0gY29udGFpbmVyRWxlbWVudC51aUVsZW1lbnRDb3VudEZvclNlYXJjaFByZWRpY2F0 ZShudWxsLCB0cnVlLCAiQVhMaXN0U2VhcmNoS2V5IiwgIiIsIGZhbHNlLCB0cnVlKTsKLSAgICAg ICAgc2hvdWxkQmUoImltbWVkaWF0ZURlc2NlbmRhbnRzQ291bnQiLCAiMyIpOworICAgICAgICAv LyBJbW1lZGl0YXRlIGRlc2NlbmRhbnRzLgorICAgICAgICB2YXIgaW1tZWRpYXRlRGVzY2VuZGFu dHNDb3VudCA9IGNvbnRhaW5lckVsZW1lbnQudWlFbGVtZW50Q291bnRGb3JTZWFyY2hQcmVkaWNh dGUobnVsbCwgdHJ1ZSwgIkFYQW55VHlwZVNlYXJjaEtleSIsICIiLCBmYWxzZSwgdHJ1ZSk7Cisg ICAgICAgIHNob3VsZEJlKCJpbW1lZGlhdGVEZXNjZW5kYW50c0NvdW50IiwgIjYiKTsKKyAgICAg ICAgCisgICAgICAgIC8vIFRoZSBudW1iZXIgb2YgaW1tZWRpYXRlIGRlc2NlbmRhbnRzIHNob3Vs ZCBiZSBlcXVhbCB0byB0aGUgbnVtYmVyIG9mIGNoaWxkcmVuICh3aGVuIHVzaW5nICJBWEFueVR5 cGVTZWFyY2hLZXkiKS4KKyAgICAgICAgdmFyIGNoaWxkcmVuQ291bnQgPSBjb250YWluZXJFbGVt ZW50LmNoaWxkcmVuQ291bnQ7CisgICAgICAgIHNob3VsZEJlKCJpbW1lZGlhdGVEZXNjZW5kYW50 c0NvdW50IiwgImNoaWxkcmVuQ291bnQiKTsKICAgICAgICAgCiAgICAgICAgIC8vIEhpZGUgc3Vw ZXJmbHVvdXMgdGV4dC4KICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnRhaW5l ciIpLnN0eWxlLmRpc3BsYXkgPSAibm9uZSI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAppbmRleCA3MWMxNDZlLi5jMzBkZTAw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlP YmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eU9iamVjdC5jcHAKQEAgLTQ4OSw3ICs0ODksOCBAQCB2b2lkIEFjY2Vzc2liaWxpdHlPYmplY3Q6 OmZpbmRNYXRjaGluZ09iamVjdHMoQWNjZXNzaWJpbGl0eVNlYXJjaENyaXRlcmlhKiBjcml0ZQog ICAgICAgICAvLyBPbmx5IGFwcGVuZCB0aGUgY2hpbGRyZW4gYWZ0ZXIvYmVmb3JlIHRoZSBwcmV2 aW91cyBlbGVtZW50LCBzbyB0aGF0IHRoZSBzZWFyY2ggZG9lcyBub3QgY2hlY2sgZWxlbWVudHMg dGhhdCBhcmUgCiAgICAgICAgIC8vIGFscmVhZHkgYmVoaW5kL2FoZWFkIG9mIHN0YXJ0IGVsZW1l bnQuCiAgICAgICAgIEFjY2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciBzZWFyY2hTdGFjazsKLSAg ICAgICAgYXBwZW5kQ2hpbGRyZW5Ub0FycmF5KHN0YXJ0T2JqZWN0LCBpc0ZvcndhcmQsIHByZXZp b3VzT2JqZWN0LCBzZWFyY2hTdGFjayk7CisgICAgICAgIGlmICghY3JpdGVyaWEtPmltbWVkaWF0 ZURlc2NlbmRhbnRzT25seSB8fCBzdGFydE9iamVjdCA9PSB0aGlzKQorICAgICAgICAgICAgYXBw ZW5kQ2hpbGRyZW5Ub0FycmF5KHN0YXJ0T2JqZWN0LCBpc0ZvcndhcmQsIHByZXZpb3VzT2JqZWN0 LCBzZWFyY2hTdGFjayk7CiAKICAgICAgICAgLy8gVGhpcyBub3cgZG9lcyBhIERGUyBhdCB0aGUg Y3VycmVudCBsZXZlbCBvZiB0aGUgcGFyZW50LgogICAgICAgICB3aGlsZSAoIXNlYXJjaFN0YWNr LmlzRW1wdHkoKSkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDNhZTMyMzQuLmRiOTEzZTUgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAxNC0wMi0xOCAgU2FtdWVsIFdoaXRlICA8c2FtdWVsX3doaXRlQGFwcGxlLmNvbT4K KworICAgICAgICBBWDogU2VhcmNoaW5nIGZvciAiaW1tZWRpYXRlIGRlc2NlbmRhbnRzIG9ubHki IGNhbiByZXR1cm4gdW5leHBlY3RlZCByZXN1bHRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4OTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlZCB0ZXN0IGFuZCBleHBlY3RhdGlvbnMgdG8g bWFrZSBzdXJlIHRoZSByZXN1bHRzIG1hdGNoIHRyYWRpdGlvbmFsICJjaGlsZHJlbiIgcmVzdWx0 cyB3aGVuIGFwcHJvcHJpYXRlLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxp dHkvc2VhcmNoLXByZWRpY2F0ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS1leHBlY3RlZC50 eHQ6CisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXByZWRpY2F0 ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS5odG1sOgorCiAyMDE0LTAyLTE3ICBSYWR1IFN0 YXZpbGEgIDxzdGF2aWxhQGFkb2JlLmNvbT4KCiAgICAgICAgIFtDU1MgUmVnaW9uc10gTWFrZSBy ZWdpb25zIHVuc3BsaXR0YWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDQ1OGJjNTkuLjE0NjZhYmIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNC0wMi0xOCAgU2FtdWVsIFdoaXRlICA8c2FtdWVs X3doaXRlQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogU2VhcmNoaW5nIGZvciAiaW1tZWRpYXRl IGRlc2NlbmRhbnRzIG9ubHkiIGNhbiByZXR1cm4gdW5leHBlY3RlZCByZXN1bHRzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4OTg2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWlzc2VkIGFuIGFwcGxp Y2F0aW9uIG9mIHRoZSBpbW1lZGlhdGVEZXNjZW5kYW50c09ubHkgZHVyaW5nIHRoZSBpbml0aWFs IGltcGxlbWVudGF0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdXBkYXRlZCBleGlzdGlu ZyBzZWFyY2gtcHJlZGljYXRlLWltbWVkaWF0ZS1kZXNjZW5kYW50cy1vbmx5Lmh0bWwgdGVzdCB0 byBjb3ZlciB0aGlzIGNhc2UuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eU9iamVjdDo6Zmlu ZE1hdGNoaW5nT2JqZWN0cyk6CisKIDIwMTQtMDItMTcgIENoYW5nU2VvayBPaCAgPGNoYW5nc2Vv ay5vaEBjb2xsYWJvcmEuY29tPgoKICAgICAgICAgW0dUS10gQnVpbGQgZmFpbHVyZSBjYXVzZWQg YnkgbWlzc2luZyBqc21pbiBtb2R1bGUK 224542 2014-02-18 13:51:59 -0800 2014-02-18 14:34:31 -0800 Updated patch. search.patch text/plain 5945 samuel_white ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlYXJj aC1wcmVkaWNhdGUtaW1tZWRpYXRlLWRlc2NlbmRhbnRzLW9ubHktZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXByZWRpY2F0ZS1pbW1l ZGlhdGUtZGVzY2VuZGFudHMtb25seS1leHBlY3RlZC50eHQKaW5kZXggYmE2MWExYS4uMjlmZGI1 MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2Vh cmNoLXByZWRpY2F0ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXByZWRpY2F0 ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS1leHBlY3RlZC50eHQKQEAgLTMsOCArMyw5IEBA IFRoaXMgdGVzdHMgdGhhdCBzZWFyY2ggcHJlZGljYXRlIGltbWVkaWF0ZSBkZXNjZW5kYW50IG9u bHkgcmVzdWx0cyBhcmUgYWNjdXJhdGUuCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCiAKIAot UEFTUyBhbGxEZXNjZW5kYW50c0NvdW50IGlzIDYKLVBBU1MgaW1tZWRpYXRlRGVzY2VuZGFudHND b3VudCBpcyAzCitQQVNTIGFsbERlc2NlbmRhbnRzQ291bnQgaXMgMjUKK1BBU1MgaW1tZWRpYXRl RGVzY2VuZGFudHNDb3VudCBpcyA2CitQQVNTIGltbWVkaWF0ZURlc2NlbmRhbnRzQ291bnQgaXMg Y2hpbGRyZW5Db3VudAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENP TVBMRVRFCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0 eS9zZWFyY2gtcHJlZGljYXRlLWltbWVkaWF0ZS1kZXNjZW5kYW50cy1vbmx5Lmh0bWwgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9zZWFyY2gtcHJlZGljYXRlLWltbWVk aWF0ZS1kZXNjZW5kYW50cy1vbmx5Lmh0bWwKaW5kZXggMmRiY2YzYi4uYmEwNDQyYSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXByZWRp Y2F0ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS5odG1sCisrKyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlYXJjaC1wcmVkaWNhdGUtaW1tZWRpYXRlLWRlc2Nl bmRhbnRzLW9ubHkuaHRtbApAQCAtNyw5ICs3LDkgQEAKIDxib2R5PgogCiA8ZGl2IGlkPSJjb250 YWluZXIiPgotPHVsPjxsaT5pbW1lZGlhdGUgZGVzY2VuZGFudDwvbGk+PGxpPjx1bD48bGk+ZGlz dGFudCBkZXNjZW5kYW50PC9saT48L3VsPjwvbGk+PC91bD4KLTx1bD48bGk+aW1tZWRpYXRlIGRl c2NlbmRhbnQ8L2xpPjxsaT48dWw+PGxpPmRpc3RhbnQgZGVzY2VuZGFudDwvbGk+PC91bD48L2xp PjwvdWw+Ci08dWw+PGxpPmltbWVkaWF0ZSBkZXNjZW5kYW50PC9saT48bGk+PHVsPjxsaT5kaXN0 YW50IGRlc2NlbmRhbnQ8L2xpPjwvdWw+PC9saT48L3VsPgorPGgxPmhlYWRpbmc8aW1nIHNyYz0i cmVzb3VyY2VzL2Nha2UucG5nIiBhbHQ9IkNha2UiPjwvaDE+Cis8cD50ZXh0IDxhIGhyZWY9IiMi Pmxpbms8L2E+PC9wPgorPHVsPjxsaT5pdGVtPC9saT48bGk+PHVsPjxsaT5zdWJpdGVtPC9saT48 L3VsPjwvbGk+PC91bD4KIDwvZGl2PgogCiA8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KQEAgLTIz LDEyICsyMywxNiBAQAogICAgICAgICB2YXIgY29udGFpbmVyRWxlbWVudCA9IGFjY2Vzc2liaWxp dHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50OwogICAgICAgICAKICAgICAgICAgLy8gQWxsIGRl c2NlbmRhbnRzLgotICAgICAgICB2YXIgYWxsRGVzY2VuZGFudHNDb3VudCA9IGNvbnRhaW5lckVs ZW1lbnQudWlFbGVtZW50Q291bnRGb3JTZWFyY2hQcmVkaWNhdGUobnVsbCwgdHJ1ZSwgIkFYTGlz dFNlYXJjaEtleSIsICIiLCBmYWxzZSwgZmFsc2UpOwotICAgICAgICBzaG91bGRCZSgiYWxsRGVz Y2VuZGFudHNDb3VudCIsICI2Iik7CisgICAgICAgIHZhciBhbGxEZXNjZW5kYW50c0NvdW50ID0g Y29udGFpbmVyRWxlbWVudC51aUVsZW1lbnRDb3VudEZvclNlYXJjaFByZWRpY2F0ZShudWxsLCB0 cnVlLCAiQVhBbnlUeXBlU2VhcmNoS2V5IiwgIiIsIGZhbHNlLCBmYWxzZSk7CisgICAgICAgIHNo b3VsZEJlKCJhbGxEZXNjZW5kYW50c0NvdW50IiwgIjI1Iik7CiAgICAgICAgIAotICAgICAgICAv LyBJbW1lZGlhdGUgZGVzY2VuZGFudHMuCi0gICAgICAgIHZhciBpbW1lZGlhdGVEZXNjZW5kYW50 c0NvdW50ID0gY29udGFpbmVyRWxlbWVudC51aUVsZW1lbnRDb3VudEZvclNlYXJjaFByZWRpY2F0 ZShudWxsLCB0cnVlLCAiQVhMaXN0U2VhcmNoS2V5IiwgIiIsIGZhbHNlLCB0cnVlKTsKLSAgICAg ICAgc2hvdWxkQmUoImltbWVkaWF0ZURlc2NlbmRhbnRzQ291bnQiLCAiMyIpOworICAgICAgICAv LyBJbW1lZGl0YXRlIGRlc2NlbmRhbnRzLgorICAgICAgICB2YXIgaW1tZWRpYXRlRGVzY2VuZGFu dHNDb3VudCA9IGNvbnRhaW5lckVsZW1lbnQudWlFbGVtZW50Q291bnRGb3JTZWFyY2hQcmVkaWNh dGUobnVsbCwgdHJ1ZSwgIkFYQW55VHlwZVNlYXJjaEtleSIsICIiLCBmYWxzZSwgdHJ1ZSk7Cisg ICAgICAgIHNob3VsZEJlKCJpbW1lZGlhdGVEZXNjZW5kYW50c0NvdW50IiwgIjYiKTsKKyAgICAg ICAgCisgICAgICAgIC8vIFRoZSBudW1iZXIgb2YgaW1tZWRpYXRlIGRlc2NlbmRhbnRzIHNob3Vs ZCBiZSBlcXVhbCB0byB0aGUgbnVtYmVyIG9mIGNoaWxkcmVuICh3aGVuIHVzaW5nICJBWEFueVR5 cGVTZWFyY2hLZXkiKS4KKyAgICAgICAgdmFyIGNoaWxkcmVuQ291bnQgPSBjb250YWluZXJFbGVt ZW50LmNoaWxkcmVuQ291bnQ7CisgICAgICAgIHNob3VsZEJlKCJpbW1lZGlhdGVEZXNjZW5kYW50 c0NvdW50IiwgImNoaWxkcmVuQ291bnQiKTsKICAgICAgICAgCiAgICAgICAgIC8vIEhpZGUgc3Vw ZXJmbHVvdXMgdGV4dC4KICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnRhaW5l ciIpLnN0eWxlLmRpc3BsYXkgPSAibm9uZSI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAppbmRleCA3MWMxNDZlLi5jMzBkZTAw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlP YmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eU9iamVjdC5jcHAKQEAgLTQ4OSw3ICs0ODksOCBAQCB2b2lkIEFjY2Vzc2liaWxpdHlPYmplY3Q6 OmZpbmRNYXRjaGluZ09iamVjdHMoQWNjZXNzaWJpbGl0eVNlYXJjaENyaXRlcmlhKiBjcml0ZQog ICAgICAgICAvLyBPbmx5IGFwcGVuZCB0aGUgY2hpbGRyZW4gYWZ0ZXIvYmVmb3JlIHRoZSBwcmV2 aW91cyBlbGVtZW50LCBzbyB0aGF0IHRoZSBzZWFyY2ggZG9lcyBub3QgY2hlY2sgZWxlbWVudHMg dGhhdCBhcmUgCiAgICAgICAgIC8vIGFscmVhZHkgYmVoaW5kL2FoZWFkIG9mIHN0YXJ0IGVsZW1l bnQuCiAgICAgICAgIEFjY2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciBzZWFyY2hTdGFjazsKLSAg ICAgICAgYXBwZW5kQ2hpbGRyZW5Ub0FycmF5KHN0YXJ0T2JqZWN0LCBpc0ZvcndhcmQsIHByZXZp b3VzT2JqZWN0LCBzZWFyY2hTdGFjayk7CisgICAgICAgIGlmICghY3JpdGVyaWEtPmltbWVkaWF0 ZURlc2NlbmRhbnRzT25seSB8fCBzdGFydE9iamVjdCA9PSB0aGlzKQorICAgICAgICAgICAgYXBw ZW5kQ2hpbGRyZW5Ub0FycmF5KHN0YXJ0T2JqZWN0LCBpc0ZvcndhcmQsIHByZXZpb3VzT2JqZWN0 LCBzZWFyY2hTdGFjayk7CiAKICAgICAgICAgLy8gVGhpcyBub3cgZG9lcyBhIERGUyBhdCB0aGUg Y3VycmVudCBsZXZlbCBvZiB0aGUgcGFyZW50LgogICAgICAgICB3aGlsZSAoIXNlYXJjaFN0YWNr LmlzRW1wdHkoKSkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDNhZTMyMzQuLmRiOTEzZTUgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAxNC0wMi0xOCAgU2FtdWVsIFdoaXRlICA8c2FtdWVsX3doaXRlQGFwcGxlLmNvbT4K KworICAgICAgICBBWDogU2VhcmNoaW5nIGZvciAiaW1tZWRpYXRlIGRlc2NlbmRhbnRzIG9ubHki IGNhbiByZXR1cm4gdW5leHBlY3RlZCByZXN1bHRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4OTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlZCB0ZXN0IGFuZCBleHBlY3RhdGlvbnMgdG8g bWFrZSBzdXJlIHRoZSByZXN1bHRzIG1hdGNoIHRyYWRpdGlvbmFsICJjaGlsZHJlbiIgcmVzdWx0 cyB3aGVuIGFwcHJvcHJpYXRlLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxp dHkvc2VhcmNoLXByZWRpY2F0ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS1leHBlY3RlZC50 eHQ6CisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc2VhcmNoLXByZWRpY2F0 ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS5odG1sOgorCiAyMDE0LTAyLTE3ICBSYWR1IFN0 YXZpbGEgIDxzdGF2aWxhQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIFJlZ2lvbnNdIE1ha2Ug cmVnaW9ucyB1bnNwbGl0dGFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0NThiYzU5Li41Yzc2Y2I0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDItMTggIFNhbXVlbCBXaGl0ZSAgPHNhbXVl bF93aGl0ZUBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFNlYXJjaGluZyBmb3IgImltbWVkaWF0 ZSBkZXNjZW5kYW50cyBvbmx5IiBjYW4gcmV0dXJuIHVuZXhwZWN0ZWQgcmVzdWx0cy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODk4NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1pc3NlZCBhbiBhcHBs aWNhdGlvbiBvZiB0aGUgaW1tZWRpYXRlRGVzY2VuZGFudHNPbmx5IGZsYWcgZHVyaW5nIHRoZSBp bml0aWFsIGltcGxlbWVudGF0aW9uLiBXZQorICAgICAgICBuZWVkIHRvIG1ha2Ugc3VyZSB3ZSBk b24ndCBkZWNlbmQgaW50byB0aGUgc3RhcnRPYmplY3QgZmlyc3QgaWYgaXQgaXMgcHJvdmlkZWQu IFRoaXMgZml4IGNhdXNlcworICAgICAgICB0aGUgb3V0ZXIgbG9vcCB0byAnc2tpcCcgdGhlIGZp cnN0IGl0ZXJhdGlvbiBzbyBvbmx5IHNpYmxpbmdzIG9mIHRoZSBzdGFydE9iamVjdCBhcmUgY29u c2lkZXJlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHVwZGF0ZWQgZXhpc3Rpbmcgc2VhcmNo LXByZWRpY2F0ZS1pbW1lZGlhdGUtZGVzY2VuZGFudHMtb25seS5odG1sIHRlc3QgdG8gY292ZXIg dGhpcyBjYXNlLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q6OmZpbmRNYXRjaGlu Z09iamVjdHMpOgorCiAyMDE0LTAyLTE3ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29s bGFib3JhLmNvbT4KIAogICAgICAgICBbR1RLXSBCdWlsZCBmYWlsdXJlIGNhdXNlZCBieSBtaXNz aW5nIGpzbWluIG1vZHVsZQo=