128959 2014-02-18 00:24:30 -0800 [iOS] Web Inspector: JSContext inspection crashes in isMainThread, uninitialized WebCoreWebThreadIsLockedOrDisabled 2014-02-18 11:45:48 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned benjamin cmarcelo commit-queue ddkilzer joepeck timothy webkit-bug-importer oldest_to_newest 981820 0 joepeck 2014-02-18 00:24:30 -0800 An iOS Application can use JavaScriptCore / JSContext without WebKit. In this path, the WTF WebCoreWebThread functions have not been initialized yet, and isMainThread with USE(WEB_THREAD) assumes it is and calls WebCoreWebThreadIsLockedOrDisabled and causes a crash. We should not assume that the function pointer has been filled in, as will be the case when this is used outside of a web environment. 981821 1 webkit-bug-importer 2014-02-18 00:25:02 -0800 <rdar://problem/16095242> 981824 2 224478 joepeck 2014-02-18 00:30:18 -0800 Created attachment 224478 [PATCH] Proposed Fix 981998 3 224478 ddkilzer 2014-02-18 11:14:02 -0800 Comment on attachment 224478 [PATCH] Proposed Fix r=me 982025 4 224478 commit-queue 2014-02-18 11:45:46 -0800 Comment on attachment 224478 [PATCH] Proposed Fix Clearing flags on attachment: 224478 Committed r164301: <http://trac.webkit.org/changeset/164301> 982026 5 commit-queue 2014-02-18 11:45:48 -0800 All reviewed patches have been landed. Closing bug. 224478 2014-02-18 00:30:18 -0800 2014-02-18 11:45:46 -0800 [PATCH] Proposed Fix fix-jscontext.patch text/plain 2286 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYjQ2OGYyOC4uZmI4ZTMwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxNC0wMi0xOCAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFdl YiBJbnNwZWN0b3I6IEpTQ29udGV4dCBpbnNwZWN0aW9uIGNyYXNoZXMgaW4gaXNNYWluVGhyZWFk LCB1bmluaXRpYWxpemVkIFdlYkNvcmVXZWJUaHJlYWRJc0xvY2tlZE9yRGlzYWJsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODk1OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gSmF2YVNjcmlw dENvcmUgaXMgdXNlZCB3aXRob3V0IFdlYkNvcmUgb24gaU9TIChlLmcuIEpTQ29udGV4dCkKKyAg ICAgICAgdGhlIFdlYkNvcmVXZWJUaHJlYWQqIGZ1bmN0aW9ucyB3aWxsIG5vdCBiZSBpbml0aWFs aXplZC4gQXZvaWQKKyAgICAgICAgY2FsbGluZyB0aGUgZnVuY3Rpb24gcG9pbnRlciBpZiBpdCBp cyB1bmluaXRpYWxpemVkLiBUaGlzIHdhcworICAgICAgICBoYXBwZW5pbmcgd2l0aCByZW1vdGUg aW5zcGVjdGlvbiB2aWEgU3RyaW5nSW1wbDo6Y3JlYXRlQ0ZTdHJpbmcKKyAgICAgICAgZm9yIGlt cGxpY2l0IE5TU3RyaW5nIC8gV1RGU3RyaW5nIGNvbnZlcnNpb24gd2hpY2ggdXNlcyBpc01haW5U aHJlYWQuCisKKyAgICAgICAgKiB3dGYvbWFjL01haW5UaHJlYWRNYWMubW06CisgICAgICAgIChX VEY6OndlYlRocmVhZElzVW5pbml0aWFsaXplZE9yTG9ja2VkT3JEaXNhYmxlZCk6CisgICAgICAg IChXVEY6OmlzTWFpblRocmVhZCk6CisgICAgICAgIChXVEY6OmNhbkFjY2Vzc1RocmVhZExvY2Fs RGF0YUZvclRocmVhZCk6CisKIDIwMTQtMDItMTcgIFJ5YW4gTG9ydGllICA8ZGVzcnRAZGVzcnQu Y2E+CiAKICAgICAgICAgRW5hYmxlIERGR19KSVQgb24gRnJlZUJTRApkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvbWFjL01haW5UaHJlYWRNYWMubW0gYi9Tb3VyY2UvV1RGL3d0Zi9tYWMvTWFp blRocmVhZE1hYy5tbQppbmRleCBlNGQ5MWYzLi5mNjEwYjk3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQorKysgYi9Tb3VyY2UvV1RGL3d0Zi9tYWMvTWFp blRocmVhZE1hYy5tbQpAQCAtMTQwLDkgKzE0MCwxNCBAQCB2b2lkIHNjaGVkdWxlRGlzcGF0Y2hG dW5jdGlvbnNPbk1haW5UaHJlYWQoKQogfQogCiAjaWYgVVNFKFdFQl9USFJFQUQpCitzdGF0aWMg Ym9vbCB3ZWJUaHJlYWRJc1VuaW5pdGlhbGl6ZWRPckxvY2tlZE9yRGlzYWJsZWQoKQoreworICAg IHJldHVybiAhV2ViQ29yZVdlYlRocmVhZElzTG9ja2VkT3JEaXNhYmxlZCB8fCBXZWJDb3JlV2Vi VGhyZWFkSXNMb2NrZWRPckRpc2FibGVkKCk7Cit9CisKIGJvb2wgaXNNYWluVGhyZWFkKCkKIHsK LSAgICByZXR1cm4gKGlzV2ViVGhyZWFkKCkgfHwgcHRocmVhZF9tYWluX25wKCkpICYmIFdlYkNv cmVXZWJUaHJlYWRJc0xvY2tlZE9yRGlzYWJsZWQoKTsKKyAgICByZXR1cm4gKGlzV2ViVGhyZWFk KCkgfHwgcHRocmVhZF9tYWluX25wKCkpICYmIHdlYlRocmVhZElzVW5pbml0aWFsaXplZE9yTG9j a2VkT3JEaXNhYmxlZCgpOwogfQogCiBib29sIGlzVUlUaHJlYWQoKQpAQCAtMTgzLDcgKzE4OCw3 IEBAIGJvb2wgY2FuQWNjZXNzVGhyZWFkTG9jYWxEYXRhRm9yVGhyZWFkKFRocmVhZElkZW50aWZp ZXIgdGhyZWFkSWQpCiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgaWYgKHRocmVhZElkID09 IHNXZWJUaHJlYWRJZGVudGlmaWVyIHx8IHRocmVhZElkID09IHNBcHBsaWNhdGlvblVJVGhyZWFk SWRlbnRpZmllcikKLSAgICAgICAgcmV0dXJuIChjdXJyZW50VGhyZWFkSWQgPT0gc1dlYlRocmVh ZElkZW50aWZpZXIgfHwgY3VycmVudFRocmVhZElkID09IHNBcHBsaWNhdGlvblVJVGhyZWFkSWRl bnRpZmllcikgJiYgV2ViQ29yZVdlYlRocmVhZElzTG9ja2VkT3JEaXNhYmxlZCgpOworICAgICAg ICByZXR1cm4gKGN1cnJlbnRUaHJlYWRJZCA9PSBzV2ViVGhyZWFkSWRlbnRpZmllciB8fCBjdXJy ZW50VGhyZWFkSWQgPT0gc0FwcGxpY2F0aW9uVUlUaHJlYWRJZGVudGlmaWVyKSAmJiB3ZWJUaHJl YWRJc1VuaW5pdGlhbGl6ZWRPckxvY2tlZE9yRGlzYWJsZWQoKTsKIAogICAgIHJldHVybiBmYWxz ZTsKIH0K