128956 2014-02-17 23:35:33 -0800 [Cocoa] Implement -description in some API objects 2014-02-18 11:31:39 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca oldest_to_newest 981803 0 mitz 2014-02-17 23:35:33 -0800 [Cocoa] Implement -description in some API objects 981807 1 224475 mitz 2014-02-17 23:37:42 -0800 Created attachment 224475 Implement -description in UIProcess/API/Cocoa and Shared/API/Cocoa 982008 2 224475 andersca 2014-02-18 11:27:13 -0800 Comment on attachment 224475 Implement -description in UIProcess/API/Cocoa and Shared/API/Cocoa View in context: https://bugs.webkit.org/attachment.cgi?id=224475&action=review > Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterface.mm:146 > + return [NSString stringWithFormat:@"<%@: %p; protocol = \"%@\"; identifier = \"%@\">", NSStringFromClass([self class]), self, _identifier, NSStringFromProtocol(_protocol)]; Please use self.class instead of [self class]. > Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:53 > + return [NSString stringWithFormat:@"<%@: %p; isMainFrame = %d; request = %@>", NSStringFromClass([self class]), self, _mainFrame, _request.get()]; Please use self.class instead of [self class]. I think you should return either YES or NO for the main frame bit. > Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:41 > + return [NSString stringWithFormat:@"<%@: %p; navigationType = %ld; request = %@; sourceFrame = %@; destinationFrame = %@>", NSStringFromClass([self class]), self, Please use self.class instead of [self class]. > Source/WebKit2/UIProcess/API/Cocoa/WKNavigationResponse.mm:40 > + return [NSString stringWithFormat:@"<%@: %p; frame = %@; response = %@>", NSStringFromClass([self class]), self, _frame.get(), _response.get()]; Please use self.class instead of [self class]. > Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:83 > + return [NSString stringWithFormat:@"<%@: %p; configuration = %@>", NSStringFromClass([self class]), self, _configuration.get()]; Please use self.class instead of [self class]. > Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:49 > + NSString *description = [NSString stringWithFormat:@"<%@: %p; maximumProcessCount = %ld", NSStringFromClass([self class]), self, _maximumProcessCount]; Please use self.class instead of [self class]. > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:42 > + return [NSString stringWithFormat:@"<%@: %p; processClass = %@; preferences = %@>", NSStringFromClass([self class]), self, _processClass.get(), _preferences.get()]; Please use self.class instead of [self class]. 982014 3 mitz 2014-02-18 11:31:39 -0800 Committed <http://trac.webkit.org/r164300>. 224475 2014-02-17 23:37:42 -0800 2014-02-18 11:27:13 -0800 Implement -description in UIProcess/API/Cocoa and Shared/API/Cocoa bug-128956-20140217233808.patch text/plain 6686 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDI3NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE0LTAyLTE3ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBJbXBsZW1lbnQgLWRl c2NyaXB0aW9uIGluIHNvbWUgQVBJIG9iamVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODk1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdElu dGVyZmFjZS5tbToKKyAgICAgICAgQ2hhbmdlZCBjYXRlZ29yeSBuYW1lIHRvIGhhdmUgdGhlIGZy YW1ld29ya+KAmXMgcHJlZml4LgorICAgICAgICAoLVtXS1JlbW90ZU9iamVjdEludGVyZmFjZSBk ZXNjcmlwdGlvbl0pOiBBZGRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLRnJh bWVJbmZvLm1tOgorICAgICAgICAoLVtXS0ZyYW1lSW5mbyBkZXNjcmlwdGlvbl0pOiBBZGRlZC4K KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLTmF2aWdhdGlvbkFjdGlvbi5tbToKKyAg ICAgICAgKC1bV0tOYXZpZ2F0aW9uQWN0aW9uIGRlc2NyaXB0aW9uXSk6IEFkZGVkLgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tOYXZpZ2F0aW9uUmVzcG9uc2UubW06CisgICAgICAg ICgtW1dLTmF2aWdhdGlvblJlc3BvbnNlIGRlc2NyaXB0aW9uXSk6IEFkZGVkLgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzQ2xhc3MubW06CisgICAgICAgICgtW1dLUHJv Y2Vzc0NsYXNzIGRlc2NyaXB0aW9uXSk6IEFkZGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv Q29jb2EvV0tQcm9jZXNzQ2xhc3NDb25maWd1cmF0aW9uLm1tOgorICAgICAgICAoLVtXS1Byb2Nl c3NDbGFzc0NvbmZpZ3VyYXRpb24gZGVzY3JpcHRpb25dKTogQWRkZWQuCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9uLm1tOgorICAgICAgICAoLVtX S1dlYlZpZXdDb25maWd1cmF0aW9uIGRlc2NyaXB0aW9uXSk6IEFkZGVkLgorCiAyMDE0LTAyLTE3 ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkIGd0ayBidWlsZCBmaXguCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJ L0NvY29hL1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RJbnRlcmZhY2UubW0JKHJldmlz aW9uIDE2NDI3MikKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVP YmplY3RJbnRlcmZhY2UubW0JKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2LDcgQEAKIGV4dGVy biAiQyIKIGNvbnN0IGNoYXIgKl9wcm90b2NvbF9nZXRNZXRob2RUeXBlRW5jb2RpbmcoUHJvdG9j b2wgKnAsIFNFTCBzZWwsIEJPT0wgaXNSZXF1aXJlZE1ldGhvZCwgQk9PTCBpc0luc3RhbmNlTWV0 aG9kKTsKIAotQGludGVyZmFjZSBOU01ldGhvZFNpZ25hdHVyZSAoRGV0YWlscykKK0BpbnRlcmZh Y2UgTlNNZXRob2RTaWduYXR1cmUgKFdLRGV0YWlscykKIC0gKENsYXNzKV9jbGFzc0Zvck9iamVj dEF0QXJndW1lbnRJbmRleDooTlNJbnRlZ2VyKWlkeDsKIEBlbmQKIApAQCAtMTQxLDYgKzE0MSwx MSBAQCArIChpbnN0YW5jZXR5cGUpcmVtb3RlT2JqZWN0SW50ZXJmYWNlV2l0CiAgICAgcmV0dXJu IFtbW3NlbGYgYWxsb2NdIGluaXRXaXRoUHJvdG9jb2w6cHJvdG9jb2wgaWRlbnRpZmllcjpOU1N0 cmluZ0Zyb21Qcm90b2NvbChwcm90b2NvbCldIGF1dG9yZWxlYXNlXTsKIH0KIAorLSAoTlNTdHJp bmcgKilkZXNjcmlwdGlvbgoreworICAgIHJldHVybiBbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1h dDpAIjwlQDogJXA7IHByb3RvY29sID0gXCIlQFwiOyBpZGVudGlmaWVyID0gXCIlQFwiPiIsIE5T U3RyaW5nRnJvbUNsYXNzKFtzZWxmIGNsYXNzXSksIHNlbGYsIF9pZGVudGlmaWVyLCBOU1N0cmlu Z0Zyb21Qcm90b2NvbChfcHJvdG9jb2wpXTsKK30KKwogc3RhdGljIFJldGFpblB0cjxOU1NldD4m IGNsYXNzZXNGb3JTZWxlY3RvckFyZ3VtZW50KFdLUmVtb3RlT2JqZWN0SW50ZXJmYWNlICppbnRl cmZhY2UsIFNFTCBzZWxlY3RvciwgTlNVSW50ZWdlciBhcmd1bWVudEluZGV4KQogewogICAgIGF1 dG8gaXQgPSBpbnRlcmZhY2UtPl9hbGxvd2VkQXJndW1lbnRDbGFzc2VzLmZpbmQoc2VsZWN0b3Ip OwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS0ZyYW1lSW5mby5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLRnJh bWVJbmZvLm1tCShyZXZpc2lvbiAxNjQyNzIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLRnJhbWVJbmZvLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCwxMSBA QCAtIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhXZWJGcmFtZVByb3h5OihXCiAgICAgcmV0dXJuIHNl bGY7CiB9CiAKKy0gKE5TU3RyaW5nICopZGVzY3JpcHRpb24KK3sKKyAgICByZXR1cm4gW05TU3Ry aW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCI8JUA6ICVwOyBpc01haW5GcmFtZSA9ICVkOyByZXF1ZXN0 ID0gJUA+IiwgTlNTdHJpbmdGcm9tQ2xhc3MoW3NlbGYgY2xhc3NdKSwgc2VsZiwgX21haW5GcmFt ZSwgX3JlcXVlc3QuZ2V0KCldOworfQorCiAtIChOU1VSTFJlcXVlc3QgKilyZXF1ZXN0CiB7CiAg ICAgcmV0dXJuIF9yZXF1ZXN0LmdldCgpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS05hdmlnYXRpb25BY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS05hdmlnYXRpb25BY3Rpb24ubW0JKHJldmlzaW9u IDE2NDI3MikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tOYXZpZ2F0 aW9uQWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiwxMiBAQAogICAgIFJldGFp blB0cjxOU1VSTFJlcXVlc3Q+IF9yZXF1ZXN0OwogfQogCistIChOU1N0cmluZyAqKWRlc2NyaXB0 aW9uCit7CisgICAgcmV0dXJuIFtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiPCVAOiAlcDsg bmF2aWdhdGlvblR5cGUgPSAlbGQ7IHJlcXVlc3QgPSAlQDsgc291cmNlRnJhbWUgPSAlQDsgZGVz dGluYXRpb25GcmFtZSA9ICVAPiIsIE5TU3RyaW5nRnJvbUNsYXNzKFtzZWxmIGNsYXNzXSksIHNl bGYsCisgICAgICAgIChsb25nKV9uYXZpZ2F0aW9uVHlwZSwgX3JlcXVlc3QuZ2V0KCksIF9zb3Vy Y2VGcmFtZS5nZXQoKSwgX2Rlc3RpbmF0aW9uRnJhbWUuZ2V0KCldOworfQorCiAtIChXS0ZyYW1l SW5mbyAqKXNvdXJjZUZyYW1lCiB7CiAgICAgcmV0dXJuIF9zb3VyY2VGcmFtZS5nZXQoKTsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tOYXZpZ2F0aW9uUmVzcG9u c2UubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S05hdmlnYXRpb25SZXNwb25zZS5tbQkocmV2aXNpb24gMTY0MjcyKQorKysgU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS05hdmlnYXRpb25SZXNwb25zZS5tbQkod29ya2luZyBj b3B5KQpAQCAtMzUsNiArMzUsMTEgQEAKICAgICBSZXRhaW5QdHI8TlNVUkxSZXNwb25zZT4gX3Jl c3BvbnNlOwogfQogCistIChOU1N0cmluZyAqKWRlc2NyaXB0aW9uCit7CisgICAgcmV0dXJuIFtO U1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiPCVAOiAlcDsgZnJhbWUgPSAlQDsgcmVzcG9uc2Ug PSAlQD4iLCBOU1N0cmluZ0Zyb21DbGFzcyhbc2VsZiBjbGFzc10pLCBzZWxmLCBfZnJhbWUuZ2V0 KCksIF9yZXNwb25zZS5nZXQoKV07Cit9CisKIC0gKFdLRnJhbWVJbmZvICopZnJhbWUKIHsKICAg ICByZXR1cm4gX2ZyYW1lLmdldCgpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1Byb2Nlc3NDbGFzcy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc0NsYXNzLm1tCShyZXZpc2lvbiAxNjQyNzIpCisr KyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc0NsYXNzLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC03OCw2ICs3OCwxMSBAQCAtICh2b2lkKWRlYWxsb2MKICAgICBbc3Vw ZXIgZGVhbGxvY107CiB9CiAKKy0gKE5TU3RyaW5nICopZGVzY3JpcHRpb24KK3sKKyAgICByZXR1 cm4gW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCI8JUA6ICVwOyBjb25maWd1cmF0aW9uID0g JUA+IiwgTlNTdHJpbmdGcm9tQ2xhc3MoW3NlbGYgY2xhc3NdKSwgc2VsZiwgX2NvbmZpZ3VyYXRp b24uZ2V0KCldOworfQorCiAtIChXS1Byb2Nlc3NDbGFzc0NvbmZpZ3VyYXRpb24gKiljb25maWd1 cmF0aW9uCiB7CiAgICAgcmV0dXJuIFtbX2NvbmZpZ3VyYXRpb24gY29weV0gYXV0b3JlbGVhc2Vd OwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nlc3NDbGFz c0NvbmZpZ3VyYXRpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1Byb2Nlc3NDbGFzc0NvbmZpZ3VyYXRpb24ubW0JKHJldmlzaW9uIDE2NDI3 MikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzQ2xhc3ND b25maWd1cmF0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCwxNSBAQCAtICh2b2lk KV9zZXRJbmplY3RlZEJ1bmRsZVVSTDooTlNVUkwgKilpCiAgICAgX2luamVjdGVkQnVuZGxlVVJM ID0gYWRvcHROUyhbaW5qZWN0ZWRCdW5kbGVVUkwgY29weV0pOwogfQogCistIChOU1N0cmluZyAq KWRlc2NyaXB0aW9uCit7CisgICAgTlNTdHJpbmcgKmRlc2NyaXB0aW9uID0gW05TU3RyaW5nIHN0 cmluZ1dpdGhGb3JtYXQ6QCI8JUA6ICVwOyBtYXhpbXVtUHJvY2Vzc0NvdW50ID0gJWxkIiwgTlNT dHJpbmdGcm9tQ2xhc3MoW3NlbGYgY2xhc3NdKSwgc2VsZiwgX21heGltdW1Qcm9jZXNzQ291bnRd OworICAgIGlmIChfaW5qZWN0ZWRCdW5kbGVVUkwpCisgICAgICAgIHJldHVybiBbZGVzY3JpcHRp b24gc3RyaW5nQnlBcHBlbmRpbmdGb3JtYXQ6QCI7IGluamVjdGVkQnVuZGxlVVJMOiBcIiVAXCI+ IiwgX2luamVjdGVkQnVuZGxlVVJMLmdldCgpXTsKKworICAgIHJldHVybiBbZGVzY3JpcHRpb24g c3RyaW5nQnlBcHBlbmRpbmdTdHJpbmc6QCI+Il07Cit9CisKIC0gKGlkKWNvcHlXaXRoWm9uZToo TlNab25lICopem9uZQogewogICAgIFdLUHJvY2Vzc0NsYXNzQ29uZmlndXJhdGlvbiAqY29uZmln dXJhdGlvbiA9IFtbW3NlbGYgY2xhc3NdIGFsbG9jV2l0aFpvbmU6em9uZV0gaW5pdF07CkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRp b24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXdDb25maWd1cmF0aW9uLm1tCShyZXZpc2lvbiAxNjQyNzIpCisrKyBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW0JKHdvcmtp bmcgY29weSkKQEAgLTM3LDYgKzM3LDExIEBACiAgICAgV2ViS2l0OjpXZWFrT2JqQ1B0cjxXS1dl YlZpZXc+IF9yZWxhdGVkV2ViVmlldzsKIH0KIAorLSAoTlNTdHJpbmcgKilkZXNjcmlwdGlvbgor eworICAgIHJldHVybiBbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIjwlQDogJXA7IHByb2Nl c3NDbGFzcyA9ICVAOyBwcmVmZXJlbmNlcyA9ICVAPiIsIE5TU3RyaW5nRnJvbUNsYXNzKFtzZWxm IGNsYXNzXSksIHNlbGYsIF9wcm9jZXNzQ2xhc3MuZ2V0KCksIF9wcmVmZXJlbmNlcy5nZXQoKV07 Cit9CisKIC0gKGlkKWNvcHlXaXRoWm9uZTooTlNab25lICopem9uZQogewogICAgIFdLV2ViVmll d0NvbmZpZ3VyYXRpb24gKmNvbmZpZ3VyYXRpb24gPSBbW1tzZWxmIGNsYXNzXSBhbGxvY1dpdGha b25lOnpvbmVdIGluaXRdOwo=