12895 2007-02-26 05:03:59 -0800 REGRESSION: imagemap: pointer cursor is shown everywhere 2007-03-02 00:36:01 -0800 1 1 1 Unclassified WebKit Images 523.x (Safari 3) Mac (PowerPC) OS X 10.4 RESOLVED FIXED http://michi.stuenzi.net/ InRadar, Regression P1 Normal --- 1 tom webkit-unassigned darin eric koivisto mitz oldest_to_newest 21478 0 tom 2007-02-26 05:03:59 -0800 Using revision 19850, the pointer cursor on the image map on http://michi.stuenzi.net/ is shown everywhere, not just on the links. This doesn't occur in shipping Safari. 21370 1 mitz 2007-02-26 10:04:53 -0800 Probably caused by <http://trac.webkit.org/projects/webkit/changeset/19400>. 21160 2 darin 2007-02-27 06:31:55 -0800 I can't get to the URL mentioned here. I'll look for other image maps. 21161 3 darin 2007-02-27 06:34:45 -0800 Testing with the image map at <http://www.december.com/html/demo/imagemap.html>, everything's working fine. So I can't diagnose this without access to the broken test case. 21152 4 mitz 2007-02-27 06:44:27 -0800 Another test case: data:text/html,<img src="http://webkit.org/images/icon-gold.png" usemap="#map"> Some other places that check isLink() specifically exclude elements whose renderer is an image. Perhaps that's just what Document::prepareMouseEvent() should do. 21131 5 tom 2007-02-27 08:29:12 -0800 The page is working again. I changed the DNS servers and forgot to set them up correctly. So please try again. 20985 6 mjs 2007-02-27 19:36:21 -0800 <rdar://problem/5028163> 20806 7 13439 koivisto 2007-03-01 11:58:52 -0800 Created attachment 13439 imagemap image should never itself be the URLElement in hit test results This does not replicate Firefox behavior where if usemap attribute is empty or wrong the hand cursor is shown over entire image area. That seems more like a bug than a feature. 20808 8 13440 rwlbuis 2007-03-01 13:28:16 -0800 Created attachment 13440 First attempt Hi, I am not sure HTMLImageElement should ever return true for isLink, so I am attaching the patch since it is an easy fix. Let me know if I got isLink all wrong though. Cheers, Rob. 20812 9 koivisto 2007-03-01 15:01:24 -0800 I wasn't sure either but not setting isLink for imagemaps seemed like a risky change considering that it is used from quite many places not related to this particular problem. 20824 10 mjs 2007-03-01 18:24:42 -0800 I think it is safer to take Antti's narrow fix for now, and later investigate whether any of the paces calling isLink also want to include imagemaps. It's hard to tell from a quick scan of the code. 20826 11 13439 mjs 2007-03-01 18:33:25 -0800 Comment on attachment 13439 imagemap image should never itself be the URLElement in hit test results r=me 20827 12 13440 mjs 2007-03-01 18:34:17 -0800 Comment on attachment 13440 First attempt I don't think we should land this fix for now, but in the future we should figure out what parts of the code expect an imagemap to be treated as a link, and which don't. 20831 13 13440 mjs 2007-03-01 23:23:11 -0800 Comment on attachment 13440 First attempt (r-, but I think we should investigate this approach later, when we have time to review the affected code). 20751 14 koivisto 2007-03-02 00:36:01 -0800 r19941 13439 2007-03-01 11:58:52 -0800 2007-03-01 18:33:25 -0800 imagemap image should never itself be the URLElement in hit test results 12895.patch text/plain 1489 koivisto SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxOTkyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDctMDItMjggIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4OTUKKyAgICAg ICAgUkVHUkVTU0lPTjogaW1hZ2VtYXA6IHBvaW50ZXIgY3Vyc29yIGlzIHNob3duIGV2ZXJ5d2hl cmUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUwMjgxNjM+CisgCisgICAgICAgIEltYWdlIHdp dGggaW1hZ2VtYXAgc2hvdWxkIG5ldmVyIGl0c2VsZiBiZSBVUkxFbGVtZW50IGluIGhpdCB0ZXN0 IHJlc3VsdHMuIAorICAgICAgICAgICAgICAgCisgICAgICAgIE5vIGxheW91dCB0ZXN0LCBjdXJz b3Igc3RhdGUgY2FuJ3QgYmUgY2FwdHVyZWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy TGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmhpdFRlc3QpOgorCiAy MDA3LTAyLTI4ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBCZXRoCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShyZXZpc2lv biAxOTkxMCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTUyOCw3ICsxNTI4LDggQEAgYm9vbCBSZW5kZXJMYXllcjo6aGl0VGVzdChjb25z dCBIaXRUZXN0UgogICAgIC8vIGl0IGFscmVhZHkgc2V0IFVSTEVsZW1lbnQgYW5kIG9ubHkgdXNl IHRoZSBpbm5lcm1vc3QuCiAgICAgTm9kZSogbm9kZSA9IHJlc3VsdC5pbm5lck5vZGUoKTsKICAg ICB3aGlsZSAobm9kZSkgewotICAgICAgICBpZiAobm9kZS0+aXNMaW5rKCkgJiYgIXJlc3VsdC5V UkxFbGVtZW50KCkpCisgICAgICAgIC8vIGZvciBpbWFnZW1hcHMsIFVSTEVsZW1lbnQgaXMgdGhl IGFzc29jaWF0ZWQgYXJlYSBlbGVtZW50IG5vdCB0aGUgaW1hZ2UgaXRzZWxmCisgICAgICAgIGlm IChub2RlLT5pc0xpbmsoKSAmJiAhcmVzdWx0LlVSTEVsZW1lbnQoKSAmJiAhbm9kZS0+aGFzVGFn TmFtZShpbWdUYWcpKQogICAgICAgICAgICAgcmVzdWx0LnNldFVSTEVsZW1lbnQoc3RhdGljX2Nh c3Q8RWxlbWVudCo+KG5vZGUpKTsKICAgICAgICAgbm9kZSA9IG5vZGUtPnBhcmVudE5vZGUoKTsK ICAgICB9Cg== 13440 2007-03-01 13:28:16 -0800 2007-03-01 23:23:11 -0800 First attempt 12895.diff text/plain 1821 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxOTkyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDctMDMtMDEgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODk1CisgICAgICAgIFJFR1JFU1NJT046IGlt YWdlbWFwOiBwb2ludGVyIGN1cnNvciBpcyBzaG93biBldmVyeXdoZXJlCisKKyAgICAgICAgRml4 IHRoZSByZWdyZXNzaW9uIGJ5IG5vdCBtYXJraW5nIEhUTUxJbWFnZUVsZW1lbnQgYXMgYSBsaW5r LCBldmVuIHdoZW4gaXQgdXNlcyBhbiBpbWFnZSBtYXAuCisgICAgICAgIEFkZCBhIG1hbnVhbCB0 ZXN0IGZvciB0aGUgcmVncmVzc2lvbi4KKworICAgICAgICAqIGh0bWwvSFRNTEltYWdlRWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW1hZ2VFbGVtZW50OjpwYXJzZU1hcHBlZEF0 dHJpYnV0ZSk6CisgICAgICAgICogbWFudWFsLXRlc3RzL2ltYWdlbWFwLWN1cnNvci5odG1sOiBB ZGRlZC4KKwogMjAwNy0wMy0wMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqLgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxJ bWFnZUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MSW1hZ2VFbGVt ZW50LmNwcAkocmV2aXNpb24gMTk5MjYpCisrKyBXZWJDb3JlL2h0bWwvSFRNTEltYWdlRWxlbWVu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMSw3ICsxMjEsNiBAQCB2b2lkIEhUTUxJbWFnZUVs ZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmliCiAgICAgICAgICAgICB1c2VtYXAgPSBhdHRyLT52YWx1 ZSgpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICB1c2VtYXAgPSBkb2N1bWVudCgpLT5jb21w bGV0ZVVSTChwYXJzZVVSTChhdHRyLT52YWx1ZSgpKSk7Ci0gICAgICAgIG1faXNMaW5rID0gIWF0 dHItPmlzTnVsbCgpOwogICAgIH0gZWxzZSBpZiAoYXR0ck5hbWUgPT0gaXNtYXBBdHRyKQogICAg ICAgICBpc21hcCA9IHRydWU7CiAgICAgZWxzZSBpZiAoYXR0ck5hbWUgPT0gb25hYm9ydEF0dHIp CkluZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy9pbWFnZW1hcC1jdXJzb3IuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9pbWFnZW1hcC1jdXJzb3IuaHRtbAkocmV2aXNp b24gMCkKKysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL2ltYWdlbWFwLWN1cnNvci5odG1sCShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDkgQEAKKzxodG1sPgorPGJvZHk+Cis8cD5UaGUgdXBwZXIgaGFs ZiBvZiB0aGUgcmVjdCBzaG91bGQgc2hvdyBhIGhhbmQgY3Vyc29yLCB0aGUgbG93ZXIgaGFsZiBz aG91bGRuJ3QuPC9wPgorPG1hcCBuYW1lPSJuYXZtYXAiPgorPGFyZWEgc2hhcGU9cmVjdCBjb29y ZHM9IjAsMCwxMDAsNTAiIGhyZWY9IiMiLz4KKzwvbWFwPgorPGltZyBib3JkZXI9MiB3aWR0aD0x MDAgaGVpZ2h0PTEwMCB1c2VtYXA9I25hdm1hcCBpc21hcD4KKzwvYm9keT4KKzwvaHRtbD4K