128926 2014-02-17 12:01:55 -0800 [Win] Fall back to Windows symbol servers when necessary 2014-02-17 13:35:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham commit-queue glenn rniwa oldest_to_newest 981602 0 bfulgham 2014-02-17 12:01:55 -0800 I noticed that our test bots were not generating crash dumps because the _NT_SYMBOL_PATH environment variable was not always properly defined on our test bots. A better solution is to fall back to using the Microsoft Symbol Servers in this case, rather than failing to generate dump files. The only downside is some increased test latency due to having to query and download symbols (on demand) from MSDN when symbols are not available locally. 981605 1 224411 bfulgham 2014-02-17 12:04:37 -0800 Created attachment 224411 Patch 981615 2 bfulgham 2014-02-17 12:20:23 -0800 Committed r164244: <http://trac.webkit.org/changeset/164244> 981629 3 rniwa 2014-02-17 13:35:04 -0800 Fixed webkitpy tests on Mac in http://trac.webkit.org/changeset/164247. 224411 2014-02-17 12:04:37 -0800 2014-02-17 12:18:57 -0800 Patch bug-128926-20140217120423.patch text/plain 1547 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NDIzOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE0LTAyLTE3ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIEZhbGwgYmFjayB0byBXaW5kb3dzIHN5bWJvbCBzZXJ2ZXJzIHdo ZW4gbmVjZXNzYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjg5MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHk6CisgICAgICAgIChXaW5Qb3J0KToK KyAgICAgICAgKHNldHVwX2NyYXNoX2xvZ19zYXZpbmcpOiBGYWxsIGJhY2sgdG8gTWljcm9zb2Z0 IFN5bWJvbCBTZXJ2ZXIgd2hlbiBsb2NhbCBzeW1ib2xzIGFyZQorICAgICAgICBub3Qgc3BlY2lm aWVkLgorCiAyMDE0LTAyLTE3ICBMw6FzemzDsyBMYW5nw7MgIDxsbGFuZ28udS1zemVnZWRAcGFy dG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBGaXggdHlwb3MgaW4gVG9vbHMvZWZsL2poYnVp bGQubW9kdWxlcy4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQkocmV2aXNpb24g MTY0MjIyKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQkod29ya2luZyBj b3B5KQpAQCAtMTk5LDggKzE5OSw4IEBAIGNsYXNzIFdpblBvcnQoQXBwbGVQb3J0KToKIAogICAg IGRlZiBzZXR1cF9jcmFzaF9sb2dfc2F2aW5nKHNlbGYpOgogICAgICAgICBpZiAnX05UX1NZTUJP TF9QQVRIJyBub3QgaW4gb3MuZW52aXJvbjoKLSAgICAgICAgICAgIF9sb2cud2FybmluZygiVGhl IF9OVF9TWU1CT0xfUEFUSCBlbnZpcm9ubWVudCB2YXJpYWJsZSBpcyBub3Qgc2V0LiBDcmFzaCBs b2dzIHdpbGwgbm90IGJlIHNhdmVkLiIpCi0gICAgICAgICAgICByZXR1cm4gTm9uZQorICAgICAg ICAgICAgX2xvZy53YXJuaW5nKCJUaGUgX05UX1NZTUJPTF9QQVRIIGVudmlyb25tZW50IHZhcmlh YmxlIGlzIG5vdCBzZXQuIFVzaW5nIE1pY3Jvc29mdCBTeW1ib2wgU2VydmVyLiIpCisgICAgICAg ICAgICBvcy5lbnZpcm9uWydfTlRfU1lNQk9MX1BBVEgnXSA9ICdTUlYqaHR0cDovL21zZGwubWlj cm9zb2Z0LmNvbS9kb3dubG9hZC9zeW1ib2xzJwogICAgICAgICBudHNkX3BhdGggPSBzZWxmLl9u dHNkX2xvY2F0aW9uKCkKICAgICAgICAgaWYgbm90IG50c2RfcGF0aDoKICAgICAgICAgICAgIF9s b2cud2FybmluZygiQ2FuJ3QgZmluZCBudHNkLmV4ZS4gQ3Jhc2ggbG9ncyB3aWxsIG5vdCBiZSBz YXZlZC4iKQo=