128919 2014-02-17 11:10:27 -0800 WebKitGTK+ should stop calling functions to set the view source mode 2014-02-17 11:21:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca berto cgarcia commit-queue gustavo mrobinson oldest_to_newest 981550 0 andersca 2014-02-17 11:10:27 -0800 WebKitGTK+ should stop calling functions to set the view source mode 981552 1 224399 andersca 2014-02-17 11:12:28 -0800 Created attachment 224399 Patch 981553 2 commit-queue 2014-02-17 11:14:32 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 981558 3 224399 cgarcia 2014-02-17 11:18:41 -0800 Comment on attachment 224399 Patch We should also mark the methods as deprecated in both APIs and the WebKitViewMode too in the WebKit2 API. But that shouldn't block this, I can do it in a follow up patch 981560 4 224399 cgarcia 2014-02-17 11:20:48 -0800 Comment on attachment 224399 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224399&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3036 > if (webView->priv->viewMode == viewMode) > return; You should remove this as well 981561 5 andersca 2014-02-17 11:21:46 -0800 Committed r164235: <http://trac.webkit.org/changeset/164235> 224399 2014-02-17 11:12:28 -0800 2014-02-17 11:20:48 -0800 Patch bug-128919-20140217111227.patch text/plain 4591 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMTFmMGRiYjRi NTY1YTNmODdjOGM3NGJjODNlNzJhMzk5Y2JjYTBmNC4uZDM2MTAxY2QwMzM4NGQ2N2EyMjA5ZTNj NjRlYzBhNmZkMTZmNTQwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0 LTAyLTE3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAg V2ViS2l0R1RLKyBzaG91bGQgc3RvcCBjYWxsaW5nIGZ1bmN0aW9ucyB0byBzZXQgdGhlIHZpZXcg c291cmNlIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyODkxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgaXMgYSBmaXJzdCBzdGVwIHRvd2FyZHMgZ2V0dGluZyByaWQgb2YgdGhlIHZpZXcg c291cmNlIG1vZGUgZnJvbSBXZWJDb3JlLiAKKyAgICAgICAgVmlldyBzb3VyY2Ugc2hvdWxkbid0 IGJlIGEgbW9kZSBvbiB0aGUgd2ViIHBhZ2UgYW5kIGNhbiBiZSBpbXBsZW1lbnRlZCBpbiBvdGhl ciB3YXlzIGJ5CisgICAgICAgIGVtYmVkZGluZyBhcHBzLiBGdXJ0aGVybW9yZSwgdGhlIGluc3Bl Y3RvciBoYXMgYW4gZXhjZWxsZW50IHZpZXcgc291cmNlIG1vZGUuCisKKyAgICAgICAgKiB3ZWJr aXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfc2V0X3ZpZXdf c291cmNlX21vZGUpOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2dldF92aWV3X3NvdXJjZV9t b2RlKToKKyAgICAgICAgVHVybiB0aGVzZSBpbnRvIG5vLW9wcy4KKwogMjAxNC0wMi0xMSAgWmFs YW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFN1YnBpeGVsIHJlbmRlcmlu ZzogTWFrZSBHcmFwaGljc0xheWVyQ2xpZW50OjpwYWludENvbnRlbnRzJ3MgY2xpcCByZWN0IHN1 YnBpeGVsIGJhc2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDk2N2MzZTg1MjEwMGU4N2ZkMmVmNDRlNzQxYmQ0 ZDMxOWYxZDQ2MDYuLjgwZjI0NmM0M2ExNjBkZTVlMzkyMGU4ZTk2MTQ2NWFiYjZhYjk5YTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAxNC0wMi0xNyAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFdlYktpdEdUSysgc2hvdWxkIHN0b3AgY2Fs bGluZyBmdW5jdGlvbnMgdG8gc2V0IHRoZSB2aWV3IHNvdXJjZSBtb2RlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg5MTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgZmlyc3Qgc3RlcCB0 b3dhcmRzIGdldHRpbmcgcmlkIG9mIHRoZSB2aWV3IHNvdXJjZSBtb2RlIGZyb20gV2ViQ29yZS4g CisgICAgICAgIFZpZXcgc291cmNlIHNob3VsZG4ndCBiZSBhIG1vZGUgb24gdGhlIHdlYiBwYWdl IGFuZCBjYW4gYmUgaW1wbGVtZW50ZWQgaW4gb3RoZXIgd2F5cyBieQorICAgICAgICBlbWJlZGRp bmcgYXBwcy4gRnVydGhlcm1vcmUsIHRoZSBpbnNwZWN0b3IgaGFzIGFuIGV4Y2VsbGVudCB2aWV3 IHNvdXJjZSBtb2RlLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmll dy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfc2V0X3ZpZXdfbW9kZSk6CisgICAgICAg ICh3ZWJraXRfd2ViX3ZpZXdfZ2V0X3ZpZXdfbW9kZSk6CisgICAgICAgIFR1cm4gdGhlc2UgaW50 byBuby1vcHMuCisKKzIwMTQtMDItMTcgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KKwogICAgICAgICBUdXJuIHRoZSBoaXN0b3J5IGNsaWVudCBpbnRvIGEgZmFuY3kgQVBJ OjpIaXN0b3J5Q2xpZW50IGFic3RyYWN0IGJhc2UgY2xhc3MKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODkxNwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggZGU0NmEyZjgxOWNlZGYzZWE5ODVmMzdmY2Uw MzIzNmMyYjhiODY5Mi4uNDhmMTVjOWNkOGY4OTk3NjRjZjA3ZmU4MTJiOWZiMjQwZjBhOWUwYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtNTE5MSw3 ICs1MTkxLDcgQEAgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfc2V0X3ZpZXdfc291cmNlX21vZGUgKFdl YktpdFdlYlZpZXcqIHdlYlZpZXcsIGdib29sZWFuIG1vZGUKIHsKICAgICBnX3JldHVybl9pZl9m YWlsKFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSk7CiAKLSAgICBjb3JlKHdlYlZpZXcpLT5t YWluRnJhbWUoKS5zZXRJblZpZXdTb3VyY2VNb2RlKG1vZGUpOworICAgIGdfd2FybmluZygid2Vi a2l0X3dlYl92aWV3X3NldF92aWV3X3NvdXJjZV9tb2RlIGhhcyBiZWVuIGRlcHJlY2F0ZWQgYW5k IGlzIGEgbm8tb3AuIik7CiB9CiAKIC8qKgpAQCAtNTIwNiw3ICs1MjA2LDggQEAgZ2Jvb2xlYW4g d2Via2l0X3dlYl92aWV3X2dldF92aWV3X3NvdXJjZV9tb2RlIChXZWJLaXRXZWJWaWV3KiB3ZWJW aWV3KQogewogICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19XRUJfVklFVyh3ZWJW aWV3KSwgRkFMU0UpOwogCi0gICAgcmV0dXJuIGNvcmUod2ViVmlldyktPm1haW5GcmFtZSgpLmlu Vmlld1NvdXJjZU1vZGUoKTsKKyAgICBnX3dhcm5pbmcoIndlYmtpdF93ZWJfdmlld19nZXRfdmll d19zb3VyY2VfbW9kZSBoYXMgYmVlbiBkZXByZWNhdGVkIGFuZCBhbHdheXMgcmV0dXJucyBGQUxT RS4iKTsKKyAgICByZXR1cm4gRkFMU0U7CiB9CiAKIC8vIEludGVybmFsIHN1YnJlc291cmNlIG1h bmFnZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 V2ViVmlldy5jcHAKaW5kZXggYmEyYzY3N2E1ZTNhZTUzNGIzNGU3ZDVmNjMwZGE3MTlkNzEyYjU2 Yy4uYTFiNWI2ZjQ5YTk5MmQ2YWE2MTNkOGRkMDAzNGYzNjBkNmM4ZTA0OSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKQEAgLTE2 Myw3ICsxNjMsNiBAQCBzdHJ1Y3QgX1dlYktpdFdlYlZpZXdQcml2YXRlIHsKICAgICBkb3VibGUg ZXN0aW1hdGVkTG9hZFByb2dyZXNzOwogICAgIENTdHJpbmcgYWN0aXZlVVJJOwogICAgIGJvb2wg aXNMb2FkaW5nOwotICAgIFdlYktpdFZpZXdNb2RlIHZpZXdNb2RlOwogCiAgICAgYm9vbCB3YWl0 aW5nRm9yTWFpblJlc291cmNlOwogICAgIHVuc2lnbmVkIGxvbmcgbWFpblJlc291cmNlUmVzcG9u c2VIYW5kbGVySUQ7CkBAIC0zMDM2LDEwICszMDM1LDcgQEAgdm9pZCB3ZWJraXRfd2ViX3ZpZXdf c2V0X3ZpZXdfbW9kZShXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJLaXRWaWV3TW9kZSB2aWV3 TW8KICAgICBpZiAod2ViVmlldy0+cHJpdi0+dmlld01vZGUgPT0gdmlld01vZGUpCiAgICAgICAg IHJldHVybjsKIAotICAgIGdldFBhZ2Uod2ViVmlldyktPnNldE1haW5GcmFtZUluVmlld1NvdXJj ZU1vZGUodmlld01vZGUgPT0gV0VCS0lUX1ZJRVdfTU9ERV9TT1VSQ0UpOwotCi0gICAgd2ViVmll dy0+cHJpdi0+dmlld01vZGUgPSB2aWV3TW9kZTsKLSAgICBnX29iamVjdF9ub3RpZnkoR19PQkpF Q1Qod2ViVmlldyksICJ2aWV3LW1vZGUiKTsKKyAgICBnX3dhcm5pbmcoIndlYmtpdF93ZWJfdmll d19zZXRfdmlld19tb2RlIGhhcyBiZWVuIGRlcHJlY2F0ZWQgYW5kIGlzIGEgbm8tb3AuIik7CiB9 CiAKIC8qKgpAQCAtMzA1NCw3ICszMDUwLDggQEAgV2ViS2l0Vmlld01vZGUgd2Via2l0X3dlYl92 aWV3X2dldF92aWV3X21vZGUoV2ViS2l0V2ViVmlldyogd2ViVmlldykKIHsKICAgICBnX3JldHVy bl92YWxfaWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVcod2ViVmlldyksIFdFQktJVF9WSUVXX01P REVfV0VCKTsKIAotICAgIHJldHVybiB3ZWJWaWV3LT5wcml2LT52aWV3TW9kZTsKKyAgICBnX3dh cm5pbmcoIndlYmtpdF93ZWJfdmlld19nZXRfdmlld19tb2RlIGhhcyBiZWVuIGRlcHJlY2F0ZWQg YW5kIGFsd2F5cyByZXR1cm5zIFdFQktJVF9WSUVXX01PREVfV0VCLiIpOworICAgIHJldHVybiBX RUJLSVRfVklFV19NT0RFX1dFQjsKIH0KIAogLyoqCg==