128916 2014-02-17 10:46:59 -0800 Rename Document::m_selfOnlyRefCount to m_referencingNodeCount 2014-02-17 13:16:07 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue esprehn+autocc kangil.han oldest_to_newest 981531 0 koivisto 2014-02-17 10:46:59 -0800 Seems more informative. 981588 1 224404 koivisto 2014-02-17 11:50:07 -0800 Created attachment 224404 patch 981598 2 224404 kling 2014-02-17 11:59:57 -0800 Comment on attachment 224404 patch View in context: https://bugs.webkit.org/attachment.cgi?id=224404&action=review r=me > Source/WebCore/dom/Document.h:271 > + void increaseReferencingNodeCount() increment* > Source/WebCore/dom/Document.h:277 > + void decreaseReferencingNodeCount() decrement* 981623 3 koivisto 2014-02-17 13:16:07 -0800 https://trac.webkit.org/r164242 224404 2014-02-17 11:50:07 -0800 2014-02-17 11:59:57 -0800 patch rename-selfonlyrefcount.patch text/plain 6729 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDIyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE0LTAyLTE3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZW5hbWUgRG9jdW1lbnQ6Om1f c2VsZk9ubHlSZWZDb3VudCB0byBtX3JlZmVyZW5jaW5nTm9kZUNvdW50CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg5MTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHRoZSBuYW1lIG1vcmUgaW5m b3JtYXRpdmUuIEFsc28gbWFrZSBpdCB6ZXJvIGJhc2VkIChkb2N1bWVudCBpcyBub3QgY29uc2lk ZXJlZCB0byByZWZlcmVuY2UgaXRzZWxmKS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6RG9jdW1lbnQpOgorICAgICAgICAoV2ViQ29y ZTo6RG9jdW1lbnQ6OnJlbW92ZWRMYXN0UmVmKToKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoK KyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjppbmNyZWFzZVJlZmVyZW5jaW5nTm9kZUNvdW50 KToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpkZWNyZWFzZVJlZmVyZW5jaW5nTm9kZUNv dW50KToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6Ok5vZGUpOgorICAgICAgICAqIGRvbS9Ob2Rl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6On5Ob2RlKToKKyAgICAgICAgKiBkb20vVHJl ZVNjb3BlQWRvcHRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUcmVlU2NvcGVBZG9wdGVyOjpt b3ZlVHJlZVRvTmV3U2NvcGUpOgorICAgICAgICAoV2ViQ29yZTo6VHJlZVNjb3BlQWRvcHRlcjo6 bW92ZU5vZGVUb05ld0RvY3VtZW50KToKKwogMjAxNC0wMi0xNyAgQnJlbmRhbiBMb25nICA8Yi5s b25nQGNhYmxlbGFicy5jb20+CiAKICAgICAgICAgRGF0YUN1ZS5kYXRhIHNob3VsZCBiZSBhIGNv cHkgb2YgdGhlIGlucHV0IEFycmF5QnVmZmVyLCBub3QgYSBwb2ludGVyCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDE2NDIyNCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwMCw3ICs0MDAsNyBAQCBEb2N1bWVudDo6 RG9jdW1lbnQoRnJhbWUqIGZyYW1lLCBjb25zdCBVCiAgICAgLCBtX3RvdWNoRXZlbnRSZWdpb25z RGlydHkoZmFsc2UpCiAgICAgLCBtX3RvdWNoRXZlbnRzQ2hhbmdlZFRpbWVyKHRoaXMsICZEb2N1 bWVudDo6dG91Y2hFdmVudHNDaGFuZ2VkVGltZXJGaXJlZCkKICNlbmRpZgotICAgICwgbV9zZWxm T25seVJlZkNvdW50KDEpCisgICAgLCBtX3JlZmVyZW5jaW5nTm9kZUNvdW50KDApCiAgICAgLCBt X3N0eWxlUmVzb2x2ZXJUaHJvd2F3YXlUaW1lcih0aGlzLCAmRG9jdW1lbnQ6OnN0eWxlUmVzb2x2 ZXJUaHJvd2F3YXlUaW1lckZpcmVkLCB0aW1lQmVmb3JlVGhyb3dpbmdBd2F5U3R5bGVSZXNvbHZl ckFmdGVyTGFzdFVzZUluU2Vjb25kcykKICAgICAsIG1fZGlkQ2FsY3VsYXRlU3R5bGVSZXNvbHZl cihmYWxzZSkKICAgICAsIG1faGFzTm9kZXNXaXRoUGxhY2Vob2xkZXJTdHlsZShmYWxzZSkKQEAg LTY0MCwxMSArNjQwLDEwIEBAIERvY3VtZW50Ojp+RG9jdW1lbnQoKQogdm9pZCBEb2N1bWVudDo6 cmVtb3ZlZExhc3RSZWYoKQogewogICAgIEFTU0VSVCghbV9kZWxldGlvbkhhc0JlZ3VuKTsKLSAg ICBBU1NFUlQobV9zZWxmT25seVJlZkNvdW50KTsKLSAgICBpZiAobV9zZWxmT25seVJlZkNvdW50 ID4gMSkgewotICAgICAgICAvLyBJZiByZW1vdmluZyBhIGNoaWxkIHJlbW92ZXMgdGhlIGxhc3Qg c2VsZi1vbmx5IHJlZiwgd2UgZG9uJ3Qgd2FudCB0aGUgc2NvcGUgdG8gYmUgZGVzdHJveWVkCi0g ICAgICAgIC8vIHVudGlsIGFmdGVyIHJlbW92ZURldGFjaGVkQ2hpbGRyZW4gcmV0dXJucywgc28g d2UgcHJvdGVjdCBvdXJzZWx2ZXMgd2l0aCBhbiBleHRyYSBzZWxmLW9ubHkgcmVmLgotICAgICAg ICBzZWxmT25seVJlZigpOworICAgIGlmIChtX3JlZmVyZW5jaW5nTm9kZUNvdW50KSB7CisgICAg ICAgIC8vIElmIHJlbW92aW5nIGEgY2hpbGQgcmVtb3ZlcyB0aGUgbGFzdCBub2RlIHJlZmVyZW5j ZSwgd2UgZG9uJ3Qgd2FudCB0aGUgc2NvcGUgdG8gYmUgZGVzdHJveWVkCisgICAgICAgIC8vIHVu dGlsIGFmdGVyIHJlbW92ZURldGFjaGVkQ2hpbGRyZW4gcmV0dXJucywgc28gd2UgcHJvdGVjdCBv dXJzZWx2ZXMuCisgICAgICAgIGluY3JlYXNlUmVmZXJlbmNpbmdOb2RlQ291bnQoKTsKIAogICAg ICAgICAvLyBXZSBtdXN0IG1ha2Ugc3VyZSBub3QgdG8gYmUgcmV0YWluaW5nIGFueSBvZiBvdXIg Y2hpbGRyZW4gdGhyb3VnaAogICAgICAgICAvLyB0aGVzZSBleHRyYSBwb2ludGVycyBvciB3ZSB3 aWxsIGNyZWF0ZSBhIHJlZmVyZW5jZSBjeWNsZS4KQEAgLTY3OSw3ICs2NzgsNyBAQCB2b2lkIERv Y3VtZW50OjpyZW1vdmVkTGFzdFJlZigpCiAgICAgICAgIC8vIFdlIG5lZWQgdG8gZG8gdGhpcyBy aWdodCBub3cgc2luY2Ugc2VsZk9ubHlEZXJlZigpIGNhbiBkZWxldGUgdGhpcy4KICAgICAgICAg bV9pblJlbW92ZWRMYXN0UmVmRnVuY3Rpb24gPSBmYWxzZTsKICNlbmRpZgotICAgICAgICBzZWxm T25seURlcmVmKCk7CisgICAgICAgIGRlY3JlYXNlUmVmZXJlbmNpbmdOb2RlQ291bnQoKTsKICAg ICB9IGVsc2UgewogI2lmbmRlZiBOREVCVUcKICAgICAgICAgbV9pblJlbW92ZWRMYXN0UmVmRnVu Y3Rpb24gPSBmYWxzZTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCShyZXZpc2lvbiAxNjQyMjQp CisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMjYz LDIyICsyNjMsMjIgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB+RG9jdW1lbnQoKTsKIAotICAg IC8vIE5vZGVzIGJlbG9uZ2luZyB0byB0aGlzIGRvY3VtZW50IGhvbGQgc2VsZi1vbmx5IHJlZmVy ZW5jZXMgLQorICAgIC8vIE5vZGVzIGJlbG9uZ2luZyB0byB0aGlzIGRvY3VtZW50IGluY3JlYXNl IHJlZmVyZW5jaW5nTm9kZUNvdW50IC0KICAgICAvLyB0aGVzZSBhcmUgZW5vdWdoIHRvIGtlZXAg dGhlIGRvY3VtZW50IGZyb20gYmVpbmcgZGVzdHJveWVkLCBidXQKICAgICAvLyBub3QgZW5vdWdo IHRvIGtlZXAgaXQgZnJvbSByZW1vdmluZyBpdHMgY2hpbGRyZW4uIFRoaXMgYWxsb3dzIGEKLSAg ICAvLyBub2RlIHRoYXQgb3V0bGl2ZXMgaXRzIHNjb3BlIHRvIHN0aWxsIGhhdmUgYSB2YWxpZCBk b2N1bWVudAorICAgIC8vIG5vZGUgdGhhdCBvdXRsaXZlcyBpdHMgZG9jdW1lbnQgdG8gc3RpbGwg aGF2ZSBhIHZhbGlkIGRvY3VtZW50CiAgICAgLy8gcG9pbnRlciB3aXRob3V0IGludHJvZHVjaW5n IHJlZmVyZW5jZSBjeWNsZXMuCi0gICAgdm9pZCBzZWxmT25seVJlZigpCisgICAgdm9pZCBpbmNy ZWFzZVJlZmVyZW5jaW5nTm9kZUNvdW50KCkKICAgICB7CiAgICAgICAgIEFTU0VSVCghbV9kZWxl dGlvbkhhc0JlZ3VuKTsKLSAgICAgICAgKyttX3NlbGZPbmx5UmVmQ291bnQ7CisgICAgICAgICsr bV9yZWZlcmVuY2luZ05vZGVDb3VudDsKICAgICB9CiAKLSAgICB2b2lkIHNlbGZPbmx5RGVyZWYo KQorICAgIHZvaWQgZGVjcmVhc2VSZWZlcmVuY2luZ05vZGVDb3VudCgpCiAgICAgewotICAgICAg ICBBU1NFUlQoIW1fZGVsZXRpb25IYXNCZWd1biB8fCBtX3NlbGZPbmx5UmVmQ291bnQgPT0gMSk7 Ci0gICAgICAgIC0tbV9zZWxmT25seVJlZkNvdW50OwotICAgICAgICBpZiAobV9zZWxmT25seVJl ZkNvdW50ID09IDEgJiYgIXJlZkNvdW50KCkpIHsKKyAgICAgICAgQVNTRVJUKCFtX2RlbGV0aW9u SGFzQmVndW4gfHwgIW1fcmVmZXJlbmNpbmdOb2RlQ291bnQpOworICAgICAgICAtLW1fcmVmZXJl bmNpbmdOb2RlQ291bnQ7CisgICAgICAgIGlmICghbV9yZWZlcmVuY2luZ05vZGVDb3VudCAmJiAh cmVmQ291bnQoKSkgewogI2lmICFBU1NFUlRfRElTQUJMRUQKICAgICAgICAgICAgIG1fZGVsZXRp b25IYXNCZWd1biA9IHRydWU7CiAjZW5kaWYKQEAgLTEzNDQsNyArMTM0NCw3IEBAIHByaXZhdGU6 CiAKICAgICB2b2lkIHN0eWxlUmVzb2x2ZXJUaHJvd2F3YXlUaW1lckZpcmVkKERlZmVycmFibGVP bmVTaG90VGltZXI8RG9jdW1lbnQ+Jik7CiAKLSAgICB1bnNpZ25lZCBtX3NlbGZPbmx5UmVmQ291 bnQ7CisgICAgdW5zaWduZWQgbV9yZWZlcmVuY2luZ05vZGVDb3VudDsKIAogICAgIERlZmVycmFi bGVPbmVTaG90VGltZXI8RG9jdW1lbnQ+IG1fc3R5bGVSZXNvbHZlclRocm93YXdheVRpbWVyOwog CkBAIC0xNzE1LDcgKzE3MTUsNyBAQCBpbmxpbmUgTm9kZTo6Tm9kZShEb2N1bWVudCogZG9jdW1l bnQsIENvCiAgICAgLCBtX3ByZXZpb3VzKDApCiAgICAgLCBtX25leHQoMCkKIHsKLSAgICBkb2N1 bWVudC0+c2VsZk9ubHlSZWYoKTsKKyAgICBkb2N1bWVudC0+aW5jcmVhc2VSZWZlcmVuY2luZ05v ZGVDb3VudCgpOwogCiAjaWYgIWRlZmluZWQoTkRFQlVHKSB8fCAoZGVmaW5lZChEVU1QX05PREVf U1RBVElTVElDUykgJiYgRFVNUF9OT0RFX1NUQVRJU1RJQ1MpCiAgICAgdHJhY2tGb3JEZWJ1Z2dp bmcoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAJKHJldmlzaW9uIDE2NDIyNCkKKysrIFNvdXJjZS9X ZWJDb3JlL2RvbS9Ob2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzA4LDcgKzMwOCw3IEBAIE5v ZGU6On5Ob2RlKCkKICAgICBpZiAoIWlzQ29udGFpbmVyTm9kZSgpKQogICAgICAgICB3aWxsQmVE ZWxldGVkRnJvbSgmZG9jdW1lbnQoKSk7CiAKLSAgICBkb2N1bWVudCgpLnNlbGZPbmx5RGVyZWYo KTsKKyAgICBkb2N1bWVudCgpLmRlY3JlYXNlUmVmZXJlbmNpbmdOb2RlQ291bnQoKTsKIAogICAg IEluc3BlY3RvckNvdW50ZXJzOjpkZWNyZW1lbnRDb3VudGVyKEluc3BlY3RvckNvdW50ZXJzOjpO b2RlQ291bnRlcik7CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vVHJlZVNjb3BlQWRvcHRl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL1RyZWVTY29wZUFkb3B0ZXIu Y3BwCShyZXZpc2lvbiAxNjQyMjQpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vVHJlZVNjb3BlQWRv cHRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDcgKzQ1LDcgQEAgdm9pZCBUcmVlU2NvcGVB ZG9wdGVyOjptb3ZlVHJlZVRvTmV3U2NvcAogICAgIERvY3VtZW50JiBuZXdEb2N1bWVudCA9IG1f bmV3U2NvcGUuZG9jdW1lbnRTY29wZSgpOwogICAgIGJvb2wgd2lsbE1vdmVUb05ld0RvY3VtZW50 ID0gJm9sZERvY3VtZW50ICE9ICZuZXdEb2N1bWVudDsKICAgICBpZiAod2lsbE1vdmVUb05ld0Rv Y3VtZW50KSB7Ci0gICAgICAgIG9sZERvY3VtZW50LnNlbGZPbmx5UmVmKCk7CisgICAgICAgIG9s ZERvY3VtZW50LmluY3JlYXNlUmVmZXJlbmNpbmdOb2RlQ291bnQoKTsKICAgICAgICAgb2xkRG9j dW1lbnQuaW5jRE9NVHJlZVZlcnNpb24oKTsKICAgICB9CiAKQEAgLTc3LDcgKzc3LDcgQEAgdm9p ZCBUcmVlU2NvcGVBZG9wdGVyOjptb3ZlVHJlZVRvTmV3U2NvcAogICAgIH0KIAogICAgIGlmICh3 aWxsTW92ZVRvTmV3RG9jdW1lbnQpCi0gICAgICAgIG9sZERvY3VtZW50LnNlbGZPbmx5RGVyZWYo KTsKKyAgICAgICAgb2xkRG9jdW1lbnQuZGVjcmVhc2VSZWZlcmVuY2luZ05vZGVDb3VudCgpOwog fQogCiB2b2lkIFRyZWVTY29wZUFkb3B0ZXI6Om1vdmVTaGFkb3dUcmVlVG9OZXdEb2N1bWVudChT aGFkb3dSb290KiBzaGFkb3dSb290LCBEb2N1bWVudCogb2xkRG9jdW1lbnQsIERvY3VtZW50KiBu ZXdEb2N1bWVudCkgY29uc3QKQEAgLTExMiw4ICsxMTIsOCBAQCBpbmxpbmUgdm9pZCBUcmVlU2Nv cGVBZG9wdGVyOjptb3ZlTm9kZVRvCiB7CiAgICAgQVNTRVJUKCFub2RlLT5pbkRvY3VtZW50KCkg fHwgb2xkRG9jdW1lbnQgIT0gbmV3RG9jdW1lbnQpOwogCi0gICAgbmV3RG9jdW1lbnQtPnNlbGZP bmx5UmVmKCk7Ci0gICAgb2xkRG9jdW1lbnQtPnNlbGZPbmx5RGVyZWYoKTsKKyAgICBuZXdEb2N1 bWVudC0+aW5jcmVhc2VSZWZlcmVuY2luZ05vZGVDb3VudCgpOworICAgIG9sZERvY3VtZW50LT5k ZWNyZWFzZVJlZmVyZW5jaW5nTm9kZUNvdW50KCk7CiAKICAgICBpZiAobm9kZS0+aGFzUmFyZURh dGEoKSkgewogICAgICAgICBOb2RlUmFyZURhdGEqIHJhcmVEYXRhID0gbm9kZS0+cmFyZURhdGEo KTsK