128909 2014-02-17 07:08:17 -0800 Web Inspector: CSS selectors containing a color name shouldn't be considered for color editing 2014-02-17 11:30:49 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 981434 0 graouts 2014-02-17 07:08:17 -0800 If you have a CSS selector like #facebook, the #fac part of the selector is recognised as a color in the CSS resource and hovering the string will show a hover menu to edit the text as a color. This doesn't make sense, this type of UI should be reserved for CSS properties. 981436 1 webkit-bug-importer 2014-02-17 07:08:59 -0800 <rdar://problem/16083842> 981480 2 224378 graouts 2014-02-17 08:44:06 -0800 Created attachment 224378 Patch 981542 3 224378 joepeck 2014-02-17 11:02:59 -0800 Comment on attachment 224378 Patch r=me 981569 4 224378 commit-queue 2014-02-17 11:30:47 -0800 Comment on attachment 224378 Patch Clearing flags on attachment: 224378 Committed r164236: <http://trac.webkit.org/changeset/164236> 981570 5 commit-queue 2014-02-17 11:30:49 -0800 All reviewed patches have been landed. Closing bug. 224378 2014-02-17 08:44:06 -0800 2014-02-17 11:30:47 -0800 Patch bug-128909-20140217174404.patch text/plain 1760 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 MTViNmE0NmQ1YWZiNTJiN2U2ZGY2MzIyYmQ0NjU0YzZmZmViMDBlLi4xZTcyNmZhN2I1OWIyYWRk YjBmZGM4NDcwOGZiMzJlNjM5OTBhY2EzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNC0wMi0xNyAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9y Zz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDU1Mgc2VsZWN0b3JzIGNvbnRhaW5pbmcgYSBj b2xvciBuYW1lIHNob3VsZG4ndCBiZSBjb25zaWRlcmVkIGZvciBjb2xvciBlZGl0aW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg5MDkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNyZWdhcmQgYW55 IHRleHQgdGhhdCBtaWdodCBiZSBjb250YWluZWQgd2l0aGluIGEgQ1NTIHNlbGVjdG9yLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9Db2RlTWlycm9yQWRkaXRpb25zLmpzOgorCiAyMDE0LTAy LTE1ICBDaHJpcyBKLiBTaHVsbCAgPGNocmlzanNodWxsQGdtYWlsLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBzY29wZSBjaGFpbiBkZXRhaWxzIHNpZGViYXIgZG9lc24ndCB1cGRhdGUg dmFsdWVzIG1vZGlmaWVkIHZpYSBjb25zb2xlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Db2RlTWlycm9yQWRkaXRpb25zLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29kZU1pcnJvckFkZGl0aW9ucy5qcwppbmRleCA2NTI2 MGRhNTQyMDM2OTQ0ZmQ0ZTFhYTBkYzAyMmQ4YTQ3NGY4YjNlLi43Mjc2YjkyNWJmM2RjNDM0OGU1 OGQxYmRkMzUxMDNiOTYzNmRlMDVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Db2RlTWlycm9yQWRkaXRpb25zLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvZGVNaXJyb3JBZGRpdGlvbnMuanMKQEAgLTQ2MSw2ICs0 NjEsMTMgQEAKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAg fQogCisgICAgICAgICAgICAgICAgLy8gV2UncmUgbm90IGludGVyZXN0ZWQgaW4gdGV4dCB3aXRo aW4gYSBDU1Mgc2VsZWN0b3IuCisgICAgICAgICAgICAgICAgdmFyIHRva2VuVHlwZSA9IHRoaXMu Z2V0VG9rZW5UeXBlQXQoZnJvbSk7CisgICAgICAgICAgICAgICAgaWYgKHRva2VuVHlwZSAmJiAo dG9rZW5UeXBlLmluZGV4T2YoImJ1aWx0aW4iKSAhPT0gLTEgfHwgdG9rZW5UeXBlLmluZGV4T2Yo InRhZyIpICE9PSAtMSkpIHsKKyAgICAgICAgICAgICAgICAgICAgbWF0Y2ggPSBjb2xvclJlZ2V4 LmV4ZWMobGluZUNvbnRlbnQpOworICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAg ICAgICAgICAgICB9CisKICAgICAgICAgICAgICAgICB2YXIgY29sb3JTdHJpbmcgPSBtYXRjaFsw XTsKICAgICAgICAgICAgICAgICB2YXIgY29sb3IgPSBXZWJJbnNwZWN0b3IuQ29sb3IuZnJvbVN0 cmluZyhjb2xvclN0cmluZyk7CiAgICAgICAgICAgICAgICAgaWYgKCFjb2xvcikgewo=