128899 2014-02-17 04:28:17 -0800 CLoop buildfix after r164207 2014-02-17 05:09:42 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128795 1 dbatyai.u-szeged webkit-unassigned commit-queue fpizlo oliver ossy oldest_to_newest 981391 0 dbatyai.u-szeged 2014-02-17 04:28:17 -0800 In file included from /Volumes/Data/slave/mavericks-cloop-debug/build/Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:29: In file included from /Volumes/Data/slave/mavericks-cloop-debug/build/Source/JavaScriptCore/bytecode/CodeBlock.h:45: /Volumes/Data/slave/mavericks-cloop-debug/build/Source/JavaScriptCore/dfg/DFGCommon.h:293:51: error: unused parameter 'mode' [-Werror,-Wunused-parameter] inline bool shouldShowDisassembly(CompilationMode mode = DFGMode) ^ 1 error generated. 981392 1 224356 dbatyai.u-szeged 2014-02-17 04:29:22 -0800 Created attachment 224356 Proposed fix 981393 2 224356 ossy 2014-02-17 04:31:23 -0800 Comment on attachment 224356 Proposed fix LGTM, r=me 981404 3 224356 commit-queue 2014-02-17 05:09:34 -0800 Comment on attachment 224356 Proposed fix Clearing flags on attachment: 224356 Committed r164216: <http://trac.webkit.org/changeset/164216> 981405 4 commit-queue 2014-02-17 05:09:42 -0800 All reviewed patches have been landed. Closing bug. 224356 2014-02-17 04:29:22 -0800 2014-02-17 05:09:33 -0800 Proposed fix proposedpatch.patch text/plain 1069 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGU4ZmQxMzIuLmM2NWY3YzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAyLTE3ICBEw6FuaWVsIELDoXR5 YWkgIDxkYmF0eWFpLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgQ0xv b3AgYnVpbGRmaXggYWZ0ZXIgcjE2NDIwNworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI4ODk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHQ29tbW9uLmg6CisgICAgICAgIChKU0M6OkRGRzo6 c2hvdWxkU2hvd0Rpc2Fzc2VtYmx5KToKKwogMjAxNC0wMi0xNiAgRmlsaXAgUGl6bG8gIDxmcGl6 bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIDMyLWJpdCBidWlsZCBmaXguCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbW1vbi5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb21tb24uaAppbmRleCA5YzhhOTM0Li44YzdiMDdmIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbW1vbi5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29tbW9uLmgKQEAgLTI5NSw2ICsyOTUsNyBAQCBp bmxpbmUgYm9vbCBzaG91bGRTaG93RGlzYXNzZW1ibHkoQ29tcGlsYXRpb25Nb2RlIG1vZGUgPSBE RkdNb2RlKQogI2lmIEVOQUJMRShERkdfSklUKQogICAgIHJldHVybiBPcHRpb25zOjpzaG93RGlz YXNzZW1ibHkoKSB8fCBPcHRpb25zOjpzaG93REZHRGlzYXNzZW1ibHkoKSB8fCAoaXNGVEwobW9k ZSkgJiYgT3B0aW9uczo6c2hvd0ZUTERpc2Fzc2VtYmx5KCkpOwogI2Vsc2UKKyAgICBVTlVTRURf UEFSQU0obW9kZSk7CiAgICAgcmV0dXJuIGZhbHNlOwogI2VuZGlmCiB9Cg==