<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>128897</bug_id>
          
          <creation_ts>2014-02-17 03:20:22 -0800</creation_ts>
          <short_desc>Move inheriting method to the superclass in the JavaScript media controls</short_desc>
          <delta_ts>2014-02-18 02:17:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Xabier Rodríguez Calvar">calvaris</reporter>
          <assigned_to name="Xabier Rodríguez Calvar">calvaris</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>glenn</cc>
    
    <cc>jer.noble</cc>
    
    <cc>philipj</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>981375</commentid>
    <comment_count>0</comment_count>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2014-02-17 03:20:22 -0800</bug_when>
    <thetext>Move inheriting method to the superclass in the JavaScript media controls</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981376</commentid>
    <comment_count>1</comment_count>
      <attachid>224350</attachid>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2014-02-17 03:23:51 -0800</bug_when>
    <thetext>Created attachment 224350
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981474</commentid>
    <comment_count>2</comment_count>
      <attachid>224350</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2014-02-17 08:33:48 -0800</bug_when>
    <thetext>Comment on attachment 224350
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224350&amp;action=review

&gt; Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:100
&gt; +    inheritTo: function(child) {

I&apos;m not a huge fan of &quot;inheritTo()&quot;.  How about &quot;extend()&quot;?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981483</commentid>
    <comment_count>3</comment_count>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2014-02-17 08:48:17 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 224350 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=224350&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:100
&gt; &gt; +    inheritTo: function(child) {
&gt; 
&gt; I&apos;m not a huge fan of &quot;inheritTo()&quot;.  How about &quot;extend()&quot;?

Awesome :) Actually I didn&apos;t like it either but at that moment my head couldn&apos;t work out anything better. Good, so I&apos;ll commit that change tomorrow morning.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981501</commentid>
    <comment_count>4</comment_count>
      <attachid>224386</attachid>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2014-02-17 09:31:08 -0800</bug_when>
    <thetext>Created attachment 224386
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981832</commentid>
    <comment_count>5</comment_count>
      <attachid>224386</attachid>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2014-02-18 01:13:52 -0800</bug_when>
    <thetext>Comment on attachment 224386
Patch

Committing as per Jer Noble&apos;s previous r+</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981833</commentid>
    <comment_count>6</comment_count>
      <attachid>224386</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-02-18 01:15:07 -0800</bug_when>
    <thetext>Comment on attachment 224386
Patch

Rejecting attachment 224386 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.appspot.com&apos;, &apos;--bot-id=webkit-cq-03&apos;, &apos;validate-changelog&apos;, &apos;--check-oops&apos;, &apos;--non-interactive&apos;, 224386, &apos;--port=mac&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6614922536419328</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981840</commentid>
    <comment_count>7</comment_count>
      <attachid>224481</attachid>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2014-02-18 01:37:08 -0800</bug_when>
    <thetext>Created attachment 224481
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981843</commentid>
    <comment_count>8</comment_count>
      <attachid>224481</attachid>
    <who name="Xabier Rodríguez Calvar">calvaris</who>
    <bug_when>2014-02-18 01:38:15 -0800</bug_when>
    <thetext>Comment on attachment 224481
Patch

Committing as per r+ from Jer Noble (now in the ChangeLog)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981850</commentid>
    <comment_count>9</comment_count>
      <attachid>224481</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-02-18 02:17:10 -0800</bug_when>
    <thetext>Comment on attachment 224481
Patch

Clearing flags on attachment: 224481

Committed r164279: &lt;http://trac.webkit.org/changeset/164279&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981851</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-02-18 02:17:13 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>224350</attachid>
            <date>2014-02-17 03:23:51 -0800</date>
            <delta_ts>2014-02-17 09:31:03 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-128897-20140217122350.patch</filename>
            <type>text/plain</type>
            <size>3989</size>
            <attacher name="Xabier Rodríguez Calvar">calvaris</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFkZDYwMzFjZDIxYTkz
MjUzYjNiYzE1Y2ZmNWQwOTY3MDM1YjUxOC4uZDFmMmQ4NTgyYzZjYTI2MjFkYjE2MDUxNTBmOTgz
ZThjOWZkYTJiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTAyLTE3ICBYYWJp
ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTW92
ZSBpbmhlcml0aW5nIG1ldGhvZCB0byB0aGUgc3VwZXJjbGFzcyBpbiB0aGUgSmF2YVNjcmlwdCBt
ZWRpYSBjb250cm9scworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTI4ODk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgVGhlIGluaGVyaXRpbmcgbWV0aG9kIG9mIHRoZSBKYXZhU2NyaXB0IG11bHRpbWVkaWEg
Y29udHJvbHMgd2FzCisgICAgICAgIG1vdmVkIGZyb20gdGhlIHN1YmNsYXNzZXMgdG8gdGhlIHN1
cGVyY2xhc3MgYmVjYXVzZSB0aGlzIHdheSBpdCBpcworICAgICAgICBvbmx5IGRlZmluZWQgb25j
ZS4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUu
anM6CisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS5pbmhlcml0VG8pOiBBZGRlZCB0byBy
ZXBsYWNlIGluaGVyaXRGcm9tIGluCisgICAgICAgIHRoZSBzdWJjbGFzc2VzLgorICAgICAgICAq
IE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzOgorICAgICAgICAqIE1v
ZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzOiBSZW1vdmVkIGluaGVyaXRG
cm9tCisgICAgICAgIGFuZCB1c2VkIGluaGVyaXRUby4KKwogMjAxNC0wMi0xNSAgUnlvc3VrZSBO
aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBET01TZWxlY3Rpb24gc2hvdWxkbid0
IGluc3RhbnRpYXRlIFZpc2libGVTZWxlY3Rpb24gZXZlcnl3aGVyZQpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcyBi
L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUu
anMKaW5kZXggYjQ3OGEwM2NmZjI2OTRlMjM2MDVjMmRhZWVkYzQ2ODFhYmE3ZDViZC4uOWQ4YTk2
N2I0MjFmNjE4N2MyOTk0NzQ2ZTQwZjgxMjBhNGRjYjc4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcworKysgYi9T
b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpz
CkBAIC05Nyw2ICs5NywxMyBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgZG93
bjogNDAKICAgICB9LAogCisgICAgaW5oZXJpdFRvOiBmdW5jdGlvbihjaGlsZCkgeworICAgICAg
ICBmb3IgKHZhciBwcm9wZXJ0eSBpbiB0aGlzKSB7CisgICAgICAgICAgICBpZiAoIWNoaWxkLmhh
c093blByb3BlcnR5KHByb3BlcnR5KSkKKyAgICAgICAgICAgICAgICBjaGlsZFtwcm9wZXJ0eV0g
PSB0aGlzW3Byb3BlcnR5XTsKKyAgICAgICAgfQorICAgIH0sCisKICAgICAvLyBMb2NhbGl6ZWQg
c3RyaW5nIGFjY2Vzc29yCiAgICAgVUlTdHJpbmc6IGZ1bmN0aW9uKHMpewogICAgICAgICBpZiAo
dGhpcy5sb2NhbGl6ZWRTdHJpbmdzW3NdKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k
dWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMgYi9Tb3VyY2UvV2ViQ29yZS9N
b2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0d0ay5qcwppbmRleCBhZDcxZWMyNmFh
MDQ3ZTRiMTA0ODRhODMwNTJiMDM3NTU5NzFhMGVkLi44N2MxYTFhOTM1OThmOWZiYzQ0OGVmNWUz
MDQxNTc3MDU2NTUyMDc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh
Y29udHJvbHMvbWVkaWFDb250cm9sc0d0ay5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz
L21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0d0ay5qcwpAQCAtMTksMTMgKzE5LDYgQEAgZnVu
Y3Rpb24gY29udGFpbnMobGlzdCwgb2JqKQogCiBDb250cm9sbGVyR3RrLnByb3RvdHlwZSA9IHsK
IAotICAgIGluaGVyaXRGcm9tOiBmdW5jdGlvbihwYXJlbnQpIHsKLSAgICAgICAgZm9yICh2YXIg
cHJvcGVydHkgaW4gcGFyZW50KSB7Ci0gICAgICAgICAgICBpZiAoIXRoaXMuaGFzT3duUHJvcGVy
dHkocHJvcGVydHkpKQotICAgICAgICAgICAgICAgIHRoaXNbcHJvcGVydHldID0gcGFyZW50W3By
b3BlcnR5XTsKLSAgICAgICAgfQotICAgIH0sCi0KICAgICBjcmVhdGVDb250cm9sczogZnVuY3Rp
b24oKQogICAgIHsKICAgICAgICAgQ29udHJvbGxlci5wcm90b3R5cGUuY3JlYXRlQ29udHJvbHMu
YXBwbHkodGhpcyk7CkBAIC0yMTMsNSArMjA2LDUgQEAgQ29udHJvbGxlckd0ay5wcm90b3R5cGUg
PSB7CiAgICAgfSwKIH07CiAKLUNvbnRyb2xsZXJHdGsucHJvdG90eXBlLmluaGVyaXRGcm9tKE9i
amVjdC5jcmVhdGUoQ29udHJvbGxlci5wcm90b3R5cGUpKTsKK09iamVjdC5jcmVhdGUoQ29udHJv
bGxlci5wcm90b3R5cGUpLmluaGVyaXRUbyhDb250cm9sbGVyR3RrLnByb3RvdHlwZSk7CiBPYmpl
Y3QuZGVmaW5lUHJvcGVydHkoQ29udHJvbGxlckd0ay5wcm90b3R5cGUsICdjb25zdHJ1Y3Rvcics
IHsgZW51bWVyYWJsZTpmYWxzZSwgdmFsdWU6Q29udHJvbGxlckd0ayB9KTsKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpz
IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1Mu
anMKaW5kZXggYmUyZDVhNDI5NGRjMzhlNTU3MjU1ZmMzZjVlMzYyZjQxOWFkOGRiYi4uYjI1OTE2
MDAxNjliOGQyNDZlYzNhZmI1NTk4NTdiNDAxYmNjYjgwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMKKysrIGIvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMKQEAg
LTEyLDEzICsxMiw2IEBAIGZ1bmN0aW9uIENvbnRyb2xsZXJJT1Mocm9vdCwgdmlkZW8sIGhvc3Qp
CiBDb250cm9sbGVySU9TLlN0YXJ0UGxheWJhY2tDb250cm9scyA9IDI7CiAKIENvbnRyb2xsZXJJ
T1MucHJvdG90eXBlID0gewotICAgIGluaGVyaXRGcm9tOiBmdW5jdGlvbihwYXJlbnQpIHsKLSAg
ICAgICAgZm9yICh2YXIgcHJvcGVydHkgaW4gcGFyZW50KSB7Ci0gICAgICAgICAgICBpZiAoIXRo
aXMuaGFzT3duUHJvcGVydHkocHJvcGVydHkpKQotICAgICAgICAgICAgICAgIHRoaXNbcHJvcGVy
dHldID0gcGFyZW50W3Byb3BlcnR5XTsKLSAgICAgICAgfQotICAgIH0sCi0KICAgICBhZGRWaWRl
b0xpc3RlbmVyczogZnVuY3Rpb24oKSB7CiAgICAgICAgIENvbnRyb2xsZXIucHJvdG90eXBlLmFk
ZFZpZGVvTGlzdGVuZXJzLmNhbGwodGhpcyk7CiAKQEAgLTI0Nyw1ICsyNDAsNSBAQCBDb250cm9s
bGVySU9TLnByb3RvdHlwZSA9IHsKIAogfTsKIAotQ29udHJvbGxlcklPUy5wcm90b3R5cGUuaW5o
ZXJpdEZyb20oT2JqZWN0LmNyZWF0ZShDb250cm9sbGVyLnByb3RvdHlwZSkpOworT2JqZWN0LmNy
ZWF0ZShDb250cm9sbGVyLnByb3RvdHlwZSkuaW5oZXJpdFRvKENvbnRyb2xsZXJJT1MucHJvdG90
eXBlKTsKIE9iamVjdC5kZWZpbmVQcm9wZXJ0eShDb250cm9sbGVySU9TLnByb3RvdHlwZSwgJ2Nv
bnN0cnVjdG9yJywgeyBlbnVtZXJhYmxlOmZhbHNlLCB2YWx1ZTpDb250cm9sbGVySU9TIH0pOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>224386</attachid>
            <date>2014-02-17 09:31:08 -0800</date>
            <delta_ts>2014-02-18 01:37:04 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-128897-20140217183106.patch</filename>
            <type>text/plain</type>
            <size>3974</size>
            <attacher name="Xabier Rodríguez Calvar">calvaris</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFkZDYwMzFjZDIxYTkz
MjUzYjNiYzE1Y2ZmNWQwOTY3MDM1YjUxOC4uZjgyYTdmYzVlYjc2YmIzMTlkNzNkZWM3YWQ2MTlk
NTUyY2I5ODY4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTAyLTE3ICBYYWJp
ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTW92
ZSBpbmhlcml0aW5nIG1ldGhvZCB0byB0aGUgc3VwZXJjbGFzcyBpbiB0aGUgSmF2YVNjcmlwdCBt
ZWRpYSBjb250cm9scworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTI4ODk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgVGhlIGluaGVyaXRpbmcgbWV0aG9kIG9mIHRoZSBKYXZhU2NyaXB0IG11bHRpbWVkaWEg
Y29udHJvbHMgd2FzCisgICAgICAgIG1vdmVkIGZyb20gdGhlIHN1YmNsYXNzZXMgdG8gdGhlIHN1
cGVyY2xhc3MgYmVjYXVzZSB0aGlzIHdheSBpdCBpcworICAgICAgICBvbmx5IGRlZmluZWQgb25j
ZS4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUu
anM6CisgICAgICAgIChDb250cm9sbGVyLnByb3RvdHlwZS5leHRlbmQpOiBBZGRlZCB0byByZXBs
YWNlIGluaGVyaXRGcm9tIGluIHRoZQorICAgICAgICBzdWJjbGFzc2VzLgorICAgICAgICAqIE1v
ZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzOgorICAgICAgICAqIE1vZHVs
ZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzOiBSZW1vdmVkIGluaGVyaXRGcm9t
CisgICAgICAgIGFuZCB1c2VkIGV4dGVuZC4KKwogMjAxNC0wMi0xNSAgUnlvc3VrZSBOaXdhICA8
cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBET01TZWxlY3Rpb24gc2hvdWxkbid0IGluc3Rh
bnRpYXRlIFZpc2libGVTZWxlY3Rpb24gZXZlcnl3aGVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcyBiL1NvdXJj
ZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMKaW5k
ZXggYjQ3OGEwM2NmZjI2OTRlMjM2MDVjMmRhZWVkYzQ2ODFhYmE3ZDViZC4uZWViNWM0OGYzZjc1
NmQ4NzM4MzlmM2NiN2JiNWI3ZjRjMmE5YmI2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv
TW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcworKysgYi9Tb3VyY2Uv
V2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCkBAIC05
Nyw2ICs5NywxMyBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAgZG93bjogNDAK
ICAgICB9LAogCisgICAgZXh0ZW5kOiBmdW5jdGlvbihjaGlsZCkgeworICAgICAgICBmb3IgKHZh
ciBwcm9wZXJ0eSBpbiB0aGlzKSB7CisgICAgICAgICAgICBpZiAoIWNoaWxkLmhhc093blByb3Bl
cnR5KHByb3BlcnR5KSkKKyAgICAgICAgICAgICAgICBjaGlsZFtwcm9wZXJ0eV0gPSB0aGlzW3By
b3BlcnR5XTsKKyAgICAgICAgfQorICAgIH0sCisKICAgICAvLyBMb2NhbGl6ZWQgc3RyaW5nIGFj
Y2Vzc29yCiAgICAgVUlTdHJpbmc6IGZ1bmN0aW9uKHMpewogICAgICAgICBpZiAodGhpcy5sb2Nh
bGl6ZWRTdHJpbmdzW3NdKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp
YWNvbnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l
ZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0d0ay5qcwppbmRleCBhZDcxZWMyNmFhMDQ3ZTRiMTA0
ODRhODMwNTJiMDM3NTU5NzFhMGVkLi5hMzk1NzBlNGJmN2NmZWJlZTQ0ZWM3ODQwYTFmYTFkZmUx
Zjg4YTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMv
bWVkaWFDb250cm9sc0d0ay5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29u
dHJvbHMvbWVkaWFDb250cm9sc0d0ay5qcwpAQCAtMTksMTMgKzE5LDYgQEAgZnVuY3Rpb24gY29u
dGFpbnMobGlzdCwgb2JqKQogCiBDb250cm9sbGVyR3RrLnByb3RvdHlwZSA9IHsKIAotICAgIGlu
aGVyaXRGcm9tOiBmdW5jdGlvbihwYXJlbnQpIHsKLSAgICAgICAgZm9yICh2YXIgcHJvcGVydHkg
aW4gcGFyZW50KSB7Ci0gICAgICAgICAgICBpZiAoIXRoaXMuaGFzT3duUHJvcGVydHkocHJvcGVy
dHkpKQotICAgICAgICAgICAgICAgIHRoaXNbcHJvcGVydHldID0gcGFyZW50W3Byb3BlcnR5XTsK
LSAgICAgICAgfQotICAgIH0sCi0KICAgICBjcmVhdGVDb250cm9sczogZnVuY3Rpb24oKQogICAg
IHsKICAgICAgICAgQ29udHJvbGxlci5wcm90b3R5cGUuY3JlYXRlQ29udHJvbHMuYXBwbHkodGhp
cyk7CkBAIC0yMTMsNSArMjA2LDUgQEAgQ29udHJvbGxlckd0ay5wcm90b3R5cGUgPSB7CiAgICAg
fSwKIH07CiAKLUNvbnRyb2xsZXJHdGsucHJvdG90eXBlLmluaGVyaXRGcm9tKE9iamVjdC5jcmVh
dGUoQ29udHJvbGxlci5wcm90b3R5cGUpKTsKK09iamVjdC5jcmVhdGUoQ29udHJvbGxlci5wcm90
b3R5cGUpLmV4dGVuZChDb250cm9sbGVyR3RrLnByb3RvdHlwZSk7CiBPYmplY3QuZGVmaW5lUHJv
cGVydHkoQ29udHJvbGxlckd0ay5wcm90b3R5cGUsICdjb25zdHJ1Y3RvcicsIHsgZW51bWVyYWJs
ZTpmYWxzZSwgdmFsdWU6Q29udHJvbGxlckd0ayB9KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzIGIvU291cmNlL1dl
YkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMKaW5kZXggYmUy
ZDVhNDI5NGRjMzhlNTU3MjU1ZmMzZjVlMzYyZjQxOWFkOGRiYi4uMTM2YThmYjEyMjE3OTJkNzJj
YTQyNWJiYzRhNzJhZGI0ZDQzMmQxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxl
cy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMKKysrIGIvU291cmNlL1dlYkNvcmUv
TW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMKQEAgLTEyLDEzICsxMiw2
IEBAIGZ1bmN0aW9uIENvbnRyb2xsZXJJT1Mocm9vdCwgdmlkZW8sIGhvc3QpCiBDb250cm9sbGVy
SU9TLlN0YXJ0UGxheWJhY2tDb250cm9scyA9IDI7CiAKIENvbnRyb2xsZXJJT1MucHJvdG90eXBl
ID0gewotICAgIGluaGVyaXRGcm9tOiBmdW5jdGlvbihwYXJlbnQpIHsKLSAgICAgICAgZm9yICh2
YXIgcHJvcGVydHkgaW4gcGFyZW50KSB7Ci0gICAgICAgICAgICBpZiAoIXRoaXMuaGFzT3duUHJv
cGVydHkocHJvcGVydHkpKQotICAgICAgICAgICAgICAgIHRoaXNbcHJvcGVydHldID0gcGFyZW50
W3Byb3BlcnR5XTsKLSAgICAgICAgfQotICAgIH0sCi0KICAgICBhZGRWaWRlb0xpc3RlbmVyczog
ZnVuY3Rpb24oKSB7CiAgICAgICAgIENvbnRyb2xsZXIucHJvdG90eXBlLmFkZFZpZGVvTGlzdGVu
ZXJzLmNhbGwodGhpcyk7CiAKQEAgLTI0Nyw1ICsyNDAsNSBAQCBDb250cm9sbGVySU9TLnByb3Rv
dHlwZSA9IHsKIAogfTsKIAotQ29udHJvbGxlcklPUy5wcm90b3R5cGUuaW5oZXJpdEZyb20oT2Jq
ZWN0LmNyZWF0ZShDb250cm9sbGVyLnByb3RvdHlwZSkpOworT2JqZWN0LmNyZWF0ZShDb250cm9s
bGVyLnByb3RvdHlwZSkuZXh0ZW5kKENvbnRyb2xsZXJJT1MucHJvdG90eXBlKTsKIE9iamVjdC5k
ZWZpbmVQcm9wZXJ0eShDb250cm9sbGVySU9TLnByb3RvdHlwZSwgJ2NvbnN0cnVjdG9yJywgeyBl
bnVtZXJhYmxlOmZhbHNlLCB2YWx1ZTpDb250cm9sbGVySU9TIH0pOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>224481</attachid>
            <date>2014-02-18 01:37:08 -0800</date>
            <delta_ts>2014-02-18 02:17:10 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-128897-20140218103707.patch</filename>
            <type>text/plain</type>
            <size>3969</size>
            <attacher name="Xabier Rodríguez Calvar">calvaris</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFkZDYwMzFjZDIxYTkz
MjUzYjNiYzE1Y2ZmNWQwOTY3MDM1YjUxOC4uOTBmMGI0YzdmYzgzODlmOGEzNzBjY2ZiZTZkOGUx
ZDg1MjhmZTQxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTAyLTE4ICBYYWJp
ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTW92
ZSBpbmhlcml0aW5nIG1ldGhvZCB0byB0aGUgc3VwZXJjbGFzcyBpbiB0aGUgSmF2YVNjcmlwdCBt
ZWRpYSBjb250cm9scworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTI4ODk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSmVyIE5vYmxlLgorCisgICAgICAg
IFRoZSBpbmhlcml0aW5nIG1ldGhvZCBvZiB0aGUgSmF2YVNjcmlwdCBtdWx0aW1lZGlhIGNvbnRy
b2xzIHdhcworICAgICAgICBtb3ZlZCBmcm9tIHRoZSBzdWJjbGFzc2VzIHRvIHRoZSBzdXBlcmNs
YXNzIGJlY2F1c2UgdGhpcyB3YXkgaXQgaXMKKyAgICAgICAgb25seSBkZWZpbmVkIG9uY2UuCisK
KyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzOgor
ICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUuZXh0ZW5kKTogQWRkZWQgdG8gcmVwbGFjZSBp
bmhlcml0RnJvbSBpbiB0aGUKKyAgICAgICAgc3ViY2xhc3Nlcy4KKyAgICAgICAgKiBNb2R1bGVz
L21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0d0ay5qczoKKyAgICAgICAgKiBNb2R1bGVzL21l
ZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qczogUmVtb3ZlZCBpbmhlcml0RnJvbQorICAg
ICAgICBhbmQgdXNlZCBleHRlbmQuCisKIDIwMTQtMDItMTUgIFJ5b3N1a2UgTml3YSAgPHJuaXdh
QHdlYmtpdC5vcmc+CiAKICAgICAgICAgRE9NU2VsZWN0aW9uIHNob3VsZG4ndCBpbnN0YW50aWF0
ZSBWaXNpYmxlU2VsZWN0aW9uIGV2ZXJ5d2hlcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMgYi9Tb3VyY2UvV2Vi
Q29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCmluZGV4IGI0
NzhhMDNjZmYyNjk0ZTIzNjA1YzJkYWVlZGM0NjgxYWJhN2Q1YmQuLmVlYjVjNDhmM2Y3NTZkODcz
ODM5ZjNjYjdiYjViN2Y0YzJhOWJiNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVs
ZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMKKysrIGIvU291cmNlL1dlYkNv
cmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwpAQCAtOTcsNiAr
OTcsMTMgQEAgQ29udHJvbGxlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIGRvd246IDQwCiAgICAg
fSwKIAorICAgIGV4dGVuZDogZnVuY3Rpb24oY2hpbGQpIHsKKyAgICAgICAgZm9yICh2YXIgcHJv
cGVydHkgaW4gdGhpcykgeworICAgICAgICAgICAgaWYgKCFjaGlsZC5oYXNPd25Qcm9wZXJ0eShw
cm9wZXJ0eSkpCisgICAgICAgICAgICAgICAgY2hpbGRbcHJvcGVydHldID0gdGhpc1twcm9wZXJ0
eV07CisgICAgICAgIH0KKyAgICB9LAorCiAgICAgLy8gTG9jYWxpemVkIHN0cmluZyBhY2Nlc3Nv
cgogICAgIFVJU3RyaW5nOiBmdW5jdGlvbihzKXsKICAgICAgICAgaWYgKHRoaXMubG9jYWxpemVk
U3RyaW5nc1tzXSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250
cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNv
bnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMKaW5kZXggYWQ3MWVjMjZhYTA0N2U0YjEwNDg0YTgz
MDUyYjAzNzU1OTcxYTBlZC4uYTM5NTcwZTRiZjdjZmViZWU0NGVjNzg0MGExZmExZGZlMWY4OGE3
ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlh
Q29udHJvbHNHdGsuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xz
L21lZGlhQ29udHJvbHNHdGsuanMKQEAgLTE5LDEzICsxOSw2IEBAIGZ1bmN0aW9uIGNvbnRhaW5z
KGxpc3QsIG9iaikKIAogQ29udHJvbGxlckd0ay5wcm90b3R5cGUgPSB7CiAKLSAgICBpbmhlcml0
RnJvbTogZnVuY3Rpb24ocGFyZW50KSB7Ci0gICAgICAgIGZvciAodmFyIHByb3BlcnR5IGluIHBh
cmVudCkgewotICAgICAgICAgICAgaWYgKCF0aGlzLmhhc093blByb3BlcnR5KHByb3BlcnR5KSkK
LSAgICAgICAgICAgICAgICB0aGlzW3Byb3BlcnR5XSA9IHBhcmVudFtwcm9wZXJ0eV07Ci0gICAg
ICAgIH0KLSAgICB9LAotCiAgICAgY3JlYXRlQ29udHJvbHM6IGZ1bmN0aW9uKCkKICAgICB7CiAg
ICAgICAgIENvbnRyb2xsZXIucHJvdG90eXBlLmNyZWF0ZUNvbnRyb2xzLmFwcGx5KHRoaXMpOwpA
QCAtMjEzLDUgKzIwNiw1IEBAIENvbnRyb2xsZXJHdGsucHJvdG90eXBlID0gewogICAgIH0sCiB9
OwogCi1Db250cm9sbGVyR3RrLnByb3RvdHlwZS5pbmhlcml0RnJvbShPYmplY3QuY3JlYXRlKENv
bnRyb2xsZXIucHJvdG90eXBlKSk7CitPYmplY3QuY3JlYXRlKENvbnRyb2xsZXIucHJvdG90eXBl
KS5leHRlbmQoQ29udHJvbGxlckd0ay5wcm90b3R5cGUpOwogT2JqZWN0LmRlZmluZVByb3BlcnR5
KENvbnRyb2xsZXJHdGsucHJvdG90eXBlLCAnY29uc3RydWN0b3InLCB7IGVudW1lcmFibGU6ZmFs
c2UsIHZhbHVlOkNvbnRyb2xsZXJHdGsgfSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N
b2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcyBiL1NvdXJjZS9XZWJDb3Jl
L01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzCmluZGV4IGJlMmQ1YTQy
OTRkYzM4ZTU1NzI1NWZjM2Y1ZTM2MmY0MTlhZDhkYmIuLjEzNmE4ZmIxMjIxNzkyZDcyY2E0MjVi
YmM0YTcyYWRiNGQ0MzJkMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk
aWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs
ZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9TLmpzCkBAIC0xMiwxMyArMTIsNiBAQCBm
dW5jdGlvbiBDb250cm9sbGVySU9TKHJvb3QsIHZpZGVvLCBob3N0KQogQ29udHJvbGxlcklPUy5T
dGFydFBsYXliYWNrQ29udHJvbHMgPSAyOwogCiBDb250cm9sbGVySU9TLnByb3RvdHlwZSA9IHsK
LSAgICBpbmhlcml0RnJvbTogZnVuY3Rpb24ocGFyZW50KSB7Ci0gICAgICAgIGZvciAodmFyIHBy
b3BlcnR5IGluIHBhcmVudCkgewotICAgICAgICAgICAgaWYgKCF0aGlzLmhhc093blByb3BlcnR5
KHByb3BlcnR5KSkKLSAgICAgICAgICAgICAgICB0aGlzW3Byb3BlcnR5XSA9IHBhcmVudFtwcm9w
ZXJ0eV07Ci0gICAgICAgIH0KLSAgICB9LAotCiAgICAgYWRkVmlkZW9MaXN0ZW5lcnM6IGZ1bmN0
aW9uKCkgewogICAgICAgICBDb250cm9sbGVyLnByb3RvdHlwZS5hZGRWaWRlb0xpc3RlbmVycy5j
YWxsKHRoaXMpOwogCkBAIC0yNDcsNSArMjQwLDUgQEAgQ29udHJvbGxlcklPUy5wcm90b3R5cGUg
PSB7CiAKIH07CiAKLUNvbnRyb2xsZXJJT1MucHJvdG90eXBlLmluaGVyaXRGcm9tKE9iamVjdC5j
cmVhdGUoQ29udHJvbGxlci5wcm90b3R5cGUpKTsKK09iamVjdC5jcmVhdGUoQ29udHJvbGxlci5w
cm90b3R5cGUpLmV4dGVuZChDb250cm9sbGVySU9TLnByb3RvdHlwZSk7CiBPYmplY3QuZGVmaW5l
UHJvcGVydHkoQ29udHJvbGxlcklPUy5wcm90b3R5cGUsICdjb25zdHJ1Y3RvcicsIHsgZW51bWVy
YWJsZTpmYWxzZSwgdmFsdWU6Q29udHJvbGxlcklPUyB9KTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>