128896 2014-02-17 02:32:09 -0800 TextAutosizer: avoid unnecessary calls to containerShouldBeAutosized. 2016-09-17 07:17:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified NEW BlinkMergeCandidate P2 Normal --- 1 lvidacs.u-szeged webkit-unassigned andersca bfulgham commit-queue darin esprehn+autocc glenn kling kondapallykalyan ossy oldest_to_newest 981364 0 lvidacs.u-szeged 2014-02-17 02:32:09 -0800 Blink merge candidate: https://codereview.chromium.org/134153006/ by timvolodine This patch adds a simple check to ensure that the multiplier > 1 before calling containerShouldBeAutosized() inside processContainer(). If the multiplier is exactly 1 the return value of containerShouldBeAutosized does not matter. Due to the cascading structure of the algorithm quite a few unnecessary calls to containerShouldBeAutosized are avoided in this way, reducing the text autosizing times by up to 30% on some websites. 981365 1 224348 lvidacs.u-szeged 2014-02-17 02:38:50 -0800 Created attachment 224348 Patch 1230832 2 224348 mcatanzaro 2016-09-17 07:17:49 -0700 Comment on attachment 224348 Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug. 224348 2014-02-17 02:38:50 -0800 2016-09-17 07:17:49 -0700 Patch bug-128896-20140217113849.patch text/plain 1684 lvidacs.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTMyYWRjZmY2Njk3OTNk NmYxMzRlYmQ1Y2JhNTQyODg4M2I0OTZkYS4uYmRmOTBhNDllNjk3NjBlODlmN2IzZGMxMmY3MzQw YTQyNGEzZTFjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTE3ICBMYXN6 bG8gVmlkYWNzICA8bHZpZGFjcy51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCisgICAg ICAgIFRleHRBdXRvc2l6ZXI6IGF2b2lkIHVubmVjZXNzYXJ5IGNhbGxzIHRvIGNvbnRhaW5lclNo b3VsZEJlQXV0b3NpemVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI4ODk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ2hlY2sgZm9yIG11bHRpcGxpZXIgPiAxIGJlZm9yZSBjYWxsaW5nIGNvbnRhaW5l clNob3VsZEJlQXV0b3NpemVkKCkgaW5zaWRlIHByb2Nlc3NDb250YWluZXIoKS4KKyAgICAgICAg QmxpbmsgbWVyZ2UgZnJvbSBodHRwczovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzEzNDE1MzAw Ni8gYnkgdGltdm9sb2RpbmUKKworICAgICAgICAqIHJlbmRlcmluZy9UZXh0QXV0b3NpemVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRBdXRvc2l6ZXI6OnByb2Nlc3NDb250YWluZXIpOgor CiAyMDE0LTAyLTEzICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4K IAogICAgICAgICBTdXBwb3J0IEFOR0xFX2luc3RhbmNlZF9hcnJheXMgZm9yIEdMRVMgYmFja2Vu ZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0QXV0b3NpemVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0QXV0b3NpemVyLmNwcAppbmRleCBmMDM2 ZjU0ZGZkZjc0NGE5M2I0NzA3NzQ1ZTM0NDYyYjk2MjdjZTE5Li44MjQ0MDA1NGMyNjQxMWQyZWY5 YjE3YWM0NzY4Zjg3MmEyNWZkZmM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvVGV4dEF1dG9zaXplci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRB dXRvc2l6ZXIuY3BwCkBAIC0yMDAsNyArMjAwLDcgQEAgdm9pZCBUZXh0QXV0b3NpemVyOjpwcm9j ZXNzQ29udGFpbmVyKGZsb2F0IG11bHRpcGxpZXIsIFJlbmRlckJsb2NrKiBjb250YWluZXIsIFQK IHsKICAgICBBU1NFUlQoaXNBdXRvc2l6aW5nQ29udGFpbmVyKGNvbnRhaW5lcikpOwogCi0gICAg ZmxvYXQgbG9jYWxNdWx0aXBsaWVyID0gY29udGFpbmVyU2hvdWxkQmVBdXRvc2l6ZWQoY29udGFp bmVyKSA/IG11bHRpcGxpZXI6IDE7CisgICAgZmxvYXQgbG9jYWxNdWx0aXBsaWVyID0gKG11bHRp cGxpZXIgPiAxICYmIGNvbnRhaW5lclNob3VsZEJlQXV0b3NpemVkKGNvbnRhaW5lcikpID8gbXVs dGlwbGllcjogMTsKIAogICAgIFJlbmRlck9iamVjdCogZGVzY2VuZGFudCA9IG5leHRJblByZU9y ZGVyU2tpcHBpbmdEZXNjZW5kYW50c09mQ29udGFpbmVycyhzdWJ0cmVlUm9vdCwgc3VidHJlZVJv b3QpOwogICAgIHdoaWxlIChkZXNjZW5kYW50KSB7Cg==