128884 2014-02-16 00:31:36 -0800 [iOS] ASSERT in DocumentLoader::checkLoadComplete when navigating 2014-07-09 11:37:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified NEW InRadar P2 Normal --- 1 psolanki psolanki beidson commit-queue japhet psolanki oldest_to_newest 981260 0 psolanki 2014-02-16 00:31:36 -0800 Debug iOS WebKit asserts when navigating navigation bar links on the top on apple.com. 981261 1 psolanki 2014-02-16 00:32:09 -0800 <rdar://problem/12952107> 981262 2 224316 psolanki 2014-02-16 00:51:19 -0800 Created attachment 224316 Patch 982470 3 224316 bfulgham 2014-02-19 11:34:48 -0800 Comment on attachment 224316 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224316&action=review r=me. A noticed a minor typo in the ChangeLog. > Source/WebCore/ChangeLog:9 > + On iOS, a mouse events get triggered when you tap on an link. If a page decides to load a "... when you tap on A link" 985431 4 224316 ap 2014-02-27 18:01:25 -0800 Comment on attachment 224316 Patch Pratik and myself looked into this a little bit, and it looks like the issue is not with the assertion, but with some code that fails to prevent loading in an inactive loader. Furthermore, Pratik got a different assertion when reproducing this issue now. 224316 2014-02-16 00:51:19 -0800 2014-07-09 11:37:18 -0700 Patch bug-128884-20140216005119.patch text/plain 1791 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQxYWEzYzVjNTNjMWJj NmFiODJiYzEwNDRmZjhiMDAwYzYwODRjOC4uMzM4YmJmZDgxZDA0OWMwOTFlMDhkYjMxNzc0YjM1 NDc3MThiYTYwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAyLTE2ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBU1NFUlQg aW4gRG9jdW1lbnRMb2FkZXI6OmNoZWNrTG9hZENvbXBsZXRlIHdoZW4gbmF2aWdhdGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4ODg0CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xMjk1MjEwNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBPbiBpT1MsIGEgbW91c2UgZXZlbnRzIGdldCB0cmlnZ2Vy ZWQgd2hlbiB5b3UgdGFwIG9uIGFuIGxpbmsuIElmIGEgcGFnZSBkZWNpZGVzIHRvIGxvYWQgYQor ICAgICAgICByZXNvdXJjZSAoZS5nLiBhIGRhdGEgVVJMIGluIHRoZSBjYXNlIG9mIGFwcGxlLmNv bSkgb24gdGhlIG1vdXNlIGV2ZW50LCB0aGVuIHRoYXQgcmVzb3VyY2UKKyAgICAgICAgbWF5IGZp bmlzaCBsb2FkaW5nIHdoZW4gdGhlIGRvY3VtZW50IGlzIHN0aWxsIGluIGEgcHJvdmlzaW9uYWwg bG9hZCBzdGF0ZS4gVGhpcyB3b3VsZAorICAgICAgICB0cmlnZ2VyIHRoZSBhc3NlcnQuIFJlbGF4 IHRoZSBhc3NlcnQgc28gdGhhdCBpdCdzIG9rYXkgdG8gaGF2ZSBlaXRoZXIgcHJvdmlzaW9uYWwg b3IgdGhlCisgICAgICAgIGRvY3VtZW50IGxvYWRlci4KKworICAgICAgICAqIGxvYWRlci9Eb2N1 bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6Y2hlY2tM b2FkQ29tcGxldGUpOgorCiAyMDE0LTAyLTE0ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxl LmNvbT4KIAogICAgICAgICBDVFRFOiBXb3JrZXJHbG9iYWxTY29wZSBpcyBhbHdheXMgb3duZWQg YnkgYSBXb3JrZXJUaHJlYWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9j dW1lbnRMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNw cAppbmRleCA1MzlhNTVkZDJmMzMwNmRmZGNkODJjNTg4Mzc3MjAwNWI3ZmNhMDVkLi43OWJjZWZh MWE1MmViZDA5ZDQ5NmQwYTNjMTNmYmU5NTIxYTE1MWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9Eb2N1bWVudExvYWRlci5jcHAKQEAgLTkxNCw3ICs5MTQsNyBAQCB2b2lkIERvY3VtZW50TG9h ZGVyOjpjaGVja0xvYWRDb21wbGV0ZSgpCiAgICAgaWYgKCFtX2ZyYW1lIHx8IGlzTG9hZGluZygp KQogICAgICAgICByZXR1cm47CiAKLSAgICBBU1NFUlQodGhpcyA9PSBmcmFtZUxvYWRlcigpLT5h Y3RpdmVEb2N1bWVudExvYWRlcigpKTsKKyAgICBBU1NFUlQodGhpcyA9PSBmcmFtZUxvYWRlcigp LT5kb2N1bWVudExvYWRlcigpIHx8IHRoaXMgPT0gZnJhbWVMb2FkZXIoKS0+cHJvdmlzaW9uYWxE b2N1bWVudExvYWRlcigpKTsKICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpLT5kb21XaW5kb3coKS0+ ZmluaXNoZWRMb2FkaW5nKCk7CiB9CiAK