128880 2014-02-15 19:20:53 -0800 Build break when disabled ACCESSIBILITY since r162986 2014-02-15 21:02:52 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi commit-queue oldest_to_newest 981241 0 ryuan.choi 2014-02-15 19:20:53 -0800 CMakeFiles/TestRunnerInjectedBundle.dir/__/__/DerivedSources/InjectedBundle/JSAccessibilityUIElement.cpp.o: In function `WTR::JSAccessibilityUIElement::columnHeaders(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**)': JSAccessibilityUIElement.cpp:(.text+0x260e): undefined reference to `WTR::AccessibilityUIElement::columnHeaders() const' CMakeFiles/TestRunnerInjectedBundle.dir/__/__/DerivedSources/InjectedBundle/JSAccessibilityUIElement.cpp.o: In function `WTR::JSAccessibilityUIElement::rowHeaders(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**)': JSAccessibilityUIElement.cpp:(.text+0x2668): undefined reference to `WTR::AccessibilityUIElement::rowHeaders() const' CMakeFiles/TestRunnerInjectedBundle.dir/__/__/DerivedSources/InjectedBundle/JSAccessibilityUIElement.cpp.o: In function `WTR::JSAccessibilityUIElement::ariaControlsElementAtIndex(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**)': JSAccessibilityUIElement.cpp:(.text+0x290a): undefined reference to `WTR::AccessibilityUIElement::ariaControlsElementAtIndex(unsigned int)' collect2: error: ld returned 1 exit status make[2]: *** [lib/libTestRunnerInjectedBundle.so] Error 1 make[1]: *** [Tools/WebKitTestRunner/CMakeFiles/TestRunnerInjectedBundle.dir/all] Error 2 make: *** [all] Error 2 981242 1 224308 ryuan.choi 2014-02-15 19:23:29 -0800 Created attachment 224308 Patch 981243 2 224309 ryuan.choi 2014-02-15 19:24:40 -0800 Created attachment 224309 Patch 981256 3 224309 commit-queue 2014-02-15 21:02:47 -0800 Comment on attachment 224309 Patch Clearing flags on attachment: 224309 Committed r164189: <http://trac.webkit.org/changeset/164189> 981257 4 commit-queue 2014-02-15 21:02:52 -0800 All reviewed patches have been landed. Closing bug. 224308 2014-02-15 19:23:29 -0800 2014-02-15 19:24:36 -0800 Patch bug-128880-20140216122325.patch text/plain 2731 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MTcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjhjZTJkYjBkY2Y1NGJiNmE2YjMwMWIwMDI0NjVkZTdj NzIzZTdkMy4uMzY1YTZhNDI1OGZiOTRiNTZjODIwMGVjNjM4NjY5YThiNmUwN2VjNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDE0LTAyLTE1ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAor ICAgICAgICBCdWlsZCBicmVhayB3aGVuIGRpc2FibGVkIEFDQ0VTU0lCSUxJVFkgc2luY2UgcjE2 Mjk4NgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4 ODgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuY3Bw OgorICAgICAgICBBZGRlZCBkdW1teSBpbXBsZW1lbnRhdGlvbnMgZm9yIG5ld2x5IGFkZGVkIG1l dGhvZHMuCisgICAgICAgIChXVFI6OkFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnJvd0hlYWRlcnMp OgorICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojpjb2x1bW5IZWFkZXJzKToK KyAgICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6YXJpYUNvbnRyb2xzRWxlbWVu dEF0SW5kZXgpOgorCisyMDE0LTAyLTE1ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5n LmNvbT4KKwogICAgICAgICBbRUZMXVtXSzFdIERvIG5vdCBpbmNsdWRlIGNhaXJvIGhlYWRlciBp biB0aGUgcHVibGljIGhlYWRlcnMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyODc3OQogCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuY3BwIGIvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50LmNwcAppbmRl eCA1MzhjY2RlYjMwMThkNjkzODIxNjU0YTEyYThhMjEwNDkzN2YyMDI0Li5iYjg3ZDQ2MWU5NWYy MjU4ZmU5ODg5MWRjOTY3MTM1YjdlMDU1Mjk3IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL0luamVjdGVkQnVuZGxlL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuY3BwCisrKyBiL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvQWNjZXNzaWJpbGl0eVVJRWxlbWVu dC5jcHAKQEAgLTE1NCwxMiArMTU0LDE1IEBAIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBBY2Nl c3NpYmlsaXR5VUlFbGVtZW50Ojpyb3dJbmRleFJhbmdlKCkgeyByZXR1cm4gMDsgfQogSlNSZXRh aW5QdHI8SlNTdHJpbmdSZWY+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmNvbHVtbkluZGV4UmFu Z2UoKSB7IHJldHVybiAwOyB9CiBpbnQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6cm93Q291bnQo KSB7IHJldHVybiAwOyB9CiBpbnQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6Y29sdW1uQ291bnQo KSB7IHJldHVybiAwOyB9CitKU1ZhbHVlUmVmIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnJvd0hl YWRlcnMoKSBjb25zdCB7IHJldHVybiBudWxscHRyOyB9CitKU1ZhbHVlUmVmIEFjY2Vzc2liaWxp dHlVSUVsZW1lbnQ6OmNvbHVtbkhlYWRlcnMoKSBjb25zdCB7IHJldHVybiBudWxscHRyOyB9CiBQ YXNzUmVmUHRyPEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6 OnNlbGVjdGVkUm93QXRJbmRleCh1bnNpZ25lZCkgeyByZXR1cm4gMDsgfQogUGFzc1JlZlB0cjxB Y2Nlc3NpYmlsaXR5VUlFbGVtZW50PiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpkaXNjbG9zZWRC eVJvdygpIHsgcmV0dXJuIDA7IH0KIFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVVJRWxlbWVudD4g QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6ZGlzY2xvc2VkUm93QXRJbmRleCh1bnNpZ25lZCkgeyBy ZXR1cm4gMDsgfQogUGFzc1JlZlB0cjxBY2Nlc3NpYmlsaXR5VUlFbGVtZW50PiBBY2Nlc3NpYmls aXR5VUlFbGVtZW50Ojpyb3dBdEluZGV4KHVuc2lnbmVkKSB7IHJldHVybiAwOyB9CiBQYXNzUmVm UHRyPEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmFyaWFP d25zRWxlbWVudEF0SW5kZXgodW5zaWduZWQpIHsgcmV0dXJuIDA7IH0KIFBhc3NSZWZQdHI8QWNj ZXNzaWJpbGl0eVVJRWxlbWVudD4gQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6YXJpYUZsb3dUb0Vs ZW1lbnRBdEluZGV4KHVuc2lnbmVkKSB7IHJldHVybiAwOyB9CitQYXNzUmVmUHRyPEFjY2Vzc2li aWxpdHlVSUVsZW1lbnQ+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmFyaWFDb250cm9sc0VsZW1l bnRBdEluZGV4KHVuc2lnbmVkKSB7IHJldHVybiBudWxscHRyOyB9CiBib29sIEFjY2Vzc2liaWxp dHlVSUVsZW1lbnQ6OmFyaWFJc0dyYWJiZWQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogSlNS ZXRhaW5QdHI8SlNTdHJpbmdSZWY+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmFyaWFEcm9wRWZm ZWN0cygpIGNvbnN0IHsgcmV0dXJuIDA7IH0KIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBBY2Nl c3NpYmlsaXR5VUlFbGVtZW50OjpjbGFzc0xpc3QoKSBjb25zdCB7IHJldHVybiAwOyB9Cg== 224309 2014-02-15 19:24:40 -0800 2014-02-15 21:02:47 -0800 Patch bug-128880-20140216122436.patch text/plain 2725 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MTcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjhjZTJkYjBkY2Y1NGJiNmE2YjMwMWIwMDI0NjVkZTdj NzIzZTdkMy4uNDk5NjEyYzI2MDA1ODM0ZTI2ZjhmNDEzOWIwMWRlMThmYzgwZTIzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDE0LTAyLTE1ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAor ICAgICAgICBCdWlsZCBicmVhayB3aGVuIGRpc2FibGVkIEFDQ0VTU0lCSUxJVFkgc2luY2UgcjE2 Mjk4NgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4 ODgwCisKKyAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgKiBXZWJLaXRU ZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuY3BwOgorICAg ICAgICBBZGRlZCBkdW1teSBpbXBsZW1lbnRhdGlvbnMgZm9yIG5ld2x5IGFkZGVkIG1ldGhvZHMu CisgICAgICAgIChXVFI6OkFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnJvd0hlYWRlcnMpOgorICAg ICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojpjb2x1bW5IZWFkZXJzKToKKyAgICAg ICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6YXJpYUNvbnRyb2xzRWxlbWVudEF0SW5k ZXgpOgorCisyMDE0LTAyLTE1ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4K KwogICAgICAgICBbRUZMXVtXSzFdIERvIG5vdCBpbmNsdWRlIGNhaXJvIGhlYWRlciBpbiB0aGUg cHVibGljIGhlYWRlcnMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyODc3OQogCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9JbmplY3RlZEJ1bmRsZS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50LmNwcAppbmRleCA1Mzhj Y2RlYjMwMThkNjkzODIxNjU0YTEyYThhMjEwNDkzN2YyMDI0Li5iYjg3ZDQ2MWU5NWYyMjU4ZmU5 ODg5MWRjOTY3MTM1YjdlMDU1Mjk3IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuY3BwCisrKyBiL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvQWNjZXNzaWJpbGl0eVVJRWxlbWVudC5jcHAK QEAgLTE1NCwxMiArMTU0LDE1IEBAIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBBY2Nlc3NpYmls aXR5VUlFbGVtZW50Ojpyb3dJbmRleFJhbmdlKCkgeyByZXR1cm4gMDsgfQogSlNSZXRhaW5QdHI8 SlNTdHJpbmdSZWY+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmNvbHVtbkluZGV4UmFuZ2UoKSB7 IHJldHVybiAwOyB9CiBpbnQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6cm93Q291bnQoKSB7IHJl dHVybiAwOyB9CiBpbnQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6Y29sdW1uQ291bnQoKSB7IHJl dHVybiAwOyB9CitKU1ZhbHVlUmVmIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnJvd0hlYWRlcnMo KSBjb25zdCB7IHJldHVybiBudWxscHRyOyB9CitKU1ZhbHVlUmVmIEFjY2Vzc2liaWxpdHlVSUVs ZW1lbnQ6OmNvbHVtbkhlYWRlcnMoKSBjb25zdCB7IHJldHVybiBudWxscHRyOyB9CiBQYXNzUmVm UHRyPEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnNlbGVj dGVkUm93QXRJbmRleCh1bnNpZ25lZCkgeyByZXR1cm4gMDsgfQogUGFzc1JlZlB0cjxBY2Nlc3Np YmlsaXR5VUlFbGVtZW50PiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpkaXNjbG9zZWRCeVJvdygp IHsgcmV0dXJuIDA7IH0KIFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVVJRWxlbWVudD4gQWNjZXNz aWJpbGl0eVVJRWxlbWVudDo6ZGlzY2xvc2VkUm93QXRJbmRleCh1bnNpZ25lZCkgeyByZXR1cm4g MDsgfQogUGFzc1JlZlB0cjxBY2Nlc3NpYmlsaXR5VUlFbGVtZW50PiBBY2Nlc3NpYmlsaXR5VUlF bGVtZW50Ojpyb3dBdEluZGV4KHVuc2lnbmVkKSB7IHJldHVybiAwOyB9CiBQYXNzUmVmUHRyPEFj Y2Vzc2liaWxpdHlVSUVsZW1lbnQ+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmFyaWFPd25zRWxl bWVudEF0SW5kZXgodW5zaWduZWQpIHsgcmV0dXJuIDA7IH0KIFBhc3NSZWZQdHI8QWNjZXNzaWJp bGl0eVVJRWxlbWVudD4gQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6YXJpYUZsb3dUb0VsZW1lbnRB dEluZGV4KHVuc2lnbmVkKSB7IHJldHVybiAwOyB9CitQYXNzUmVmUHRyPEFjY2Vzc2liaWxpdHlV SUVsZW1lbnQ+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmFyaWFDb250cm9sc0VsZW1lbnRBdElu ZGV4KHVuc2lnbmVkKSB7IHJldHVybiBudWxscHRyOyB9CiBib29sIEFjY2Vzc2liaWxpdHlVSUVs ZW1lbnQ6OmFyaWFJc0dyYWJiZWQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogSlNSZXRhaW5Q dHI8SlNTdHJpbmdSZWY+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmFyaWFEcm9wRWZmZWN0cygp IGNvbnN0IHsgcmV0dXJuIDA7IH0KIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBBY2Nlc3NpYmls aXR5VUlFbGVtZW50OjpjbGFzc0xpc3QoKSBjb25zdCB7IHJldHVybiAwOyB9Cg==