128871 2014-02-15 07:04:51 -0800 [ASan] WebKit1 sources are not compiled using ASAN macros 2014-02-22 09:27:42 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer aestes commit-queue dfarler mrowe oldest_to_newest 981157 0 ddkilzer 2014-02-15 07:04:51 -0800 The way the OTHER_CPLUSPLUSFLAGS variable is defined in WebKit.xcconfig doesn't include ASAN_OTHER_CPLUSPLUSFLAGS set in DebugRelease.xcconfig, so not all files are compiled with ASan enabled in WebKit1. 981158 1 224298 ddkilzer 2014-02-15 07:06:50 -0800 Created attachment 224298 Patch v1 982472 2 224298 bfulgham 2014-02-19 11:37:08 -0800 Comment on attachment 224298 Patch v1 r=me 982869 3 224298 commit-queue 2014-02-20 10:10:27 -0800 Comment on attachment 224298 Patch v1 Clearing flags on attachment: 224298 Committed r164434: <http://trac.webkit.org/changeset/164434> 982870 4 commit-queue 2014-02-20 10:10:30 -0800 All reviewed patches have been landed. Closing bug. 983598 5 ddkilzer 2014-02-22 09:27:42 -0800 (In reply to comment #3) > (From update of attachment 224298 [details]) > Clearing flags on attachment: 224298 > > Committed r164434: <http://trac.webkit.org/changeset/164434> This change was reverted in r164542: <http://trac.webkit.org/changeset/164542> It actually broke ASan builds when specifying "ARGS=-xcconfig Tools/asan/asan.xcconfig" on the build command-line. 224298 2014-02-15 07:06:50 -0800 2014-02-20 10:10:27 -0800 Patch v1 bug-128871-20140215070649.patch text/plain 2822 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggMWRhMmQ5YjUw MWFjZWRjZDJlM2M1YWQ5YzgyNjA2YWZhYTczNmQwNy4uOGNhMGRiNWVmYTk3NzNhMjJmMDg3NTI2 NTFlOWFiM2NiMTE5OTZhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0 LTAyLTE1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgW0FT YW5dIFdlYktpdDEgc291cmNlcyBhcmUgbm90IGNvbXBpbGVkIHVzaW5nIEFTQU4gbWFjcm9zCisg ICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEyODg3MT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2Nv bmZpZzogVXNlICRpbmhlcml0ZWQgZm9yCisgICAgICAgIE9USEVSX0NGTEFHUyBhbmQgT1RIRVJf Q1BMVVNQTFVTRkxBR1Mgc28gdGhhdCBBU0FOX09USEVSX0NGTEFHUworICAgICAgICBhbmQgQVNB Tl9PVEhFUl9DUExVU1BMVVNGTEFHUyBhcmUgaW5oZXJpdGVkIGZyb20KKyAgICAgICAgRGVidWdS ZWxlYXNlLnhjY29uZmlnLgorCiAyMDE0LTAyLTEzICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhm aWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgRHVyaW5nIGEgY29weSwgcG9zaXRpb246Zml4ZWQg Z2V0cyBjb252ZXJ0ZWQgdG8gcG9zaXRpb246YWJzb2x1dGUgZXZlbiBpZiBvbmx5IHBhcnQgb2Yg dGhlIGRvY3VtZW50IGlzIHNlbGVjdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9D b25maWd1cmF0aW9ucy9XZWJLaXQueGNjb25maWcgYi9Tb3VyY2UvV2ViS2l0L21hYy9Db25maWd1 cmF0aW9ucy9XZWJLaXQueGNjb25maWcKaW5kZXggODhjOTU2YjhiNzVlOTI0YTc0N2RjYzNhNjRl YjRlY2M3MzU3Mzg5Mi4uYmMyZTBkY2UzZDBiNTZhZTBiNzNkOTRjOWM2NmVjODE0NGI4YjViOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvV2ViS2l0LnhjY29u ZmlnCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZp ZwpAQCAtNTMsOSArNTMsOSBAQCBGUkFNRVdPUktfU0VBUkNIX1BBVEhTX21hY29zeCA9ICQoU1RB R0VEX0ZSQU1FV09SS1NfU0VBUkNIX1BBVEgpICQoVU1CUkVMTEFfRlJBTQogU1RBR0VEX0ZSQU1F V09SS1NfU0VBUkNIX1BBVEggPSAkKFNUQUdFRF9GUkFNRVdPUktTX1NFQVJDSF9QQVRIXyQoVVNF X1NUQUdJTkdfSU5TVEFMTF9QQVRIKSk7CiBTVEFHRURfRlJBTUVXT1JLU19TRUFSQ0hfUEFUSF9Z RVMgPSAkKE5FWFRfUk9PVCkkKFNZU1RFTV9MSUJSQVJZX0RJUikvU3RhZ2VkRnJhbWV3b3Jrcy9T YWZhcmk7CiAKLU9USEVSX0NGTEFHUyA9ICQoT1RIRVJfQ0ZMQUdTXyQoUExBVEZPUk1fTkFNRSkp OwotT1RIRVJfQ0ZMQUdTX21hY29zeCA9ICQoT1RIRVJfQ0ZMQUdTKSAtaWZyYW1ld29yayAkKFNE S1JPT1QpJChTWVNURU1fTElCUkFSWV9ESVIpL0ZyYW1ld29ya3MvQXBwbGljYXRpb25TZXJ2aWNl cy5mcmFtZXdvcmsvRnJhbWV3b3JrcyAtaWZyYW1ld29yayAkKFNES1JPT1QpJChTWVNURU1fTElC UkFSWV9ESVIpL0ZyYW1ld29ya3MvQ2FyYm9uLmZyYW1ld29yay9GcmFtZXdvcmtzIC1pZnJhbWV3 b3JrICQoU0RLUk9PVCkkKFNZU1RFTV9MSUJSQVJZX0RJUikvRnJhbWV3b3Jrcy9RdWFydHouZnJh bWV3b3JrL0ZyYW1ld29ya3MgLWlmcmFtZXdvcmsgJChTREtST09UKSQoU1lTVEVNX0xJQlJBUllf RElSKS9GcmFtZXdvcmtzL0NvcmVTZXJ2aWNlcy5mcmFtZXdvcmsvRnJhbWV3b3JrcyAtaWZyYW1l d29yayAkKFNES1JPT1QpJChTWVNURU1fTElCUkFSWV9ESVIpL1ByaXZhdGVGcmFtZXdvcmtzOwot T1RIRVJfQ1BMVVNQTFVTRkxBR1MgPSAkKE9USEVSX0NGTEFHUyk7CitPVEhFUl9DRkxBR1MgPSAk KGluaGVyaXRlZCkgJChPVEhFUl9DRkxBR1NfJChQTEFURk9STV9OQU1FKSk7CitPVEhFUl9DRkxB R1NfbWFjb3N4ID0gLWlmcmFtZXdvcmsgJChTREtST09UKSQoU1lTVEVNX0xJQlJBUllfRElSKS9G cmFtZXdvcmtzL0FwcGxpY2F0aW9uU2VydmljZXMuZnJhbWV3b3JrL0ZyYW1ld29ya3MgLWlmcmFt ZXdvcmsgJChTREtST09UKSQoU1lTVEVNX0xJQlJBUllfRElSKS9GcmFtZXdvcmtzL0NhcmJvbi5m cmFtZXdvcmsvRnJhbWV3b3JrcyAtaWZyYW1ld29yayAkKFNES1JPT1QpJChTWVNURU1fTElCUkFS WV9ESVIpL0ZyYW1ld29ya3MvUXVhcnR6LmZyYW1ld29yay9GcmFtZXdvcmtzIC1pZnJhbWV3b3Jr ICQoU0RLUk9PVCkkKFNZU1RFTV9MSUJSQVJZX0RJUikvRnJhbWV3b3Jrcy9Db3JlU2VydmljZXMu ZnJhbWV3b3JrL0ZyYW1ld29ya3MgLWlmcmFtZXdvcmsgJChTREtST09UKSQoU1lTVEVNX0xJQlJB UllfRElSKS9Qcml2YXRlRnJhbWV3b3JrczsKK09USEVSX0NQTFVTUExVU0ZMQUdTID0gJChpbmhl cml0ZWQpICQoT1RIRVJfQ0ZMQUdTXyQoUExBVEZPUk1fTkFNRSkpOwogCiBHQ0NfUFJFRklYX0hF QURFUiA9IG1hYy9XZWJLaXRQcmVmaXguaDsKIEdDQ19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlMg PSAkKERFQlVHX0RFRklORVMpICQoRkVBVFVSRV9ERUZJTkVTKSBGUkFNRVdPUktfTkFNRT1XZWJL aXQgV0VCS0lUX1ZFUlNJT05fTUlOX1JFUVVJUkVEPVdFQktJVF9WRVJTSU9OX0xBVEVTVCAkKEdD Q19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlMpOwo=