128870 2014-02-15 01:54:47 -0800 HTMLTextFormControlElement::subtreeHasChanged should be called before updating selection 2014-02-15 16:31:24 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa adele ap darin enrica kling koivisto oldest_to_newest 981151 0 rniwa 2014-02-15 01:54:47 -0800 In order to resolve the bug 128806, it's crucial to keep value() of HTMLTextFromControlElement's up-to-date when FrameSelection::setSelection tries to update its selection caches. 981152 1 224294 rniwa 2014-02-15 02:01:51 -0800 Created attachment 224294 Cleanup 981153 2 rniwa 2014-02-15 03:21:08 -0800 Turns out we don't need this change for the bug 128806 but this is probably a good refactoring anyways. 981218 3 224294 rniwa 2014-02-15 16:31:22 -0800 Comment on attachment 224294 Cleanup Clearing flags on attachment: 224294 Committed r164183: <http://trac.webkit.org/changeset/164183> 981219 4 rniwa 2014-02-15 16:31:24 -0800 All reviewed patches have been landed. Closing bug. 224294 2014-02-15 02:01:51 -0800 2014-02-15 16:31:22 -0800 Cleanup bug-128870-20140215020154.patch text/plain 6305 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDE3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTAyLTE1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEhUTUxUZXh0Rm9ybUNvbnRyb2xF bGVtZW50OjpzdWJ0cmVlSGFzQ2hhbmdlZCBzaG91bGQgYmUgY2FsbGVkIGJlZm9yZSB1cGRhdGlu ZyBzZWxlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyODg3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEV4dHJhY3RlZCBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6ZGlkRWRpdElubmVyVGV4 dFZhbHVlIG91dCBvZiBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFu ZGxlcgorICAgICAgICBhbmQgY2FsbGVkIGl0IGluIGFwcGxpZWRFZGl0aW5nLCB1bmFwcGxpZWRF ZGl0aW5nLCBhbmQgcmVhcHBsaWVkRWRpdGluZyBiZWZvcmUgdXBkYXRpbmcgc2VsZWN0aW9uLgor CisgICAgICAgICogZWRpdGluZy9FZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bm90aWZ5 VGV4dEZyb21Db250cm9scyk6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjphcHBs aWVkRWRpdGluZyk6IFVwZGF0ZSB0ZXh0IGZvcm0gY29udHJvbCdzIGludGVybmFsIHN0YXRlcyBi ZWZvcmUgdXBkYXRpbmcgc2VsZWN0aW9uLgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjp1bmFw cGxpZWRFZGl0aW5nKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6OnJlYXBwbGll ZEVkaXRpbmcpOiBEaXR0by4KKyAgICAgICAgKiBodG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50Ojpk aWRFZGl0SW5uZXJUZXh0VmFsdWUpOgorICAgICAgICAqIGh0bWwvVGV4dEZpZWxkSW5wdXRUeXBl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRGaWVsZElucHV0VHlwZTo6c3VidHJlZUhhc0No YW5nZWQpOiBSZW1vdmVkIGEgc3RhbGUgYXNzZXJ0aW9uIGZyb20gdGhlIHRpbWUgd2UgdXNlZCB0 byBkbworICAgICAgICBldmVyeXRoaW5nIGluIHRoZSByZW5kZXIgdHJlZS4KKwogMjAxNC0wMi0x NSAgUmVuYXRhIEhvZG92YW4gIDxyaG9kb3Zhbi51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29t PgogCiAgICAgICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OIGluIFdlYkNvcmU6 OnRvRWxlbWVudApJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAkocmV2aXNpb24gMTY0 MTU3KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMDU1LDYgKzEwNTUsMTYgQEAgdm9pZCBFZGl0b3I6Om91dGRlbnQoKQogICAgIGFwcGx5 Q29tbWFuZChJbmRlbnRPdXRkZW50Q29tbWFuZDo6Y3JlYXRlKGRvY3VtZW50KCksIEluZGVudE91 dGRlbnRDb21tYW5kOjpPdXRkZW50KSk7CiB9CiAKK3N0YXRpYyB2b2lkIG5vdGlmeVRleHRGcm9t Q29udHJvbHMoRWxlbWVudCogc3RhcnRSb290LCBFbGVtZW50KiBlbmRSb290KQoreworICAgIEhU TUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50KiBzdGFydGluZ1RleHRDb250cm9sID0gZW5jbG9zaW5n VGV4dEZvcm1Db250cm9sKGZpcnN0UG9zaXRpb25Jbk9yQmVmb3JlTm9kZShzdGFydFJvb3QpKTsK KyAgICBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudCogZW5kaW5nVGV4dENvbnRyb2wgPSBlbmNs b3NpbmdUZXh0Rm9ybUNvbnRyb2woZmlyc3RQb3NpdGlvbkluT3JCZWZvcmVOb2RlKGVuZFJvb3Qp KTsKKyAgICBpZiAoc3RhcnRpbmdUZXh0Q29udHJvbCkKKyAgICAgICAgc3RhcnRpbmdUZXh0Q29u dHJvbC0+ZGlkRWRpdElubmVyVGV4dFZhbHVlKCk7CisgICAgaWYgKGVuZGluZ1RleHRDb250cm9s ICYmIHN0YXJ0aW5nVGV4dENvbnRyb2wgIT0gZW5kaW5nVGV4dENvbnRyb2wpCisgICAgICAgIGVu ZGluZ1RleHRDb250cm9sLT5kaWRFZGl0SW5uZXJUZXh0VmFsdWUoKTsKK30KKwogc3RhdGljIHZv aWQgZGlzcGF0Y2hFZGl0YWJsZUNvbnRlbnRDaGFuZ2VkRXZlbnRzKFBhc3NSZWZQdHI8RWxlbWVu dD4gcHJwU3RhcnRSb290LCBQYXNzUmVmUHRyPEVsZW1lbnQ+IHBycEVuZFJvb3QpCiB7CiAgICAg UmVmUHRyPEVsZW1lbnQ+IHN0YXJ0Um9vdCA9IHBycFN0YXJ0Um9vdDsKQEAgLTEwNzUsNiArMTA4 NSw4IEBAIHZvaWQgRWRpdG9yOjphcHBsaWVkRWRpdGluZyhQYXNzUmVmUHRyPEMKIAogICAgIG1f YWx0ZXJuYXRpdmVUZXh0Q29udHJvbGxlci0+cmVzcG9uZFRvQXBwbGllZEVkaXRpbmcoY21kLmdl dCgpKTsKIAorICAgIG5vdGlmeVRleHRGcm9tQ29udHJvbHMoY29tcG9zaXRpb24tPnN0YXJ0aW5n Um9vdEVkaXRhYmxlRWxlbWVudCgpLCBjb21wb3NpdGlvbi0+ZW5kaW5nUm9vdEVkaXRhYmxlRWxl bWVudCgpKTsKKwogICAgIC8vIERvbid0IGNsZWFyIHRoZSB0eXBpbmcgc3R5bGUgd2l0aCB0aGlz IHNlbGVjdGlvbiBjaGFuZ2UuICBXZSBkbyB0aG9zZSB0aGluZ3MgZWxzZXdoZXJlIGlmIG5lY2Vz c2FyeS4KICAgICBGcmFtZVNlbGVjdGlvbjo6U2V0U2VsZWN0aW9uT3B0aW9ucyBvcHRpb25zID0g Y21kLT5pc0RpY3RhdGlvbkNvbW1hbmQoKSA/IEZyYW1lU2VsZWN0aW9uOjpEaWN0YXRpb25Ucmln Z2VyZWQgOiAwOwogICAgIGNoYW5nZVNlbGVjdGlvbkFmdGVyQ29tbWFuZChuZXdTZWxlY3Rpb24s IG9wdGlvbnMpOwpAQCAtMTEwMSw2ICsxMTEzLDggQEAgdm9pZCBFZGl0b3I6OnVuYXBwbGllZEVk aXRpbmcoUGFzc1JlZlB0cgogewogICAgIGRvY3VtZW50KCkudXBkYXRlTGF5b3V0KCk7CiAKKyAg ICBub3RpZnlUZXh0RnJvbUNvbnRyb2xzKGNtZC0+c3RhcnRpbmdSb290RWRpdGFibGVFbGVtZW50 KCksIGNtZC0+ZW5kaW5nUm9vdEVkaXRhYmxlRWxlbWVudCgpKTsKKwogICAgIFZpc2libGVTZWxl Y3Rpb24gbmV3U2VsZWN0aW9uKGNtZC0+c3RhcnRpbmdTZWxlY3Rpb24oKSk7CiAgICAgY2hhbmdl U2VsZWN0aW9uQWZ0ZXJDb21tYW5kKG5ld1NlbGVjdGlvbiwgRnJhbWVTZWxlY3Rpb246OmRlZmF1 bHRTZXRTZWxlY3Rpb25PcHRpb25zKCkpOwogICAgIGRpc3BhdGNoRWRpdGFibGVDb250ZW50Q2hh bmdlZEV2ZW50cyhjbWQtPnN0YXJ0aW5nUm9vdEVkaXRhYmxlRWxlbWVudCgpLCBjbWQtPmVuZGlu Z1Jvb3RFZGl0YWJsZUVsZW1lbnQoKSk7CkBAIC0xMTE3LDYgKzExMzEsOCBAQCB2b2lkIEVkaXRv cjo6cmVhcHBsaWVkRWRpdGluZyhQYXNzUmVmUHRyCiB7CiAgICAgZG9jdW1lbnQoKS51cGRhdGVM YXlvdXQoKTsKIAorICAgIG5vdGlmeVRleHRGcm9tQ29udHJvbHMoY21kLT5zdGFydGluZ1Jvb3RF ZGl0YWJsZUVsZW1lbnQoKSwgY21kLT5lbmRpbmdSb290RWRpdGFibGVFbGVtZW50KCkpOworCiAg ICAgVmlzaWJsZVNlbGVjdGlvbiBuZXdTZWxlY3Rpb24oY21kLT5lbmRpbmdTZWxlY3Rpb24oKSk7 CiAgICAgY2hhbmdlU2VsZWN0aW9uQWZ0ZXJDb21tYW5kKG5ld1NlbGVjdGlvbiwgRnJhbWVTZWxl Y3Rpb246OmRlZmF1bHRTZXRTZWxlY3Rpb25PcHRpb25zKCkpOwogICAgIGRpc3BhdGNoRWRpdGFi bGVDb250ZW50Q2hhbmdlZEV2ZW50cyhjbWQtPnN0YXJ0aW5nUm9vdEVkaXRhYmxlRWxlbWVudCgp LCBjbWQtPmVuZGluZ1Jvb3RFZGl0YWJsZUVsZW1lbnQoKSk7CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAkocmV2aXNpb24g MTY0MTU3KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMiwxNSArMTAyLDEzIEBAIHZvaWQgSFRNTFRleHRG b3JtQ29udHJvbEVsZW1lbnQ6OmRpc3BhdGMKICAgICBIVE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0 aFN0YXRlOjpkaXNwYXRjaEJsdXJFdmVudChuZXdGb2N1c2VkRWxlbWVudCk7CiB9CiAKLXZvaWQg SFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIoRXZlbnQqIGV2 ZW50KQordm9pZCBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6ZGlkRWRpdElubmVyVGV4dFZh bHVlKCkKIHsKLSAgICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkud2Via2l0RWRp dGFibGVDb250ZW50Q2hhbmdlZEV2ZW50ICYmIHJlbmRlcmVyKCkgJiYgcmVuZGVyZXIoKS0+aXNU ZXh0Q29udHJvbCgpKSB7Ci0gICAgICAgIG1fbGFzdENoYW5nZVdhc1VzZXJFZGl0ID0gdHJ1ZTsK LSAgICAgICAgc3VidHJlZUhhc0NoYW5nZWQoKTsKKyAgICBpZiAoIWlzVGV4dEZvcm1Db250cm9s KCkpCiAgICAgICAgIHJldHVybjsKLSAgICB9CiAKLSAgICBIVE1MRm9ybUNvbnRyb2xFbGVtZW50 V2l0aFN0YXRlOjpkZWZhdWx0RXZlbnRIYW5kbGVyKGV2ZW50KTsKKyAgICBtX2xhc3RDaGFuZ2VX YXNVc2VyRWRpdCA9IHRydWU7CisgICAgc3VidHJlZUhhc0NoYW5nZWQoKTsKIH0KIAogdm9pZCBI VE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6Zm9yd2FyZEV2ZW50KEV2ZW50KiBldmVudCkKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50 LmgJKHJldmlzaW9uIDE2NDE1NykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRGb3Jt Q29udHJvbEVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDQsNiArNDQsNyBAQCBwdWJsaWM6 CiAKICAgICB2aXJ0dWFsIH5IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudCgpOwogCisgICAgdm9p ZCBkaWRFZGl0SW5uZXJUZXh0VmFsdWUoKTsKICAgICB2b2lkIGZvcndhcmRFdmVudChFdmVudCop OwogCiAgICAgdmlydHVhbCBJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IGluc2VydGVkSW50 byhDb250YWluZXJOb2RlJikgb3ZlcnJpZGU7CkBAIC0xMDgsNyArMTA5LDYgQEAgcHJvdGVjdGVk OgogICAgIHZvaWQgcmVzdG9yZUNhY2hlZFNlbGVjdGlvbigpOwogICAgIGJvb2wgaGFzQ2FjaGVk U2VsZWN0aW9uKCkgY29uc3QgeyByZXR1cm4gbV9jYWNoZWRTZWxlY3Rpb25TdGFydCA+PSAwOyB9 CiAKLSAgICB2aXJ0dWFsIHZvaWQgZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCopIG92ZXJyaWRl OwogICAgIHZpcnR1YWwgdm9pZCBzdWJ0cmVlSGFzQ2hhbmdlZCgpID0gMDsKIAogICAgIHZvaWQg c2V0TGFzdENoYW5nZVdhc05vdFVzZXJFZGl0KCkgeyBtX2xhc3RDaGFuZ2VXYXNVc2VyRWRpdCA9 IGZhbHNlOyB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUu Y3BwCShyZXZpc2lvbiAxNjQxNTcpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElu cHV0VHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0Myw4ICs0NDMsNiBAQCBTdHJpbmcgVGV4 dEZpZWxkSW5wdXRUeXBlOjpjb252ZXJ0RnJvbVZpCiAKIHZvaWQgVGV4dEZpZWxkSW5wdXRUeXBl OjpzdWJ0cmVlSGFzQ2hhbmdlZCgpCiB7Ci0gICAgQVNTRVJUKGVsZW1lbnQoKS5yZW5kZXJlcigp KTsKLQogICAgIGJvb2wgd2FzQ2hhbmdlZCA9IGVsZW1lbnQoKS53YXNDaGFuZ2VkU2luY2VMYXN0 Rm9ybUNvbnRyb2xDaGFuZ2VFdmVudCgpOwogICAgIGVsZW1lbnQoKS5zZXRDaGFuZ2VkU2luY2VM YXN0Rm9ybUNvbnRyb2xDaGFuZ2VFdmVudCh0cnVlKTsKIAo=