128867 2014-02-15 00:58:41 -0800 Setting currentTime on HTMLMediaElement with media controller should throw exception 2014-02-19 10:06:05 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 piotr.grad webkit-unassigned cdumez commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble kondapallykalyan philipj sergio oldest_to_newest 981142 0 piotr.grad 2014-02-15 00:58:41 -0800 According to spec. On setting, if the media element has a current media controller, then the user agent must throw an InvalidStateError exception [1] [1] http://www.w3.org/TR/html51/embedded-content-0.html#dom-media-currenttime 981155 1 224296 piotr.grad 2014-02-15 03:37:37 -0800 Created attachment 224296 Patch & layout test 981156 2 224297 piotr.grad 2014-02-15 03:41:14 -0800 Created attachment 224297 Patch & layout test 981159 3 224297 eric.carlson 2014-02-15 08:24:53 -0800 Comment on attachment 224297 Patch & layout test View in context: https://bugs.webkit.org/attachment.cgi?id=224297&action=review > LayoutTests/media/video-controller-currentTime.html:7 > + function start() { Nit: a function's opening brace should be on a new line. > LayoutTests/media/video-controller-currentTime.html:13 > + function canPlayThrough() { Ditto. > LayoutTests/media/video-controller-currentTime.html:19 > + try { > + video.currentTime = 3; > + } catch (e) { > + consoleWrite(e); > + endTest(); > + } You should also test that an INVALID_STATE_ERR exception is thrown, eg.: testDOMException("video.currentTime = 3", "DOMException.INVALID_STATE_ERR"); 981160 4 224299 piotr.grad 2014-02-15 08:39:16 -0800 Created attachment 224299 Patch & layout test 981163 5 224299 eric.carlson 2014-02-15 09:24:53 -0800 Comment on attachment 224299 Patch & layout test Thank you! 981177 6 224299 commit-queue 2014-02-15 09:55:13 -0800 Comment on attachment 224299 Patch & layout test Clearing flags on attachment: 224299 Committed r164174: <http://trac.webkit.org/changeset/164174> 981178 7 commit-queue 2014-02-15 09:55:16 -0800 All reviewed patches have been landed. Closing bug. 982395 8 224299 darin 2014-02-19 10:06:05 -0800 Comment on attachment 224299 Patch & layout test View in context: https://bugs.webkit.org/attachment.cgi?id=224299&action=review > Source/WebCore/html/HTMLMediaElement.h:183 > + virtual void setCurrentTime(double, ExceptionCode&); I see no reason for this function to be virtual. 224296 2014-02-15 03:37:37 -0800 2014-02-15 03:41:14 -0800 Patch & layout test patch.txt text/plain 5130 piotr.grad ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYmExZTlkLi4xNzMyNTYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDIt MTUgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgU2V0dGluZyBj dXJyZW50VGltZSBvbiBIVE1MTWVkaWFFbGVtZW50IHdpdGggbWVkaWEgY29udHJvbGxlciBzaG91 bGQgdGhyb3cgZXhjZXB0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI4ODY3LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogbWVkaWEvdmlkZW8tY29udHJvbGxlci1jdXJyZW50VGltZS1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL3ZpZGVvLWNvbnRyb2xsZXItY3VycmVudFRp bWUuaHRtbDogQWRkZWQuCisKIDIwMTQtMDItMTUgIFJlbmF0YSBIb2RvdmFuICA8cmhvZG92YW4u dS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBBU1NFUlRfV0lUSF9TRUNV UklUWV9JTVBMSUNBVElPTiBpbiBXZWJDb3JlOjp0b0VsZW1lbnQKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xsZXItY3VycmVudFRpbWUtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJvbGxlci1jdXJyZW50VGltZS1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZWFhMzZjNgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xsZXItY3VycmVudFRpbWUt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorCitUZXN0IHRoYXQgc2Vla2luZyB2aWRlbyB3 aXRoIG1lZGlhIGNvbnRyb2xsZXIgdGhyb3dzIGludmFsaWQgc3RhdGUgZXhjZXB0aW9uLgorCitF VkVOVChjYW5wbGF5dGhyb3VnaCkKK0Vycm9yOiBJbnZhbGlkU3RhdGVFcnJvcjogRE9NIEV4Y2Vw dGlvbiAxMQorRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlk ZW8tY29udHJvbGxlci1jdXJyZW50VGltZS5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8t Y29udHJvbGxlci1jdXJyZW50VGltZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLmRlMmQyMzkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRl by1jb250cm9sbGVyLWN1cnJlbnRUaW1lLmh0bWwKQEAgLTAsMCArMSwyOCBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHNjcmlwdCBzcmM9bWVkaWEtZmls ZS5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3Njcmlw dD4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgICAgIGZ1bmN0aW9uIHN0YXJ0KCkgeworICAg ICAgICAgICAgICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKyAgICAgICAgICAgICAgICB2aWRlby5z cmMgPSBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJjb250ZW50L3Rlc3QiKTsKKyAgICAgICAgICAg ICAgICB3YWl0Rm9yRXZlbnRPbmNlKCdjYW5wbGF5dGhyb3VnaCcsIGNhblBsYXlUaHJvdWdoKTsK KyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gY2FuUGxheVRocm91Z2goKSB7 CisgICAgICAgICAgICAgICAgdHJ5IHsKKyAgICAgICAgICAgICAgICAgICAgdmlkZW8uY3VycmVu dFRpbWUgPSAzOworICAgICAgICAgICAgICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgICAgICAg ICAgICAgY29uc29sZVdyaXRlKGUpOworICAgICAgICAgICAgICAgICAgICBlbmRUZXN0KCk7Cisg ICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIGZhaWxUZXN0KCJFeGNlcHRpb24gd2Fz IG5vdCB0aHJvd24iKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgPC9zY3JpcHQ+CisgICAgPC9o ZWFkPgorICAgIDxib2R5IG9ubG9hZD0ic3RhcnQoKSI+CisgICAgICAgIDx2aWRlbyBtZWRpYUdy b3VwPSJncm91cCIgY29udHJvbHM+PC92aWRlbz4KKyAgICAgICAgPHA+VGVzdCB0aGF0IHNlZWtp bmcgdmlkZW8gd2l0aCBtZWRpYSBjb250cm9sbGVyIHRocm93cyBpbnZhbGlkIHN0YXRlIGV4Y2Vw dGlvbi48L3A+CisgICAgPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZp bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA1ZTQ4NDRiLi5hZTk4NzBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MjAgQEAKKzIwMTQtMDItMTUgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgU2V0dGluZyBjdXJyZW50VGltZSBvbiBIVE1MTWVkaWFFbGVtZW50IHdpdGggbWVkaWEg Y29udHJvbGxlciBzaG91bGQgdGhyb3cgZXhjZXB0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4ODY3LgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGltcGxlbWVudGF0aW9uIGZvciBzZXR0 aW5nIGN1cnJlbnRUaW1lIGluIEhUTUxNZWRpYUVsZW1lbnQuIE9sZCBpbXBsZW1lbnRhdGlvbgor ICAgICAgICB3YXMgbGVmdCB0byBiZSB1c2VkIGludGVybmFsbHkuCisKKyAgICAgICAgVGVzdDog bWVkaWEvdmlkZW8tY29udHJvbGxlci1jdXJyZW50VGltZS5odG1sCisKKyAgICAgICAgKiBodG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVu dDo6cGFyc2VBdHRyaWJ1dGUpOgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOgor ICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5pZGw6CisKIDIwMTQtMDItMTUgIFJlbmF0 YSBIb2RvdmFuICA8cmhvZG92YW4udS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAg ICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTiBpbiBXZWJDb3JlOjp0b0VsZW1l bnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IDk5OGIxZWYu LmZkZWY3Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAt MjUxNCwxMiArMjUxNCwyNSBAQCBkb3VibGUgSFRNTE1lZGlhRWxlbWVudDo6Y3VycmVudFRpbWUo KSBjb25zdAogCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldEN1cnJlbnRUaW1lKGRvdWJsZSB0 aW1lKQogeworCiAgICAgaWYgKG1fbWVkaWFDb250cm9sbGVyKQogICAgICAgICByZXR1cm47CiAK ICAgICBzZWVrKHRpbWUpOwogfQogCit2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldEN1cnJlbnRU aW1lKGRvdWJsZSB0aW1lLCBFeGNlcHRpb25Db2RlJiBlYykKK3sKKyAgICAvLyBPbiBzZXR0aW5n LCBpZiB0aGUgbWVkaWEgZWxlbWVudCBoYXMgYSBjdXJyZW50IG1lZGlhIGNvbnRyb2xsZXIsIHRo ZW4gdGhlIHVzZXIgYWdlbnQgbXVzdAorICAgIC8vIHRocm93IGFuIEludmFsaWRTdGF0ZUVycm9y IGV4Y2VwdGlvbgorICAgIGlmIChtX21lZGlhQ29udHJvbGxlcikgeworICAgICAgICBlYyA9IElO VkFMSURfU1RBVEVfRVJSOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgc2Vlayh0aW1l KTsKK30KKwogZG91YmxlIEhUTUxNZWRpYUVsZW1lbnQ6OmR1cmF0aW9uKCkgY29uc3QKIHsKICAg ICBpZiAobV9wbGF5ZXIgJiYgbV9yZWFkeVN0YXRlID49IEhBVkVfTUVUQURBVEEpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmluZGV4IDZkNWU0ZTMuLmI4YTQ2ZGIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC0xODAsNiArMTgwLDcgQEAgcHVi bGljOgogLy8gcGxheWJhY2sgc3RhdGUKICAgICB2aXJ0dWFsIGRvdWJsZSBjdXJyZW50VGltZSgp IGNvbnN0IG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBzZXRDdXJyZW50VGltZShkb3VibGUp IG92ZXJyaWRlOworICAgIHZpcnR1YWwgdm9pZCBzZXRDdXJyZW50VGltZShkb3VibGUsIEV4Y2Vw dGlvbkNvZGUmKTsKICAgICB2aXJ0dWFsIGRvdWJsZSBkdXJhdGlvbigpIGNvbnN0IG92ZXJyaWRl OwogICAgIHZpcnR1YWwgYm9vbCBwYXVzZWQoKSBjb25zdCBvdmVycmlkZTsKICAgICB2aXJ0dWFs IGRvdWJsZSBkZWZhdWx0UGxheWJhY2tSYXRlKCkgY29uc3Qgb3ZlcnJpZGU7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbAppbmRleCAzMDExOTRjLi43YTI2ZWQxZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaWRsCkBAIC02Myw3ICs2Myw3IEBA CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gc2Vla2luZzsKIAogICAgIC8vIHBsYXli YWNrIHN0YXRlCi0gICAgYXR0cmlidXRlIGRvdWJsZSBjdXJyZW50VGltZTsKKyAgICBbU2V0dGVy UmFpc2VzRXhjZXB0aW9uXSBhdHRyaWJ1dGUgZG91YmxlIGN1cnJlbnRUaW1lOwogICAgIHJlYWRv bmx5IGF0dHJpYnV0ZSBkb3VibGUgZHVyYXRpb247CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJv b2xlYW4gcGF1c2VkOwogICAgIGF0dHJpYnV0ZSBkb3VibGUgZGVmYXVsdFBsYXliYWNrUmF0ZTsK 224297 2014-02-15 03:41:14 -0800 2014-02-15 08:39:16 -0800 Patch & layout test patch.txt text/plain 5029 piotr.grad ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYmExZTlkLi4xNzMyNTYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDIt MTUgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgU2V0dGluZyBj dXJyZW50VGltZSBvbiBIVE1MTWVkaWFFbGVtZW50IHdpdGggbWVkaWEgY29udHJvbGxlciBzaG91 bGQgdGhyb3cgZXhjZXB0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI4ODY3LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogbWVkaWEvdmlkZW8tY29udHJvbGxlci1jdXJyZW50VGltZS1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL3ZpZGVvLWNvbnRyb2xsZXItY3VycmVudFRp bWUuaHRtbDogQWRkZWQuCisKIDIwMTQtMDItMTUgIFJlbmF0YSBIb2RvdmFuICA8cmhvZG92YW4u dS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBBU1NFUlRfV0lUSF9TRUNV UklUWV9JTVBMSUNBVElPTiBpbiBXZWJDb3JlOjp0b0VsZW1lbnQKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xsZXItY3VycmVudFRpbWUtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJvbGxlci1jdXJyZW50VGltZS1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZWFhMzZjNgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xsZXItY3VycmVudFRpbWUt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorCitUZXN0IHRoYXQgc2Vla2luZyB2aWRlbyB3 aXRoIG1lZGlhIGNvbnRyb2xsZXIgdGhyb3dzIGludmFsaWQgc3RhdGUgZXhjZXB0aW9uLgorCitF VkVOVChjYW5wbGF5dGhyb3VnaCkKK0Vycm9yOiBJbnZhbGlkU3RhdGVFcnJvcjogRE9NIEV4Y2Vw dGlvbiAxMQorRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlk ZW8tY29udHJvbGxlci1jdXJyZW50VGltZS5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8t Y29udHJvbGxlci1jdXJyZW50VGltZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLmRlMmQyMzkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRl by1jb250cm9sbGVyLWN1cnJlbnRUaW1lLmh0bWwKQEAgLTAsMCArMSwyOCBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHNjcmlwdCBzcmM9bWVkaWEtZmls ZS5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3Njcmlw dD4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgICAgIGZ1bmN0aW9uIHN0YXJ0KCkgeworICAg ICAgICAgICAgICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKyAgICAgICAgICAgICAgICB2aWRlby5z cmMgPSBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJjb250ZW50L3Rlc3QiKTsKKyAgICAgICAgICAg ICAgICB3YWl0Rm9yRXZlbnRPbmNlKCdjYW5wbGF5dGhyb3VnaCcsIGNhblBsYXlUaHJvdWdoKTsK KyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gY2FuUGxheVRocm91Z2goKSB7 CisgICAgICAgICAgICAgICAgdHJ5IHsKKyAgICAgICAgICAgICAgICAgICAgdmlkZW8uY3VycmVu dFRpbWUgPSAzOworICAgICAgICAgICAgICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgICAgICAg ICAgICAgY29uc29sZVdyaXRlKGUpOworICAgICAgICAgICAgICAgICAgICBlbmRUZXN0KCk7Cisg ICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIGZhaWxUZXN0KCJFeGNlcHRpb24gd2Fz IG5vdCB0aHJvd24iKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgPC9zY3JpcHQ+CisgICAgPC9o ZWFkPgorICAgIDxib2R5IG9ubG9hZD0ic3RhcnQoKSI+CisgICAgICAgIDx2aWRlbyBtZWRpYUdy b3VwPSJncm91cCIgY29udHJvbHM+PC92aWRlbz4KKyAgICAgICAgPHA+VGVzdCB0aGF0IHNlZWtp bmcgdmlkZW8gd2l0aCBtZWRpYSBjb250cm9sbGVyIHRocm93cyBpbnZhbGlkIHN0YXRlIGV4Y2Vw dGlvbi48L3A+CisgICAgPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZp bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA1ZTQ4NDRiLi5hZTk4NzBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MjAgQEAKKzIwMTQtMDItMTUgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgU2V0dGluZyBjdXJyZW50VGltZSBvbiBIVE1MTWVkaWFFbGVtZW50IHdpdGggbWVkaWEg Y29udHJvbGxlciBzaG91bGQgdGhyb3cgZXhjZXB0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4ODY3LgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGltcGxlbWVudGF0aW9uIGZvciBzZXR0 aW5nIGN1cnJlbnRUaW1lIGluIEhUTUxNZWRpYUVsZW1lbnQuIE9sZCBpbXBsZW1lbnRhdGlvbgor ICAgICAgICB3YXMgbGVmdCB0byBiZSB1c2VkIGludGVybmFsbHkuCisKKyAgICAgICAgVGVzdDog bWVkaWEvdmlkZW8tY29udHJvbGxlci1jdXJyZW50VGltZS5odG1sCisKKyAgICAgICAgKiBodG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVu dDo6cGFyc2VBdHRyaWJ1dGUpOgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOgor ICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5pZGw6CisKIDIwMTQtMDItMTUgIFJlbmF0 YSBIb2RvdmFuICA8cmhvZG92YW4udS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAg ICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTiBpbiBXZWJDb3JlOjp0b0VsZW1l bnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IDk5OGIxZWYu LjFkZDI1MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAt MjUyMCw2ICsyNTIwLDE4IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2V0Q3VycmVudFRpbWUo ZG91YmxlIHRpbWUpCiAgICAgc2Vlayh0aW1lKTsKIH0KIAordm9pZCBIVE1MTWVkaWFFbGVtZW50 OjpzZXRDdXJyZW50VGltZShkb3VibGUgdGltZSwgRXhjZXB0aW9uQ29kZSYgZWMpCit7CisgICAg Ly8gT24gc2V0dGluZywgaWYgdGhlIG1lZGlhIGVsZW1lbnQgaGFzIGEgY3VycmVudCBtZWRpYSBj b250cm9sbGVyLCB0aGVuIHRoZSB1c2VyIGFnZW50IG11c3QKKyAgICAvLyB0aHJvdyBhbiBJbnZh bGlkU3RhdGVFcnJvciBleGNlcHRpb24KKyAgICBpZiAobV9tZWRpYUNvbnRyb2xsZXIpIHsKKyAg ICAgICAgZWMgPSBJTlZBTElEX1NUQVRFX0VSUjsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwor ICAgIHNlZWsodGltZSk7Cit9CisKIGRvdWJsZSBIVE1MTWVkaWFFbGVtZW50OjpkdXJhdGlvbigp IGNvbnN0CiB7CiAgICAgaWYgKG1fcGxheWVyICYmIG1fcmVhZHlTdGF0ZSA+PSBIQVZFX01FVEFE QVRBKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAppbmRleCA2ZDVlNGUzLi5i OGE0NmRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaApAQCAtMTgwLDYg KzE4MCw3IEBAIHB1YmxpYzoKIC8vIHBsYXliYWNrIHN0YXRlCiAgICAgdmlydHVhbCBkb3VibGUg Y3VycmVudFRpbWUoKSBjb25zdCBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q3VycmVu dFRpbWUoZG91YmxlKSBvdmVycmlkZTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0Q3VycmVudFRpbWUo ZG91YmxlLCBFeGNlcHRpb25Db2RlJik7CiAgICAgdmlydHVhbCBkb3VibGUgZHVyYXRpb24oKSBj b25zdCBvdmVycmlkZTsKICAgICB2aXJ0dWFsIGJvb2wgcGF1c2VkKCkgY29uc3Qgb3ZlcnJpZGU7 CiAgICAgdmlydHVhbCBkb3VibGUgZGVmYXVsdFBsYXliYWNrUmF0ZSgpIGNvbnN0IG92ZXJyaWRl OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5pZGwKaW5kZXggMzAxMTk0Yy4u N2EyNmVkMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbApAQCAt NjMsNyArNjMsNyBAQAogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIHNlZWtpbmc7CiAK ICAgICAvLyBwbGF5YmFjayBzdGF0ZQotICAgIGF0dHJpYnV0ZSBkb3VibGUgY3VycmVudFRpbWU7 CisgICAgW1NldHRlclJhaXNlc0V4Y2VwdGlvbl0gYXR0cmlidXRlIGRvdWJsZSBjdXJyZW50VGlt ZTsKICAgICByZWFkb25seSBhdHRyaWJ1dGUgZG91YmxlIGR1cmF0aW9uOwogICAgIHJlYWRvbmx5 IGF0dHJpYnV0ZSBib29sZWFuIHBhdXNlZDsKICAgICBhdHRyaWJ1dGUgZG91YmxlIGRlZmF1bHRQ bGF5YmFja1JhdGU7Cg== 224299 2014-02-15 08:39:16 -0800 2014-02-19 10:06:05 -0800 Patch & layout test patch.txt text/plain 4962 piotr.grad ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYmExZTlkLi4xNzMyNTYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDIt MTUgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgU2V0dGluZyBj dXJyZW50VGltZSBvbiBIVE1MTWVkaWFFbGVtZW50IHdpdGggbWVkaWEgY29udHJvbGxlciBzaG91 bGQgdGhyb3cgZXhjZXB0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI4ODY3LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogbWVkaWEvdmlkZW8tY29udHJvbGxlci1jdXJyZW50VGltZS1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL3ZpZGVvLWNvbnRyb2xsZXItY3VycmVudFRp bWUuaHRtbDogQWRkZWQuCisKIDIwMTQtMDItMTUgIFJlbmF0YSBIb2RvdmFuICA8cmhvZG92YW4u dS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBBU1NFUlRfV0lUSF9TRUNV UklUWV9JTVBMSUNBVElPTiBpbiBXZWJDb3JlOjp0b0VsZW1lbnQKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xsZXItY3VycmVudFRpbWUtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJvbGxlci1jdXJyZW50VGltZS1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZTE5Yzc3YwotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xsZXItY3VycmVudFRpbWUt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorCitUZXN0IHRoYXQgc2Vla2luZyB2aWRlbyB3 aXRoIG1lZGlhIGNvbnRyb2xsZXIgdGhyb3dzIGludmFsaWQgc3RhdGUgZXhjZXB0aW9uLgorCitF VkVOVChjYW5wbGF5dGhyb3VnaCkKK1RFU1QodmlkZW8uY3VycmVudFRpbWUgPSAzKSBUSFJPV1Mo RE9NRXhjZXB0aW9uLklOVkFMSURfU1RBVEVfRVJSKSBPSworRU5EIE9GIFRFU1QKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJvbGxlci1jdXJyZW50VGltZS5odG1s IGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJvbGxlci1jdXJyZW50VGltZS5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjM4MTM1MGQKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1jb250cm9sbGVyLWN1cnJlbnRUaW1lLmh0bWwK QEAgLTAsMCArMSwyNSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAg ICAgICAgPHNjcmlwdCBzcmM9bWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlw dCBzcmM9dmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAg ICAgIGZ1bmN0aW9uIHN0YXJ0KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBmaW5k TWVkaWFFbGVtZW50KCk7CisgICAgICAgICAgICAgICAgdmlkZW8uc3JjID0gZmluZE1lZGlhRmls ZSgidmlkZW8iLCAiY29udGVudC90ZXN0Iik7CisgICAgICAgICAgICAgICAgd2FpdEZvckV2ZW50 T25jZSgnY2FucGxheXRocm91Z2gnLCBjYW5QbGF5VGhyb3VnaCk7CisgICAgICAgICAgICB9CisK KyAgICAgICAgICAgIGZ1bmN0aW9uIGNhblBsYXlUaHJvdWdoKCkKKyAgICAgICAgICAgIHsKKyAg ICAgICAgICAgICAgICB0ZXN0RE9NRXhjZXB0aW9uKCJ2aWRlby5jdXJyZW50VGltZSA9IDMiLCAi RE9NRXhjZXB0aW9uLklOVkFMSURfU1RBVEVfRVJSIik7CisgICAgICAgICAgICAgICAgZW5kVGVz dCgpOworICAgICAgICAgICAgfQorICAgICAgICA8L3NjcmlwdD4KKyAgICA8L2hlYWQ+CisgICAg PGJvZHkgb25sb2FkPSJzdGFydCgpIj4KKyAgICAgICAgPHZpZGVvIG1lZGlhR3JvdXA9Imdyb3Vw IiBjb250cm9scz48L3ZpZGVvPgorICAgICAgICA8cD5UZXN0IHRoYXQgc2Vla2luZyB2aWRlbyB3 aXRoIG1lZGlhIGNvbnRyb2xsZXIgdGhyb3dzIGludmFsaWQgc3RhdGUgZXhjZXB0aW9uLjwvcD4K KyAgICA8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IDVlNDg0NGIuLmFlOTg3MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAx NC0wMi0xNSAgUGlvdHIgR3JhZCAgPHAuZ3JhZEBzYW1zdW5nLmNvbT4KKworICAgICAgICBTZXR0 aW5nIGN1cnJlbnRUaW1lIG9uIEhUTUxNZWRpYUVsZW1lbnQgd2l0aCBtZWRpYSBjb250cm9sbGVy IHNob3VsZCB0aHJvdyBleGNlcHRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjg4NjcuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkZWQgaW1wbGVtZW50YXRpb24gZm9yIHNldHRpbmcgY3VycmVu dFRpbWUgaW4gSFRNTE1lZGlhRWxlbWVudC4gT2xkIGltcGxlbWVudGF0aW9uCisgICAgICAgIHdh cyBsZWZ0IHRvIGJlIHVzZWQgaW50ZXJuYWxseS4KKworICAgICAgICBUZXN0OiBtZWRpYS92aWRl by1jb250cm9sbGVyLWN1cnJlbnRUaW1lLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpwYXJzZUF0 dHJpYnV0ZSk6CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50Lmg6CisgICAgICAgICog aHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbDoKKwogMjAxNC0wMi0xNSAgUmVuYXRhIEhvZG92YW4g IDxyaG9kb3Zhbi51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAgICAgICAgIEFTU0VS VF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OIGluIFdlYkNvcmU6OnRvRWxlbWVudApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggOTk4YjFlZi4uMWRkMjUzNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC0yNTIwLDYgKzI1 MjAsMTggQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpzZXRDdXJyZW50VGltZShkb3VibGUgdGlt ZSkKICAgICBzZWVrKHRpbWUpOwogfQogCit2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldEN1cnJl bnRUaW1lKGRvdWJsZSB0aW1lLCBFeGNlcHRpb25Db2RlJiBlYykKK3sKKyAgICAvLyBPbiBzZXR0 aW5nLCBpZiB0aGUgbWVkaWEgZWxlbWVudCBoYXMgYSBjdXJyZW50IG1lZGlhIGNvbnRyb2xsZXIs IHRoZW4gdGhlIHVzZXIgYWdlbnQgbXVzdAorICAgIC8vIHRocm93IGFuIEludmFsaWRTdGF0ZUVy cm9yIGV4Y2VwdGlvbgorICAgIGlmIChtX21lZGlhQ29udHJvbGxlcikgeworICAgICAgICBlYyA9 IElOVkFMSURfU1RBVEVfRVJSOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgc2Vlayh0 aW1lKTsKK30KKwogZG91YmxlIEhUTUxNZWRpYUVsZW1lbnQ6OmR1cmF0aW9uKCkgY29uc3QKIHsK ICAgICBpZiAobV9wbGF5ZXIgJiYgbV9yZWFkeVN0YXRlID49IEhBVkVfTUVUQURBVEEpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmluZGV4IDZkNWU0ZTMuLmI4YTQ2ZGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC0xODAsNiArMTgwLDcgQEAg cHVibGljOgogLy8gcGxheWJhY2sgc3RhdGUKICAgICB2aXJ0dWFsIGRvdWJsZSBjdXJyZW50VGlt ZSgpIGNvbnN0IG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBzZXRDdXJyZW50VGltZShkb3Vi bGUpIG92ZXJyaWRlOworICAgIHZpcnR1YWwgdm9pZCBzZXRDdXJyZW50VGltZShkb3VibGUsIEV4 Y2VwdGlvbkNvZGUmKTsKICAgICB2aXJ0dWFsIGRvdWJsZSBkdXJhdGlvbigpIGNvbnN0IG92ZXJy aWRlOwogICAgIHZpcnR1YWwgYm9vbCBwYXVzZWQoKSBjb25zdCBvdmVycmlkZTsKICAgICB2aXJ0 dWFsIGRvdWJsZSBkZWZhdWx0UGxheWJhY2tSYXRlKCkgY29uc3Qgb3ZlcnJpZGU7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaWRsIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbAppbmRleCAzMDExOTRjLi43YTI2ZWQxZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaWRsCkBAIC02Myw3ICs2Myw3 IEBACiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gc2Vla2luZzsKIAogICAgIC8vIHBs YXliYWNrIHN0YXRlCi0gICAgYXR0cmlidXRlIGRvdWJsZSBjdXJyZW50VGltZTsKKyAgICBbU2V0 dGVyUmFpc2VzRXhjZXB0aW9uXSBhdHRyaWJ1dGUgZG91YmxlIGN1cnJlbnRUaW1lOwogICAgIHJl YWRvbmx5IGF0dHJpYnV0ZSBkb3VibGUgZHVyYXRpb247CiAgICAgcmVhZG9ubHkgYXR0cmlidXRl IGJvb2xlYW4gcGF1c2VkOwogICAgIGF0dHJpYnV0ZSBkb3VibGUgZGVmYXVsdFBsYXliYWNrUmF0 ZTsK