128848 2014-02-14 15:17:22 -0800 [Win] Make tests more consistent with Mac platform 2014-02-14 16:17:45 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham webkit-bug-importer oldest_to_newest 981009 0 bfulgham 2014-02-14 15:17:22 -0800 A number of test differences have crept in to the Windows port during the last year or so of development. This bug brings them back into sync: 1. We should be using Mock scrollbars so we can share common expected output. 2. We should enable CSS Regions in DumpRenderTree, since the tests are being run and the feature is enabled on Windows. 3. It would be nice if we could make antialiasing/font smoothing identical on the two platforms, but it seems like there's still some very small differences. 981015 1 224259 bfulgham 2014-02-14 15:28:46 -0800 Created attachment 224259 Patch 981018 2 224259 simon.fraser 2014-02-14 15:35:54 -0800 Comment on attachment 224259 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224259&action=review > Source/WebKit/win/WebPreferences.h:484 > + virtual HRESULT STDMETHODCALLTYPE screenFontSubstitutionEnabled(BOOL*); > + virtual HRESULT STDMETHODCALLTYPE setScreenFontSubstitutionEnabled(BOOL); I'm not sure this one has any effect on Windows. > Source/WebKit/win/WebView.cpp:5058 > + hr = prefsPrivate->screenFontSubstitutionEnabled(&enabled); > + if (FAILED(hr)) > + return hr; > + settings.setScreenFontSubstitutionEnabled(enabled); I think this is a no-op. > Tools/DumpRenderTree/win/DumpRenderTree.cpp:876 > + preferences->setCSSRegionsEnabled(TRUE); Does this mean we can enable a bunch of tests? 981025 3 bfulgham 2014-02-14 16:17:06 -0800 Landed in http://trac.webkit.org/changeset/164141. 981026 4 webkit-bug-importer 2014-02-14 16:17:45 -0800 <rdar://problem/16075979> 224259 2014-02-14 15:28:46 -0800 2014-02-14 15:35:54 -0800 Patch bug-128848-20140214152845.patch text/plain 6678 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDEzOCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTAyLTE0 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIE1h a2UgdGVzdHMgbW9yZSBjb25zaXN0ZW50IHdpdGggTWFjIHBsYXRmb3JtCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg4NDgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEludGVyZmFjZXMvSVdlYlByZWZl cmVuY2VzUHJpdmF0ZS5pZGw6IEFkZCBhY2Nlc3MgdG8gdGhlCisgICAgICAgIG1vY2sgc2Nyb2xs YmFyIGFuZCBzY3JlZW4gZm9udCBzdWJzdGl0dXRpb24gZmVhdHVyZXMuCisgICAgICAgICogV2Vi UHJlZmVyZW5jZUtleXNQcml2YXRlLmg6IERpdHRvCisgICAgICAgICogV2ViUHJlZmVyZW5jZXMu Y3BwOiBEaXR0bworICAgICAgICAoV2ViUHJlZmVyZW5jZXM6Om1vY2tTY3JvbGxiYXJzRW5hYmxl ZCk6CisgICAgICAgIChXZWJQcmVmZXJlbmNlczo6c2V0TW9ja1Njcm9sbGJhcnNFbmFibGVkKToK KyAgICAgICAgKFdlYlByZWZlcmVuY2VzOjpzY3JlZW5Gb250U3Vic3RpdHV0aW9uRW5hYmxlZCk6 CisgICAgICAgIChXZWJQcmVmZXJlbmNlczo6c2V0U2NyZWVuRm9udFN1YnN0aXR1dGlvbkVuYWJs ZWQpOgorICAgICAgICAqIFdlYlByZWZlcmVuY2VzLmg6IERpdHRvCisgICAgICAgICogV2ViVmll dy5jcHA6CisgICAgICAgIChXZWJWaWV3Ojpub3RpZnlQcmVmZXJlbmNlc0NoYW5nZWQpOiBEaXR0 bworCiAyMDE0LTAyLTExICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAg ICAgU3VicGl4ZWwgcmVuZGVyaW5nOiBNYWtlIEdyYXBoaWNzTGF5ZXJDbGllbnQ6OnBhaW50Q29u dGVudHMncyBjbGlwIHJlY3Qgc3VicGl4ZWwgYmFzZWQuCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dp bi9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L3dpbi9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaAkocmV2aXNpb24gMTY0MTMyKQorKysgU291 cmNlL1dlYktpdC93aW4vV2ViUHJlZmVyZW5jZUtleXNQcml2YXRlLmgJKHdvcmtpbmcgY29weSkK QEAgLTE2MywzICsxNjMsNiBAQAogCiAjZGVmaW5lIFdlYktpdFJlcXVlc3RBbmltYXRpb25GcmFt ZUVuYWJsZWRQcmVmZXJlbmNlS2V5ICJXZWJLaXRSZXF1ZXN0QW5pbWF0aW9uRnJhbWVFbmFibGVk IgogCisjZGVmaW5lIFdlYktpdE1vY2tTY3JvbGxiYXJzRW5hYmxlZFByZWZlcmVuY2VLZXkgIldl YktpdE1vY2tTY3JvbGxiYXJzRW5hYmxlZCIKKworI2RlZmluZSBXZWJLaXRTY3JlZW5Gb250U3Vi c3RpdHV0aW9uRW5hYmxlZFByZWZlcmVuY2VLZXkgIldlYktpdFNjcmVlbkZvbnRTdWJzdGl0dXRp b25FbmFibGVkUHJlZmVyZW5jZUtleSIKSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYlByZWZl cmVuY2VzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJQcmVmZXJlbmNl cy5jcHAJKHJldmlzaW9uIDE2NDEzMikKKysrIFNvdXJjZS9XZWJLaXQvd2luL1dlYlByZWZlcmVu Y2VzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI1NCw2ICsxMjU0LDMwIEBAIEhSRVNVTFQgV2Vi UHJlZmVyZW5jZXM6OnVudXNlZDYoKQogICAgIHJldHVybiBFX0ZBSUw7CiB9CiAKK0hSRVNVTFQg V2ViUHJlZmVyZW5jZXM6Om1vY2tTY3JvbGxiYXJzRW5hYmxlZChCT09MKiBlbmFibGVkKQorewor ICAgICplbmFibGVkID0gYm9vbFZhbHVlRm9yS2V5KFdlYktpdE1vY2tTY3JvbGxiYXJzRW5hYmxl ZFByZWZlcmVuY2VLZXkpOworICAgIHJldHVybiBTX09LOworfQorCitIUkVTVUxUIFdlYlByZWZl cmVuY2VzOjpzZXRNb2NrU2Nyb2xsYmFyc0VuYWJsZWQoQk9PTCBlbmFibGVkKQoreworICAgIHNl dEJvb2xWYWx1ZShXZWJLaXRNb2NrU2Nyb2xsYmFyc0VuYWJsZWRQcmVmZXJlbmNlS2V5LCBlbmFi bGVkKTsKKyAgICByZXR1cm4gU19PSzsKK30KKworSFJFU1VMVCBXZWJQcmVmZXJlbmNlczo6c2Ny ZWVuRm9udFN1YnN0aXR1dGlvbkVuYWJsZWQoQk9PTCogZW5hYmxlZCkKK3sKKyAgICAqZW5hYmxl ZCA9IGJvb2xWYWx1ZUZvcktleShXZWJLaXRTY3JlZW5Gb250U3Vic3RpdHV0aW9uRW5hYmxlZFBy ZWZlcmVuY2VLZXkpOworICAgIHJldHVybiBTX09LOworfQorCitIUkVTVUxUIFdlYlByZWZlcmVu Y2VzOjpzZXRTY3JlZW5Gb250U3Vic3RpdHV0aW9uRW5hYmxlZChCT09MIGVuYWJsZWQpCit7Cisg ICAgc2V0Qm9vbFZhbHVlKFdlYktpdFNjcmVlbkZvbnRTdWJzdGl0dXRpb25FbmFibGVkUHJlZmVy ZW5jZUtleSwgZW5hYmxlZCk7CisgICAgcmV0dXJuIFNfT0s7Cit9CisKIEhSRVNVTFQgU1RETUVU SE9EQ0FMTFRZUEUgV2ViUHJlZmVyZW5jZXM6Omh5cGVybGlua0F1ZGl0aW5nRW5hYmxlZCgKICAg ICAvKiBbaW5dICovIEJPT0wqIGVuYWJsZWQpCiB7CkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9X ZWJQcmVmZXJlbmNlcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2luL1dlYlByZWZl cmVuY2VzLmgJKHJldmlzaW9uIDE2NDEzMikKKysrIFNvdXJjZS9XZWJLaXQvd2luL1dlYlByZWZl cmVuY2VzLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ3Nyw2ICs0NzcsMTIgQEAgcHVibGljOgogICAg IHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSByZXF1ZXN0QW5pbWF0aW9uRnJhbWVF bmFibGVkKEJPT0wqKTsKICAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgc2V0 UmVxdWVzdEFuaW1hdGlvbkZyYW1lRW5hYmxlZChCT09MKTsKIAorICAgIHZpcnR1YWwgSFJFU1VM VCBTVERNRVRIT0RDQUxMVFlQRSBtb2NrU2Nyb2xsYmFyc0VuYWJsZWQoQk9PTCopOworICAgIHZp cnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBzZXRNb2NrU2Nyb2xsYmFyc0VuYWJsZWQo Qk9PTCk7CisKKyAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgc2NyZWVuRm9u dFN1YnN0aXR1dGlvbkVuYWJsZWQoQk9PTCopOworICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRI T0RDQUxMVFlQRSBzZXRTY3JlZW5Gb250U3Vic3RpdHV0aW9uRW5hYmxlZChCT09MKTsKKwogICAg IC8vIFdlYlByZWZlcmVuY2VzCiAKICAgICAvLyBUaGlzIG1ldGhvZCBhY2Nlc3NlcyBhIGRpZmZl cmVudCBwcmVmZXJlbmNlIGtleSB0aGFuIGRldmVsb3BlckV4dHJhc0VuYWJsZWQuCkluZGV4OiBT b3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMTY0MTMyKQorKysgU291cmNlL1dlYktpdC93aW4v V2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUwNDcsNiArNTA0NywxNiBAQCBIUkVTVUxU IFdlYlZpZXc6Om5vdGlmeVByZWZlcmVuY2VzQ2hhbmdlCiAgICAgICAgIHJldHVybiBocjsKICAg ICBzZXR0aW5ncy5zZXRSZXF1ZXN0QW5pbWF0aW9uRnJhbWVFbmFibGVkKGVuYWJsZWQpOwogCisg ICAgaHIgPSBwcmVmc1ByaXZhdGUtPm1vY2tTY3JvbGxiYXJzRW5hYmxlZCgmZW5hYmxlZCk7Cisg ICAgaWYgKEZBSUxFRChocikpCisgICAgICAgIHJldHVybiBocjsKKyAgICBzZXR0aW5ncy5zZXRN b2NrU2Nyb2xsYmFyc0VuYWJsZWQoZW5hYmxlZCk7CisKKyAgICBociA9IHByZWZzUHJpdmF0ZS0+ c2NyZWVuRm9udFN1YnN0aXR1dGlvbkVuYWJsZWQoJmVuYWJsZWQpOworICAgIGlmIChGQUlMRUQo aHIpKQorICAgICAgICByZXR1cm4gaHI7CisgICAgc2V0dGluZ3Muc2V0U2NyZWVuRm9udFN1YnN0 aXR1dGlvbkVuYWJsZWQoZW5hYmxlZCk7CisKICAgICByZXR1cm4gU19PSzsKIH0KIApJbmRleDog U291cmNlL1dlYktpdC93aW4vSW50ZXJmYWNlcy9JV2ViUHJlZmVyZW5jZXNQcml2YXRlLmlkbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lXZWJQcmVmZXJlbmNl c1ByaXZhdGUuaWRsCShyZXZpc2lvbiAxNjQxMzIpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9JbnRl cmZhY2VzL0lXZWJQcmVmZXJlbmNlc1ByaXZhdGUuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0xNDIs NCArMTQyLDEwIEBAIGludGVyZmFjZSBJV2ViUHJlZmVyZW5jZXNQcml2YXRlIDogSVVua24KIAog ICAgIEhSRVNVTFQgc2V0UmVxdWVzdEFuaW1hdGlvbkZyYW1lRW5hYmxlZChbaW5dIEJPT0wpOwog ICAgIEhSRVNVTFQgcmVxdWVzdEFuaW1hdGlvbkZyYW1lRW5hYmxlZChbb3V0LCByZXR2YWxdIEJP T0wqKTsKKworICAgIEhSRVNVTFQgbW9ja1Njcm9sbGJhcnNFbmFibGVkKFtvdXQsIHJldHZhbF0g Qk9PTCogZW5hYmxlZCk7CisgICAgSFJFU1VMVCBzZXRNb2NrU2Nyb2xsYmFyc0VuYWJsZWQoW2lu XSBCT09MIGVuYWJsZWQpOworCisgICAgSFJFU1VMVCBzY3JlZW5Gb250U3Vic3RpdHV0aW9uRW5h YmxlZChbb3V0LCByZXR2YWxdIEJPT0wqIGVuYWJsZWQpOworICAgIEhSRVNVTFQgc2V0U2NyZWVu Rm9udFN1YnN0aXR1dGlvbkVuYWJsZWQoW2luXSBCT09MIGVuYWJsZWQpOwogfQpJbmRleDogVG9v bHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0 MTM4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTQtMDItMTQgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAg ICAgW1dpbl0gTWFrZSB0ZXN0cyBtb3JlIGNvbnNpc3RlbnQgd2l0aCBNYWMgcGxhdGZvcm0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODg0OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKHJlc2V0RGVmYXVsdHNUb0Nv bnNpc3RlbnRWYWx1ZXMpOiBUdXJuIENTUyByZWdpb25zIG9uLAorICAgICAgICB0dXJuIG1vY2sg c2Nyb2xsYmFycyBvbiwgYW5kIGFsbG93IHNjcmVlbiBmb250CisgICAgICAgIHN1YnN0aXR1dGlv bi4KKwogMjAxNC0wMi0xNCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29t PgogCiAgICAgICAgIFNhdmUgQVJHViBpbiBhIGxvY2FsIHRvIGF2b2lkIHJlcGVhdGVkIGxvb2t1 cHMKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAko cmV2aXNpb24gMTY0MTMyKQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJU cmVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODczLDYgKzg3Myw3IEBAIHN0YXRpYyB2b2lkIHJl c2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWwKICAgICBwcmVmZXJlbmNlcy0+c2V0Q2FjaGVNb2Rl bChXZWJDYWNoZU1vZGVsRG9jdW1lbnRCcm93c2VyKTsKICAgICBwcmVmZXJlbmNlcy0+c2V0TG9h ZHNJbWFnZXNBdXRvbWF0aWNhbGx5KFRSVUUpOwogICAgIHByZWZlcmVuY2VzLT5zZXRUZXh0QXJl YXNBcmVSZXNpemFibGUoVFJVRSk7CisgICAgcHJlZmVyZW5jZXMtPnNldENTU1JlZ2lvbnNFbmFi bGVkKFRSVUUpOwogCiAgICAgaWYgKHBlcnNpc3RlbnRVc2VyU3R5bGVTaGVldExvY2F0aW9uKSB7 CiAgICAgICAgIFZlY3Rvcjx3Y2hhcl90PiB1cmxDaGFyYWN0ZXJzKENGU3RyaW5nR2V0TGVuZ3Ro KHBlcnNpc3RlbnRVc2VyU3R5bGVTaGVldExvY2F0aW9uLmdldCgpKSk7CkBAIC05MDEsNiArOTAy LDggQEAgc3RhdGljIHZvaWQgcmVzZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbAogI2lmIFVTRShD RykKICAgICAgICAgcHJlZnNQcml2YXRlLT5zZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxl ZChUUlVFKTsKICNlbmRpZgorICAgICAgICBwcmVmc1ByaXZhdGUtPnNldE1vY2tTY3JvbGxiYXJz RW5hYmxlZChUUlVFKTsKKyAgICAgICAgcHJlZnNQcml2YXRlLT5zZXRTY3JlZW5Gb250U3Vic3Rp dHV0aW9uRW5hYmxlZChUUlVFKTsKICAgICB9CiAgICAgc2V0QWx3YXlzQWNjZXB0Q29va2llcyhm YWxzZSk7CiAK