128842 2014-02-14 14:01:03 -0800 Margin tiles are not created for top and left sides when there is a < 1.0 scale factor 2014-02-14 14:27:25 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin simon.fraser thorton oldest_to_newest 980964 0 bdakin 2014-02-14 14:01:03 -0800 The TileController is failing to create margin tiles for the top and left sides when the there a scaled factor on the TileController that is less the 1.0. 980976 1 224252 bdakin 2014-02-14 14:13:43 -0800 Created attachment 224252 Patch 980981 2 224252 simon.fraser 2014-02-14 14:17:33 -0800 Comment on attachment 224252 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224252&action=review > Source/WebCore/platform/graphics/ca/mac/TileController.mm:474 > + topLeft.setX(floor((float)clampedRect.x() / leftMarginWidth())); floorf? > Source/WebCore/platform/graphics/ca/mac/TileController.mm:479 > + topLeft.setY(floor((float)clampedRect.y() / topMarginHeight())); Ditto. 980993 3 bdakin 2014-02-14 14:27:25 -0800 floorf'd! Fixed with r164135 224252 2014-02-14 14:13:43 -0800 2014-02-14 14:17:33 -0800 Patch for-review.txt text/plain 1799 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDEzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTE0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBNYXJnaW4gdGlsZXMgYXJlIG5vdCBj cmVhdGVkIGZvciB0aGUgdG9wIGFuZCBsZWZ0IHNpZGVzIHdoZW4gdGhlcmUgaXMgYSA8IDEuMCAK KyAgICAgICAgc2NhbGUgZmFjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjg4NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBmbG9vciB0aGUgcmVzdWx0IG9mIHRoZSBjb21wdXRhdGlvbiB3aGVuZXZl ciB3ZSBoYXZlIGEgbmVnYXRpdmUgb3JpZ2luLCB0byBlbnN1cmUgCisgICAgICAgIHRoYXQgd2Ug YXJlIHJvdW5kaW5nICd1cCcgdG8gYSBsYXJnZXIgbnVtYmVyIG9mIHRpbGVzLiAKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIubW06CisgICAgICAgIChX ZWJDb3JlOjpUaWxlQ29udHJvbGxlcjo6Z2V0VGlsZUluZGV4UmFuZ2VGb3JSZWN0KToKKwogMjAx NC0wMi0xNCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUHVy Z2UgcmVtYWluaW5nIEVOQUJMRShTSEFET1dfRE9NKSBjcnVmdC4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxlQ29udHJvbGxlci5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xs ZXIubW0JKHJldmlzaW9uIDE2NDEwMikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NhL21hYy9UaWxlQ29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtNDcxLDEyICs0 NzEsMTIgQEAgdm9pZCBUaWxlQ29udHJvbGxlcjo6Z2V0VGlsZUluZGV4UmFuZ2VGbwogICAgIGlm IChjbGFtcGVkUmVjdC54KCkgPj0gMCkKICAgICAgICAgdG9wTGVmdC5zZXRYKGNsYW1wZWRSZWN0 LngoKSAvIG1fdGlsZVNpemUud2lkdGgoKSk7CiAgICAgZWxzZQotICAgICAgICB0b3BMZWZ0LnNl dFgoY2xhbXBlZFJlY3QueCgpIC8gbGVmdE1hcmdpbldpZHRoKCkpOworICAgICAgICB0b3BMZWZ0 LnNldFgoZmxvb3IoKGZsb2F0KWNsYW1wZWRSZWN0LngoKSAvIGxlZnRNYXJnaW5XaWR0aCgpKSk7 CiAKICAgICBpZiAoY2xhbXBlZFJlY3QueSgpID49IDApCiAgICAgICAgIHRvcExlZnQuc2V0WShj bGFtcGVkUmVjdC55KCkgLyBtX3RpbGVTaXplLmhlaWdodCgpKTsKICAgICBlbHNlCi0gICAgICAg IHRvcExlZnQuc2V0WShjbGFtcGVkUmVjdC55KCkgLyB0b3BNYXJnaW5IZWlnaHQoKSk7CisgICAg ICAgIHRvcExlZnQuc2V0WShmbG9vcigoZmxvYXQpY2xhbXBlZFJlY3QueSgpIC8gdG9wTWFyZ2lu SGVpZ2h0KCkpKTsKIAogICAgIGludCBib3R0b21YUmF0aW8gPSBjZWlsKChmbG9hdCljbGFtcGVk UmVjdC5tYXhYKCkgLyBtX3RpbGVTaXplLndpZHRoKCkpOwogICAgIGJvdHRvbVJpZ2h0LnNldFgo c3RkOjptYXgoYm90dG9tWFJhdGlvIC0gMSwgMCkpOwo=