128835 2014-02-14 12:40:52 -0800 Don't optimize variadic closure calls 2014-02-14 12:46:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg mmirman msaboff oliver sam oldest_to_newest 980911 0 fpizlo 2014-02-14 12:40:52 -0800 We never intended to optimize these and the appropriate check got lost in some refactoring. <rdar://problem/15944810> 980914 1 224243 fpizlo 2014-02-14 12:43:21 -0800 Created attachment 224243 the patch 980915 2 fpizlo 2014-02-14 12:46:51 -0800 Landed in http://trac.webkit.org/changeset/164119 224243 2014-02-14 12:43:21 -0800 2014-02-14 12:44:39 -0800 the patch blah.patch text/plain 4858 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0MTE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTAyLTE0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RG9uJ3Qgb3B0aW1pemUgdmFyaWFkaWMgY2xvc3VyZSBjYWxscworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4ODM1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBSZWFkIHRoZSBjaGVjayB0aGF0 IGhhZCBiZWVuIGluIEpJVFN0dWJzLmNwcCwgYmFjayBpbiB0aGUgZGF5LiBUaGlzIGNvZGUgY2Ft ZQorICAgICAgICBmcm9tIHRoZSBERkcgYW5kIHRoZSBERkcgZGlkbid0IG5lZWQgdGhlc2UgY2hl Y2tzLgorCisgICAgICAgICogaml0L0pJVE9wZXJhdGlvbnMuY3BwOgorCiAyMDE0LTAyLTE0ICBE YXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgW0FTYW5dIERpc2Fi bGUgSlNTdGFjazo6c2FuaXRpemVTdGFjaygpIHRvIGF2b2lkIGZhbHNlLXBvc2l0aXZlIHN0YWNr LWJ1ZmZlci1vdmVyZmxvdyBlcnJvcnMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv SklUT3BlcmF0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRPcGVyYXRpb25zLmNwcAkocmV2aXNpb24gMTY0MDEzKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzk3LDcgKzc5 Nyw3IEBAIHN0YXRpYyBib29sIGF0dGVtcHRUb09wdGltaXplQ2xvc3VyZUNhbGwKICAgICAgICAg Y29kZUJsb2NrID0gMDsKICAgICBlbHNlIHsKICAgICAgICAgY29kZUJsb2NrID0ganNDYXN0PEZ1 bmN0aW9uRXhlY3V0YWJsZSo+KGNhbGxlZS0+ZXhlY3V0YWJsZSgpKS0+Y29kZUJsb2NrRm9yQ2Fs bCgpOwotICAgICAgICBpZiAoZXhlY0NhbGxlZS0+YXJndW1lbnRDb3VudEluY2x1ZGluZ1RoaXMo KSA8IHN0YXRpY19jYXN0PHNpemVfdD4oY29kZUJsb2NrLT5udW1QYXJhbWV0ZXJzKCkpKQorICAg ICAgICBpZiAoZXhlY0NhbGxlZS0+YXJndW1lbnRDb3VudEluY2x1ZGluZ1RoaXMoKSA8IHN0YXRp Y19jYXN0PHNpemVfdD4oY29kZUJsb2NrLT5udW1QYXJhbWV0ZXJzKCkpIHx8IGNhbGxMaW5rSW5m by5jYWxsVHlwZSA9PSBDYWxsTGlua0luZm86OkNhbGxWYXJhcmdzKQogICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwogICAgIH0KICAgICAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDExNykKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0 LTAyLTE0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3Qg b3B0aW1pemUgdmFyaWFkaWMgY2xvc3VyZSBjYWxscworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4ODM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBBZGQgYSB0ZXN0IHRoYXQgY292ZXJzIGJv dGggdGhlIHBlcmZvcm1hbmNlIGFuZCBjb3JyZWN0bmVzcyBvZiB0aGlzIGNhc2UuCisKKyAgICAg ICAgKiBqcy9yZWdyZXNzL3NjcmlwdC10ZXN0cy92YXJpYWRpYy1jbG9zdXJlLWNhbGwuanM6IEFk ZGVkLgorICAgICAgICAoZm9vLmJhcik6CisgICAgICAgIChmb28pOgorICAgICAgICAqIGpzL3Jl Z3Jlc3MvdmFyaWFkaWMtY2xvc3VyZS1jYWxsLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICoganMvcmVncmVzcy92YXJpYWRpYy1jbG9zdXJlLWNhbGwuaHRtbDogQWRkZWQuCisKIDIwMTQt MDItMTQgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAg ICBJbXBsZW1lbnQgdGV4dC1kZWNvcmF0aW9uLXNraXA6IGF1dG8KSW5kZXg6IExheW91dFRlc3Rz L2pzL3JlZ3Jlc3MvdmFyaWFkaWMtY2xvc3VyZS1jYWxsLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3ZhcmlhZGljLWNsb3N1cmUtY2FsbC1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3ZhcmlhZGljLWNs b3N1cmUtY2FsbC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAor SlNSZWdyZXNzL3ZhcmlhZGljLWNsb3N1cmUtY2FsbAorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVU RSIuCisKKworUEFTUyBubyBleGNlcHRpb24gdGhyb3duCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvanMvcmVncmVz cy92YXJpYWRpYy1jbG9zdXJlLWNhbGwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9q cy9yZWdyZXNzL3ZhcmlhZGljLWNsb3N1cmUtY2FsbC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvanMvcmVncmVzcy92YXJpYWRpYy1jbG9zdXJlLWNhbGwuaHRtbAkod29ya2luZyBj b3B5KQpAQCAtMCwwICsxLDEyIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RU RCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQgc3Jj PSJyZXNvdXJjZXMvcmVncmVzcy1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InNjcmlw dC10ZXN0cy92YXJpYWRpYy1jbG9zdXJlLWNhbGwuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9 InJlc291cmNlcy9yZWdyZXNzLXBvc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4u L3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJ bmRleDogTGF5b3V0VGVzdHMvanMvcmVncmVzcy9zY3JpcHQtdGVzdHMvdmFyaWFkaWMtY2xvc3Vy ZS1jYWxsLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pzL3JlZ3Jlc3Mvc2NyaXB0LXRl c3RzL3ZhcmlhZGljLWNsb3N1cmUtY2FsbC5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2pzL3JlZ3Jlc3Mvc2NyaXB0LXRlc3RzL3ZhcmlhZGljLWNsb3N1cmUtY2FsbC5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDMzIEBACitmdW5jdGlvbiBmb28oYSkgeworICAgIHZhciB4ID0g NDIgKyBhOworICAgIGZ1bmN0aW9uIGJhcihhLCBiLCBjKSB7CisgICAgICAgIHZhciByZXN1bHQg PSBhICsgYiArIGM7CisgICAgICAgIGZvciAodmFyIGkgPSAzOyBpIDwgYXJndW1lbnRzLmxlbmd0 aDsgKytpKQorICAgICAgICAgICAgcmVzdWx0ID0gYXJndW1lbnRzW2ldICogeDsKKyAgICAgICAg cmV0dXJuIHJlc3VsdDsKKyAgICB9CisgICAgcmV0dXJuIGJhci5hcHBseSh0aGlzLCBhcmd1bWVu dHMpOworfQorCisvLyBXYXJtIGV2ZXJ5dGhpbmcgdXAgd2l0aCB2YXJpYWRpYyBjYWxscyB0aGF0 IGRvbid0IGZhaWwgYXJpdHkgY2hlY2tzLgorZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwMDA7ICsr aSkgeworICAgIHZhciBhcmdzID0gW107CisgICAgdmFyIG4gPSAoaSAlIDgpICsgODsKKyAgICBm b3IgKHZhciBqID0gMDsgaiA8IG47ICsraikKKyAgICAgICAgYXJncy5wdXNoKGopOworICAgIHZh ciByZXN1bHQgPSBmb28uYXBwbHkobnVsbCwgYXJncyk7CisgICAgaWYgKCgiIiArIHJlc3VsdCkg IT0gKCIiICsgWzI5NCwgMzM2LCAzNzgsIDQyMCwgNDYyLCA1MDQsIDU0NiwgNTg4XVtuIC0gOF0p KQorICAgICAgICB0aHJvdyAiRXJyb3I6IGJhZCByZXN1bHQgZm9yIGkgPSAiICsgaSArICI6ICIg KyByZXN1bHQ7Cit9CisKKy8vIFN0YXJ0IGZhaWxpbmcgc29tZSBhcml0eSBjaGVja3MuCitmb3Ig KHZhciBpID0gMDsgaSA8IDEwMDAwMDsgKytpKSB7CisgICAgdmFyIGFyZ3MgPSBbXTsKKyAgICB2 YXIgbiA9IGkgJSAxNjsKKyAgICBmb3IgKHZhciBqID0gMDsgaiA8IG47ICsraikKKyAgICAgICAg YXJncy5wdXNoKGopOworICAgIHZhciByZXN1bHQgPSBmb28uYXBwbHkobnVsbCwgYXJncyk7Cisg ICAgaWYgKCgiIiArIHJlc3VsdCkgIT0gKCIiICsgWzAvMCwgMC8wLCAwLzAsIDMsIDEyNiwgMTY4 LCAyMTAsIDI1MiwgMjk0LCAzMzYsIDM3OCwgNDIwLCA0NjIsIDUwNCwgNTQ2LCA1ODhdW25dKSkK KyAgICAgICAgdGhyb3cgIkVycm9yOiBiYWQgcmVzdWx0IGZvciBpID0gIiArIGkgKyAiOiAiICsg cmVzdWx0OworfQorCg==