128832 2014-02-14 11:46:07 -0800 Baseline JIT should have a fast path to bypass the write barrier on op_enter 2014-02-14 13:25:22 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg fpizlo oldest_to_newest 980894 0 mhahnenberg 2014-02-14 11:46:07 -0800 <rdar://problem/16072244> 980902 1 224241 mhahnenberg 2014-02-14 12:06:25 -0800 Created attachment 224241 Patch 980936 2 mhahnenberg 2014-02-14 13:12:49 -0800 Committed r164128: <http://trac.webkit.org/changeset/164128> 980939 3 224241 ggaren 2014-02-14 13:14:50 -0800 Comment on attachment 224241 Patch Shouldn't we check the remembered set bit instead? Many functions will be old, and checking the mark bit won't save anything for old objects. 980949 4 mhahnenberg 2014-02-14 13:25:22 -0800 (In reply to comment #3) > (From update of attachment 224241 [details]) > Shouldn't we check the remembered set bit instead? > > Many functions will be old, and checking the mark bit won't save anything for old objects. The thinking was that if you're in the baseline JIT you might still be young, but I think checking the remembered set bit as well is an improvement. 224241 2014-02-14 12:06:25 -0800 2014-02-14 13:14:50 -0800 Patch bug-128832-20140214120621.patch text/plain 4792 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0MTE1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAyLTE0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQmFzZWxpbmUgSklUIHNob3VsZCBoYXZlIGEgZmFzdCBwYXRoIHRvIGJ5cGFzcyB0 aGUgd3JpdGUgYmFycmllciBvbiBvcF9lbnRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4ODMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBqaXQvSklULmg6IFJlbW92ZWQgc29tZSByYW5kb20gY29t bWVudGVkIG91dCBmdW5jdGlvbnMuaAorICAgICAgICAqIGppdC9KSVRPcGNvZGVzLmNwcDoKKyAg ICAgICAgKEpTQzo6SklUOjplbWl0X29wX2VudGVyKToKKyAgICAgICAgKiBqaXQvSklUUHJvcGVy dHlBY2Nlc3MuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRXcml0ZUJhcnJpZXIpOgorCiAy MDE0LTAyLTE0ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAg W0FTYW5dIERpc2FibGUgSlNTdGFjazo6c2FuaXRpemVTdGFjaygpIHRvIGF2b2lkIGZhbHNlLXBv c2l0aXZlIHN0YWNrLWJ1ZmZlci1vdmVyZmxvdyBlcnJvcnMKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklULmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVQuaAkocmV2aXNpb24gMTY0MTA4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVQuaAkod29ya2luZyBjb3B5KQpAQCAtMzE4LDEwICszMTgsNyBAQCBuYW1lc3BhY2UgSlNDIHsK ICAgICAgICAgSnVtcCBjaGVja01hcmtXb3JkKEpTQ2VsbCogb3duZXIpOwogICAgICAgICB2b2lk IGVtaXRXcml0ZUJhcnJpZXIodW5zaWduZWQgb3duZXIsIHVuc2lnbmVkIHZhbHVlLCBXcml0ZUJh cnJpZXJNb2RlKTsKICAgICAgICAgdm9pZCBlbWl0V3JpdGVCYXJyaWVyKEpTQ2VsbCogb3duZXIs IHVuc2lnbmVkIHZhbHVlLCBXcml0ZUJhcnJpZXJNb2RlKTsKLS8qCi0gICAgICAgIHZvaWQgZW1p dFdyaXRlQmFycmllcihSZWdpc3RlcklEIG93bmVyLCBSZWdpc3RlcklEIHZhbHVlVGFnLCBSZWdp c3RlcklEIHNjcmF0Y2gxLCBSZWdpc3RlcklEIHNjcmF0Y2gyLCBXcml0ZUJhcnJpZXJNb2RlKTsK LSAgICAgICAgdm9pZCBlbWl0V3JpdGVCYXJyaWVyKEpTQ2VsbCogb3duZXIsIFJlZ2lzdGVySUQg dmFsdWUsIFdyaXRlQmFycmllck1vZGUpOwotKi8KKyAgICAgICAgdm9pZCBlbWl0V3JpdGVCYXJy aWVyKEpTQ2VsbCogb3duZXIpOwogCiAgICAgICAgIHRlbXBsYXRlPHR5cGVuYW1lIFN0cnVjdHVy ZVR5cGU+IC8vIFN0cnVjdHVyZVR5cGUgY2FuIGJlIFJlZ2lzdGVySUQgb3IgSW1tUHRyLgogICAg ICAgICB2b2lkIGVtaXRBbGxvY2F0ZUpTT2JqZWN0KFJlZ2lzdGVySUQgYWxsb2NhdG9yLCBTdHJ1 Y3R1cmVUeXBlLCBSZWdpc3RlcklEIHJlc3VsdCwgUmVnaXN0ZXJJRCBzY3JhdGNoKTsKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2Rlcy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcAkocmV2aXNpb24gMTY0MTA4 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNzY1LDcgKzc2NSw3IEBAIHZvaWQgSklUOjplbWl0X29wX25lcV9udWxsKEluc3Ry dWN0aW9uKiAKICAgICBlbWl0UHV0VmlydHVhbFJlZ2lzdGVyKGRzdCk7CiB9CiAKLXZvaWQgSklU OjplbWl0X29wX2VudGVyKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24pCit2b2lkIEpJ VDo6ZW1pdF9vcF9lbnRlcihJbnN0cnVjdGlvbiopCiB7CiAgICAgZW1pdEVudGVyT3B0aW1pemF0 aW9uQ2hlY2soKTsKICAgICAKQEAgLTc3Niw4ICs3NzYsNyBAQCB2b2lkIEpJVDo6ZW1pdF9vcF9l bnRlcihJbnN0cnVjdGlvbiogY3VyCiAgICAgZm9yIChzaXplX3QgaiA9IDA7IGogPCBjb3VudDsg KytqKQogICAgICAgICBlbWl0SW5pdFJlZ2lzdGVyKHZpcnR1YWxSZWdpc3RlckZvckxvY2FsKGop Lm9mZnNldCgpKTsKIAotICAgIEpJVFNsb3dQYXRoQ2FsbCBzbG93UGF0aENhbGwodGhpcywgY3Vy cmVudEluc3RydWN0aW9uLCBzbG93X3BhdGhfZW50ZXIpOwotICAgIHNsb3dQYXRoQ2FsbC5jYWxs KCk7CisgICAgZW1pdFdyaXRlQmFycmllcihtX2NvZGVCbG9jay0+b3duZXJFeGVjdXRhYmxlKCkp OwogfQogCiB2b2lkIEpJVDo6ZW1pdF9vcF9jcmVhdGVfYWN0aXZhdGlvbihJbnN0cnVjdGlvbiog Y3VycmVudEluc3RydWN0aW9uKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQ cm9wZXJ0eUFjY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAJKHJldmlzaW9uIDE2NDEwOCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05 MzEsMTIgKzkzMSw3IEBAIHZvaWQgSklUOjplbWl0V3JpdGVCYXJyaWVyKEpTQ2VsbCogb3duZXIK ICAgICBpZiAobW9kZSA9PSBTaG91bGRGaWx0ZXJWYWx1ZSkKICAgICAgICAgdmFsdWVOb3RDZWxs ID0gYnJhbmNoVGVzdDY0KE5vblplcm8sIHJlZ1QwLCB0YWdNYXNrUmVnaXN0ZXIpOwogCi0gICAg aWYgKCFNYXJrZWRCbG9jazo6YmxvY2tGb3Iob3duZXIpLT5pc01hcmtlZChvd25lcikpIHsKLSAg ICAgICAgSnVtcCBvd25lck5vdE1hcmtlZCA9IGNoZWNrTWFya1dvcmQob3duZXIpOwotICAgICAg ICBjYWxsT3BlcmF0aW9uKG9wZXJhdGlvblVuY29uZGl0aW9uYWxXcml0ZUJhcnJpZXIsIG93bmVy KTsKLSAgICAgICAgb3duZXJOb3RNYXJrZWQubGluayh0aGlzKTsKLSAgICB9IGVsc2UKLSAgICAg ICAgY2FsbE9wZXJhdGlvbihvcGVyYXRpb25VbmNvbmRpdGlvbmFsV3JpdGVCYXJyaWVyLCBvd25l cik7CisgICAgZW1pdFdyaXRlQmFycmllcihvd25lcik7CiAKICAgICBpZiAobW9kZSA9PSBTaG91 bGRGaWx0ZXJWYWx1ZSkgCiAgICAgICAgIHZhbHVlTm90Q2VsbC5saW5rKHRoaXMpOwpAQCAtOTg1 LDEyICs5ODAsNyBAQCB2b2lkIEpJVDo6ZW1pdFdyaXRlQmFycmllcihKU0NlbGwqIG93bmVyCiAg ICAgaWYgKG1vZGUgPT0gU2hvdWxkRmlsdGVyVmFsdWUpCiAgICAgICAgIHZhbHVlTm90Q2VsbCA9 IGJyYW5jaDMyKE5vdEVxdWFsLCByZWdUMCwgVHJ1c3RlZEltbTMyKEpTVmFsdWU6OkNlbGxUYWcp KTsKIAotICAgIGlmICghTWFya2VkQmxvY2s6OmJsb2NrRm9yKG93bmVyKS0+aXNNYXJrZWQob3du ZXIpKSB7Ci0gICAgICAgIEp1bXAgb3duZXJOb3RNYXJrZWQgPSBjaGVja01hcmtXb3JkKG93bmVy KTsKLSAgICAgICAgY2FsbE9wZXJhdGlvbihvcGVyYXRpb25VbmNvbmRpdGlvbmFsV3JpdGVCYXJy aWVyLCBvd25lcik7Ci0gICAgICAgIG93bmVyTm90TWFya2VkLmxpbmsodGhpcyk7Ci0gICAgfSBl bHNlCi0gICAgICAgIGNhbGxPcGVyYXRpb24ob3BlcmF0aW9uVW5jb25kaXRpb25hbFdyaXRlQmFy cmllciwgb3duZXIpOworICAgIGVtaXRXcml0ZUJhcnJpZXIob3duZXIpOwogCiAgICAgaWYgKG1v ZGUgPT0gU2hvdWxkRmlsdGVyVmFsdWUpIAogICAgICAgICB2YWx1ZU5vdENlbGwubGluayh0aGlz KTsKQEAgLTEwMDMsNiArOTkzLDIwIEBAIHZvaWQgSklUOjplbWl0V3JpdGVCYXJyaWVyKEpTQ2Vs bCogb3duZXIKIAogI2VuZGlmIC8vIFVTRShKU1ZBTFVFNjQpCiAKK3ZvaWQgSklUOjplbWl0V3Jp dGVCYXJyaWVyKEpTQ2VsbCogb3duZXIpCit7CisjaWYgRU5BQkxFKEdHQykKKyAgICBpZiAoIU1h cmtlZEJsb2NrOjpibG9ja0Zvcihvd25lciktPmlzTWFya2VkKG93bmVyKSkgeworICAgICAgICBK dW1wIG93bmVyTm90TWFya2VkID0gY2hlY2tNYXJrV29yZChvd25lcik7CisgICAgICAgIGNhbGxP cGVyYXRpb24ob3BlcmF0aW9uVW5jb25kaXRpb25hbFdyaXRlQmFycmllciwgb3duZXIpOworICAg ICAgICBvd25lck5vdE1hcmtlZC5saW5rKHRoaXMpOworICAgIH0gZWxzZQorICAgICAgICBjYWxs T3BlcmF0aW9uKG9wZXJhdGlvblVuY29uZGl0aW9uYWxXcml0ZUJhcnJpZXIsIG93bmVyKTsKKyNl bHNlCisgICAgVU5VU0VEX1BBUkFNKG93bmVyKTsKKyNlbmRpZiAvLyBFTkFCTEUoR0dDKQorfQor CiBKSVQ6Okp1bXAgSklUOjphZGRTdHJ1Y3R1cmVUcmFuc2l0aW9uQ2hlY2soSlNDZWxsKiBvYmpl Y3QsIFN0cnVjdHVyZSogc3RydWN0dXJlLCBTdHJ1Y3R1cmVTdHViSW5mbyogc3R1YkluZm8sIFJl Z2lzdGVySUQgc2NyYXRjaCkKIHsKICAgICBpZiAob2JqZWN0LT5zdHJ1Y3R1cmUoKSA9PSBzdHJ1 Y3R1cmUgJiYgc3RydWN0dXJlLT50cmFuc2l0aW9uV2F0Y2hwb2ludFNldElzU3RpbGxWYWxpZCgp KSB7Cg==