128826 2014-02-14 10:41:28 -0800 [EFL][WK2] Stop calling mktemp(3). 2014-02-15 13:11:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco bunhere cdumez commit-queue gyuyoung.kim sergio oldest_to_newest 980862 0 rakuco 2014-02-14 10:41:28 -0800 [EFL][WK2] Stop calling mktemp(3). 980863 1 224231 rakuco 2014-02-14 10:44:18 -0800 Created attachment 224231 Patch 980865 2 commit-queue 2014-02-14 10:45:27 -0800 Attachment 224231 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 980866 3 rakuco 2014-02-14 10:46:13 -0800 (In reply to comment #2) > Attachment 224231 [details] did not pass style-queue: > > > ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp:32: Alphabetical sorting problem. [build/include_order] [4] This is unrelated and should be ignored: those sys/* includes are normally expected to come before the other ones. 981036 4 224231 gyuyoung.kim 2014-02-14 16:52:38 -0800 Comment on attachment 224231 Patch It looks this is more secure than before. LGTM 981201 5 rakuco 2014-02-15 13:11:14 -0800 Committed r164179: <http://trac.webkit.org/changeset/164179> 224231 2014-02-14 10:44:18 -0800 2014-02-14 16:52:38 -0800 Patch bug-128826-20140214204501.patch text/plain 5534 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTFkZDgxY2UwNmQ3YjVk MTBmYmYwM2I0ZDc2ZDczYjAxYTUxN2JkMC4uNTY4ZGJiMDk4MGUxOGNjZmM3NGE5ODM0NmI1ZjM2 YTVkMGI0OTkxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTAyLTE0ICBSYXBo YWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisg ICAgICAgIFtFRkxdW1dLMl0gU3RvcCBjYWxsaW5nIG1rdGVtcCgzKS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODgyNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1rdGVtcCgzKSBpcyBhbiBpbnNlY3Vy ZSBmdW5jdGlvbiBhbmQgc2hvdWxkIGJlIGF2b2lkZWQgYXQgYWxsIGNvc3RzLgorICAgICAgICBS ZXBsYWNlIGl0cyB1c2FnZSB3aXRoIG1rZHRlbXAoMyk6IGluc3RlYWQgb2YganVzdCBnZXR0aW5n IGEgZmlsZSBuYW1lCisgICAgICAgIHRoYXQgaXMgc3VwcG9zZWQgdG8gYmUgcmFuZG9tIGFuZCB1 bnVzZWQsIHdlIG5vdyBjcmVhdGUgYSBkaXJlY3RvcnkKKyAgICAgICAgd2l0aCBhIHJhbmRvbSBu YW1lIGFuZCB0aGVuIHB1dCB3aGF0ZXZlciBmaWxlcyB3ZSBuZWVkIHRoZXJlIHdpdGggZml4ZWQK KyAgICAgICAgbmFtZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0 X2V3azJfY29va2llX21hbmFnZXIuY3BwOgorICAgICAgICAoVEVTVF9GKToKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfZG93bmxvYWRfam9iLmNwcDoKKyAgICAg ICAgKFRFU1RfRik6CisKIDIwMTQtMDItMTMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KIAogICAgICAgICBbQ29jb2FdIEV4cG9zZSB0aGUgYnVuZGxlIGZvcm0gY2xpZW50CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJf Y29va2llX21hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVz dHMvdGVzdF9ld2syX2Nvb2tpZV9tYW5hZ2VyLmNwcAppbmRleCA3M2IxODJjZDgyNTVhZjA0OGU2 NjI2ZTViNzZkMzMwNDhjYTQ4NTA3Li4wNmM3ODE1NjQzMDEwNDExMDVjMjEyNmVjNjQ3YzVhYjUy NzA3OGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0 cy90ZXN0X2V3azJfY29va2llX21hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb29raWVfbWFuYWdlci5jcHAKQEAgLTIyLDYg KzIyLDcgQEAKIAogI2luY2x1ZGUgIlVuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5oIgog I2luY2x1ZGUgIlVuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0U2VydmVyLmgiCisjaW5jbHVkZSA8 c3RkaW8uaD4KICNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNsdWRlIDx1bmlzdGQuaD4KIApAQCAt MTk5LDEwICsyMDAsMTIgQEAgVEVTVF9GKEVXSzJDb29raWVNYW5hZ2VyVGVzdCwgZXdrX2Nvb2tp ZV9tYW5hZ2VyX2NoYW5nZXNfd2F0Y2gpCiAgICAgZXdrX2Nvb2tpZV9tYW5hZ2VyX2NoYW5nZXNf d2F0Y2goY29va2llTWFuYWdlciwgb25Db29raWVzQ2hhbmdlZCwgJmNvb2tpZXNDaGFuZ2VkKTsK IAogICAgIC8vIE1ha2Ugc3VyZSB3ZSBkb24ndCBnZXQgbm90aWZpY2F0aW9ucyB3aGVuIGxvYWRp bmcgc2V0dGluZyBhbiBleGlzdGluZyBwZXJzaXN0ZW50IHN0b3JhZ2UKLSAgICBjaGFyIHRleHRT dG9yYWdlMVtdID0gIi90bXAvdHh0LWNvb2tpZS5YWFhYWFgiOwotICAgIEFTU0VSVF9UUlVFKG1r dGVtcCh0ZXh0U3RvcmFnZTEpKTsKLSAgICBjaGFyIHRleHRTdG9yYWdlMltdID0gIi90bXAvdHh0 LWNvb2tpZS5YWFhYWFgiOwotICAgIEFTU0VSVF9UUlVFKG1rdGVtcCh0ZXh0U3RvcmFnZTIpKTsK KyAgICBjaGFyIHN0b3JhZ2VEaXJlY3RvcnlbXSA9ICIvdG1wL2V3azJfY29va2llX21hbmFnZXIt WFhYWFhYIjsKKyAgICBBU1NFUlRfVFJVRShta2R0ZW1wKHN0b3JhZ2VEaXJlY3RvcnkpKTsKKyAg ICBjaGFyIHRleHRTdG9yYWdlMVs2NF07CisgICAgc25wcmludGYodGV4dFN0b3JhZ2UxLCBzaXpl b2YodGV4dFN0b3JhZ2UxKSwgIiVzL3R4dC1jb29raWUxIiwgc3RvcmFnZURpcmVjdG9yeSk7Cisg ICAgY2hhciB0ZXh0U3RvcmFnZTJbNjRdOworICAgIHNucHJpbnRmKHRleHRTdG9yYWdlMiwgc2l6 ZW9mKHRleHRTdG9yYWdlMiksICIlcy90eHQtY29va2llMiIsIHN0b3JhZ2VEaXJlY3RvcnkpOwog CiAgICAgZXdrX2Nvb2tpZV9tYW5hZ2VyX3BlcnNpc3RlbnRfc3RvcmFnZV9zZXQoY29va2llTWFu YWdlciwgdGV4dFN0b3JhZ2UxLCBFV0tfQ09PS0lFX1BFUlNJU1RFTlRfU1RPUkFHRV9URVhUKTsK ICAgICBBU1NFUlRfVFJVRShsb2FkVXJsU3luYyhodHRwU2VydmVyLT5nZXRVUkxGb3JQYXRoKCIv aW5kZXguaHRtbCIpLmRhdGEoKSkpOwpAQCAtMjIxLDYgKzIyNCw3IEBAIFRFU1RfRihFV0syQ29v a2llTWFuYWdlclRlc3QsIGV3a19jb29raWVfbWFuYWdlcl9jaGFuZ2VzX3dhdGNoKQogICAgIGV3 a19jb29raWVfbWFuYWdlcl9jaGFuZ2VzX3dhdGNoKGNvb2tpZU1hbmFnZXIsIDAsIDApOwogICAg IHVubGluayh0ZXh0U3RvcmFnZTEpOwogICAgIHVubGluayh0ZXh0U3RvcmFnZTIpOworICAgIHJt ZGlyKHN0b3JhZ2VEaXJlY3RvcnkpOwogfQogCiBURVNUX0YoRVdLMkNvb2tpZU1hbmFnZXJUZXN0 LCBld2tfY29va2llX21hbmFnZXJfY29va2llc19kZWxldGUpCkBAIC0yNjUsMTAgKzI2OSwxMiBA QCBURVNUX0YoRVdLMkNvb2tpZU1hbmFnZXJUZXN0LCBESVNBQkxFRF9ld2tfY29va2llX21hbmFn ZXJfcGVybWFuZW50X3N0b3JhZ2UpCiAgICAgaHR0cFNlcnZlci0+cnVuKHNlcnZlckNhbGxiYWNr KTsKIAogICAgIC8vIEdlbmVyYXRlIHVuaXF1ZSBuYW1lcyBmb3IgY29va2llIHN0b3JhZ2VzLgot ICAgIGNoYXIgdGV4dFN0b3JhZ2VbXSA9ICIvdG1wL3R4dC1jb29raWUuWFhYWFhYIjsKLSAgICBB U1NFUlRfVFJVRShta3RlbXAodGV4dFN0b3JhZ2UpKTsKLSAgICBjaGFyIHNxbGl0ZVN0b3JhZ2Vb XSA9ICIvdG1wL3NxbGl0ZS1jb29raWUuWFhYWFhYIjsKLSAgICBBU1NFUlRfVFJVRShta3RlbXAo c3FsaXRlU3RvcmFnZSkpOworICAgIGNoYXIgc3RvcmFnZURpcmVjdG9yeVtdID0gIi90bXAvZXdr Ml9jb29raWVfbWFuYWdlci1YWFhYWFgiOworICAgIEFTU0VSVF9UUlVFKG1rZHRlbXAoc3RvcmFn ZURpcmVjdG9yeSkpOworICAgIGNoYXIgdGV4dFN0b3JhZ2VbNjRdOworICAgIHNucHJpbnRmKHRl eHRTdG9yYWdlLCBzaXplb2YodGV4dFN0b3JhZ2UpLCAiJXMvdHh0LWNvb2tpZSIsIHN0b3JhZ2VE aXJlY3RvcnkpOworICAgIGNoYXIgc3FsaXRlU3RvcmFnZVs2NF07CisgICAgc25wcmludGYoc3Fs aXRlU3RvcmFnZSwgc2l6ZW9mKHNxbGl0ZVN0b3JhZ2UpLCAiJXMvc3FsaXRlLWNvb2tpZSIsIHN0 b3JhZ2VEaXJlY3RvcnkpOwogCiAgICAgRXdrX0Nvb2tpZV9NYW5hZ2VyKiBjb29raWVNYW5hZ2Vy ID0gZXdrX2NvbnRleHRfY29va2llX21hbmFnZXJfZ2V0KGV3a192aWV3X2NvbnRleHRfZ2V0KHdl YlZpZXcoKSkpOwogICAgIEFTU0VSVF9UUlVFKGNvb2tpZU1hbmFnZXIpOwpAQCAtMzA1LDQgKzMx MSw1IEBAIFRFU1RfRihFV0syQ29va2llTWFuYWdlclRlc3QsIERJU0FCTEVEX2V3a19jb29raWVf bWFuYWdlcl9wZXJtYW5lbnRfc3RvcmFnZSkKICAgICAvLyBGaW5hbCBjbGVhbiB1cC4KICAgICB1 bmxpbmsodGV4dFN0b3JhZ2UpOwogICAgIHVubGluayhzcWxpdGVTdG9yYWdlKTsKKyAgICBybWRp cihzdG9yYWdlRGlyZWN0b3J5KTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9kb3dubG9hZF9qb2IuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Rvd25sb2FkX2pvYi5jcHAK aW5kZXggNjg1OWU2MGQwMWJjYTBjZDY5NDY2NWVhZmI1NWM1NWM1ZmM5ZDFlZC4uNWU5ZTc1OWE1 OGNjYTk5NjI1YTI2NjkxZGUwYzAxYWY1ZTg1ZjMxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Rvd25sb2FkX2pvYi5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Rvd25s b2FkX2pvYi5jcHAKQEAgLTI5LDYgKzI5LDggQEAKICNpbmNsdWRlICJVbml0VGVzdFV0aWxzL0VX SzJVbml0VGVzdFNlcnZlci5oIgogI2luY2x1ZGUgPHN5cy9zdGF0Lmg+CiAjaW5jbHVkZSA8c3lz L3R5cGVzLmg+CisjaW5jbHVkZSA8c3RkaW8uaD4KKyNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNs dWRlIDx1bmlzdGQuaD4KIAogdXNpbmcgbmFtZXNwYWNlIEVXSzJVbml0VGVzdDsKQEAgLTE1Miwx MiArMTU0LDEzIEBAIFRFU1RfRihFV0syRG93bmxvYWRKb2JUZXN0LCBld2tfZG93bmxvYWQpCiAg ICAgc3RkOjp1bmlxdWVfcHRyPEVXSzJVbml0VGVzdFNlcnZlcj4gaHR0cFNlcnZlciA9IHN0ZDo6 bWFrZV91bmlxdWU8RVdLMlVuaXRUZXN0U2VydmVyPigpOwogICAgIGh0dHBTZXJ2ZXItPnJ1bihz ZXJ2ZXJDYWxsYmFjayk7CiAKLSAgICAvLyBHZW5lcmF0ZSB1bmlxdWUgbmFtZSBmb3IgZGVzdGlu YXRpb24gZmlsZS4KLSAgICBjaGFyIGRlc3RpbmF0aW9uUGF0aFtdID0gIi90bXAvcGRmLWZpbGUu WFhYWFhYIjsKLSAgICBBU1NFUlRfVFJVRShta3RlbXAoZGVzdGluYXRpb25QYXRoKSk7Ci0KICAg ICBDU3RyaW5nIGZpbGVVcmwgPSBodHRwU2VydmVyLT5nZXRVUkxGb3JQYXRoKHRlc3RGaWxlUGF0 aCk7CiAKKyAgICBjaGFyIGRlc3RpbmF0aW9uRGlyZWN0b3J5W10gPSAiL3RtcC9ld2syX2Rvd25s b2FkX2pvYi1YWFhYWFgiOworICAgIEFTU0VSVF9UUlVFKG1rZHRlbXAoZGVzdGluYXRpb25EaXJl Y3RvcnkpKTsKKyAgICBjaGFyIGRlc3RpbmF0aW9uUGF0aFs2NF07CisgICAgc25wcmludGYoZGVz dGluYXRpb25QYXRoLCBzaXplb2YoZGVzdGluYXRpb25QYXRoKSwgIiVzL3BkZi1maWxlIiwgZGVz dGluYXRpb25EaXJlY3RvcnkpOworCiAgICAgRG93bmxvYWRUZXN0RGF0YSB1c2VyRGF0YSA9IHsg ZmlsZVVybC5kYXRhKCksIGRlc3RpbmF0aW9uUGF0aCB9OwogICAgIEFTU0VSVF9GQUxTRShmaWxl RXhpc3RzKGRlc3RpbmF0aW9uUGF0aCkpOwogCkBAIC0xNzIsNCArMTc1LDUgQEAgVEVTVF9GKEVX SzJEb3dubG9hZEpvYlRlc3QsIGV3a19kb3dubG9hZCkKIAogICAgIC8vIENsZWFuIHVwCiAgICAg dW5saW5rKGRlc3RpbmF0aW9uUGF0aCk7CisgICAgcm1kaXIoZGVzdGluYXRpb25EaXJlY3Rvcnkp OwogfQo=