128811 2014-02-14 06:21:25 -0800 [CSS Regions] Make regions unsplittable 2014-02-17 11:18:20 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 57312 1 stavila stavila abucur achicu commit-queue esprehn+autocc glenn hyatt kling kondapallykalyan mihnea WebkitBugTracker oldest_to_newest 980774 0 stavila 2014-02-14 06:21:25 -0800 When a region is flowed into another flow thread and its fragmented between 2 regions, the fragmentation is incorrect. For the moment we'll make the regions unsplitable but for the future we should figure out a way to properly fragment regions (this includes computing correct pagination strut). 980776 1 stavila 2014-02-14 06:23:47 -0800 Created https://bugs.webkit.org/show_bug.cgi?id=128812 for the future work. 980788 2 224214 stavila 2014-02-14 07:53:59 -0800 Created attachment 224214 Patch 981532 3 224214 hyatt 2014-02-17 10:48:02 -0800 Comment on attachment 224214 Patch r=me 981556 4 224214 commit-queue 2014-02-17 11:18:17 -0800 Comment on attachment 224214 Patch Clearing flags on attachment: 224214 Committed r164234: <http://trac.webkit.org/changeset/164234> 981557 5 commit-queue 2014-02-17 11:18:20 -0800 All reviewed patches have been landed. Closing bug. 224214 2014-02-14 07:53:59 -0800 2014-02-17 11:18:17 -0800 Patch 128811.patch text/plain 6477 stavila ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZmUyNDk5Li5jNDM0MjM4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDIt MTQgIFJhZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVn aW9uc10gTWFrZSByZWdpb25zIHVuc3BsaXR0YWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4ODExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdCBmb3IgY2hlY2tpbmcgdGhhdCBuZXN0 ZWQgcmVnaW9ucyBhcmUgdW5zcGxpdHRhYmxlLgorCisgICAgICAgICogZmFzdC9yZWdpb25zL3Vu c3BsaXR0YWJsZS1uZXN0ZWQtcmVnaW9uLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAq IGZhc3QvcmVnaW9ucy91bnNwbGl0dGFibGUtbmVzdGVkLXJlZ2lvbi5odG1sOiBBZGRlZC4KKwog MjAxNC0wMi0xNCAgR3J6ZWdvcnogQ3phamtvd3NraSAgPGcuY3phamtvd3NraUBzYW1zdW5nLmNv bT4KIAogICAgICAgICBVc2UgYXN5bmNocm9ub3VzIHNwZWxsY2hlY2tpbmcgaW4gc3BlbGxpbmct aGFzc3BlbGxpbmdtYXJrZXIuanMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9u cy91bnNwbGl0dGFibGUtbmVzdGVkLXJlZ2lvbi1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9yZWdpb25zL3Vuc3BsaXR0YWJsZS1uZXN0ZWQtcmVnaW9uLWV4cGVjdGVkLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMTQ1Nzc3ZAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy91bnNwbGl0dGFibGUtbmVzdGVkLXJlZ2lvbi1l eHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsNTUgQEAKKzwhZG9jdHlwZSBodG1sPgorPGh0bWw+CisJ PGhlYWQ+CisJCTxzdHlsZT4KKwkJCSNvdXRlckNvbnRlbnQgeworCQkJCS13ZWJraXQtZmxvdy1p bnRvOiBvdXRlckZsb3c7CisJCQkJY29sb3I6IGJsdWU7CisJCQl9CisJCQkub3V0ZXJSZWdpb24g eworCQkJCS13ZWJraXQtZmxvdy1mcm9tOiBvdXRlckZsb3c7CisJCQkJd2lkdGg6IDMwMHB4Owor CQkJCWhlaWdodDogMTgwcHg7CisJCQkJYm9yZGVyOiBzb2xpZCAycHggR3JheTsKKwkJCQltYXJn aW46IDVweDsKKwkJCQlib3JkZXI6IDJweCBzb2xpZCBibHVlOworCQkJCXBhZGRpbmc6IDMwcHg7 CisJCQl9CisJCQkjaW5uZXJDb250ZW50IHsKKwkJCQktd2Via2l0LWZsb3ctaW50bzogaW5uZXJG bG93OworCQkJCWNvbG9yOiByZWQ7CisJCQl9CisKKwkJCSNpbm5lclJlZ2lvbiB7CisJCQkJLXdl YmtpdC1mbG93LWZyb206IGlubmVyRmxvdzsKKwkJCQlib3JkZXI6IHNvbGlkIDJweCByZWQ7CisJ CQkJb3ZlcmZsb3c6IGhpZGRlbjsKKwkJCQljb2xvcjogYmx1ZTsKKwkJCX0KKwkJCSNvdXRlclJl Z2lvbjEKKwkJCXsKKwkJCQlmbG9hdDogbGVmdDsKKwkJCX0KKwkJCSNvdXRlclJlZ2lvbjIKKwkJ CXsKKwkJCQlmbG9hdDogcmlnaHQ7CisJCQl9CisJCTwvc3R5bGU+CisJPC9oZWFkPgorCTxib2R5 PgorCQk8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4 ODExIj5CdWcgMTI4ODExPC9hPjxici8+CisJCTxwPlRoZSA8c3BhbiBzdHlsZT0iY29sb3I6cmVk Ij5uZXN0ZWQgcmVnaW9uPC9zcGFuPiBzaG91bGQgPGI+bm90PC9iPiBiZSBzcGxpdCBiZXR3ZWVu IHRoZSA8c3BhbiBzdHlsZT0iY29sb3I6Ymx1ZSI+MiBvdXRlciByZWdpb25zPC9zcGFuPiBhbmQg c2hvdWxkIG92ZXJmbG93IHRoZSBmaXJzdCByZWdpb248L3A+CisKKwkJPGRpdiBjbGFzcz0ib3V0 ZXJSZWdpb24iIGlkPSJvdXRlclJlZ2lvbjEiPgorCQkJPGRpdiBpZD0ib3V0ZXJDb250ZW50Ij4K KwkJCQk8ZGl2IGlkPSJpbm5lclJlZ2lvbiI+CisJCQkJCTxkaXYgaWQ9ImlubmVyQ29udGVudCI+ CisJCQkJCQlMb3JlbSBJcHN1bSBpcyBzaW1wbHkgZHVtbXkgdGV4dCBvZiB0aGUgcHJpbnRpbmcg YW5kIHR5cGVzZXR0aW5nIGluZHVzdHJ5LiBMb3JlbSBJcHN1bSBoYXMgYmVlbiB0aGUgaW5kdXN0 cnkncyBzdGFuZGFyZCBkdW1teSB0ZXh0IGV2ZXIgc2luY2UgdGhlIDE1MDBzLCB3aGVuIGFuIHVu a25vd24gcHJpbnRlciB0b29rIGEgZ2FsbGV5IG9mIHR5cGUgYW5kIHNjcmFtYmxlZCBpdCB0byBt YWtlIGEgdHlwZSBzcGVjaW1lbiBib29rLiBJdCBoYXMgc3Vydml2ZWQgbm90IG9ubHkgZml2ZSBj ZW50dXJpZXMsIGJ1dCBhbHNvIHRoZSBsZWFwIGludG8gZWxlY3Ryb25pYyB0eXBlc2V0dGluZywg cmVtYWluaW5nIGVzc2VudGlhbGx5IHVuY2hhbmdlZC4gSXQgd2FzIHBvcHVsYXJpc2VkIGluIHRo ZSAxOTYwcyB3aXRoIHRoZSByZWxlYXNlIG9mIExldHJhc2V0IHNoZWV0cyBjb250YWluaW5nIExv cmVtIElwc3VtIHBhc3NhZ2VzLCBhbmQgbW9yZSByZWNlbnRseSB3aXRoIGRlc2t0b3AgcHVibGlz aGluZyBzb2Z0d2FyZSBsaWtlIEFsZHVzIFBhZ2VNYWtlciBpbmNsdWRpbmcgdmVyc2lvbnMgb2Yg TG9yZW0gSXBzdW0uCisJCQkJCTwvZGl2PgorCQkJCTwvZGl2PgorCQkJPC9kaXY+CisJCTwvZGl2 PgorCisJCTxkaXYgY2xhc3M9Im91dGVyUmVnaW9uIiBpZD0ib3V0ZXJSZWdpb24yIj48L2Rpdj4K Kwk8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3Vuc3BsaXR0YWJsZS1uZXN0ZWQtcmVnaW9uLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvdW5zcGxpdHRhYmxlLW5lc3RlZC1yZWdpb24u aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jMzVmNjJlCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3Vuc3BsaXR0YWJsZS1uZXN0ZWQt cmVnaW9uLmh0bWwKQEAgLTAsMCArMSw1NCBAQAorPCFkb2N0eXBlIGh0bWw+Cis8aHRtbD4KKwk8 aGVhZD4KKwkJPHN0eWxlPgorCQkJI291dGVyQ29udGVudCB7CisJCQkJLXdlYmtpdC1mbG93LWlu dG86IG91dGVyRmxvdzsKKwkJCQljb2xvcjogYmx1ZTsKKwkJCX0KKwkJCS5vdXRlclJlZ2lvbiB7 CisJCQkJLXdlYmtpdC1mbG93LWZyb206IG91dGVyRmxvdzsKKwkJCQl3aWR0aDogMzAwcHg7CisJ CQkJaGVpZ2h0OiAxODBweDsKKwkJCQlib3JkZXI6IHNvbGlkIDJweCBHcmF5OworCQkJCW1hcmdp bjogNXB4OworCQkJCWJvcmRlcjogMnB4IHNvbGlkIGJsdWU7CisJCQkJcGFkZGluZzogMzBweDsK KwkJCX0KKwkJCSNpbm5lckNvbnRlbnQgeworCQkJCS13ZWJraXQtZmxvdy1pbnRvOiBpbm5lckZs b3c7CisJCQkJY29sb3I6IHJlZDsKKwkJCX0KKworCQkJI2lubmVyUmVnaW9uIHsKKwkJCQktd2Vi a2l0LWZsb3ctZnJvbTogaW5uZXJGbG93OworCQkJCWJvcmRlcjogc29saWQgMnB4IHJlZDsKKwkJ CQlvdmVyZmxvdzogaGlkZGVuOworCQkJCWNvbG9yOiBibHVlOworCQkJfQorCQkJI291dGVyUmVn aW9uMQorCQkJeworCQkJCWZsb2F0OiBsZWZ0OworCQkJfQorCQkJI291dGVyUmVnaW9uMgorCQkJ eworCQkJCWZsb2F0OiByaWdodDsKKwkJCX0KKwkJPC9zdHlsZT4KKwk8L2hlYWQ+CisJPGJvZHk+ CisJCTxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg4 MTEiPkJ1ZyAxMjg4MTE8L2E+PGJyLz4KKwkJPHA+VGhlIDxzcGFuIHN0eWxlPSJjb2xvcjpyZWQi Pm5lc3RlZCByZWdpb248L3NwYW4+IHNob3VsZCA8Yj5ub3Q8L2I+IGJlIHNwbGl0IGJldHdlZW4g dGhlIDxzcGFuIHN0eWxlPSJjb2xvcjpibHVlIj4yIG91dGVyIHJlZ2lvbnM8L3NwYW4+IGFuZCBz aG91bGQgb3ZlcmZsb3cgdGhlIGZpcnN0IHJlZ2lvbjwvcD4KKworCQk8ZGl2IGlkPSJvdXRlckNv bnRlbnQiPgorCQkJPGRpdiBpZD0iaW5uZXJSZWdpb24iPjwvZGl2PgorCQk8L2Rpdj4KKworCQk8 ZGl2IGlkPSJpbm5lckNvbnRlbnQiPgorCQkJTG9yZW0gSXBzdW0gaXMgc2ltcGx5IGR1bW15IHRl eHQgb2YgdGhlIHByaW50aW5nIGFuZCB0eXBlc2V0dGluZyBpbmR1c3RyeS4gTG9yZW0gSXBzdW0g aGFzIGJlZW4gdGhlIGluZHVzdHJ5J3Mgc3RhbmRhcmQgZHVtbXkgdGV4dCBldmVyIHNpbmNlIHRo ZSAxNTAwcywgd2hlbiBhbiB1bmtub3duIHByaW50ZXIgdG9vayBhIGdhbGxleSBvZiB0eXBlIGFu ZCBzY3JhbWJsZWQgaXQgdG8gbWFrZSBhIHR5cGUgc3BlY2ltZW4gYm9vay4gSXQgaGFzIHN1cnZp dmVkIG5vdCBvbmx5IGZpdmUgY2VudHVyaWVzLCBidXQgYWxzbyB0aGUgbGVhcCBpbnRvIGVsZWN0 cm9uaWMgdHlwZXNldHRpbmcsIHJlbWFpbmluZyBlc3NlbnRpYWxseSB1bmNoYW5nZWQuIEl0IHdh cyBwb3B1bGFyaXNlZCBpbiB0aGUgMTk2MHMgd2l0aCB0aGUgcmVsZWFzZSBvZiBMZXRyYXNldCBz aGVldHMgY29udGFpbmluZyBMb3JlbSBJcHN1bSBwYXNzYWdlcywgYW5kIG1vcmUgcmVjZW50bHkg d2l0aCBkZXNrdG9wIHB1Ymxpc2hpbmcgc29mdHdhcmUgbGlrZSBBbGR1cyBQYWdlTWFrZXIgaW5j bHVkaW5nIHZlcnNpb25zIG9mIExvcmVtIElwc3VtLgorCQk8L2Rpdj4KKworCQk8ZGl2IGNsYXNz PSJvdXRlclJlZ2lvbiIgaWQ9Im91dGVyUmVnaW9uMSI+PC9kaXY+CisJCTxkaXYgY2xhc3M9Im91 dGVyUmVnaW9uIiBpZD0ib3V0ZXJSZWdpb24yIj48L2Rpdj4KKwk8L2JvZHk+Cis8L2h0bWw+Clwg Tm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGFmYmVmODAuLjUzYzg1NjUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNC0wMi0xNCAgUmFkdSBTdGF2aWxhICA8 c3RhdmlsYUBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBSZWdpb25zXSBNYWtlIHJlZ2lvbnMg dW5zcGxpdHRhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjg4MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBdCB0aGUgbW9tZW50LCBuZXN0ZWQgcmVnaW9ucyBhcmUgbm90IHByb3Blcmx5IGZyYWdt ZW50ZWQgYWNyb3NzIHJlZ2lvbnMuIEZvciB0aGUgbW9tZW50LCAKKyAgICAgICAgdGhlIHJlZ2lv bnMgd2lsbCBiZWNvbWUgdW5zcGxpdHRhYmxlIGVsZW1lbnRzIHRvIGF2b2lkIHNsaWNpbmcuIEF0 IGEgbGF0ZXIgdGltZSBhIHByb3BlcgorICAgICAgICBmcmFnbWVudGF0aW9uIGFsZ29yaXRobSBz aG91bGQgYmUgd3JpdHRlbiwgYWxzbyB0YWtpbmcgaW50byBjb25zaWRlcmF0aW9uIHBhZ2luYXRp b24gc3RydXQuCisKKyAgICAgICAgVGVzdDogZmFzdC9yZWdpb25zL3Vuc3BsaXR0YWJsZS1uZXN0 ZWQtcmVnaW9uLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyQm94Ojppc1Vuc3BsaXR0YWJsZUZvclBhZ2luYXRpb24pOgor CiAyMDE0LTAyLTE0ICBMw6FzemzDsyBMYW5nw7MgIDxsbGFuZ28udS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KIAogICAgICAgICBGb2xsb3ctdXAgZml4IGFmdGVyIHIxNjQwMzYuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCmluZGV4IDk5YTQ1ZjQuLjExNTVkNjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCkBAIC00NDA4LDcgKzQ0MDgsNyBA QCBib29sIFJlbmRlckJveDo6aGFzVW5zcGxpdHRhYmxlU2Nyb2xsaW5nT3ZlcmZsb3coKSBjb25z dAogCiBib29sIFJlbmRlckJveDo6aXNVbnNwbGl0dGFibGVGb3JQYWdpbmF0aW9uKCkgY29uc3QK IHsKLSAgICByZXR1cm4gaXNSZXBsYWNlZCgpIHx8IGhhc1Vuc3BsaXR0YWJsZVNjcm9sbGluZ092 ZXJmbG93KCkgfHwgKHBhcmVudCgpICYmIGlzV3JpdGluZ01vZGVSb290KCkpOworICAgIHJldHVy biBpc1JlcGxhY2VkKCkgfHwgaGFzVW5zcGxpdHRhYmxlU2Nyb2xsaW5nT3ZlcmZsb3coKSB8fCAo cGFyZW50KCkgJiYgaXNXcml0aW5nTW9kZVJvb3QoKSkgfHwgaXNSZW5kZXJOYW1lZEZsb3dGcmFn bWVudENvbnRhaW5lcigpOwogfQogCiBMYXlvdXRVbml0IFJlbmRlckJveDo6bGluZUhlaWdodChi b29sIC8qZmlyc3RMaW5lKi8sIExpbmVEaXJlY3Rpb25Nb2RlIGRpcmVjdGlvbiwgTGluZVBvc2l0 aW9uTW9kZSAvKmxpbmVQb3NpdGlvbk1vZGUqLykgY29uc3QK