128808 2014-02-14 04:55:31 -0800 [GTK] Fix marshaller used in WebKitWebPage::document-loaded signal 2014-02-15 00:32:14 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned oldest_to_newest 980754 0 cgarcia 2014-02-14 04:55:31 -0800 We are using g_cclosure_marshal_VOID__OBJECT probably due to a copy paste error. (WebKitWebProcess:22013): GLib-GObject-CRITICAL **: g_cclosure_marshal_VOID__OBJECT: assertion 'n_param_values == 2' failed 980755 1 224201 cgarcia 2014-02-14 04:57:04 -0800 Created attachment 224201 Patch 980756 2 224201 svillar 2014-02-14 05:03:06 -0800 Comment on attachment 224201 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224201&action=review r=me, good catch! > Source/WebKit2/ChangeLog:3 > + [GTK] Fix marshaller used in WebKitWebPage::document-created signal is document-loaded right? 981135 3 cgarcia 2014-02-15 00:32:14 -0800 Committed r164167: <http://trac.webkit.org/changeset/164167> 224201 2014-02-14 04:57:04 -0800 2014-02-14 05:03:06 -0800 Patch wk2-document-loaded-marshal.diff text/plain 1357 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlMmUzMzY5Li5hNWQxYzkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDItMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEZpeCBtYXJzaGFsbGVyIHVzZWQgaW4gV2ViS2l0V2ViUGFnZTo6 ZG9jdW1lbnQtY3JlYXRlZCBzaWduYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyODgwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL1dlYktp dFdlYlBhZ2UuY3BwOgorICAgICAgICAod2Via2l0X3dlYl9wYWdlX2NsYXNzX2luaXQpOiBVc2Ug Z19jY2xvc3VyZV9tYXJzaGFsX1ZPSURfX1ZPSUQKKyAgICAgICAgaW5zdGVhZCBvZiBnX2NjbG9z dXJlX21hcnNoYWxfVk9JRF9fT0JKRUNULgorCiAyMDE0LTAyLTEwICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBDcmVhdGUgdGhlIGlu c3BlY3RvciB2aWV3IHVzaW5nIHRoZSBzYW1lIHdlYiBwcm9jZXNzIGFzIHRoZSBpbnNwZWN0ZWQg cGFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRs ZS9BUEkvZ3RrL1dlYktpdFdlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9J bmplY3RlZEJ1bmRsZS9BUEkvZ3RrL1dlYktpdFdlYlBhZ2UuY3BwCmluZGV4IDk3ZTc3YWQuLmVh OTk1NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5k bGUvQVBJL2d0ay9XZWJLaXRXZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsvV2ViS2l0V2ViUGFnZS5jcHAKQEAgLTI3MCw3ICsy NzAsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3BhZ2VfY2xhc3NfaW5pdChXZWJLaXRXZWJQ YWdlQ2xhc3MqIGtsYXNzKQogICAgICAgICBHX1RZUEVfRlJPTV9DTEFTUyhrbGFzcyksCiAgICAg ICAgIEdfU0lHTkFMX1JVTl9MQVNULAogICAgICAgICAwLCAwLCAwLAotICAgICAgICBnX2NjbG9z dXJlX21hcnNoYWxfVk9JRF9fT0JKRUNULAorICAgICAgICBnX2NjbG9zdXJlX21hcnNoYWxfVk9J RF9fVk9JRCwKICAgICAgICAgR19UWVBFX05PTkUsIDApOwogCiAgICAgLyoqCg==