<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>128798</bug_id>
          
          <creation_ts>2014-02-13 23:06:38 -0800</creation_ts>
          <short_desc>Use CXX instead of CC for preprocessor</short_desc>
          <delta_ts>2014-11-29 10:53:51 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ting-Wei Lan">lantw44</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>kangil.han</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>980655</commentid>
    <comment_count>0</comment_count>
    <who name="Ting-Wei Lan">lantw44</who>
    <bug_when>2014-02-13 23:06:38 -0800</bug_when>
    <thetext>In Source/WebCore/bindings/scripts/preprocessor.pm and Source/WebCore/dom/make_names.pl, we use -x c++ to make sure the C preprocessor is running in C++ mode. This cause problem if the user set CC with options which is not available in C++, such as &quot;clang -std=c11&quot;. We should use CXX instead for preprocessor, so -x c++ will not cause problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>980656</commentid>
    <comment_count>1</comment_count>
      <attachid>224165</attachid>
    <who name="Ting-Wei Lan">lantw44</who>
    <bug_when>2014-02-13 23:08:49 -0800</bug_when>
    <thetext>Created attachment 224165
Replace CC with CXX</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981272</commentid>
    <comment_count>2</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-02-16 02:41:31 -0800</bug_when>
    <thetext>Compiler flags should be placed into CFLAGS and CXXFLAGS environment variables.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>984186</commentid>
    <comment_count>3</comment_count>
    <who name="Ting-Wei Lan">lantw44</who>
    <bug_when>2014-02-24 22:25:58 -0800</bug_when>
    <thetext>We shuold not assume the C compiler is the same as the C++ compiler.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>224165</attachid>
            <date>2014-02-13 23:08:49 -0800</date>
            <delta_ts>2014-02-13 23:08:49 -0800</delta_ts>
            <desc>Replace CC with CXX</desc>
            <filename>webkit-cxxcpp-bugreport.patch</filename>
            <type>text/plain</type>
            <size>2599</size>
            <attacher name="Ting-Wei Lan">lantw44</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDA5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTEzICBUaW5nLVdl
aSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4KKworICAgICAgICBSZXBsYWNlIENDIHdpdGggQ1hY
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg3OTgK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg
dGVzdHMuIEJ1aWxkIGNoYW5nZSBvbmx5LgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9w
cmVwcm9jZXNzb3IucG06CisgICAgICAgIChhcHBseVByZXByb2Nlc3Nvcik6CisgICAgICAgICog
ZG9tL21ha2VfbmFtZXMucGw6CisKIDIwMTQtMDItMTMgIE15bGVzIEMuIE1heGZpZWxkICA8bW1h
eGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgcG9zaXRpb246c3RpY2t5IHJ1bnRp
bWUgZmxhZwpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNz
b3IucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVw
cm9jZXNzb3IucG0JKHJldmlzaW9uIDE2NDA5MCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz
L3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtCSh3b3JraW5nIGNvcHkpCkBAIC00NSwxNCArNDUsMTYg
QEAgc3ViIGFwcGx5UHJlcHJvY2Vzc29yCiAgICAgbXkgQGFyZ3MgPSAoKTsKICAgICBpZiAoISRw
cmVwcm9jZXNzb3IpIHsKICAgICAgICAgcmVxdWlyZSBDb25maWc7Ci0gICAgICAgIGlmICgkRU5W
e0NDfSkgewotICAgICAgICAgICAgJHByZXByb2Nlc3NvciA9ICRFTlZ7Q0N9OworICAgICAgICBp
ZiAoJEVOVntDWFh9KSB7CisgICAgICAgICAgICAkcHJlcHJvY2Vzc29yID0gJEVOVntDWFh9Owog
ICAgICAgICB9IGVsc2lmICgoJENvbmZpZzo6Q29uZmlneydvc25hbWUnfSkgPX4gL3NvbGFyaXMv
aSkgewotICAgICAgICAgICAgJHByZXByb2Nlc3NvciA9ICIvdXNyL3Nmdy9iaW4vZ2NjIjsKLSAg
ICAgICAgfSBlbHNpZiAoLXggIi91c3IvYmluL2NsYW5nIikgewotICAgICAgICAgICAgJHByZXBy
b2Nlc3NvciA9ICIvdXNyL2Jpbi9jbGFuZyI7CisgICAgICAgICAgICAkcHJlcHJvY2Vzc29yID0g
Ii91c3Ivc2Z3L2Jpbi9nKysiOworICAgICAgICB9IGVsc2lmICgteCAiL3Vzci9iaW4vY2xhbmcr
KyIpIHsKKyAgICAgICAgICAgICRwcmVwcm9jZXNzb3IgPSAiL3Vzci9iaW4vY2xhbmcrKyI7Cisg
ICAgICAgIH0gZWxzaWYgKC14ICIvdXNyL2Jpbi9nKysiKSB7CisgICAgICAgICAgICAkcHJlcHJv
Y2Vzc29yID0gIi91c3IvYmluL2crKyI7CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAk
cHJlcHJvY2Vzc29yID0gIi91c3IvYmluL2djYyI7CisgICAgICAgICAgICAkcHJlcHJvY2Vzc29y
ID0gIi91c3IvYmluL2MrKyI7CiAgICAgICAgIH0KICAgICAgICAgcHVzaChAYXJncywgcXcoLUUg
LVAgLXggYysrKSk7CiAgICAgfQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL21ha2VfbmFtZXMu
cGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL21ha2VfbmFtZXMucGwJKHJldmlz
aW9uIDE2NDA5MCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCSh3b3JraW5n
IGNvcHkpCkBAIC02MywxNCArNjMsMTQgQEAgbXkgJWV4dGVuc2lvbkF0dHJzID0gKCk7CiByZXF1
aXJlIENvbmZpZzsKIAogbXkgJGdjY0xvY2F0aW9uID0gIiI7Ci1pZiAoJEVOVntDQ30pIHsKLSAg
ICAkZ2NjTG9jYXRpb24gPSAkRU5We0NDfTsKK2lmICgkRU5We0NYWH0pIHsKKyAgICAkZ2NjTG9j
YXRpb24gPSAkRU5We0NYWH07CiB9IGVsc2lmICgoJENvbmZpZzo6Q29uZmlneyJvc25hbWUifSkg
PX4gL3NvbGFyaXMvaSkgewotICAgICRnY2NMb2NhdGlvbiA9ICIvdXNyL3Nmdy9iaW4vZ2NjIjsK
KyAgICAkZ2NjTG9jYXRpb24gPSAiL3Vzci9zZncvYmluL2crKyI7CiB9IGVsc2lmICgkQ29uZmln
OjpDb25maWd7Im9zbmFtZSJ9IGVxICJkYXJ3aW4iICYmICRFTlZ7U0RLUk9PVH0pIHsKLSAgICBj
aG9tcCgkZ2NjTG9jYXRpb24gPSBgeGNydW4gLWZpbmQgY2MgLXNkayAnJEVOVntTREtST09UfSdg
KTsKKyAgICBjaG9tcCgkZ2NjTG9jYXRpb24gPSBgeGNydW4gLWZpbmQgYysrIC1zZGsgJyRFTlZ7
U0RLUk9PVH0nYCk7CiB9IGVsc2UgewotICAgICRnY2NMb2NhdGlvbiA9ICIvdXNyL2Jpbi9jYyI7
CisgICAgJGdjY0xvY2F0aW9uID0gIi91c3IvYmluL2MrKyI7CiB9CiBteSAkcHJlcHJvY2Vzc29y
ID0gJGdjY0xvY2F0aW9uIC4gIiAtRSAteCBjKysiOwogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>