128772 2014-02-13 15:13:11 -0800 GetByIdStatus shouldn't call takesSlowPathInDFGForImpureProperty() for self accesses, and calling that method should never assert about anything 2014-02-13 16:31:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 980483 0 fpizlo 2014-02-13 15:13:11 -0800 Patch forthcoming 980484 1 224118 fpizlo 2014-02-13 15:14:03 -0800 Created attachment 224118 the patch 980487 2 224118 mhahnenberg 2014-02-13 15:16:23 -0800 Comment on attachment 224118 the patch r=me 980497 3 fpizlo 2014-02-13 15:27:24 -0800 Landed in http://trac.webkit.org/changeset/164066 980510 4 fpizlo 2014-02-13 15:49:01 -0800 This is wrong. Rolling it out. 980526 5 fpizlo 2014-02-13 16:31:51 -0800 Rolled out in http://trac.webkit.org/changeset/164071 224118 2014-02-13 15:14:03 -0800 2014-02-13 15:16:21 -0800 the patch blah.patch text/plain 2973 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0MDY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAyLTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg R2V0QnlJZFN0YXR1cyBzaG91bGRuJ3QgY2FsbCB0YWtlc1Nsb3dQYXRoSW5ERkdGb3JJbXB1cmVQ cm9wZXJ0eSgpIGZvciBzZWxmIGFjY2Vzc2VzLCBhbmQgY2FsbGluZyB0aGF0IG1ldGhvZCBzaG91 bGQgbmV2ZXIgYXNzZXJ0IGFib3V0IGFueXRoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg3NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGJ5dGVjb2RlL0dldEJ5SWRTdGF0dXMuY3BwOgorICAg ICAgICAoSlNDOjpHZXRCeUlkU3RhdHVzOjpjb21wdXRlRnJvbUxMSW50KToKKyAgICAgICAgKEpT Qzo6R2V0QnlJZFN0YXR1czo6Y29tcHV0ZUZvclN0dWJJbmZvKToKKyAgICAgICAgKiBydW50aW1l L1N0cnVjdHVyZS5oOgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmU6OnRha2VzU2xvd1BhdGhJbkRG R0ZvckltcHVyZVByb3BlcnR5KToKKwogMjAxNC0wMi0xMyAgTWFyayBIYWhuZW5iZXJnICA8bWhh aG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzb21lIFJFTEVBU0VfQVNTRVJUcyB0 byBjYXRjaCBKU0xvY2sgYnVncyBlYXJsaWVyCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvZGUvR2V0QnlJZFN0YXR1cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL0dldEJ5SWRTdGF0dXMuY3BwCShyZXZpc2lvbiAxNjQwNTcpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvR2V0QnlJZFN0YXR1cy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTU5LDkgKzU5LDYgQEAgR2V0QnlJZFN0YXR1cyBHZXRCeUlkU3RhdHVzOjpjb21w dXRlRnJvbQogICAgIGlmICghc3RydWN0dXJlKQogICAgICAgICByZXR1cm4gR2V0QnlJZFN0YXR1 cyhOb0luZm9ybWF0aW9uLCBmYWxzZSk7CiAKLSAgICBpZiAoc3RydWN0dXJlLT50YWtlc1Nsb3dQ YXRoSW5ERkdGb3JJbXB1cmVQcm9wZXJ0eSgpKQotICAgICAgICByZXR1cm4gR2V0QnlJZFN0YXR1 cyhOb0luZm9ybWF0aW9uLCBmYWxzZSk7Ci0KICAgICB1bnNpZ25lZCBhdHRyaWJ1dGVzSWdub3Jl ZDsKICAgICBKU0NlbGwqIHNwZWNpZmljVmFsdWU7CiAgICAgUHJvcGVydHlPZmZzZXQgb2Zmc2V0 ID0gc3RydWN0dXJlLT5nZXRDb25jdXJyZW50bHkoCkBAIC0xOTEsOCArMTg4LDYgQEAgR2V0QnlJ ZFN0YXR1cyBHZXRCeUlkU3RhdHVzOjpjb21wdXRlRm9yUwogICAgICAgICAKICAgICBjYXNlIGFj Y2Vzc19nZXRfYnlfaWRfc2VsZjogewogICAgICAgICBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA9IHN0 dWJJbmZvLT51LmdldEJ5SWRTZWxmLmJhc2VPYmplY3RTdHJ1Y3R1cmUuZ2V0KCk7Ci0gICAgICAg IGlmIChzdHJ1Y3R1cmUtPnRha2VzU2xvd1BhdGhJbkRGR0ZvckltcHVyZVByb3BlcnR5KCkpCi0g ICAgICAgICAgICByZXR1cm4gR2V0QnlJZFN0YXR1cyhUYWtlc1Nsb3dQYXRoLCB0cnVlKTsKICAg ICAgICAgdW5zaWduZWQgYXR0cmlidXRlc0lnbm9yZWQ7CiAgICAgICAgIEpTQ2VsbCogc3BlY2lm aWNWYWx1ZTsKICAgICAgICAgcmVzdWx0Lm1fb2Zmc2V0ID0gc3RydWN0dXJlLT5nZXRDb25jdXJy ZW50bHkoCkBAIC0yMTUsOSArMjEwLDYgQEAgR2V0QnlJZFN0YXR1cyBHZXRCeUlkU3RhdHVzOjpj b21wdXRlRm9yUwogICAgICAgICAgICAgQVNTRVJUKGxpc3QtPmxpc3RbaV0uaXNEaXJlY3QpOwog ICAgICAgICAgICAgCiAgICAgICAgICAgICBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA9IGxpc3QtPmxp c3RbaV0uYmFzZS5nZXQoKTsKLSAgICAgICAgICAgIGlmIChzdHJ1Y3R1cmUtPnRha2VzU2xvd1Bh dGhJbkRGR0ZvckltcHVyZVByb3BlcnR5KCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuIEdldEJ5 SWRTdGF0dXMoVGFrZXNTbG93UGF0aCwgdHJ1ZSk7Ci0KICAgICAgICAgICAgIGlmIChyZXN1bHQu bV9zdHJ1Y3R1cmVTZXQuY29udGFpbnMoc3RydWN0dXJlKSkKICAgICAgICAgICAgICAgICBjb250 aW51ZTsKICAgICAgICAgICAgIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv U3RydWN0dXJlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv U3RydWN0dXJlLmgJKHJldmlzaW9uIDE2NDA1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1N0cnVjdHVyZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzksNyArMTM5LDYgQEAgcHVi bGljOgogICAgIC8vIERGRyBmcm9tIGlubGluaW5nIHByb3BlcnR5IGFjY2Vzc2VzIHNpbmNlIHN0 cnVjdHVyZXMgZG9uJ3QgdHJhbnNpdGlvbiB3aGVuIGEgbmV3IGltcHVyZSBwcm9wZXJ0eSBhcHBl YXJzLgogICAgIGJvb2wgdGFrZXNTbG93UGF0aEluREZHRm9ySW1wdXJlUHJvcGVydHkoKQogICAg IHsKLSAgICAgICAgQVNTRVJUKCF0eXBlSW5mbygpLmhhc0ltcHVyZUdldE93blByb3BlcnR5U2xv dCgpIHx8IHR5cGVJbmZvKCkubmV3SW1wdXJlUHJvcGVydHlGaXJlc1dhdGNocG9pbnRzKCkpOwog ICAgICAgICByZXR1cm4gdHlwZUluZm8oKS5oYXNJbXB1cmVHZXRPd25Qcm9wZXJ0eVNsb3QoKTsK ICAgICB9CiAK