128771 2014-02-13 15:11:02 -0800 SVG - Filtered element will be upscaled with low filterRes value 2014-06-04 00:50:07 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 68469 1 savagobr webkit-unassigned commit-queue dino d-r esprehn+autocc fmalita glenn gyuyoung.kim kondapallykalyan krit pdr schenney sergio zimmermann oldest_to_newest 980481 0 savagobr 2014-02-13 15:11:02 -0800 Should appear as a green rectangle, will display 2 rectangles (one being red at the background). 980482 1 224117 savagobr 2014-02-13 15:11:40 -0800 Created attachment 224117 PoC: should appear as a single green rectangle 982521 2 224668 savagobr 2014-02-19 13:33:08 -0800 Created attachment 224668 Patch 982522 3 commit-queue 2014-02-19 13:34:40 -0800 Attachment 224668 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:12: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 982524 4 224668 krit 2014-02-19 13:36:29 -0800 Comment on attachment 224668 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224668&action=review > Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:171 > + // If the scale factor is way too low, it will deform/upscale the > + // element size. filterRes is used by internal code as well to make sure we do nor create to big buffers. Does the issue happen for internal code as well? If not, we should rather remove the API from SVGFitlerElement. It already was removed from Fitler Effects specification. 982612 5 savagobr 2014-02-19 16:59:28 -0800 Dirk Thanks for the review. When you mentioned "internal code" and "big buffers", are you referring to that function that tests for maximumImageSize (i.e. bool RenderSVGResourceFilter::fitsInMaximumImageSize(const FloatSize& size, FloatSize& scale)? If so, scale factor is not tested there. Or are you talking about other code path? 985353 6 savagobr 2014-02-27 14:44:38 -0800 Dirk As you have pointed, the spec will drop the filterRes parameter and it seems that FF has dropped it already. Should I instead created a new bug to propose removal of this feature? 985464 7 krit 2014-02-27 22:16:13 -0800 (In reply to comment #6) > Dirk > > As you have pointed, the spec will drop the filterRes parameter and it seems that FF has dropped it already. > > Should I instead created a new bug to propose removal of this feature? yes please. :) 986023 8 savagobr 2014-03-01 17:31:43 -0800 The followup bug: https://bugs.webkit.org/show_bug.cgi?id=129565 986088 9 krit 2014-03-02 08:33:36 -0800 Can we close this bug now? 1013254 10 224668 ossy 2014-06-04 00:50:07 -0700 Comment on attachment 224668 Patch Cleared review? from attachment 224668 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 224117 2014-02-13 15:11:40 -0800 2014-02-13 15:11:40 -0800 PoC: should appear as a single green rectangle filter-res.svg image/svg+xml 435 savagobr PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KPGRlZnM+Cgo8IS0tIHNjYWxlIDAuMDA4MyAtLT4K PGZpbHRlciBpZD0iZjAiIGZpbHRlclJlcz0iMSI+CiAgICA8ZmVGbG9vZCBmbG9vZC1jb2xvcj0i cmVkIi8+CjwvZmlsdGVyPgoKPCEtLSBzY2FsZSAwLjE2IC0tPgo8ZmlsdGVyIGlkPSJmMSIgZmls dGVyUmVzPSIyMCI+CiAgICA8ZmVGbG9vZCBmbG9vZC1jb2xvcj0iZ3JlZW4iLz4KPC9maWx0ZXI+ CgoKPC9kZWZzPgo8cmVjdCB4PSIyMCIgeT0iMjAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBm aWx0ZXI9InVybCgjZjApIi8+CjxyZWN0IHg9IjIwIiB5PSIyMCIgd2lkdGg9IjEwMCIgaGVpZ2h0 PSIxMDAiIGZpbHRlcj0idXJsKCNmMSkiLz4KCjwvc3ZnPgoK 224668 2014-02-19 13:33:08 -0800 2014-06-04 00:50:07 -0700 Patch bug-128771-20140219133307.patch text/plain 2210 savagobr U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0Mzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWY2MTQzZDIxN2U2OGU1 OGE5MWQ0NjQ0MDVkNmFmZDMzOTVlZDQyYy4uM2IzMDg5YjRmMGI0YzZkZWU0MmVmZmY1Zjg2ZTM5 MmVkZjZlOTU1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAyLTE5ICBBZGVu aWxzb24gQ2F2YWxjYW50aSAgPGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KKworICAgICAgICBTVkcg LSBGaWx0ZXJlZCBlbGVtZW50IHdpbGwgYmUgdXBzY2FsZWQgd2l0aCBsb3cgZmlsdGVyUmVzIHZh bHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg3 NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBh ZGRzIGEgdGVzdCBmb3IgbWluaW11bSBzY2FsZSBmYWN0b3IgdXNlZCBpbiBmaWx0ZXJSZXMgYXR0 cmlidXRlCisgICAgICAgIGluIGEgU1ZHIGZpbHRlci4gSWYgYmVsb3cgYSBtaW5pbXVtIHRocmVz aG9sZCwgdGhlIFNWRyBlbGVtZW50CisgICAgICAgIHdpbGwgYmUgZHJhd24gdXBzY2FsZWQuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3Zn L1JlbmRlclNWR1Jlc291cmNlRmlsdGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNW R1Jlc291cmNlRmlsdGVyOjphcHBseVJlc291cmNlKToKKwogMjAxNC0wMi0xOSAgVGhpYWdvIGRl IEJhcnJvcyBMYWNlcmRhICA8dGhpYWdvLmxhY2VyZGFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAg ICBbV2ViUlRDXSBVcGRhdGluZyBSVENDb25maWd1cmF0aW9uIHRvIG1hdGNoIFdlYlJUQyBlZGl0 b3IncyBkcmFmdCBvZiAwMS8yNy8yMDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvc3ZnL1JlbmRlclNWR1Jlc291cmNlRmlsdGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VGaWx0ZXIuY3BwCmluZGV4IDZlYmUxMzRjYWNl OGRkY2M1MmRkOTIzN2Q0MjliOGU5ZTE3OWUwNWUuLjgyMmQ1YzQ5MTAwN2ExZTQxMTliOTkwMjA5 ZjZjOWUxMzZiMDUxMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcv UmVuZGVyU1ZHUmVzb3VyY2VGaWx0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VGaWx0ZXIuY3BwCkBAIC00Niw2ICs0Niw4IEBACiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAorc3RhdGljIGNvbnN0IGZsb2F0IG1pbmltdW1TY2FsZUZhY3Rv ciA9IDAuMjA7CisKIFJlbmRlclNWR1Jlc291cmNlVHlwZSBSZW5kZXJTVkdSZXNvdXJjZUZpbHRl cjo6c19yZXNvdXJjZVR5cGUgPSBGaWx0ZXJSZXNvdXJjZVR5cGU7CiAKIFJlbmRlclNWR1Jlc291 cmNlRmlsdGVyOjpSZW5kZXJTVkdSZXNvdXJjZUZpbHRlcihTVkdGaWx0ZXJFbGVtZW50JiBlbGVt ZW50LCBQYXNzUmVmPFJlbmRlclN0eWxlPiBzdHlsZSkKQEAgLTE2NSw2ICsxNjcsMTAgQEAgYm9v bCBSZW5kZXJTVkdSZXNvdXJjZUZpbHRlcjo6YXBwbHlSZXNvdXJjZShSZW5kZXJFbGVtZW50JiBy ZW5kZXJlciwgY29uc3QgUmVuZGUKIAogICAgIGlmIChzY2FsZS5pc0VtcHR5KCkpCiAgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICAvLyBJZiB0aGUgc2NhbGUgZmFjdG9yIGlzIHdheSB0b28gbG93 LCBpdCB3aWxsIGRlZm9ybS91cHNjYWxlIHRoZQorICAgIC8vIGVsZW1lbnQgc2l6ZS4KKyAgICBp ZiAoKHNjYWxlLndpZHRoKCkgPCBtaW5pbXVtU2NhbGVGYWN0b3IpIHx8IChzY2FsZS5oZWlnaHQo KSA8IG1pbmltdW1TY2FsZUZhY3RvcikpCisgICAgICAgIHNjYWxlID0gRmxvYXRTaXplKG1pbmlt dW1TY2FsZUZhY3RvciwgbWluaW11bVNjYWxlRmFjdG9yKTsKIAogICAgIC8vIERldGVybWluZSBz Y2FsZSBmYWN0b3IgZm9yIGZpbHRlci4gVGhlIHNpemUgb2YgaW50ZXJtZWRpYXRlIEltYWdlQnVm ZmVycyBzaG91bGRuJ3QgYmUgYmlnZ2VyIHRoYW4ga01heEZpbHRlclNpemUuCiAgICAgRmxvYXRS ZWN0IHRlbXBTb3VyY2VSZWN0ID0gYWJzb2x1dGVEcmF3aW5nUmVnaW9uOwo=