128767 2014-02-13 14:29:36 -0800 Write FEComposite::computeArithmeticPixelsNeon() in terms of loadRGBA8AsFloat() 2014-02-13 15:30:44 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates barraclough ddkilzer dino fpizlo ggaren oldest_to_newest 980455 0 dbates 2014-02-13 14:29:36 -0800 We should use loadRGBA8AsFloat() instead of duplicating similar code in FEComposite::computeArithmeticPixelsNeon(). Also, this will resolve the following uninitialized variable compiler warning: Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h:52:61: error: variable 'temporary1' is uninitialized when used within its own initialization [-Werror,-Wuninitialized] uint32x2_t temporary1 = vset_lane_u32(*sourcePixel, temporary1, 0); 980456 1 224111 dbates 2014-02-13 14:30:19 -0800 Created attachment 224111 Patch 980461 2 dbates 2014-02-13 14:40:40 -0800 Committed r164058: <http://trac.webkit.org/changeset/164058> 980500 3 dbates 2014-02-13 15:30:44 -0800 Included header NEONHelpers.h and committed build fix in <http://trac.webkit.org/changeset/164060>. 224111 2014-02-13 14:30:19 -0800 2014-02-13 14:32:40 -0800 Patch bug-128767-20140213143019.patch text/plain 2618 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjIxODgwZTJmZThhZDAz NmQyNWNjNWEzNzhkNDlhZmY0NmJiNGFkNi4uOWI1Mjc2NjJmMjk0NWZiNzU1MGM3ZTliZDkwYzNm MDY5NWJjNzhkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAyLTEzICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBXcml0ZSBGRUNvbXBvc2l0 ZTo6Y29tcHV0ZUFyaXRobWV0aWNQaXhlbHNOZW9uKCkgaW4gdGVybXMgb2YgbG9hZFJHQkE4QXNG bG9hdCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x Mjg3NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHBhdGNoIHdhcyBpbnNwaXJlZCBieSBHYWJvciBSYXBjc2FueWkncyB3b3JrIGluIDxodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA2Njk+LgorCisgICAgICAgIEN1 cnJlbnRseSB3ZSBkdXBsaWNhdGUgY29kZSBpbiBGRUNvbXBvc2l0ZTo6Y29tcHV0ZUFyaXRobWV0 aWNQaXhlbHNOZW9uKCkgdG8gcmVhZCBwaXhlbCBkYXRhLgorICAgICAgICBJbnN0ZWFkIHdlIHNo b3VsZCB1c2UgdGhlIGNvbnZlbmllbmNlIGZ1bmN0aW9uIFdlYkNvcmU6OmxvYWRSR0JBOEFzRmxv YXQuIFRoaXMgYWxzbyByZXNvbHZlcworICAgICAgICBhbiB1bmluaXRpYWxpemVkIHZhcmlhYmxl IGNvbXBpbGVyIHdhcm5pbmcgaW4gdGhlIGV4aXN0aW5nIGNvZGUuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9jcHUvYXJtL2ZpbHRlcnMvRkVDb21wb3NpdGVBcml0aG1ldGljTkVPTi5o OgorICAgICAgICAoV2ViQ29yZTo6RkVDb21wb3NpdGU6OmNvbXB1dGVBcml0aG1ldGljUGl4ZWxz TmVvbik6CisKIDIwMTQtMDItMTIgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgog CiAgICAgICAgIFJFR1JFU1NJT04gKHIxNjM1NjApOiBBbHdheXMgdHJlYXQgU1ZHIDx0c3Bhbj4g YW5kIDx0ZXh0UGF0aD4gYXMgZGlzcGxheSBpbmxpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NwdS9hcm0vZmlsdGVycy9GRUNvbXBvc2l0ZUFyaXRobWV0 aWNORU9OLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jcHUvYXJtL2ZpbHRl cnMvRkVDb21wb3NpdGVBcml0aG1ldGljTkVPTi5oCmluZGV4IDIzNTRkZmM4MDlhODI2N2E1OTE1 YTk1ZGU1M2U5YjdkMTNlZDU1NDQuLjllYmI5MTk2NjdjYjI5ZGVkM2NlMTNiZmNiMDZjYTk0N2Vj YzFjOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NwdS9h cm0vZmlsdGVycy9GRUNvbXBvc2l0ZUFyaXRobWV0aWNORU9OLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY3B1L2FybS9maWx0ZXJzL0ZFQ29tcG9zaXRlQXJpdGhtZXRp Y05FT04uaApAQCAtNDksMTMgKzQ5LDggQEAgaW5saW5lIHZvaWQgRkVDb21wb3NpdGU6OmNvbXB1 dGVBcml0aG1ldGljUGl4ZWxzTmVvbih1bnNpZ25lZCBjaGFyKiBzb3VyY2UsIHVuc2kKICAgICB1 aW50MzJfdCogZGVzdGluYXRpb25FbmRQaXhlbCA9IGRlc3RpbmF0aW9uUGl4ZWwgKyAocGl4ZWxB cnJheUxlbmd0aCA+PiAyKTsKIAogICAgIHdoaWxlIChkZXN0aW5hdGlvblBpeGVsIDwgZGVzdGlu YXRpb25FbmRQaXhlbCkgewotICAgICAgICB1aW50MzJ4Ml90IHRlbXBvcmFyeTEgPSB2c2V0X2xh bmVfdTMyKCpzb3VyY2VQaXhlbCwgdGVtcG9yYXJ5MSwgMCk7Ci0gICAgICAgIHVpbnQxNng0X3Qg dGVtcG9yYXJ5MiA9IHZnZXRfbG93X3UxNih2bW92bF91OCh2cmVpbnRlcnByZXRfdThfdTMyKHRl bXBvcmFyeTEpKSk7Ci0gICAgICAgIGZsb2F0MzJ4NF90IHNvdXJjZVBpeGVsQXNGbG9hdCA9IHZj dnRxX2YzMl91MzIodm1vdmxfdTE2KHRlbXBvcmFyeTIpKTsKLQotICAgICAgICB0ZW1wb3Jhcnkx ID0gdnNldF9sYW5lX3UzMigqZGVzdGluYXRpb25QaXhlbCwgdGVtcG9yYXJ5MSwgMCk7Ci0gICAg ICAgIHRlbXBvcmFyeTIgPSB2Z2V0X2xvd191MTYodm1vdmxfdTgodnJlaW50ZXJwcmV0X3U4X3Uz Mih0ZW1wb3JhcnkxKSkpOwotICAgICAgICBmbG9hdDMyeDRfdCBkZXN0aW5hdGlvblBpeGVsQXNG bG9hdCA9IHZjdnRxX2YzMl91MzIodm1vdmxfdTE2KHRlbXBvcmFyeTIpKTsKKyAgICAgICAgZmxv YXQzMng0X3Qgc291cmNlUGl4ZWxBc0Zsb2F0ID0gbG9hZFJHQkE4QXNGbG9hdChzb3VyY2VQaXhl bCk7CisgICAgICAgIGZsb2F0MzJ4NF90IGRlc3RpbmF0aW9uUGl4ZWxBc0Zsb2F0ID0gbG9hZFJH QkE4QXNGbG9hdChkZXN0aW5hdGlvblBpeGVsKTsKIAogICAgICAgICBmbG9hdDMyeDRfdCByZXN1 bHQgPSB2bXVscV9mMzIoc291cmNlUGl4ZWxBc0Zsb2F0LCBrMng0KTsKICAgICAgICAgcmVzdWx0 ID0gdm1sYXFfZjMyKHJlc3VsdCwgZGVzdGluYXRpb25QaXhlbEFzRmxvYXQsIGszeDQpOwo=