128753 2014-02-13 12:04:03 -0800 Normalize some of the older JSC options 2014-03-19 12:33:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 980383 0 mhahnenberg 2014-02-13 12:04:03 -0800 Some of the options manually look for non-standard environment variables (e.g. GCMaxHeapSize). We should get rid of these special cases. 989752 1 226538 mhahnenberg 2014-03-12 11:34:18 -0700 Created attachment 226538 Patch 989794 2 226538 msaboff 2014-03-12 12:44:12 -0700 Comment on attachment 226538 Patch r=me You're actually deleted unused old options and note normalizing. 989801 3 mhahnenberg 2014-03-12 13:08:03 -0700 (In reply to comment #2) > (From update of attachment 226538 [details]) > r=me > > You're actually deleted unused old options and note normalizing. These were just non-standard names for other options which will continue to exist. E.g. JSC_recordGCPauseTimes and JSRecordGCPauseTimes were equivalent. We'll still have JSC_recordGCPauseTimes. Same for JSC_objectsAreImmortal, JSC_useZombieMode, JSC_gcMaxHeapSize, and JSC_logHeapStatisticsAtExit. I'm not removing the functionality of any of these options. So if we're being pedantic it really is a "standardization" or a "normalization" and not a "deletion". 992210 4 226538 commit-queue 2014-03-19 12:33:11 -0700 Comment on attachment 226538 Patch Clearing flags on attachment: 226538 Committed r165909: <http://trac.webkit.org/changeset/165909> 992211 5 commit-queue 2014-03-19 12:33:13 -0700 All reviewed patches have been landed. Closing bug. 226538 2014-03-12 11:34:18 -0700 2014-03-19 12:33:11 -0700 Patch bug-128753-20140312112857.patch text/plain 1551 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY1NDkwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTAzLTEyICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgTm9ybWFsaXplIHNvbWUgb2YgdGhlIG9sZGVyIEpTQyBvcHRpb25zCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg3NTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvT3B0aW9u cy5jcHA6CisgICAgICAgIChKU0M6Ok9wdGlvbnM6OmluaXRpYWxpemUpOgorCiAyMDE0LTAzLTEy ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVt b3ZlIEhhbmRsZVNldDo6bV9uZXh0VG9GaW5hbGl6ZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAJKHJldmlzaW9uIDE2NTQ4NykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzcsMTUg KzIzNyw2IEBAIHZvaWQgT3B0aW9uczo6aW5pdGlhbGl6ZSgpCiAgICAgSlNDX09QVElPTlMoRk9S X0VBQ0hfT1BUSU9OKQogI3VuZGVmIEZPUl9FQUNIX09QVElPTgogICAgICAgICAKLSNpZiBVU0Uo Q0YpIHx8IE9TKFVOSVgpCi0gICAgb2JqZWN0c0FyZUltbW9ydGFsKCkgPSAhIWdldGVudigiSlNJ bW1vcnRhbFpvbWJpZUVuYWJsZWQiKTsKLSAgICB1c2Vab21iaWVNb2RlKCkgPSAhIWdldGVudigi SlNJbW1vcnRhbFpvbWJpZUVuYWJsZWQiKSB8fCAhIWdldGVudigiSlNab21iaWVFbmFibGVkIik7 Ci0KLSAgICBnY01heEhlYXBTaXplKCkgPSBnZXRlbnYoIkdDTWF4SGVhcFNpemUiKSA/IEhlYXBT dGF0aXN0aWNzOjpwYXJzZU1lbW9yeUFtb3VudChnZXRlbnYoIkdDTWF4SGVhcFNpemUiKSkgOiAw OwotICAgIHJlY29yZEdDUGF1c2VUaW1lcygpID0gISFnZXRlbnYoIkpTUmVjb3JkR0NQYXVzZVRp bWVzIik7Ci0gICAgbG9nSGVhcFN0YXRpc3RpY3NBdEV4aXQoKSA9IGdjTWF4SGVhcFNpemUoKSB8 fCByZWNvcmRHQ1BhdXNlVGltZXMoKTsKLSNlbmRpZgotCiAgICAgLy8gQWxsb3cgZW52aXJvbm1l bnQgdmFycyB0byBvdmVycmlkZSBvcHRpb25zIGlmIGFwcGxpY2FibGUuCiAgICAgLy8gVGhlIGV2 biB2YXIgc2hvdWxkIGJlIHRoZSBuYW1lIG9mIHRoZSBvcHRpb24gcHJlZml4ZWQgd2l0aAogICAg IC8vICJKU0NfIi4K