128742 2014-02-13 06:52:41 -0800 [GTK] Build failure caused by missing jsmin module 2014-02-17 11:43:22 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 changseok changseok berto calvaris commit-queue gustavo mrobinson pnormand zan oldest_to_newest 980286 0 changseok 2014-02-13 06:52:41 -0800 ../../autogen.sh --prefix=/usr/local --enable-gles2 --enable-egl --enable-developer-mode;make -j4 GEN DerivedSources/WebCore/XMLNames.cpp GEN DerivedSources/WebCore/XMLNSNames.cpp GEN DerivedSources/WebCore/UserAgentStyleSheets.h Traceback (most recent call last): File "../../Source/WebCore/Scripts/make-js-file-arrays.py", line 28, in <module> from jsmin import JavascriptMinify ImportError: No module named jsmin make: *** [DerivedSources/WebCore/UserAgentScripts.h] Error 1 make: *** Waiting for unfinished jobs.... mkdir -p DerivedSources/JavaScriptCore/inspector Perhaps https://bugs.webkit.org/show_bug.cgi?id=127559 is related? 980290 1 224067 changseok 2014-02-13 06:59:42 -0800 Created attachment 224067 Patch 980634 2 changseok 2014-02-13 21:27:34 -0800 I've tested with python3 for a while. But no luck there too. Another failure happend like following. GEN DerivedSources/WebCore/XLinkNames.cpp GEN DerivedSources/WebCore/XMLNames.cpp File "../../Source/WebCore/Scripts/make-js-file-arrays.py", line 48 print 'Error: must provide at least 3 arguments' ^ SyntaxError: invalid syntax make: *** [DerivedSources/WebCore/UserAgentScripts.h] Error 1 make: *** Waiting for unfinished jobs.... GEN DerivedSources/WebCore/InjectedScriptCanvasModuleSource.h But this can also be resolved with the patch. I guess if gtk bots uses cmake build system, they may not complain. 980657 3 changseok 2014-02-13 23:11:28 -0800 o.k I found an another clue, https://bugs.webkit.org/show_bug.cgi?id=123097 MediaControlScript affects the failure. 980699 4 224180 changseok 2014-02-14 01:46:48 -0800 Created attachment 224180 Patch 980700 5 changseok 2014-02-14 01:50:50 -0800 @calvaris, Isn't this what you intended? > $(AM_V_GEN) PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR) $(PYTHON) $< $@ DerivedSources/WebCore/UserAgentScriptsData.cpp $(USER_AGENT_SCRIPT_FILES) 980724 6 224180 calvaris 2014-02-14 03:07:07 -0800 Comment on attachment 224180 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224180&action=review > Source/WebCore/GNUmakefile.am:271 > -DerivedSources/WebCore/UserAgentScripts.h: PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR) > DerivedSources/WebCore/UserAgentScripts.h: $(WebCore)/Scripts/make-js-file-arrays.py $(USER_AGENT_SCRIPT_FILES) > - $(AM_V_GEN)$(PYTHON) $< $@ DerivedSources/WebCore/UserAgentScriptsData.cpp $(USER_AGENT_SCRIPT_FILES) > + $(AM_V_GEN) PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR) $(PYTHON) $< $@ DerivedSources/WebCore/UserAgentScriptsData.cpp $(USER_AGENT_SCRIPT_FILES) I intented that, yes, but for some reason I couldn't make it work because I was prepending the PYTHONPATH to AM_V_GEN and that didn't work. If this does, it makes sense. Anyway, is there a problem with this? According something I read, this was the recommended way of enabling an environment variable for only one make target. 980811 7 changseok 2014-02-14 09:07:36 -0800 (In reply to comment #6) > (From update of attachment 224180 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=224180&action=review > > > Source/WebCore/GNUmakefile.am:271 > > -DerivedSources/WebCore/UserAgentScripts.h: PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR) > > DerivedSources/WebCore/UserAgentScripts.h: $(WebCore)/Scripts/make-js-file-arrays.py $(USER_AGENT_SCRIPT_FILES) > > - $(AM_V_GEN)$(PYTHON) $< $@ DerivedSources/WebCore/UserAgentScriptsData.cpp $(USER_AGENT_SCRIPT_FILES) > > + $(AM_V_GEN) PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR) $(PYTHON) $< $@ DerivedSources/WebCore/UserAgentScriptsData.cpp $(USER_AGENT_SCRIPT_FILES) > > I intented that, yes, but for some reason I couldn't make it work because I was prepending the PYTHONPATH to AM_V_GEN and that didn't work. If this does, it makes sense. > > Anyway, is there a problem with this? According something I read, this was the recommended way of enabling an environment variable for only one make target. Yes. The failure still happens on my system, Ubuntu 13.10 using python 2.7.x It's really odd that gtk bot doesn't catch this failure if it uses autotool as default. I tried to build after bumping python up to 3.x. It was not helpful, on the contrary it causes two other problem 1. some webkit scripts in ./Tools are not working with python 3.x 2. Bumping the version just causes another break while generating DerivedSources Anyway the make-us-xxx script needs jsmin.py so we should indicate where it is or add $(INSPECTOR...)/jsmin.py explicitly as an argument of python. 981370 8 224180 pnormand 2014-02-17 02:56:53 -0800 Comment on attachment 224180 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224180&action=review > Source/WebCore/GNUmakefile.am:-270 > -DerivedSources/WebCore/UserAgentScripts.h: PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR) How could this work? :) Perhaps build-webkit somehow sets the PYTHONPATH, I suppose you don't use it, ChangSeok? 981372 9 calvaris 2014-02-17 03:04:49 -0800 (In reply to comment #8) > (From update of attachment 224180 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=224180&action=review > > > Source/WebCore/GNUmakefile.am:-270 > > -DerivedSources/WebCore/UserAgentScripts.h: PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR) > > How could this work? :) Perhaps build-webkit somehow sets the PYTHONPATH, I suppose you don't use it, ChangSeok? I read it here: http://stackoverflow.com/questions/15229833/set-environment-variable-inside-target and it worked for me and for the bots, it seems. 981421 10 pnormand 2014-02-17 05:58:48 -0800 (In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 224180 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=224180&action=review > > > > > Source/WebCore/GNUmakefile.am:-270 > > > -DerivedSources/WebCore/UserAgentScripts.h: PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR) > > > > How could this work? :) Perhaps build-webkit somehow sets the PYTHONPATH, I suppose you don't use it, ChangSeok? > > I read it here: http://stackoverflow.com/questions/15229833/set-environment-variable-inside-target and it worked for me and for the bots, it seems. Ah ok I didn't know about that trick... Perhaps the GNU make version ChangSeok uses has an issue with that syntax? Anyway, the patch looks harmless to me. 981423 11 berto 2014-02-17 06:13:26 -0800 Not quite related to this, but it would also be awesome to replace jsmin with a more recent version: https://bugs.webkit.org/show_bug.cgi?id=123665 981456 12 changseok 2014-02-17 08:09:33 -0800 (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > (From update of attachment 224180 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=224180&action=review > > > > > > > Source/WebCore/GNUmakefile.am:-270 > > > > -DerivedSources/WebCore/UserAgentScripts.h: PYTHONPATH=$(INSPECTOR_SCRIPTS_DIR) > > > > > > How could this work? :) Perhaps build-webkit somehow sets the PYTHONPATH, I suppose you don't use it, ChangSeok? > > > > I read it here: http://stackoverflow.com/questions/15229833/set-environment-variable-inside-target and it worked for me and for the bots, it seems. > > Ah ok I didn't know about that trick... Perhaps the GNU make version ChangSeok uses has an issue with that syntax? Anyway, the patch looks harmless to me. Yes. you guys are right. The system GNU make I used was 3.81 which is a little old, so that the grammar Xabier wrote was unrecognizable(even though it was correct!). If we build through build-webkit script. the script set Dependencies/Root/bin to the PATH env variable. So actually make used is the one in Dependencies/Root/bin, the version 3.82. That's why gtk bots doesn't complain. :P I like a tolerant approach, But I will not commit this if somebody feels this change unnecessary. :) 981464 13 calvaris 2014-02-17 08:14:23 -0800 (In reply to comment #12) > Yes. you guys are right. The system GNU make I used was 3.81 which is a little old, so that the grammar Xabier wrote was unrecognizable(even though it was correct!). If we build through build-webkit script. the script set Dependencies/Root/bin to the PATH env variable. So actually make used is the one in Dependencies/Root/bin, the version 3.82. That's why gtk bots doesn't complain. :P > I like a tolerant approach, But I will not commit this if somebody feels this change unnecessary. :) I don't mind changing it as long as it works. 981551 14 224180 changseok 2014-02-17 11:11:50 -0800 Comment on attachment 224180 Patch I checked this hurt nothing for make 3.81 & 3.82. Thanks for the r+! 981584 15 224180 commit-queue 2014-02-17 11:43:19 -0800 Comment on attachment 224180 Patch Clearing flags on attachment: 224180 Committed r164239: <http://trac.webkit.org/changeset/164239> 981585 16 commit-queue 2014-02-17 11:43:22 -0800 All reviewed patches have been landed. Closing bug. 224067 2014-02-13 06:59:42 -0800 2014-02-14 01:46:44 -0800 Patch bug-128742-20140213235941.patch text/plain 1845 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTMyYWRjZmY2Njk3OTNk NmYxMzRlYmQ1Y2JhNTQyODg4M2I0OTZkYS4uNzM2MTM3OTAzZTM4MjZkNDRhN2JjNDIzNjAzZjAx ZDUyOGQyNTc5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE0LTAyLTEzICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KIAorICAgICAgICBbR1RLXSBC dWlsZCBmYWlsdXJlIGNhdXNlZCBieSBtaXNzaW5nIGpzbWluIG1vZHVsZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NzQyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIG5v IGZ1bmN0aW9uYWxpdHkgY2hhbmdlZC4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOiBBZGQg anNtaW4gbW9kdWxlIHRvIGdlbmVyYXRlIFVzZXJBZ2VudFNjcmlwdHMuaAorCisyMDE0LTAyLTEz ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKwogICAgICAgICBT dXBwb3J0IEFOR0xFX2luc3RhbmNlZF9hcnJheXMgZm9yIEdMRVMgYmFja2VuZC4KICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODU3OQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbSBiL1NvdXJjZS9XZWJDb3JlL0dOVW1h a2VmaWxlLmFtCmluZGV4IDRjMzcxZmE0Y2UwZTBhODIxNGFmOGRiYzZhY2ZjZGZlYjA1YzVjNmUu LjkxYThiYzhhMTVmMzdiZDc5NmRlMTIwNmFlZjc0MGM5NDQ1OGEzMjggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtCisrKyBiL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2Vm aWxlLmFtCkBAIC0yNjcsOSArMjY3LDggQEAgRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9DU1NHcmFt bWFyLmNwcDogJChXZWJDb3JlKS9jc3MvQ1NTR3JhbW1hci55LmluCiAKIFVTRVJfQUdFTlRfU0NS SVBUX0ZJTEVTID0gJChXZWJDb3JlKS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9s c0FwcGxlLmpzICQoV2ViQ29yZSkvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNH dGsuanMKIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvVXNlckFnZW50U2NyaXB0c0RhdGEuY3BwOiBE ZXJpdmVkU291cmNlcy9XZWJDb3JlL1VzZXJBZ2VudFNjcmlwdHMuaAotRGVyaXZlZFNvdXJjZXMv V2ViQ29yZS9Vc2VyQWdlbnRTY3JpcHRzLmg6IFBZVEhPTlBBVEg9JChJTlNQRUNUT1JfU0NSSVBU U19ESVIpCiBEZXJpdmVkU291cmNlcy9XZWJDb3JlL1VzZXJBZ2VudFNjcmlwdHMuaDogJChXZWJD b3JlKS9TY3JpcHRzL21ha2UtanMtZmlsZS1hcnJheXMucHkgJChVU0VSX0FHRU5UX1NDUklQVF9G SUxFUykKLQkkKEFNX1ZfR0VOKSQoUFlUSE9OKSAkPCAkQCBEZXJpdmVkU291cmNlcy9XZWJDb3Jl L1VzZXJBZ2VudFNjcmlwdHNEYXRhLmNwcCAkKFVTRVJfQUdFTlRfU0NSSVBUX0ZJTEVTKQorCSQo QU1fVl9HRU4pJChQWVRIT04pICQoSU5TUEVDVE9SX1NDUklQVFNfRElSKS9qc21pbi5weSAkPCAk QCBEZXJpdmVkU291cmNlcy9XZWJDb3JlL1VzZXJBZ2VudFNjcmlwdHNEYXRhLmNwcCAkKFVTRVJf QUdFTlRfU0NSSVBUX0ZJTEVTKQogCiAjIHVzZXIgYWdlbnQgc3R5bGUgc2hlZXRzCiBVU0VSX0FH RU5UX1NUWUxFX1NIRUVUUyA9IFwK 224180 2014-02-14 01:46:48 -0800 2014-02-17 11:43:19 -0800 Patch bug-128742-20140214184647.patch text/plain 1831 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmM1YjM1YTBhNjI1NmNl MmRhMzAzN2Q3ODY0NzFiNWE5MTA1YTZiNi4uYTYzMzgwM2FhMDU5ZGQwNjA2ZTRhZTdlNTgzOTA3 ODQwM2M3ODk4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAyLTE0ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbR1RLXSBC dWlsZCBmYWlsdXJlIGNhdXNlZCBieSBtaXNzaW5nIGpzbWluIG1vZHVsZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NzQyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIG5v IGZ1bmN0aW9uYWxpdHkgY2hhbmdlZC4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOiBSZWxv Y2F0ZSBQWVRIT05QQVRIIHRvIG1ha2UgaXQgbWVhbmluZ2Z1bC4KKwogMjAxNC0wMi0xMyAgQnl1 bmdzZW9uIFNoaW4gIDxzdW4uc2hpbkBsZ2UuY29tPgogCiAgICAgICAgIFtNU0VdIE1vdmUgUHVi bGljVVJMTWFuYWdlciBzaHV0ZG93biBsb2dpYyBzbyBBY3RpdmVET01PYmplY3RzIGFzc29jaWF0 ZWQgd2l0aCBwdWJsaWMgVVJMcyB3b24ndCBsZWFrLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQppbmRleCA0 YzM3MWZhNGNlMGUwYTgyMTRhZjhkYmM2YWNmY2RmZWIwNWM1YzZlLi4zZjQ0NDI0MmJiOGIwZTZj NWE4ZTVlMmY3YTY0ZTE5NzFmMGJlYTY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9HTlVt YWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQpAQCAtMjY3LDkg KzI2Nyw4IEBAIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTR3JhbW1hci5jcHA6ICQoV2ViQ29y ZSkvY3NzL0NTU0dyYW1tYXIueS5pbgogCiBVU0VSX0FHRU5UX1NDUklQVF9GSUxFUyA9ICQoV2Vi Q29yZSkvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcyAkKFdlYkNv cmUpL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzCiBEZXJpdmVkU291 cmNlcy9XZWJDb3JlL1VzZXJBZ2VudFNjcmlwdHNEYXRhLmNwcDogRGVyaXZlZFNvdXJjZXMvV2Vi Q29yZS9Vc2VyQWdlbnRTY3JpcHRzLmgKLURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvVXNlckFnZW50 U2NyaXB0cy5oOiBQWVRIT05QQVRIPSQoSU5TUEVDVE9SX1NDUklQVFNfRElSKQogRGVyaXZlZFNv dXJjZXMvV2ViQ29yZS9Vc2VyQWdlbnRTY3JpcHRzLmg6ICQoV2ViQ29yZSkvU2NyaXB0cy9tYWtl LWpzLWZpbGUtYXJyYXlzLnB5ICQoVVNFUl9BR0VOVF9TQ1JJUFRfRklMRVMpCi0JJChBTV9WX0dF TikkKFBZVEhPTikgJDwgJEAgRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9Vc2VyQWdlbnRTY3JpcHRz RGF0YS5jcHAgJChVU0VSX0FHRU5UX1NDUklQVF9GSUxFUykKKwkkKEFNX1ZfR0VOKSBQWVRIT05Q QVRIPSQoSU5TUEVDVE9SX1NDUklQVFNfRElSKSAkKFBZVEhPTikgJDwgJEAgRGVyaXZlZFNvdXJj ZXMvV2ViQ29yZS9Vc2VyQWdlbnRTY3JpcHRzRGF0YS5jcHAgJChVU0VSX0FHRU5UX1NDUklQVF9G SUxFUykKIAogIyB1c2VyIGFnZW50IHN0eWxlIHNoZWV0cwogVVNFUl9BR0VOVF9TVFlMRV9TSEVF VFMgPSBcCg==