128729 2014-02-13 01:44:51 -0800 Code cleanup: remove gcc<4.7 guards. 2014-02-13 09:55:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tgergely.u-szeged webkit-unassigned barraclough benjamin cmarcelo commit-queue dbates oliver zherczeg oldest_to_newest 980190 0 tgergely.u-szeged 2014-02-13 01:44:51 -0800 Remove GCC_VERSION_AT_LEAST guards (and guarded code if possible) when it checks for pre-4.7 versions. According to bug 127049, 4.7 is the minimum supported gcc version. 980191 1 224053 tgergely.u-szeged 2014-02-13 02:16:54 -0800 Created attachment 224053 patch clang is also seen as gcc. I think it causes no problem in these situations. 980337 2 224053 commit-queue 2014-02-13 09:55:41 -0800 Comment on attachment 224053 patch Clearing flags on attachment: 224053 Committed r164032: <http://trac.webkit.org/changeset/164032> 980338 3 commit-queue 2014-02-13 09:55:43 -0800 All reviewed patches have been landed. Closing bug. 224053 2014-02-13 02:16:54 -0800 2014-02-13 09:55:41 -0800 patch code_cleanup_gcc_at_least_4_7.patch text/plain 5736 tgergely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGMzOTg1MzYuLmMyZWNjYjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAyLTEzICBUYW1hcyBHZXJnZWx5 ICA8dGdlcmdlbHkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAgICAgICBDb2Rl IGNsZWFudXA6IHJlbW92ZSBnY2M8NC43IGd1YXJkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODcyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBHQ0NfVkVSU0lPTl9BVF9MRUFTVCBndWFy ZHMgd2hlbiBpdCBjaGVja3MgZm9yIHByZS00LjcgdmVyc2lvbnMsCisgICAgICAgIGFzIFdLIGRv ZXMgbm90IGNvbXBpbGUgd2l0aCBlYXJsaWVyIGdjYyB2ZXJzaW9ucy4KKworICAgICAgICAqIGFz c2VtYmxlci9NSVBTQXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6Ok1JUFNBc3NlbWJsZXI6OmNh Y2hlRmx1c2gpOgorICAgICAgICAqIGludGVycHJldGVyL1N0YWNrVmlzaXRvci5jcHA6CisgICAg ICAgIChKU0M6OnByaW50aWYpOgorCiAyMDE0LTAyLTEyICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBObyBuZWVkIHRvIHNhdmUgcmVzZXJ2ZWRab25lU2l6ZSB3aGVu IGRyb3BwaW5nIHRoZSBKU0xvY2suCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTUlQU0Fzc2VtYmxlci5oCmluZGV4IGI3NWI0ZDAuLmNhYWQxNTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCkBAIC04NzAsMjggKzg3 MCw4IEBAIHB1YmxpYzoKIAogICAgIHN0YXRpYyB2b2lkIGNhY2hlRmx1c2godm9pZCogY29kZSwg c2l6ZV90IHNpemUpCiAgICAgewotI2lmIEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDMsIDApCi0j aWYgV1RGX01JUFNfSVNBX1JFVigyKSAmJiAhR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgNCwgMykK LSAgICAgICAgaW50IGxpbmVTaXplOwotICAgICAgICBhc20oInJkaHdyICUwLCAkMSIgOiAiPXIi IChsaW5lU2l6ZSkpOwotICAgICAgICAvLwotICAgICAgICAvLyBNb2RpZnkgInN0YXJ0IiBhbmQg ImVuZCIgdG8gYXZvaWQgR0NDIDQuMy4wLTQuNC4yIGJ1ZyBpbgotICAgICAgICAvLyBtaXBzX2V4 cGFuZF9zeW5jaV9sb29wIHRoYXQgbWF5IGV4ZWN1dGUgc3luY2kgb25lIG1vcmUgdGltZS4KLSAg ICAgICAgLy8gInN0YXJ0IiBwb2ludHMgdG8gdGhlIGZpc3J0IGJ5dGUgb2YgdGhlIGNhY2hlIGxp bmUuCi0gICAgICAgIC8vICJlbmQiIHBvaW50cyB0byB0aGUgbGFzdCBieXRlIG9mIHRoZSBsaW5l IGJlZm9yZSB0aGUgbGFzdCBjYWNoZSBsaW5lLgotICAgICAgICAvLyBCZWNhdXNlIHNpemUgaXMg YWx3YXlzIGEgbXVsdGlwbGUgb2YgNCwgdGhpcyBpcyBzYWZlIHRvIHNldAotICAgICAgICAvLyAi ZW5kIiB0byB0aGUgbGFzdCBieXRlLgotICAgICAgICAvLwotICAgICAgICBpbnRwdHJfdCBzdGFy dCA9IHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KGNvZGUpICYgKC1saW5lU2l6ZSk7Ci0gICAg ICAgIGludHB0cl90IGVuZCA9ICgocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oY29kZSkgKyBz aXplIC0gMSkgJiAoLWxpbmVTaXplKSkgLSAxOwotICAgICAgICBfX2J1aWx0aW5fX19jbGVhcl9j YWNoZShyZWludGVycHJldF9jYXN0PGNoYXIqPihzdGFydCksIHJlaW50ZXJwcmV0X2Nhc3Q8Y2hh cio+KGVuZCkpOwotI2Vsc2UKICAgICAgICAgaW50cHRyX3QgZW5kID0gcmVpbnRlcnByZXRfY2Fz dDxpbnRwdHJfdD4oY29kZSkgKyBzaXplOwogICAgICAgICBfX2J1aWx0aW5fX19jbGVhcl9jYWNo ZShyZWludGVycHJldF9jYXN0PGNoYXIqPihjb2RlKSwgcmVpbnRlcnByZXRfY2FzdDxjaGFyKj4o ZW5kKSk7Ci0jZW5kaWYKLSNlbHNlCi0gICAgICAgIF9mbHVzaF9jYWNoZShyZWludGVycHJldF9j YXN0PGNoYXIqPihjb2RlKSwgc2l6ZSwgQkNBQ0hFKTsKLSNlbmRpZgogICAgIH0KIAogICAgIHN0 YXRpYyBwdHJkaWZmX3QgbWF4SnVtcFJlcGxhY2VtZW50U2l6ZSgpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvU3RhY2tWaXNpdG9yLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9TdGFja1Zpc2l0b3IuY3BwCmluZGV4IDA2YjE1YTEu LmRjMWQ4MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9T dGFja1Zpc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9T dGFja1Zpc2l0b3IuY3BwCkBAIC0zNDcsNyArMzQ3LDcgQEAgc3RhdGljIHZvaWQgcHJpbnRpZihp bnQgaW5kZW50TGV2ZWxzLCBjb25zdCBjaGFyKiBmb3JtYXQsIC4uLikKICAgICBpZiAoaW5kZW50 TGV2ZWxzKQogICAgICAgICBwcmludEluZGVudHMoaW5kZW50TGV2ZWxzKTsKIAotI2lmIENPTVBJ TEVSKENMQU5HKSB8fCAoQ09NUElMRVIoR0NDKSAmJiBHQ0NfVkVSU0lPTl9BVF9MRUFTVCg0LCA2 LCAwKSkKKyNpZiBDT01QSUxFUihDTEFORykgfHwgQ09NUElMRVIoR0NDKQogI3ByYWdtYSBHQ0Mg ZGlhZ25vc3RpYyBwdXNoCiAjcHJhZ21hIEdDQyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XZm9ybWF0 LW5vbmxpdGVyYWwiCiAjcHJhZ21hIEdDQyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XbWlzc2luZy1m b3JtYXQtYXR0cmlidXRlIgpAQCAtMzU1LDcgKzM1NSw3IEBAIHN0YXRpYyB2b2lkIHByaW50aWYo aW50IGluZGVudExldmVscywgY29uc3QgY2hhciogZm9ybWF0LCAuLi4pCiAKICAgICBXVEY6OmRh dGFMb2dGVihmb3JtYXQsIGFyZ0xpc3QpOwogCi0jaWYgQ09NUElMRVIoQ0xBTkcpIHx8IChDT01Q SUxFUihHQ0MpICYmIEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDYsIDApKQorI2lmIENPTVBJTEVS KENMQU5HKSB8fCBDT01QSUxFUihHQ0MpCiAjcHJhZ21hIEdDQyBkaWFnbm9zdGljIHBvcAogI2Vu ZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFu Z2VMb2cKaW5kZXggMDRiNDU0Mi4uNWIwOTNiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNC0w Mi0xMyAgVGFtYXMgR2VyZ2VseSAgPHRnZXJnZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5j b20+CisKKyAgICAgICAgQ29kZSBjbGVhbnVwOiByZW1vdmUgZ2NjPDQuNyBndWFyZHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg3MjkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgR0NDX1ZF UlNJT05fQVRfTEVBU1QgZ3VhcmRzIHdoZW4gaXQgY2hlY2tzIGZvciBwcmUtNC43IHZlcnNpb25z LAorICAgICAgICBhcyBXSyBkb2VzIG5vdCBjb21waWxlIHdpdGggZWFybGllciBnY2MgdmVyc2lv bnMuCisKKyAgICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5jcHA6CisgICAgICAgICogd3RmL1BsYXRm b3JtLmg6CisKIDIwMTQtMDItMTIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIE5vIG5lZWQgdG8gc2F2ZSByZXNlcnZlZFpvbmVTaXplIHdoZW4gZHJvcHBpbmcgdGhl IEpTTG9jay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwIGIvU291 cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKaW5kZXggYTM3MDMwMi4uNDczNGFhNSAxMDA2NDQK LS0tIGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKKysrIGIvU291cmNlL1dURi93dGYv QXNzZXJ0aW9ucy5jcHAKQEAgLTE0OCw3ICsxNDgsNyBAQCBzdGF0aWMgdm9pZCB2cHJpbnRmX3N0 ZGVycl9jb21tb24oY29uc3QgY2hhciogZm9ybWF0LCB2YV9saXN0IGFyZ3MpCiAgICAgdmZwcmlu dGYoc3RkZXJyLCBmb3JtYXQsIGFyZ3MpOwogfQogCi0jaWYgQ09NUElMRVIoQ0xBTkcpIHx8IChD T01QSUxFUihHQ0MpICYmIEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDYsIDApKQorI2lmIENPTVBJ TEVSKENMQU5HKSB8fCBDT01QSUxFUihHQ0MpCiAjcHJhZ21hIEdDQyBkaWFnbm9zdGljIHB1c2gK ICNwcmFnbWEgR0NDIGRpYWdub3N0aWMgaWdub3JlZCAiLVdmb3JtYXQtbm9ubGl0ZXJhbCIKICNl bmRpZgpAQCAtMTgxLDcgKzE4MSw3IEBAIHN0YXRpYyB2b2lkIHZwcmludGZfc3RkZXJyX3dpdGhf dHJhaWxpbmdfbmV3bGluZShjb25zdCBjaGFyKiBmb3JtYXQsIHZhX2xpc3QgYXJnCiAgICAgdnBy aW50Zl9zdGRlcnJfY29tbW9uKGZvcm1hdFdpdGhOZXdsaW5lLmdldCgpLCBhcmdzKTsKIH0KIAot I2lmIENPTVBJTEVSKENMQU5HKSB8fCAoQ09NUElMRVIoR0NDKSAmJiBHQ0NfVkVSU0lPTl9BVF9M RUFTVCg0LCA2LCAwKSkKKyNpZiBDT01QSUxFUihDTEFORykgfHwgQ09NUElMRVIoR0NDKQogI3By YWdtYSBHQ0MgZGlhZ25vc3RpYyBwb3AKICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCA2MDI1MGU3 Li42OWI0ZWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTI5OCw3ICsyOTgsNyBAQAogI2RlZmluZSBXVEZf Q1BVX0FSTV9ORU9OIDEKICNlbmRpZgogCi0jaWYgQ1BVKEFSTV9ORU9OKSAmJiAoIUNPTVBJTEVS KEdDQykgfHwgR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgNywgMCkpCisjaWYgQ1BVKEFSTV9ORU9O KQogLy8gQWxsIE5FT04gaW50cmluc2ljcyB1c2FnZSBjYW4gYmUgZGlzYWJsZWQgYnkgdGhpcyBt YWNyby4KICNkZWZpbmUgSEFWRV9BUk1fTkVPTl9JTlRSSU5TSUNTIDEKICNlbmRpZgpAQCAtNjQy LDE1ICs2NDIsOSBAQAogI2RlZmluZSBFTkFCTEVfRlRMX0pJVCAwCiAjZW5kaWYKIAotLyogRGlz YWJsZSB0aGUgSklUIG9uIHZlcnNpb25zIG9mIEdDQyBwcmlvciB0byA0LjEgKi8KLSNpZiAhZGVm aW5lZChFTkFCTEVfSklUKSAmJiBDT01QSUxFUihHQ0MpICYmICFHQ0NfVkVSU0lPTl9BVF9MRUFT VCg0LCAxLCAwKQotI2RlZmluZSBFTkFCTEVfSklUIDAKLSNlbmRpZgotCiAvKiBUaGUgSklUIGlz IGVuYWJsZWQgYnkgZGVmYXVsdCBvbiBhbGwgeDg2LCB4ODYtNjQsIEFSTSAmIE1JUFMgcGxhdGZv cm1zIGV4Y2VwdCBXaW5kb3dzLiAqLwogI2lmICFkZWZpbmVkKEVOQUJMRV9KSVQpIFwKICAgICAm JiAoQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkgfHwgQ1BVKEFSTSkgfHwgQ1BVKEFSTTY0KSB8fCBD UFUoTUlQUykpIFwKLSAgICAmJiAoT1MoREFSV0lOKSB8fCAhQ09NUElMRVIoR0NDKSB8fCBHQ0Nf VkVSU0lPTl9BVF9MRUFTVCg0LCAxLCAwKSkgXAogICAgICYmICFPUyhXSU5DRSkgXAogICAgICYm ICFPUyhXSU5ET1dTKQogI2RlZmluZSBFTkFCTEVfSklUIDEK