128727 2014-02-12 22:55:54 -0800 CC and PKG_CONFIG should be quoted 2014-03-25 15:34:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Other RESOLVED INVALID P2 Normal --- 1 lantw44 webkit-unassigned berto commit-queue gustavo mrobinson zan oldest_to_newest 980176 0 lantw44 2014-02-12 22:55:54 -0800 In Tools/gtk/GNUmakefile.am, line 45: CC=$(CC) $(srcdir)/Tools/gtk/generate-gtkdoc This does not work if CC contains spaces. When I set CC to "clang -std=c11 -pedantic", I get the following error: CC=clang -std=c11 -pedantic ./Tools/gtk/generate-gtkdoc -std=c11: not found gmake[1]: *** [docs-build.stamp] Error 127 gmake[1]: *** Waiting for unfinished jobs.... We should change it to CC="$(CC)" so it will work even if CC contains spaces. 980273 1 224059 lantw44 2014-02-13 05:36:44 -0800 Created attachment 224059 [GTK] Quote the CC and PKG_CONFIG variable 981269 2 224317 lantw44 2014-02-16 02:39:14 -0800 Created attachment 224317 [GTK] Quote the CC and PKG_CONFIG variable (updated) 981270 3 commit-queue 2014-02-16 02:41:06 -0800 Attachment 224317 did not pass style-queue: ERROR: Tools/ChangeLog:319: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 981271 4 zan 2014-02-16 02:41:22 -0800 Compiler flags should be placed into CFLAGS and CXXFLAGS environment variables. 981273 5 224318 lantw44 2014-02-16 02:45:49 -0800 Created attachment 224318 [GTK] Quote the CC and PKG_CONFIG variable (updated again) 981274 6 berto 2014-02-16 05:12:31 -0800 (In reply to comment #5) > Created an attachment (id=224318) [details] > [GTK] Quote the CC and PKG_CONFIG variable (updated again) In what case does an unquoted PKG_CONFIG break? 981275 7 lantw44 2014-02-16 07:09:13 -0800 (In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=224318) [details] [details] > > [GTK] Quote the CC and PKG_CONFIG variable (updated again) > > In what case does an unquoted PKG_CONFIG break? It may not break. I found it when I found the unquoted CC, so I patched both CC and PKG_CONFIG. 981297 8 berto 2014-02-16 14:40:01 -0800 (In reply to comment #7) > > In what case does an unquoted PKG_CONFIG break? > It may not break. I found it when I found the unquoted CC, so I > patched both CC and PKG_CONFIG. Well, the Makefile is full of unquoted variables (e.g. PYTHON in that very same line) :) Quoting PKG_CONFIG doesn't harm, but it probably doesn't fix anything either. I'd bet that if there was a case where PKG_CONFIG needed to be quoted something else would break. Anyway, quoting CC is fine. Altough, as Žan says, compiler flags shouldn't generally go there, setting CC to "icecc gcc", "ccache gcc" and friends is common practice. 984421 9 224318 gustavo 2014-02-25 12:07:33 -0800 Comment on attachment 224318 [GTK] Quote the CC and PKG_CONFIG variable (updated again) I agree there's no point in changing PKG_CONFIG unless we're fixing an actual issue. 984423 10 224318 gustavo 2014-02-25 12:08:04 -0800 Comment on attachment 224318 [GTK] Quote the CC and PKG_CONFIG variable (updated again) View in context: https://bugs.webkit.org/attachment.cgi?id=224318&action=review > Tools/ChangeLog:319 > * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webCryptoMasterKeyForWebView:]): > Use the SPI to specify a key. > > +2014-02-13 Ting-Wei Lan <lantw44@gmail.com> This looks like it could break, btw, you want your ChangeLog entry at the top. 985490 11 225444 lantw44 2014-02-28 00:34:50 -0800 Created attachment 225444 [GTK] Quote the CC variable 985495 12 berto 2014-02-28 00:47:16 -0800 (In reply to comment #11) > Created an attachment (id=225444) [details] > [GTK] Quote the CC variable lgtm 994401 13 mrobinson 2014-03-25 15:34:54 -0700 Autotools build is gone now. Feel free to reopen if this is an issue with the CMake build. 224059 2014-02-13 05:36:44 -0800 2014-02-16 02:39:14 -0800 [GTK] Quote the CC and PKG_CONFIG variable webkit-quote-bugreport.patch text/plain 1306 lantw44 SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDAy OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAy LTEzICBUaW5nLVdlaSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4KKworICAgICAgICBbR1RLXSBR dW90ZSB0aGUgQ0MgYW5kIFBLR19DT05GSUcgdmFyaWFibGUKKyAgICAgICAgaHR0cHM6Ly9idWd6 aWxsYS5nbm9tZS5vcmcvc2hvd19idWcuY2dpP2lkPTcyNDI3NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3RrL0dOVW1ha2VmaWxlLmFtOgorCiAy MDE0LTAyLTEzICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQuIE1vdmVkIG15c2VsZiB0byB0aGUgbGlzdCBvZiByZXZpZXdlcnMu CkluZGV4OiBndGsvR05VbWFrZWZpbGUuYW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZ3RrL0dOVW1ha2VmaWxl LmFtCShyZXZpc2lvbiAxNjQwMTEpCisrKyBndGsvR05VbWFrZWZpbGUuYW0JKHdvcmtpbmcgY29w eSkKQEAgLTQ1LDcgKzQ1LDcgQEAKIAkkKHRvcF9idWlsZGRpcikvRGVyaXZlZFNvdXJjZXMvd2Vi a2l0ZG9tL2RvY3Mvd2Via2l0ZG9tZ3RrLXNlY3Rpb25zLnR4dAogCiBkb2NzLWJ1aWxkLnN0YW1w OiAkKGRvY3NfYnVpbGRfc3RhbXBfbGlzdCkKLQlDQz0kKENDKSAkKHNyY2RpcikvVG9vbHMvZ3Rr L2dlbmVyYXRlLWd0a2RvYworCUNDPSIkKENDKSIgJChzcmNkaXIpL1Rvb2xzL2d0ay9nZW5lcmF0 ZS1ndGtkb2MKIAlAdG91Y2ggZG9jcy1idWlsZC5zdGFtcAogCiBjbGVhbi1sb2NhbDogZG9jLWNs ZWFuLWxvY2FsCkBAIC0xMjgsNyArMTI4LDcgQEAKIAkgIGZpOyBcCiAJZmkKIGlmIEVOQUJMRV9H VEtfRE9DCi0JQCQoQU1fVl9HRU4pIFBLR19DT05GSUc9JChQS0dfQ09ORklHKSAkKFBZVEhPTikg JChzcmNkaXIpL1Rvb2xzL2d0ay9nZW5lcmF0ZS1ndGtkb2MgLS1yZWJhc2UgLS12aXJ0dWFsLXJv b3Q9JCR7REVTVERJUn0KKwlAJChBTV9WX0dFTikgUEtHX0NPTkZJRz0iJChQS0dfQ09ORklHKSIg JChQWVRIT04pICQoc3JjZGlyKS9Ub29scy9ndGsvZ2VuZXJhdGUtZ3RrZG9jIC0tcmViYXNlIC0t dmlydHVhbC1yb290PSQke0RFU1RESVJ9CiBlbmRpZgogCiB1bmluc3RhbGwtbG9jYWw6Cg== 224317 2014-02-16 02:39:14 -0800 2014-02-16 02:45:49 -0800 [GTK] Quote the CC and PKG_CONFIG variable (updated) webkit-quote-bugreport.patch text/plain 1512 lantw44 SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NDE5MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMzE2 LDYgKzMxNiwxNSBAQAogICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9VSURlbGVnYXRlLm1t OiAoLVtVSURlbGVnYXRlIHdlYkNyeXB0b01hc3RlcktleUZvcldlYlZpZXc6XSk6CiAgICAgICAg IFVzZSB0aGUgU1BJIHRvIHNwZWNpZnkgYSBrZXkuCiAKKzIwMTQtMDItMTMgIFRpbmctV2VpIExh biAgPGxhbnR3NDRAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIFF1b3RlIHRoZSBDQyBhbmQg UEtHX0NPTkZJRyB2YXJpYWJsZQorICAgICAgICBodHRwczovL2J1Z3ppbGxhLmdub21lLm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzI0Mjc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBndGsvR05VbWFrZWZpbGUuYW06CisKIDIwMTQtMDItMTMgIFNlcmdp byBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZC4gTW92ZWQgbXlzZWxmIHRvIHRoZSBsaXN0IG9mIHJldmlld2Vycy4KSW5kZXg6IFRvb2xzL2d0 ay9HTlVtYWtlZmlsZS5hbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9ndGsvR05VbWFrZWZpbGUuYW0J KHJldmlzaW9uIDE2NDE5MCkKKysrIFRvb2xzL2d0ay9HTlVtYWtlZmlsZS5hbQkod29ya2luZyBj b3B5KQpAQCAtNDUsNyArNDUsNyBAQCBkb2NzX2J1aWxkX3N0YW1wX2xpc3QgKz0gXAogCSQodG9w X2J1aWxkZGlyKS9EZXJpdmVkU291cmNlcy93ZWJraXRkb20vZG9jcy93ZWJraXRkb21ndGstc2Vj dGlvbnMudHh0CiAKIGRvY3MtYnVpbGQuc3RhbXA6ICQoZG9jc19idWlsZF9zdGFtcF9saXN0KQot CUNDPSQoQ0MpICQoc3JjZGlyKS9Ub29scy9ndGsvZ2VuZXJhdGUtZ3RrZG9jCisJQ0M9IiQoQ0Mp IiAkKHNyY2RpcikvVG9vbHMvZ3RrL2dlbmVyYXRlLWd0a2RvYwogCUB0b3VjaCBkb2NzLWJ1aWxk LnN0YW1wCiAKIGNsZWFuLWxvY2FsOiBkb2MtY2xlYW4tbG9jYWwKQEAgLTEyOCw3ICsxMjgsNyBA QCBlbmRpZgogCSAgZmk7IFwKIAlmaQogaWYgRU5BQkxFX0dUS19ET0MKLQlAJChBTV9WX0dFTikg UEtHX0NPTkZJRz0kKFBLR19DT05GSUcpICQoUFlUSE9OKSAkKHNyY2RpcikvVG9vbHMvZ3RrL2dl bmVyYXRlLWd0a2RvYyAtLXJlYmFzZSAtLXZpcnR1YWwtcm9vdD0kJHtERVNURElSfQorCUAkKEFN X1ZfR0VOKSBQS0dfQ09ORklHPSIkKFBLR19DT05GSUcpIiAkKFBZVEhPTikgJChzcmNkaXIpL1Rv b2xzL2d0ay9nZW5lcmF0ZS1ndGtkb2MgLS1yZWJhc2UgLS12aXJ0dWFsLXJvb3Q9JCR7REVTVERJ Un0KIGVuZGlmCiAKIHVuaW5zdGFsbC1sb2NhbDoK 224318 2014-02-16 02:45:49 -0800 2014-02-28 00:34:50 -0800 [GTK] Quote the CC and PKG_CONFIG variable (updated again) webkit-quote-bugreport.patch text/plain 1509 lantw44 SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NDE5MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMzE2 LDYgKzMxNiwxNSBAQAogICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9VSURlbGVnYXRlLm1t OiAoLVtVSURlbGVnYXRlIHdlYkNyeXB0b01hc3RlcktleUZvcldlYlZpZXc6XSk6CiAgICAgICAg IFVzZSB0aGUgU1BJIHRvIHNwZWNpZnkgYSBrZXkuCiAKKzIwMTQtMDItMTMgIFRpbmctV2VpIExh biAgPGxhbnR3NDRAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIFF1b3RlIHRoZSBDQyBhbmQg UEtHX0NPTkZJRyB2YXJpYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI4NzI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBndGsvR05VbWFrZWZpbGUuYW06CisKIDIwMTQtMDItMTMgIFNlcmdpbyBW aWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4g TW92ZWQgbXlzZWxmIHRvIHRoZSBsaXN0IG9mIHJldmlld2Vycy4KSW5kZXg6IFRvb2xzL2d0ay9H TlVtYWtlZmlsZS5hbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9ndGsvR05VbWFrZWZpbGUuYW0JKHJl dmlzaW9uIDE2NDE5MCkKKysrIFRvb2xzL2d0ay9HTlVtYWtlZmlsZS5hbQkod29ya2luZyBjb3B5 KQpAQCAtNDUsNyArNDUsNyBAQCBkb2NzX2J1aWxkX3N0YW1wX2xpc3QgKz0gXAogCSQodG9wX2J1 aWxkZGlyKS9EZXJpdmVkU291cmNlcy93ZWJraXRkb20vZG9jcy93ZWJraXRkb21ndGstc2VjdGlv bnMudHh0CiAKIGRvY3MtYnVpbGQuc3RhbXA6ICQoZG9jc19idWlsZF9zdGFtcF9saXN0KQotCUND PSQoQ0MpICQoc3JjZGlyKS9Ub29scy9ndGsvZ2VuZXJhdGUtZ3RrZG9jCisJQ0M9IiQoQ0MpIiAk KHNyY2RpcikvVG9vbHMvZ3RrL2dlbmVyYXRlLWd0a2RvYwogCUB0b3VjaCBkb2NzLWJ1aWxkLnN0 YW1wCiAKIGNsZWFuLWxvY2FsOiBkb2MtY2xlYW4tbG9jYWwKQEAgLTEyOCw3ICsxMjgsNyBAQCBl bmRpZgogCSAgZmk7IFwKIAlmaQogaWYgRU5BQkxFX0dUS19ET0MKLQlAJChBTV9WX0dFTikgUEtH X0NPTkZJRz0kKFBLR19DT05GSUcpICQoUFlUSE9OKSAkKHNyY2RpcikvVG9vbHMvZ3RrL2dlbmVy YXRlLWd0a2RvYyAtLXJlYmFzZSAtLXZpcnR1YWwtcm9vdD0kJHtERVNURElSfQorCUAkKEFNX1Zf R0VOKSBQS0dfQ09ORklHPSIkKFBLR19DT05GSUcpIiAkKFBZVEhPTikgJChzcmNkaXIpL1Rvb2xz L2d0ay9nZW5lcmF0ZS1ndGtkb2MgLS1yZWJhc2UgLS12aXJ0dWFsLXJvb3Q9JCR7REVTVERJUn0K IGVuZGlmCiAKIHVuaW5zdGFsbC1sb2NhbDoK 225444 2014-02-28 00:34:50 -0800 2014-02-28 00:34:50 -0800 [GTK] Quote the CC variable webkit-quote-bugreport-nopkgconfig.patch text/plain 989 lantw44 SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2NDg1NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE0LTAyLTI3ICBUaW5nLVdlaSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4K KworICAgICAgICBbR1RLXSBRdW90ZSB0aGUgQ0MgdmFyaWFibGUuIAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NzI3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBndGsvR05VbWFrZWZpbGUuYW06CisK IDIwMTQtMDItMjcgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogbW9kZWwgdGVzdHMgc2hvdWxkIHVzZSBhIHNwZWNpYWwgVGVzdC5odG1sIGlu c3BlY3RvciBwYWdlCkluZGV4OiBUb29scy9ndGsvR05VbWFrZWZpbGUuYW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvZ3RrL0dOVW1ha2VmaWxlLmFtCShyZXZpc2lvbiAxNjQ4NTUpCisrKyBUb29scy9n dGsvR05VbWFrZWZpbGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTQ4LDcgKzQ4LDcgQEAgZG9jc19i dWlsZF9kZXBlbmRlbmNpZXMgKz0gXAogCWd0a2RvYy13ZWJraXRkb20uY2ZnCiAKIGRvY3MtYnVp bGQuc3RhbXA6ICQoZG9jc19idWlsZF9kZXBlbmRlbmNpZXMpCi0JQ0M9JChDQykgJChzcmNkaXIp L1Rvb2xzL2d0ay9nZW5lcmF0ZS1ndGtkb2MKKwlDQz0iJChDQykiICQoc3JjZGlyKS9Ub29scy9n dGsvZ2VuZXJhdGUtZ3RrZG9jCiAJQHRvdWNoIGRvY3MtYnVpbGQuc3RhbXAKIAogY2xlYW4tbG9j YWw6IGRvYy1jbGVhbi1sb2NhbAo=