128714 2014-02-12 18:12:01 -0800 Pass the related page in the WebPageConfiguration struct 2014-02-12 20:38:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 980119 0 andersca 2014-02-12 18:12:01 -0800 Pass the related page in the WebPageConfiguration struct 980120 1 224038 andersca 2014-02-12 18:12:15 -0800 Created attachment 224038 Patch 980143 2 224038 darin 2014-02-12 19:41:07 -0800 Comment on attachment 224038 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224038&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:134 > WebKit::WebPageConfiguration webPageConfiguration; > webPageConfiguration.preferences = [_configuration preferences]->_preferences.get(); > Need to remove these lines of code to make this compile on Mac. 980156 3 andersca 2014-02-12 20:38:26 -0800 Committed r164010: <http://trac.webkit.org/changeset/164010> 224038 2014-02-12 18:12:15 -0800 2014-02-12 19:41:07 -0800 Patch bug-128714-20140212181214.patch text/plain 5160 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDg1YTZiOWRiOTE1ZmEx ODg0ODVkZGRjMDU4ODY1ZDc4OWUzNTllOS4uOTE4NWEzN2QzZTU0MWU4MWRlM2I4OTYwZTUxOTRm NWZkYTcwNjkzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTAyLTEyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUGFzcyB0aGUgcmVs YXRlZCBwYWdlIGluIHRoZSBXZWJQYWdlQ29uZmlndXJhdGlvbiBzdHJ1Y3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODcxNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBpbml0V2l0aEZyYW1lOmNvbmZp Z3VyYXRpb246XSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9pb3MvV0tDb250ZW50Vmlldy5o OgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvaW9zL1dLQ29udGVudFZpZXcubW06CisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgaW5pdFdpdGhGcmFtZTpjb250ZXh0OldlYktpdDo6Y29uZmlndXJh dGlvbjpXZWJLaXQ6Ol0pOgorCisyMDE0LTAyLTEyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIHJlbGF0ZWRXZWJWaWV3IHByb3BlcnR5IHRvIFdL V2ViVmlld0NvbmZpZ3VyYXRpb24KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyODcwNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IGJmZWEzM2RiZmE4YzI4ZGQzMzk2MjZiYWI3ZTMwZjU0 NTk0ZDI0MDEuLjhlMTY0Y2U2ODI2ZGEzN2MyYjYyMzQxZTA2M2QwM2VjNTBkNjFhODggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC0x MDQsNiArMTA0LDEzIEBACiAKICAgICBDR1JlY3QgYm91bmRzID0gc2VsZi5ib3VuZHM7CiAKKyAg ICBXZWJLaXQ6OldlYkNvbnRleHQmIGNvbnRleHQgPSAqW19jb25maWd1cmF0aW9uIHByb2Nlc3ND bGFzc10tPl9jb250ZXh0OworCisgICAgV2ViS2l0OjpXZWJQYWdlQ29uZmlndXJhdGlvbiB3ZWJQ YWdlQ29uZmlndXJhdGlvbjsKKyAgICB3ZWJQYWdlQ29uZmlndXJhdGlvbi5wcmVmZXJlbmNlcyA9 IFtfY29uZmlndXJhdGlvbiBwcmVmZXJlbmNlc10tPl9wcmVmZXJlbmNlcy5nZXQoKTsKKyAgICBp ZiAoV0tXZWJWaWV3ICpyZWxhdGVkV2ViVmlldyA9IFtfY29uZmlndXJhdGlvbiBfcmVsYXRlZFdl YlZpZXddKQorICAgICAgICB3ZWJQYWdlQ29uZmlndXJhdGlvbi5yZWxhdGVkUGFnZSA9IHJlbGF0 ZWRXZWJWaWV3LT5fcGFnZS5nZXQoKTsKKwogI2lmIFBMQVRGT1JNKElPUykKICAgICBfc2Nyb2xs VmlldyA9IGFkb3B0TlMoW1tXS1Njcm9sbFZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Ym91bmRz XSk7CiAgICAgW19zY3JvbGxWaWV3IHNldEludGVybmFsRGVsZWdhdGU6c2VsZl07CkBAIC0xMTEs NyArMTE4LDcgQEAKIAogICAgIFtzZWxmIGFkZFN1YnZpZXc6X3Njcm9sbFZpZXcuZ2V0KCldOwog Ci0gICAgX2NvbnRlbnRWaWV3ID0gYWRvcHROUyhbW1dLQ29udGVudFZpZXcgYWxsb2NdIGluaXRX aXRoRnJhbWU6Ym91bmRzIGNvbmZpZ3VyYXRpb246X2NvbmZpZ3VyYXRpb24uZ2V0KCldKTsKKyAg ICBfY29udGVudFZpZXcgPSBhZG9wdE5TKFtbV0tDb250ZW50VmlldyBhbGxvY10gaW5pdFdpdGhG cmFtZTpib3VuZHMgY29udGV4dDpjb250ZXh0IGNvbmZpZ3VyYXRpb246c3RkOjptb3ZlKHdlYlBh Z2VDb25maWd1cmF0aW9uKV0pOwogICAgIF9wYWdlID0gX2NvbnRlbnRWaWV3LT5fcGFnZTsKICAg ICBbX2NvbnRlbnRWaWV3IHNldERlbGVnYXRlOnNlbGZdOwogICAgIFtfY29udGVudFZpZXcgbGF5 ZXJdLmFuY2hvclBvaW50ID0gQ0dQb2ludFplcm87CkBAIC0xMjUsNyArMTMyLDcgQEAKICAgICBX ZWJLaXQ6OldlYlBhZ2VDb25maWd1cmF0aW9uIHdlYlBhZ2VDb25maWd1cmF0aW9uOwogICAgIHdl YlBhZ2VDb25maWd1cmF0aW9uLnByZWZlcmVuY2VzID0gW19jb25maWd1cmF0aW9uIHByZWZlcmVu Y2VzXS0+X3ByZWZlcmVuY2VzLmdldCgpOwogCi0gICAgX3drVmlldyA9IFtbV0tWaWV3IGFsbG9j XSBpbml0V2l0aEZyYW1lOmJvdW5kcyBjb250ZXh0OipbX2NvbmZpZ3VyYXRpb24uZ2V0KCkgcHJv Y2Vzc0NsYXNzXS0+X2NvbnRleHQgY29uZmlndXJhdGlvbjpzdGQ6Om1vdmUod2ViUGFnZUNvbmZp Z3VyYXRpb24pXTsKKyAgICBfd2tWaWV3ID0gW1tXS1ZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6 Ym91bmRzIGNvbnRleHQ6Y29udGV4dCBjb25maWd1cmF0aW9uOnN0ZDo6bW92ZSh3ZWJQYWdlQ29u ZmlndXJhdGlvbildOwogICAgIFtzZWxmIGFkZFN1YnZpZXc6X3drVmlldy5nZXQoKV07CiAgICAg X3BhZ2UgPSBXZWJLaXQ6OnRvSW1wbChbX3drVmlldyBwYWdlUmVmXSk7CiAjZW5kaWYKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLQ29udGVudFZpZXcuaCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLQ29udGVudFZpZXcuaAppbmRleCAx MTc3NWVlOWU2NTAwMGExNTUwNzg1YWZhM2QzYTJkZDdmZDEzMmNhLi4wYjdmYjAxZDkyZTE1YWFk M2IwMjM5M2FkOGE0MDYxMTYwNzVjYzhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2lvcy9XS0NvbnRlbnRWaWV3LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9pb3MvV0tDb250ZW50Vmlldy5oCkBAIC0zNSw2ICszNSw4IEBACiAKIG5hbWVzcGFj ZSBXZWJLaXQgewogY2xhc3MgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb247CitjbGFzcyBXZWJD b250ZXh0Oworc3RydWN0IFdlYlBhZ2VDb25maWd1cmF0aW9uOwogfQogCiBAcHJvdG9jb2wgV0tD b250ZW50Vmlld0RlbGVnYXRlIDxOU09iamVjdD4KQEAgLTU1LDcgKzU3LDcgQEAgV0tfQVBJX0NM QVNTCiAKIEBwcm9wZXJ0eSAocmVhZG9ubHkpIFdLUGFnZVJlZiBfcGFnZVJlZjsKIAotLSAoaW5z dGFuY2V0eXBlKWluaXRXaXRoRnJhbWU6KENHUmVjdClmcmFtZSBjb25maWd1cmF0aW9uOihXS1dl YlZpZXdDb25maWd1cmF0aW9uICopY29uZmlndXJhdGlvbjsKKy0gKGluc3RhbmNldHlwZSlpbml0 V2l0aEZyYW1lOihDR1JlY3QpZnJhbWUgY29udGV4dDooV2ViS2l0OjpXZWJDb250ZXh0Jiljb250 ZXh0IGNvbmZpZ3VyYXRpb246KFdlYktpdDo6V2ViUGFnZUNvbmZpZ3VyYXRpb24pd2ViUGFnZUNv bmZpZ3VyYXRpb247CiAKIC0gKGlkKWluaXRXaXRoRnJhbWU6KENHUmVjdClmcmFtZSBjb250ZXh0 UmVmOihXS0NvbnRleHRSZWYpY29udGV4dFJlZiBwYWdlR3JvdXBSZWY6KFdLUGFnZUdyb3VwUmVm KXBhZ2VHcm91cFJlZjsKIC0gKGlkKWluaXRXaXRoRnJhbWU6KENHUmVjdClmcmFtZSBjb250ZXh0 UmVmOihXS0NvbnRleHRSZWYpY29udGV4dFJlZiBwYWdlR3JvdXBSZWY6KFdLUGFnZUdyb3VwUmVm KXBhZ2VHcm91cFJlZiByZWxhdGVkVG9QYWdlOihXS1BhZ2VSZWYpcmVsYXRlZFBhZ2U7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2lvcy9XS0NvbnRlbnRWaWV3Lm1t IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tDb250ZW50Vmlldy5tbQppbmRl eCA4YTgwZmU4YzI5OTA5NjA3YzhjMThkMmIzZmNhOWUwYWViNWUzZGM4Li42ZGU4MmViZTY2ZDRm ZGZhM2M2OTI4NmM0NWNkNzc1YjMwMmJlMGMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvaW9zL1dLQ29udGVudFZpZXcubW0KQEAgLTk1LDcgKzk1LDcgQEAgdXNpbmcg bmFtZXNwYWNlIFdlYktpdDsKICAgICByZXR1cm4gc2VsZjsKIH0KIAotLSAoaW5zdGFuY2V0eXBl KWluaXRXaXRoRnJhbWU6KENHUmVjdClmcmFtZSBjb25maWd1cmF0aW9uOihXS1dlYlZpZXdDb25m aWd1cmF0aW9uICopY29uZmlndXJhdGlvbgorLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoRnJhbWU6 KENHUmVjdClmcmFtZSBjb250ZXh0OihXZWJLaXQ6OldlYkNvbnRleHQmKWNvbnRleHQgY29uZmln dXJhdGlvbjooV2ViS2l0OjpXZWJQYWdlQ29uZmlndXJhdGlvbil3ZWJQYWdlQ29uZmlndXJhdGlv bgogewogICAgIGlmICghKHNlbGYgPSBbc3VwZXIgaW5pdFdpdGhGcmFtZTpmcmFtZV0pKQogICAg ICAgICByZXR1cm4gbmlsOwpAQCAtMTA0LDEwICsxMDQsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2Vi S2l0OwogCiAgICAgX3BhZ2VDbGllbnQgPSBzdGQ6Om1ha2VfdW5pcXVlPFBhZ2VDbGllbnRJbXBs PihzZWxmKTsKIAotICAgIFdlYlBhZ2VDb25maWd1cmF0aW9uIHdlYlBhZ2VDb25maWd1cmF0aW9u OwotICAgIHdlYlBhZ2VDb25maWd1cmF0aW9uLnByZWZlcmVuY2VzID0gY29uZmlndXJhdGlvbi5w cmVmZXJlbmNlcy0+X3ByZWZlcmVuY2VzLmdldCgpOwotCi0gICAgX3BhZ2UgPSBjb25maWd1cmF0 aW9uLnByb2Nlc3NDbGFzcy0+X2NvbnRleHQtPmNyZWF0ZVdlYlBhZ2UoKl9wYWdlQ2xpZW50LCBz dGQ6Om1vdmUod2ViUGFnZUNvbmZpZ3VyYXRpb24pKTsKKyAgICBfcGFnZSA9IGNvbnRleHQuY3Jl YXRlV2ViUGFnZSgqX3BhZ2VDbGllbnQsIHN0ZDo6bW92ZSh3ZWJQYWdlQ29uZmlndXJhdGlvbikp OwogICAgIF9wYWdlLT5pbml0aWFsaXplV2ViUGFnZSgpOwogICAgIF9wYWdlLT5zZXRJbnRyaW5z aWNEZXZpY2VTY2FsZUZhY3RvcihbVUlTY3JlZW4gbWFpblNjcmVlbl0uc2NhbGUpOwogICAgIF9w YWdlLT5zZXRVc2VGaXhlZExheW91dCh0cnVlKTsK