128713 2014-02-12 18:09:47 -0800 JSManagedValue::dealloc modifies NSMapTable while iterating it 2014-02-13 18:31:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 980118 0 mhahnenberg 2014-02-12 18:09:47 -0800 ... 980525 1 224128 mhahnenberg 2014-02-13 16:26:49 -0800 Created attachment 224128 Patch 980529 2 224128 ggaren 2014-02-13 16:50:34 -0800 Comment on attachment 224128 Patch r=me 980588 3 224128 commit-queue 2014-02-13 18:31:39 -0800 Comment on attachment 224128 Patch Clearing flags on attachment: 224128 Committed r164088: <http://trac.webkit.org/changeset/164088> 980589 4 commit-queue 2014-02-13 18:31:40 -0800 All reviewed patches have been landed. Closing bug. 224128 2014-02-13 16:26:49 -0800 2014-02-13 18:31:39 -0800 Patch bug-128713-20140213162648.patch text/plain 4583 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0MDc0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE0LTAyLTEzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgSlNNYW5hZ2VkVmFsdWU6OmRlYWxsb2MgbW9kaWZpZXMgTlNNYXBUYWJsZSB3aGls ZSBpdGVyYXRpbmcgaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyODcxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEhhdmluZyB0byB3cml0ZSBhIHRlc3QgZm9yIHRoaXMgcmV2ZWFsZWQgYSBidWcgaW4g aG93IGFkZE1hbmFnZWRSZWZlcmVuY2U6d2l0aE93bmVyOgorICAgICAgICBhY3R1YWxseSBub3Rp ZmllcyBKU01hbmFnZWRWYWx1ZXMgb2YgbmV3IG93bmVycy4KKworICAgICAgICAqIEFQSS9KU01h bmFnZWRWYWx1ZS5tbToKKyAgICAgICAgKC1bSlNNYW5hZ2VkVmFsdWUgZGVhbGxvY10pOgorICAg ICAgICAqIEFQSS9KU1ZpcnR1YWxNYWNoaW5lLm1tOgorICAgICAgICAoLVtKU1ZpcnR1YWxNYWNo aW5lIGFkZE1hbmFnZWRSZWZlcmVuY2U6d2l0aE93bmVyOl0pOgorICAgICAgICAoLVtKU1ZpcnR1 YWxNYWNoaW5lIHJlbW92ZU1hbmFnZWRSZWZlcmVuY2U6d2l0aE93bmVyOl0pOgorICAgICAgICAq IEFQSS90ZXN0cy90ZXN0YXBpLm1tOgorICAgICAgICAodGVzdE9iamVjdGl2ZUNBUEkpOgorCiAy MDE0LTAyLTEzICBNYXR0aGV3IE1pcm1hbiAgPG1taXJtYW5AYXBwbGUuY29tPgogCiAgICAgICAg IEFkZGVkIEdldE15QXJndW1lbnRzTGVuZ3RoIHRvIEZUTApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL0FQSS9KU01hbmFnZWRWYWx1ZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQVBJL0pTTWFuYWdlZFZhbHVlLm1tCShyZXZpc2lvbiAxNjQwMzApCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTTWFuYWdlZFZhbHVlLm1tCSh3b3JraW5nIGNvcHkpCkBA IC0yMjEsMTEgKzIyMSwxMyBAQCAtICh2b2lkKWRlYWxsb2MKIHsKICAgICBKU1ZpcnR1YWxNYWNo aW5lICp2aXJ0dWFsTWFjaGluZSA9IFtbW3NlbGYgdmFsdWVdIGNvbnRleHRdIHZpcnR1YWxNYWNo aW5lXTsKICAgICBpZiAodmlydHVhbE1hY2hpbmUpIHsKLSAgICAgICAgZm9yIChpZCBvd25lciBp biBbbV9vd25lcnMga2V5RW51bWVyYXRvcl0pIHsKKyAgICAgICAgTlNNYXBUYWJsZSAqY29weSA9 IFttX293bmVycyBjb3B5XTsKKyAgICAgICAgZm9yIChpZCBvd25lciBpbiBbY29weSBrZXlFbnVt ZXJhdG9yXSkgewogICAgICAgICAgICAgc2l6ZV90IGNvdW50ID0gcmVpbnRlcnByZXRfY2FzdDxz aXplX3Q+KE5TTWFwR2V0KG1fb3duZXJzLCBvd25lcikpOwogICAgICAgICAgICAgd2hpbGUgKGNv dW50LS0pCiAgICAgICAgICAgICAgICAgW3ZpcnR1YWxNYWNoaW5lIHJlbW92ZU1hbmFnZWRSZWZl cmVuY2U6c2VsZiB3aXRoT3duZXI6b3duZXJdOwogICAgICAgICB9CisgICAgICAgIFtjb3B5IHJl bGVhc2VdOwogICAgIH0KIAogICAgIFtzZWxmIGRpc2Nvbm5lY3RWYWx1ZV07CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmUubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1YWxNYWNoaW5lLm1tCShyZXZpc2lvbiAx NjQwMzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmlydHVhbE1hY2hpbmUubW0J KHdvcmtpbmcgY29weSkKQEAgLTE0OCw2ICsxNDgsOSBAQCBzdGF0aWMgaWQgZ2V0SW50ZXJuYWxP YmpjT2JqZWN0KGlkIG9iamVjCiAKIC0gKHZvaWQpYWRkTWFuYWdlZFJlZmVyZW5jZTooaWQpb2Jq ZWN0IHdpdGhPd25lcjooaWQpb3duZXIKIHsgICAgCisgICAgaWYgKFtvYmplY3QgaXNLaW5kT2ZD bGFzczpbSlNNYW5hZ2VkVmFsdWUgY2xhc3NdXSkKKyAgICAgICAgW29iamVjdCBkaWRBZGRPd25l cjpvd25lcl07CisgICAgICAgIAogICAgIG9iamVjdCA9IGdldEludGVybmFsT2JqY09iamVjdChv YmplY3QpOwogICAgIG93bmVyID0gZ2V0SW50ZXJuYWxPYmpjT2JqZWN0KG93bmVyKTsKICAgICAK QEAgLTE2NiwxNSArMTY5LDE1IEBAIC0gKHZvaWQpYWRkTWFuYWdlZFJlZmVyZW5jZTooaWQpb2Jq ZWN0IHcKICAgICAgICAgW293bmVkT2JqZWN0cyByZWxlYXNlXTsKICAgICB9CiAKLSAgICBpZiAo W29iamVjdCBpc0tpbmRPZkNsYXNzOltKU01hbmFnZWRWYWx1ZSBjbGFzc11dKQotICAgICAgICBb b2JqZWN0IGRpZEFkZE93bmVyOm93bmVyXTsKLSAgICAgICAgCiAgICAgc2l6ZV90IGNvdW50ID0g cmVpbnRlcnByZXRfY2FzdDxzaXplX3Q+KE5TTWFwR2V0KG93bmVkT2JqZWN0cywgb2JqZWN0KSk7 CiAgICAgTlNNYXBJbnNlcnQob3duZWRPYmplY3RzLCBvYmplY3QsIHJlaW50ZXJwcmV0X2Nhc3Q8 dm9pZCo+KGNvdW50ICsgMSkpOwogfQogCiAtICh2b2lkKXJlbW92ZU1hbmFnZWRSZWZlcmVuY2U6 KGlkKW9iamVjdCB3aXRoT3duZXI6KGlkKW93bmVyCiB7CisgICAgaWYgKFtvYmplY3QgaXNLaW5k T2ZDbGFzczpbSlNNYW5hZ2VkVmFsdWUgY2xhc3NdXSkKKyAgICAgICAgW29iamVjdCBkaWRSZW1v dmVPd25lcjpvd25lcl07CisKICAgICBvYmplY3QgPSBnZXRJbnRlcm5hbE9iamNPYmplY3Qob2Jq ZWN0KTsKICAgICBvd25lciA9IGdldEludGVybmFsT2JqY09iamVjdChvd25lcik7CiAgICAgCkBA IC0xOTYsOSArMTk5LDYgQEAgLSAodm9pZClyZW1vdmVNYW5hZ2VkUmVmZXJlbmNlOihpZClvYmpl YwogICAgIGlmIChjb3VudCA9PSAxKQogICAgICAgICBOU01hcFJlbW92ZShvd25lZE9iamVjdHMs IG9iamVjdCk7CiAKLSAgICBpZiAoW29iamVjdCBpc0tpbmRPZkNsYXNzOltKU01hbmFnZWRWYWx1 ZSBjbGFzc11dKQotICAgICAgICBbb2JqZWN0IGRpZFJlbW92ZU93bmVyOm93bmVyXTsKLQogICAg IGlmICghW293bmVkT2JqZWN0cyBjb3VudF0pCiAgICAgICAgIFttX2V4dGVybmFsT2JqZWN0R3Jh cGggcmVtb3ZlT2JqZWN0Rm9yS2V5Om93bmVyXTsKIH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0JKHJldmlzaW9uIDE2NDAzMCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5tbQkod29ya2luZyBjb3B5KQpAQCAtNTM5 LDYgKzUzOSwyMCBAQCB2b2lkIHRlc3RPYmplY3RpdmVDQVBJKCkKIAogICAgIEBhdXRvcmVsZWFz ZXBvb2wgewogICAgICAgICBKU0NvbnRleHQgKmNvbnRleHQgPSBbW0pTQ29udGV4dCBhbGxvY10g aW5pdF07CisgICAgICAgIEpTVmFsdWUgKm1lc3NhZ2UgPSBbSlNWYWx1ZSB2YWx1ZVdpdGhPYmpl Y3Q6QCJoZWxsbyIgaW5Db250ZXh0OmNvbnRleHRdOworICAgICAgICBUZXN0T2JqZWN0ICpyb290 T2JqZWN0ID0gW1Rlc3RPYmplY3QgdGVzdE9iamVjdF07CisgICAgICAgIEpTQ29sbGVjdGlvbiAq Y29sbGVjdGlvbiA9IFtbSlNDb2xsZWN0aW9uIGFsbG9jXSBpbml0XTsKKyAgICAgICAgY29udGV4 dFtAInJvb3QiXSA9IHJvb3RPYmplY3Q7CisgICAgICAgIEBhdXRvcmVsZWFzZXBvb2wgeworICAg ICAgICAgICAgSlNWYWx1ZSAqanNDb2xsZWN0aW9uID0gW0pTVmFsdWUgdmFsdWVXaXRoT2JqZWN0 OmNvbGxlY3Rpb24gaW5Db250ZXh0OmNvbnRleHRdOworICAgICAgICAgICAgSlNNYW5hZ2VkVmFs dWUgKndlYWtDb2xsZWN0aW9uID0gW0pTTWFuYWdlZFZhbHVlIG1hbmFnZWRWYWx1ZVdpdGhWYWx1 ZTpqc0NvbGxlY3Rpb24gYW5kT3duZXI6cm9vdE9iamVjdF07CisgICAgICAgICAgICBbY29udGV4 dC52aXJ0dWFsTWFjaGluZSBhZGRNYW5hZ2VkUmVmZXJlbmNlOndlYWtDb2xsZWN0aW9uIHdpdGhP d25lcjptZXNzYWdlXTsKKyAgICAgICAgICAgIEpTU3luY2hyb25vdXNHYXJiYWdlQ29sbGVjdEZv ckRlYnVnZ2luZyhbY29udGV4dCBKU0dsb2JhbENvbnRleHRSZWZdKTsKKyAgICAgICAgfQorICAg IH0KKworICAgIEBhdXRvcmVsZWFzZXBvb2wgeworICAgICAgICBKU0NvbnRleHQgKmNvbnRleHQg PSBbW0pTQ29udGV4dCBhbGxvY10gaW5pdF07CiAgICAgICAgIF9fYmxvY2sgaW50IHJlc3VsdDsK ICAgICAgICAgY29udGV4dFtAImJsb2NrQ2FsbGJhY2siXSA9IF4oaW50IHZhbHVlKXsKICAgICAg ICAgICAgIHJlc3VsdCA9IHZhbHVlOwo=