128712 2014-02-12 17:54:21 -0800 Return immediately from DestroyPlugin IPC call 2018-01-19 16:42:02 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181889 P2 Normal --- 176881 1 koivisto webkit-unassigned andersca commit-queue oldest_to_newest 980115 0 koivisto 2014-02-12 17:54:21 -0800 Don't unnecessarily wait for plugin termination. 980116 1 224037 koivisto 2014-02-12 18:07:36 -0800 Created attachment 224037 patch 980117 2 commit-queue 2014-02-12 18:08:14 -0800 Attachment 224037 did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 980163 3 224037 andersca 2014-02-12 21:45:48 -0800 Comment on attachment 224037 patch Sure, let's try this. If we see any fallout we can either: 1. Limit by plug-in type. 2. Only do this when we're certain that the plug-in isn't playing any audio, showing ui, etc. 980168 4 koivisto 2014-02-12 21:59:55 -0800 https://trac.webkit.org/r164015 224037 2014-02-12 18:07:36 -0800 2014-02-12 21:45:48 -0800 patch plugin-destroy-return.patch text/plain 4057 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDAwNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTAyLTEyICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZXR1cm4gaW1tZWRpYXRlbHkg ZnJvbSBEZXN0cm95UGx1Z2luIElQQyBjYWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg3MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEluIHNvbWUgY2FzZXMgd2Ugc3BlbmQgYSBsb3Qg b2YgdGltZSB3YWl0aW5nIGZvciBzeW5jaHJvbm91cyBJUEMgZm9yIHBsdWdpbiB0ZXJtaW5hdGlv biB0byBjb21wbGV0ZS4gUmVkdWNlCisgICAgICAgIHRoZSBkZWxheSBieSByZXR1cm5pbmcgZnJv bSBJUEMgaW1tZWRpYXRlbHkgd2hlbiB0aGUgcGx1Z2luIHByb2Nlc3MgcmVjZWl2ZXMgaXQuIEp1 c3QgdXNpbmcgYXN5bmNocm91bm91cworICAgICAgICBJUEMgbWlnaHQgaW50cm9kdWNlIHVuZGVz aXJhYmxlIGFyYml0cmFyeSBkZWxheSBiZXR3ZWVuIHRoZSBJUEMgY2FsbCByZXR1cm5pbmcgYW5k IHRoZSBkZXN0cnVjdGlvbiBhY3R1YWxseQorICAgICAgICBzdGFydGluZy4KKworICAgICAgICAq IFBsdWdpblByb2Nlc3MvV2ViUHJvY2Vzc0Nvbm5lY3Rpb24uY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJQcm9jZXNzQ29ubmVjdGlvbjo6ZGVzdHJveVBsdWdpbik6CisgICAgICAgICogUGx1Z2lu UHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5oOi9Vc2Vycy9hbnR0aS9wYXRjaGVzL3BsdWdp bi1kZXN0cm95LXJldHVybi5wYXRjaAorICAgICAgICAqIFBsdWdpblByb2Nlc3MvV2ViUHJvY2Vz c0Nvbm5lY3Rpb24ubWVzc2FnZXMuaW46CisKIDIwMTQtMDItMTIgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgcmVsYXRlZFdlYlZpZXcgcHJvcGVy dHkgdG8gV0tXZWJWaWV3Q29uZmlndXJhdGlvbgpJbmRleDogU291cmNlL1dlYktpdDIvUGx1Z2lu UHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvUGx1Z2luUHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5jcHAJKHJldmlzaW9uIDE2 Mzk4MikKKysrIFNvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvV2ViUHJvY2Vzc0Nvbm5lY3Rp b24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzgsOCArMTc4LDEyIEBAIHZvaWQgV2ViUHJvY2Vz c0Nvbm5lY3Rpb246OmRpZENsb3NlKElQQzoKICAgICAgICAgZGVzdHJveVBsdWdpbkNvbnRyb2xs ZXJQcm94eShwbHVnaW5Db250cm9sbGVyc1tpXSk7CiB9CiAKLXZvaWQgV2ViUHJvY2Vzc0Nvbm5l Y3Rpb246OmRlc3Ryb3lQbHVnaW4odWludDY0X3QgcGx1Z2luSW5zdGFuY2VJRCwgYm9vbCBhc3lu Y2hyb25vdXNDcmVhdGlvbkluY29tcGxldGUpCit2b2lkIFdlYlByb2Nlc3NDb25uZWN0aW9uOjpk ZXN0cm95UGx1Z2luKHVpbnQ2NF90IHBsdWdpbkluc3RhbmNlSUQsIGJvb2wgYXN5bmNocm9ub3Vz Q3JlYXRpb25JbmNvbXBsZXRlLCBQYXNzUmVmUHRyPE1lc3NhZ2VzOjpXZWJQcm9jZXNzQ29ubmVj dGlvbjo6RGVzdHJveVBsdWdpbjo6RGVsYXllZFJlcGx5PiByZXBseSkKIHsKKyAgICAvLyBXZSBy ZXR1cm4gaW1tZWRpYXRlbHkgZnJvbSB0aGlzIHN5bmNocm9ub3VzIElQQy4gV2Ugd2FudCB0byBt YWtlIHN1cmUgdGhlIHBsdWdpbiBkZXN0cnVjdGlvbiBpcyBqdXN0IGFib3V0IHRvIHN0YXJ0IHNv IGF1ZGlvIHBsYXliYWNrCisgICAgLy8gd2lsbCBmaW5pc2ggc29vbiBhZnRlciByZXR1cm5pbmcu IEhvd2V2ZXIgd2UgZG9uJ3Qgd2FudCB0byB3YWl0IGZvciBkZXN0cnVjdGlvbiB0byBjb21wbGV0 ZSBmdWxseSBhcyB0aGF0IG1heSB0YWtlIGEgd2hpbGUuCisgICAgcmVwbHktPnNlbmQoKTsKKwog ICAgIC8vIEVuc3VyZSB3ZSBkb24ndCBjbGFtcCBhbnkgdGltZXJzIGR1cmluZyBkZXN0cnVjdGlv bgogICAgIEFjdGl2aXR5QXNzZXJ0aW9uIGFjdGl2aXR5QXNzZXJ0aW9uKFBsdWdpblByb2Nlc3M6 OnNoYXJlZCgpLmNvbm5lY3Rpb25BY3Rpdml0eSgpKTsKIApJbmRleDogU291cmNlL1dlYktpdDIv UGx1Z2luUHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvV2ViUHJvY2Vzc0Nvbm5lY3Rpb24uaAkocmV2aXNpb24g MTYzOTgyKQorKysgU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVj dGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC03Miw3ICs3Miw3IEBAIHByaXZhdGU6CiAgICAgdm9p ZCBkaWRSZWNlaXZlU3luY1dlYlByb2Nlc3NDb25uZWN0aW9uTWVzc2FnZShJUEM6OkNvbm5lY3Rp b24qLCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJiwgc3RkOjp1bmlxdWVfcHRyPElQQzo6TWVzc2FnZUVu Y29kZXI+Jik7CiAgICAgdm9pZCBjcmVhdGVQbHVnaW4oY29uc3QgUGx1Z2luQ3JlYXRpb25QYXJh bWV0ZXJzJiwgUGFzc1JlZlB0cjxNZXNzYWdlczo6V2ViUHJvY2Vzc0Nvbm5lY3Rpb246OkNyZWF0 ZVBsdWdpbjo6RGVsYXllZFJlcGx5Pik7CiAgICAgdm9pZCBjcmVhdGVQbHVnaW5Bc3luY2hyb25v dXNseShjb25zdCBQbHVnaW5DcmVhdGlvblBhcmFtZXRlcnMmKTsKLSAgICB2b2lkIGRlc3Ryb3lQ bHVnaW4odWludDY0X3QgcGx1Z2luSW5zdGFuY2VJRCwgYm9vbCBhc3luY2hyb25vdXNDcmVhdGlv bkluY29tcGxldGUpOworICAgIHZvaWQgZGVzdHJveVBsdWdpbih1aW50NjRfdCBwbHVnaW5JbnN0 YW5jZUlELCBib29sIGFzeW5jaHJvbm91c0NyZWF0aW9uSW5jb21wbGV0ZSwgUGFzc1JlZlB0cjxN ZXNzYWdlczo6V2ViUHJvY2Vzc0Nvbm5lY3Rpb246OkRlc3Ryb3lQbHVnaW46OkRlbGF5ZWRSZXBs eT4pOwogICAgIAogICAgIHZvaWQgY3JlYXRlUGx1Z2luSW50ZXJuYWwoY29uc3QgUGx1Z2luQ3Jl YXRpb25QYXJhbWV0ZXJzJiwgYm9vbCYgcmVzdWx0LCBib29sJiB3YW50c1doZWVsRXZlbnRzLCB1 aW50MzJfdCYgcmVtb3RlTGF5ZXJDbGllbnRJRCk7CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1Bs dWdpblByb2Nlc3MvV2ViUHJvY2Vzc0Nvbm5lY3Rpb24ubWVzc2FnZXMuaW4KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5tZXNz YWdlcy5pbgkocmV2aXNpb24gMTYzOTgyKQorKysgU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vz cy9XZWJQcm9jZXNzQ29ubmVjdGlvbi5tZXNzYWdlcy5pbgkod29ya2luZyBjb3B5KQpAQCAtMzAs NyArMzAsNyBAQCBtZXNzYWdlcyAtPiBXZWJQcm9jZXNzQ29ubmVjdGlvbiBMZWdhY3lSCiAgICAg Q3JlYXRlUGx1Z2luQXN5bmNocm9ub3VzbHkoV2ViS2l0OjpQbHVnaW5DcmVhdGlvblBhcmFtZXRl cnMgcGx1Z2luQ3JlYXRpb25QYXJhbWV0ZXJzKQogCiAgICAgIyBEZXN0cm95cyB0aGUgcGx1Zy1p biBpbnN0YW5jZSB3aXRoIHRoZSBnaXZlbiBpbnN0YW5jZSBJRC4KLSAgICBEZXN0cm95UGx1Z2lu KHVpbnQ2NF90IHBsdWdpbkluc3RhbmNlSUQsIGJvb2wgYXN5bmNocm9ub3VzQ3JlYXRpb25JbmNv bXBsZXRlKSAtPiAoKQorICAgIERlc3Ryb3lQbHVnaW4odWludDY0X3QgcGx1Z2luSW5zdGFuY2VJ RCwgYm9vbCBhc3luY2hyb25vdXNDcmVhdGlvbkluY29tcGxldGUpIC0+ICgpIERlbGF5ZWQKIH0K IAogI2VuZGlmCg==