12870 2007-02-23 08:23:52 -0800 REGRESSION: Safari accepts and attempts to load any file dragged into it 2007-02-23 17:39:06 -0800 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 dev+webkit oliver oliver oldest_to_newest 21945 0 dev+webkit 2007-02-23 08:23:52 -0800 Safari now claims to accept (shows the cursor with the green + orb) and seems to try to load anything dragged into it - things like application bundles, folders or zip files. The title is blanked and history functionality for that tab/window is dead. 21867 1 13356 oliver 2007-02-23 17:21:10 -0800 Created attachment 13356 instamatic fix Okay, the problem is that the drag and drop code had an "improvement" that short circuited the evaluation of _web_best_URL if the dragging Pasteboard contained any url. _web_best_URL filters out insane URLs (eg. directories) so this was bad. This fix stops directories from being accepted. All other files are accepted, and will bring up the finder if the dropped file isn't viewable with webkit. 21869 2 13356 aroben 2007-02-23 17:29:17 -0800 Comment on attachment 13356 instamatic fix + Drag a file that WebKit doesn't recognise -- eg. a disk image, tarball, etc.<p> Would be better to either wrap this in a <p></p> pair, or use <br> r=me 21870 3 oliver 2007-02-23 17:39:06 -0800 Landed in r19382 (ChangeLog corrected in r19833 *sigh*) 13356 2007-02-23 17:21:10 -0800 2007-02-23 17:29:17 -0800 instamatic fix directoryDrop.patch text/plain 2108 oliver SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODMx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDctMDIt MjMgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyODcwCisKKyAgICAgICAgSXQgdHVybnMgb3V0IHNob3J0IGNp cmN1aXRpbmcgRHJhZ0RhdGE6OmNvbnRhaW5zVVJMKCkgd2FzIGJhZAorCisgICAgICAgICogQ2hh bmdlTG9nOgorICAgICAgICAqIFdlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajoKKyAg ICAgICAgKiBtYW51YWwtdGVzdHMvZGlyZWN0b3J5LWRyb3Atb24tdmlldy5odG1sOiBBZGRlZC4K KyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvRHJhZ0RhdGFNYWMubW06CisgICAgICAgIChXZWJDb3Jl OjpEcmFnRGF0YTo6Y29udGFpbnNVUkwpOgorCiAyMDA3LTAyLTIzICBNYWNpZWogU3RhY2hvd2lh ayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWl0ei4KSW5kZXg6IG1h bnVhbC10ZXN0cy9kaXJlY3RvcnktZHJvcC1vbi12aWV3Lmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbWFu dWFsLXRlc3RzL2RpcmVjdG9yeS1kcm9wLW9uLXZpZXcuaHRtbAkocmV2aXNpb24gMCkKKysrIG1h bnVhbC10ZXN0cy9kaXJlY3RvcnktZHJvcC1vbi12aWV3Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMjAgQEAKKzxodG1sPiAKKyAgPGhlYWQ+CisgICAgPHRpdGxlPiAKKwkgICAgTWFudWFs IGRyb3AgdGVzdAorICAgIDwvdGl0bGU+ICAgCisgIDwvaGVhZD4KKyAgPGJvZHk+IAorCVRoaXMg dGVzdHMgdGhhdCB1bmtub3duIGZpbGUgdHlwZXMgYXJlIGhhbmRsZWQgY29ycmVjdGx5IHdoZW4g ZHJvcHBlZCBpbiB0aGUgd2luZG93CisJPHVsPiAKKwkJPGxpPgorCQkJRHJhZyBhIGZpbGUgdGhh dCBXZWJLaXQgZG9lc24ndCByZWNvZ25pc2UgLS0gZWcuIGEgZGlzayBpbWFnZSwgdGFyYmFsbCwg ZXRjLjxwPgorCQkJV2ViS2l0IHNob3VsZCBjYXVzZSBhIEZpbmRlciB3aW5kb3cgdG8gb3Blbiwg d2l0aCB0aGUgZHJvcHBlZCBmaWxlIHNlbGVjdGVkLiAgCisJCTwvbGk+CisJCTxsaT4gCisJCQlB dHRlbXB0IHRvIGRyb3AgYSBkaXJlY3Rvcnkgb250byB0aGUgV2ViVmlldy48cD4KKwkJCVRoZSBk cmFnIHNob3VsZCBub3QgYmUgYWNjZXB0ZWQsIGFuZCB0aGUgZHJhZyBjdXJzb3Igc2hvdWxkIGJl IHRoZSBzdGFuZGFyZCBkaXNhbGxvd2VkIGRyYWcgY3Vyc29yLiAKKwkJPC9saT4KKwk8L3VsPgor ICA8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogcGxh dGZvcm0vbWFjL0RyYWdEYXRhTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRmb3JtL21hYy9EcmFn RGF0YU1hYy5tbQkocmV2aXNpb24gMTk4MzEpCisrKyBwbGF0Zm9ybS9tYWMvRHJhZ0RhdGFNYWMu bW0JKHdvcmtpbmcgY29weSkKQEAgLTExNiw4ICsxMTYsNyBAQCBib29sIERyYWdEYXRhOjpjb250 YWluc0NvbXBhdGlibGVDb250ZW50CiAgICAgCiBib29sIERyYWdEYXRhOjpjb250YWluc1VSTCgp IGNvbnN0CiB7Ci0gICAgLy9GSVhNRTogaXMgaXQgd29ydGggZG9pbmcgdGhlIGluaXRpYWwgW3R5 cGVzIGNvbnRhaW5zIFVSTF0gY2hlY2s/Ci0gICAgcmV0dXJuIFtbW21fcGxhdGZvcm1EcmFnRGF0 YSBkcmFnZ2luZ1Bhc3RlYm9hcmRdIHR5cGVzXSBjb250YWluc09iamVjdDpOU1VSTFBib2FyZFR5 cGVdIHx8ICFhc1VSTCgpLmlzRW1wdHkoKTsKKyAgICByZXR1cm4gIWFzVVJMKCkuaXNFbXB0eSgp OwogfQogICAgIAogU3RyaW5nIERyYWdEYXRhOjphc1VSTChTdHJpbmcqIHRpdGxlKSBjb25zdAo=