128698 2014-02-12 15:02:27 -0800 REGRESSION: Crashing/Broken Tests Due To Unexpected 8-bit Character Data 2014-02-12 17:23:42 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Major --- 95812 1 bfulgham bfulgham andersca bfulgham mitz msaboff webkit-bug-importer oldest_to_newest 980031 0 bfulgham 2014-02-12 15:02:27 -0800 The code change in http://trac.webkit.org/changeset/127801, coupled with the recent change to turn on 8-bit character use everywhere caused the Windows build to break. Windows API only accepts 16-bit Unicode strings for certain operations. The 8-bit strings being passed around inside WebKit need to be converted to 16-bit when calling these APIs. 980037 1 224014 bfulgham 2014-02-12 15:04:55 -0800 Created attachment 224014 Patch 980041 2 224014 thorton 2014-02-12 15:10:58 -0800 Comment on attachment 224014 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224014&action=review > Source/WebCore/platform/graphics/win/UniscribeController.cpp:111 > + String tempToHold16BitCopy; "temp" not so great 980051 3 bfulgham 2014-02-12 15:38:17 -0800 (In reply to comment #2) > (From update of attachment 224014 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=224014&action=review > > > Source/WebCore/platform/graphics/win/UniscribeController.cpp:111 > > + String tempToHold16BitCopy; > > "temp" not so great Changing to bufferFor16BitData. 980094 4 bfulgham 2014-02-12 17:22:25 -0800 Committed r164001: <http://trac.webkit.org/changeset/164001> 980095 5 webkit-bug-importer 2014-02-12 17:23:42 -0800 <rdar://problem/16054890> 224014 2014-02-12 15:04:55 -0800 2014-02-12 15:10:57 -0800 Patch bug-128698-20140212150454.patch text/plain 2672 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Mzk5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTEyICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IENyYXNo aW5nL0Jyb2tlbiBUZXN0cyBEdWUgVG8gVW5leHBlY3RlZCA4LWJpdCBDaGFyYWN0ZXIgRGF0YQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4Njk4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy93aW4vVW5pc2NyaWJlQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpVbmlzY3JpYmVDb250cm9sbGVyOjphZHZhbmNlKTogTWFrZSAxNi1iaXQgY29weSB3aGVuIG5l ZWRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlVuaXNjcmliZUNvbnRyb2xsZXI6OnNoYXBlQW5kUGxh Y2VJdGVtKTogSGFuZGxlIDgtYml0IGNhc2Ugd2hlbiBjaGVja2luZworICAgICAgICBmb3Igd29y ZCBib3VuZGFyaWVzLgorCiAyMDE0LTAyLTEyICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBs ZS5jb20+CiAKICAgICAgICAgV0syOiBjb29yZGluYXRlIG1hcHBpbmcgZm9yIGZyYW1lcyBkb2Vz IG5vdCB3b3JrIHdoZW4gdGhlIHBhZ2UgaXMgc2Nyb2xsZWQuCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vVW5pc2NyaWJlQ29udHJvbGxlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1VuaXNjcmliZUNvbnRy b2xsZXIuY3BwCShyZXZpc2lvbiAxNjM5NjgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy93aW4vVW5pc2NyaWJlQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEw OCw4ICsxMDgsMTcgQEAgdm9pZCBVbmlzY3JpYmVDb250cm9sbGVyOjphZHZhbmNlKHVuc2lnbgog ICAgIGlmIChsZW5ndGggPD0gMCkKICAgICAgICAgcmV0dXJuOwogCisgICAgU3RyaW5nIHRlbXBU b0hvbGQxNkJpdENvcHk7CisKICAgICAvLyBJdGVtaXplIHRoZSBzdHJpbmcuCi0gICAgY29uc3Qg VUNoYXIqIGNwID0gbV9ydW4uZGF0YTE2KG1fY3VycmVudENoYXJhY3Rlcik7CisgICAgY29uc3Qg VUNoYXIqIGNwID0gbnVsbHB0cjsKKyAgICBpZiAobV9ydW4uaXM4Qml0KCkpIHsKKyAgICAgICAg Ly8gVW5pc2NyaWJlIG9ubHkgZGVhbHMgd2l0aCAxNi1iaXQgY2hhcmFjdGVycy4gTXVzdCBnZW5l cmF0ZSB0aGVtIG5vdy4KKyAgICAgICAgdGVtcFRvSG9sZDE2Qml0Q29weSA9IFN0cmluZzo6bWFr ZTE2Qml0RnJvbThCaXRTb3VyY2UobV9ydW4uZGF0YTgobV9jdXJyZW50Q2hhcmFjdGVyKSwgbGVu Z3RoKTsKKyAgICAgICAgY3AgPSB0ZW1wVG9Ib2xkMTZCaXRDb3B5LmNoYXJhY3RlcnMxNigpOwor ICAgIH0gZWxzZQorICAgICAgICBjcCA9IG1fcnVuLmRhdGExNihtX2N1cnJlbnRDaGFyYWN0ZXIp OworCiAgICAgdW5zaWduZWQgYmFzZUNoYXJhY3RlciA9IG1fY3VycmVudENoYXJhY3RlcjsKIAog ICAgIC8vIFdlIGJyZWFrIHVwIGl0ZW1pemF0aW9uIG9mIHRoZSBzdHJpbmcgYnkgZm9udERhdGEg YW5kIChpZiBuZWVkZWQpIHRoZSB1c2Ugb2Ygc21hbGwgY2Fwcy4KQEAgLTMzMCw4ICszMzksMTYg QEAgYm9vbCBVbmlzY3JpYmVDb250cm9sbGVyOjpzaGFwZUFuZFBsYWNlSQogICAgICAgICAgICAg ICAgIH0KIAogICAgICAgICAgICAgICAgIC8vIEFjY291bnQgZm9yIHdvcmQtc3BhY2luZy4KLSAg ICAgICAgICAgICAgICBpZiAoY2hhcmFjdGVySW5kZXggPiAwICYmICFGb250Ojp0cmVhdEFzU3Bh Y2UoKm1fcnVuLmRhdGExNihjaGFyYWN0ZXJJbmRleCAtIDEpKSAmJiBtX2ZvbnQud29yZFNwYWNp bmcoKSkKLSAgICAgICAgICAgICAgICAgICAgYWR2YW5jZSArPSBtX2ZvbnQud29yZFNwYWNpbmco KTsKKyAgICAgICAgICAgICAgICBpZiAoY2hhcmFjdGVySW5kZXggPiAwICYmIG1fZm9udC53b3Jk U3BhY2luZygpKSB7CisgICAgICAgICAgICAgICAgICAgIFVDaGFyIGNhbmRpZGF0ZVNwYWNlOwor ICAgICAgICAgICAgICAgICAgICBpZiAobV9ydW4uaXM4Qml0KCkpCisgICAgICAgICAgICAgICAg ICAgICAgICBjYW5kaWRhdGVTcGFjZSA9ICoobV9ydW4uZGF0YTgoY2hhcmFjdGVySW5kZXggLSAx KSk7CisgICAgICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgICAgIGNh bmRpZGF0ZVNwYWNlID0gKihtX3J1bi5kYXRhMTYoY2hhcmFjdGVySW5kZXggLSAxKSk7CisKKyAg ICAgICAgICAgICAgICAgICAgaWYgKCFGb250Ojp0cmVhdEFzU3BhY2UoY2FuZGlkYXRlU3BhY2Up KQorICAgICAgICAgICAgICAgICAgICAgICAgYWR2YW5jZSArPSBtX2ZvbnQud29yZFNwYWNpbmco KTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAo=