128654 2014-02-11 22:10:54 -0800 CopiedBlock::pin can call into fastFree while forbidden 2014-02-20 14:49:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 979770 0 mhahnenberg 2014-02-11 22:10:54 -0800 ... 979880 1 mhahnenberg 2014-02-12 09:19:14 -0800 This is probably due to the fact that a FullCollection that skips copying doesn't clear the CopyWorkList of the all the surviving CopiedBlocks because we now only call didSurviveGC() at the beginning of FullCollections. EdenCollections always do copying, therefore they always clear all CopyWorkLists. The fix is probably to call didSurviveGC() for all surviving CopiedBlocks at the end of FullCollections as well at the beginning. 982928 2 224781 mhahnenberg 2014-02-20 12:12:17 -0800 Created attachment 224781 Patch 982986 3 224781 commit-queue 2014-02-20 14:49:53 -0800 Comment on attachment 224781 Patch Clearing flags on attachment: 224781 Committed r164448: <http://trac.webkit.org/changeset/164448> 982987 4 commit-queue 2014-02-20 14:49:54 -0800 All reviewed patches have been landed. Closing bug. 224781 2014-02-20 12:12:17 -0800 2014-02-20 14:49:53 -0800 Patch bug-128654-20140220121213.patch text/plain 2190 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY0NDQxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE0LTAyLTIwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ29waWVkQmxvY2s6OnBpbiBjYW4gY2FsbCBpbnRvIGZhc3RGcmVlIHdoaWxlIGZv cmJpZGRlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI4NjU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QSBGdWxsQ29sbGVjdGlvbiB0aGF0IHNraXBzIGNvcHlpbmcgZG9lc24ndCBjbGVhciB0aGUgQ29w eVdvcmtMaXN0IG9mIHRoZSBhbGwgdGhlIHN1cnZpdmluZyAKKyAgICAgICAgQ29waWVkQmxvY2tz IGJlY2F1c2Ugd2UgY3VycmVudGx5IG9ubHkgY2FsbCBkaWRTdXJ2aXZlR0MoKSBhdCB0aGUgYmVn aW5uaW5nIG9mIEZ1bGxDb2xsZWN0aW9ucy4KKworICAgICAgICBFZGVuQ29sbGVjdGlvbnMgYWx3 YXlzIGRvIGNvcHlpbmcsIHRoZXJlZm9yZSB0aGV5IGFsd2F5cyBjbGVhciBhbGwgQ29weVdvcmtM aXN0cy4KKworICAgICAgICBUaGUgZml4IGlzIHRvIGNhbGwgZGlkU3Vydml2ZUdDKCkgZm9yIGFs bCBzdXJ2aXZpbmcgQ29waWVkQmxvY2tzIGF0IHRoZSBlbmQgb2YgRnVsbENvbGxlY3Rpb25zIAor ICAgICAgICBhcyB3ZWxsIGF0IHRoZSBiZWdpbm5pbmcuCisKKyAgICAgICAgKiBoZWFwL0NvcGll ZEJsb2NrLmg6CisgICAgICAgIChKU0M6OkNvcGllZEJsb2NrOjpkaWRTdXJ2aXZlR0MpOgorICAg ICAgICAqIGhlYXAvQ29waWVkU3BhY2UuY3BwOgorICAgICAgICAoSlNDOjpDb3BpZWRTcGFjZTo6 ZG9uZUNvcHlpbmcpOgorCiAyMDE0LTAyLTIwICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVy Z0BhcHBsZS5jb20+CiAKICAgICAgICAgRHluYW1pY2FsbHkgZ2VuZXJhdGVkIEpTRXhwb3J0IHBy b3RvY29scyBhZGRlZCB0byBhIGNsYXNzIHJlc3VsdHMgaW4gYSBjcmFzaApJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkQmxvY2suaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRCbG9jay5oCShyZXZpc2lvbiAxNjQ0NDApCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBA IC0xNDcsNiArMTQ3LDcgQEAgaW5saW5lIENvcGllZEJsb2NrOjpDb3BpZWRCbG9jayhSZWdpb24q IAogaW5saW5lIHZvaWQgQ29waWVkQmxvY2s6OmRpZFN1cnZpdmVHQygpCiB7CiAgICAgY2hlY2tD b25zaXN0ZW5jeSgpOworICAgIEFTU0VSVChpc09sZCgpKTsKICAgICBtX2xpdmVCeXRlcyA9IDA7 CiAjaWZuZGVmIE5ERUJVRwogICAgIG1fbGl2ZU9iamVjdHMgPSAwOwpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZFNwYWNlLmNwcAkocmV2aXNpb24gMTY0NDQwKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2UuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNTMsNiArMjUzLDcgQEAgdm9pZCBDb3BpZWRTcGFjZTo6ZG9uZUNvcHlpbmcoKQogICAg ICAgICAvLyBXZSBkb24ndCBhZGQgdGhlIGJsb2NrIHRvIHRoZSBibG9ja1NldCBiZWNhdXNlIGl0 IHdhcyBuZXZlciByZW1vdmVkLgogICAgICAgICBBU1NFUlQobV9ibG9ja1NldC5jb250YWlucyhi bG9jaykpOwogICAgICAgICBibG9ja0ZpbHRlci0+YWRkKHJlaW50ZXJwcmV0X2Nhc3Q8Qml0cz4o YmxvY2spKTsKKyAgICAgICAgYmxvY2stPmRpZFN1cnZpdmVHQygpOwogICAgICAgICB0b1NwYWNl LT5wdXNoKGJsb2NrKTsKICAgICB9CiAK