128648 2014-02-11 20:13:55 -0800 Fix assertions and incorrect codegen for CompareEq(ObjectOrOther:, Object:) 2014-02-11 20:19:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough commit-queue ggaren mark.lam mhahnenberg mmirman msaboff nrotem oliver sam oldest_to_newest 979743 0 fpizlo 2014-02-11 20:13:55 -0800 We did CompareEq(Object:, ObjectOrOther:) correctly but the flipped version wrong. 979744 1 223935 fpizlo 2014-02-11 20:15:26 -0800 Created attachment 223935 the patch 979745 2 223935 mark.lam 2014-02-11 20:17:20 -0800 Comment on attachment 223935 the patch r=me 979746 3 fpizlo 2014-02-11 20:18:25 -0800 I'll land! 979747 4 fpizlo 2014-02-11 20:19:56 -0800 Landed in http://trac.webkit.org/changeset/163938 223935 2014-02-11 20:15:26 -0800 2014-02-11 20:18:14 -0800 the patch blah.patch text/plain 1556 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzOTM3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTAyLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Rml4IGFzc2VydGlvbnMgYW5kIGluY29ycmVjdCBjb2RlZ2VuIGZvciBDb21wYXJlRXEoT2JqZWN0 T3JPdGhlcjosIE9iamVjdDopCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjg2NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KyAgICAgICAgCisgICAgICAgIEkgZGlkIENvbXBhcmVFcShPYmplY3Q6LCBPYmplY3RPck90aGVy OikgY29ycmVjdGx5IGJ1dCB0aGUgZmxpcHBlZCB2ZXJzaW9uIHdyb25nLgorICAgICAgICBUaGF0 J3Mgd2hhdCBJIGdldCBmb3IgcnVubmluZyB0ZXN0cyBpbiByZWxlYXNlIG1vZGUuIEl0J3MgaGFy ZCB0byB3cml0ZSBhIHRlc3QgZm9yCisgICAgICAgIHRoZSBpbmNvcnJlY3QgY29kZWdlbjsgdGhh dCdzIGtpbmQgb2Ygd2h5IHRoZSBhc3NlcnRpb25zIGFyZSB0aGVyZS4KKworICAgICAgICAqIGZ0 bC9GVExMb3dlckRGR1RvTExWTS5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xM Vk06OmNvbXBpbGVDb21wYXJlRXEpOgorCiAyMDE0LTAyLTExICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdHJpdmlhbCBjaGFuZ2UgdG8gc2ls ZW5jZSBGVEwgYXNzZXJ0aW9ucwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExM b3dlckRGR1RvTExWTS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0 bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHJldmlzaW9uIDE2MzkzNykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z MjE2LDcgKzMyMTYsNyBAQCBwcml2YXRlOgogICAgICAgICAKICAgICAgICAgaWYgKG1fbm9kZS0+ Y2hpbGQxKCkudXNlS2luZCgpID09IE9iamVjdE9yT3RoZXJVc2UKICAgICAgICAgICAgICYmIG1f bm9kZS0+Y2hpbGQyKCkudXNlS2luZCgpID09IE9iamVjdFVzZSkgewotICAgICAgICAgICAgY29t cGFyZUVxT2JqZWN0T3JPdGhlclRvT2JqZWN0KG1fbm9kZS0+Y2hpbGQyKCksIG1fbm9kZS0+Y2hp bGQxKCkpOworICAgICAgICAgICAgY29tcGFyZUVxT2JqZWN0T3JPdGhlclRvT2JqZWN0KG1fbm9k ZS0+Y2hpbGQxKCksIG1fbm9kZS0+Y2hpbGQyKCkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICB9CiAgICAgICAgIAo=