128621 2014-02-11 13:40:53 -0800 IDB: The test after storage/indexeddb/mozilla/object-identity.html fails in cleanup code 2014-02-11 14:56:22 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson alecflett commit-queue jsbell webkit-bug-importer oldest_to_newest 979582 0 beidson 2014-02-11 13:40:53 -0800 IDB: The test after storage/indexeddb/mozilla/object-identity.html fails in cleanup code Way to reproduce - run-webkit-tests -2 storage/indexeddb/mozilla/object-identity.html storage/indexeddb/mozilla/put-get-values.html The backtrace is: #0 0x0000000111f6be5c in WTF::Ref<WebCore::IDBServerConnection>::get() at /Volumes/Data/CabUser/build/Debug/usr/local/include/wtf/Ref.h:61 #1 0x0000000111f5e5fc in WebCore::IDBDatabaseBackend::serverConnection() at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.h:65 #2 0x0000000111f53d65 in WebCore::IDBTransactionBackend::commit()::$_3::operator()(bool) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp:245 #3 0x0000000111f53ce3 in bool&& std::__1::forward<bool>(std::__1::remove_reference<bool>::type&) [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/__functional_base:344 #4 0x0000000111f53cb3 in std::__1::__function::__func<WebCore::IDBTransactionBackend::commit()::$_3, std::__1::allocator<WebCore::IDBTransactionBackend::commit()::$_3>, void (bool)>::operator()(bool&&) at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/functional:1059 #5 0x000000010da2f3d1 in std::__1::function<void (bool)>::operator()(bool) const at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/functional:1435 #6 0x000000010e0aa33a in WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3::operator()() const at /Volumes/Data/git/OpenSource/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:220 #7 0x000000010e0aa30c in decltype(std::__1::forward<WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3&>(fp)(std::__1::forward<>(fp0))) std::__1::__invoke<WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3&>(WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3&&&) [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/__functional_base:344 #8 0x000000010e0aa2fb in std::__1::__function::__func<WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3, std::__1::allocator<WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3>, void ()>::operator()() at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/functional:1059 #9 0x000000010d9cc46a in std::__1::function<void ()>::operator()() const at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/functional:1435 #10 0x000000010e0d2df5 in WebKit::AsyncRequest::requestAborted() at /Volumes/Data/git/OpenSource/Source/WebKit2/Shared/AsyncRequest.cpp:60 #11 0x000000010e083ee8 in WebKit::WebIDBServerConnection::close() at /Volumes/Data/git/OpenSource/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:152 #12 0x00000001129c157c in WebCore::IDBDatabaseBackend::close(WTF::PassRefPtr<WebCore::IDBDatabaseCallbacks>) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.cpp:611 #13 0x00000001123131e7 in WebCore::IDBDatabase::closeConnection() at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:291 #14 0x0000000112312ce1 in WebCore::IDBDatabase::close() at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:283 #15 0x0000000112314819 in WebCore::IDBDatabase::stop() at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:360 #16 0x000000011231484c in _ZThn88_N7WebCore11IDBDatabase4stopEv at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:363 #17 0x00000001128ba3d6 in WebCore::ScriptExecutionContext::stopActiveDOMObjects() at /Volumes/Data/git/OpenSource/Source/WebCore/dom/ScriptExecutionContext.cpp:234 #18 0x0000000111488f45 in WebCore::Document::stopActiveDOMObjects() at /Volumes/Data/git/OpenSource/Source/WebCore/dom/Document.cpp:2135 #19 0x0000000111488d0c in WebCore::Document::prepareForDestruction() at /Volumes/Data/git/OpenSource/Source/WebCore/dom/Document.cpp:2059 #20 0x00000001117de736 in WebCore::Frame::setView(WTF::PassRefPtr<WebCore::FrameView>) at /Volumes/Data/git/OpenSource/Source/WebCore/page/Frame.cpp:270 #21 0x00000001117e0e37 in WebCore::Frame::createView(WebCore::IntSize const&, WebCore::Color const&, bool, WebCore::IntSize const&, WebCore::IntRect const&, bool, WebCore::ScrollbarMode, bool, WebCore::ScrollbarMode, bool) at /Volumes/Data/git/OpenSource/Source/WebCore/page/Frame.cpp:901 #22 0x000000010de2d45d in WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage() at /Volumes/Data/git/OpenSource/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1192 #23 0x00000001117f26e7 in WebCore::FrameLoader::transitionToCommitted(WebCore::CachedPage*) at /Volumes/Data/git/OpenSource/Source/WebCore/loader/FrameLoader.cpp:1955 #24 0x00000001117f19e0 in WebCore::FrameLoader::commitProvisionalLoad() at /Volumes/Data/git/OpenSource/Source/WebCore/loader/FrameLoader.cpp:1785 #25 0x00000001114d0e4c in WebCore::DocumentLoader::commitIfReady() at /Volumes/Data/git/OpenSource/Source/WebCore/loader/DocumentLoader.cpp:353 #26 0x00000001114d1212 in WebCore::DocumentLoader::finishedLoading(double) at /Volumes/Data/git/OpenSource/Source/WebCore/loader/DocumentLoader.cpp:427 #27 0x00000001114d5981 in WebCore::DocumentLoader::maybeLoadEmpty() at /Volumes/Data/git/OpenSource/Source/WebCore/loader/DocumentLoader.cpp:1383 #28 0x00000001114d5af2 in WebCore::DocumentLoader::startLoadingMainResource() at /Volumes/Data/git/OpenSource/Source/WebCore/loader/DocumentLoader.cpp:1395 The IDBDatabaseBackend in stack frame #1 is null 979584 1 webkit-bug-importer 2014-02-11 13:41:36 -0800 <rdar://problem/16040663> 979603 2 beidson 2014-02-11 14:14:41 -0800 After plugging that, there's a problem where IDBTransactionBackend::abort removes the transactionbackend from the databasebackend, then calls its own onAbort callback, which calls the database shutdown code, which calls back into the transaction to abort its commit request, which then tries to remove itself from the databasebackend *again* trigging an assert. #0 0x000000010db3502a in WTFCrash at /Volumes/Data/git/OpenSource/Source/WTF/wtf/Assertions.cpp:333 #1 0x0000000110660f8f in WebCore::IDBDatabaseBackend::transactionFinished(WebCore::IDBTransactionBackend*) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.cpp:331 #2 0x000000010fbf4d5c in WebCore::IDBTransactionBackend::commit()::$_3::operator()(bool) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp:259 #3 0x000000010fbf4bc3 in bool&& std::__1::forward<bool>(std::__1::remove_reference<bool>::type&) [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/__functional_base:344 #4 0x000000010fbf4b93 in std::__1::__function::__func<WebCore::IDBTransactionBackend::commit()::$_3, std::__1::allocator<WebCore::IDBTransactionBackend::commit()::$_3>, void (bool)>::operator()(bool&&) at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/functional:1059 #5 0x000000010b6d03d1 in std::__1::function<void (bool)>::operator()(bool) const at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/functional:1435 #6 0x000000010bd4b33a in WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3::operator()() const at /Volumes/Data/git/OpenSource/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:220 #7 0x000000010bd4b30c in decltype(std::__1::forward<WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3&>(fp)(std::__1::forward<>(fp0))) std::__1::__invoke<WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3&>(WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3&&&) [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/__functional_base:344 #8 0x000000010bd4b2fb in std::__1::__function::__func<WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3, std::__1::allocator<WebKit::WebIDBServerConnection::commitTransaction(long long, std::__1::function<void (bool)>)::$_3>, void ()>::operator()() at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/functional:1059 #9 0x000000010b66d46a in std::__1::function<void ()>::operator()() const at /Applications/Xcode.app/Contents/Developer/Toolchains/OSX10.9.xctoolchain/usr/bin/../lib/c++/v1/functional:1435 #10 0x000000010bd73df5 in WebKit::AsyncRequest::requestAborted() at /Volumes/Data/git/OpenSource/Source/WebKit2/Shared/AsyncRequest.cpp:60 #11 0x000000010bd24ee8 in WebKit::WebIDBServerConnection::close() at /Volumes/Data/git/OpenSource/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:152 #12 0x00000001106624fc in WebCore::IDBDatabaseBackend::close(WTF::PassRefPtr<WebCore::IDBDatabaseCallbacks>) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.cpp:613 #13 0x000000010ffb4147 in WebCore::IDBDatabase::closeConnection() at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:291 #14 0x000000010ffb4074 in WebCore::IDBDatabase::transactionFinished(WebCore::IDBTransaction*) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:112 #15 0x00000001100f416b in WebCore::IDBTransaction::onAbort(WTF::PassRefPtr<WebCore::IDBDatabaseError>) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:310 #16 0x000000010ffb4307 in WebCore::IDBDatabase::onAbort(long long, WTF::PassRefPtr<WebCore::IDBDatabaseError>) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:118 #17 0x000000010eea351f in WebCore::IDBDatabaseCallbacksImpl::onAbort(long long, WTF::PassRefPtr<WebCore::IDBDatabaseError>) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:71 #18 0x000000010fbed615 in WebCore::IDBTransactionBackend::abort(WTF::PassRefPtr<WebCore::IDBDatabaseError>) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp:162 #19 0x000000010fbed1b6 in WebCore::IDBTransactionBackend::abort() at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp:114 #20 0x00000001106601b9 in WebCore::IDBDatabaseBackend::abort(long long) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBDatabaseBackend.cpp:212 #21 0x00000001100f399f in WebCore::IDBTransaction::abort(int&) at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:222 #22 0x00000001100f4a27 in WebCore::IDBTransaction::stop() at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:411 #23 0x00000001100f4a4c in _ZThn88_N7WebCore14IDBTransaction4stopEv at /Volumes/Data/git/OpenSource/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:412 979608 3 beidson 2014-02-11 14:46:02 -0800 IDBTransactionBackend::abort simply needs to clear it's m_database pointer before possibly re-entering abort code. Patch is coming. 979610 4 223903 beidson 2014-02-11 14:49:03 -0800 Created attachment 223903 Patch v1 979617 5 beidson 2014-02-11 14:56:22 -0800 http://trac.webkit.org/changeset/163912 223903 2014-02-11 14:49:03 -0800 2014-02-11 14:49:48 -0800 Patch v1 patch text/plain 6359 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMzlmNDJlLi4wZjNmZDZhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTQtMDIt MTEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIElEQjogVGhl IHRlc3QgYWZ0ZXIgc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9vYmplY3QtaWRlbnRpdHkuaHRt bCBmYWlscyBpbiBjbGVhbnVwIGNvZGUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2MDQwNjYz PiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODYyMQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v bWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOiBFbmFibGVkIGFsbCBvZiB0aGUgc3RvcmFnZS9pbmRl eGVkZGIvbW96aWxsYSB0ZXN0cyBleGNlcHQgMS4KKworMjAxNC0wMi0xMSAgQnJhZHkgRWlkc29u ICA8YmVpZHNvbkBhcHBsZS5jb20+CisKICAgICAgICAgSW5kZXhlZERCIHRlc3RzIG9uIHNvbWUg Ym90cyBhcmUgZmxha2V5ICh0aW1lb3V0cykKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2MDM4 NzQ1PiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODYxMgog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlv bnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXgg YTM1NjEzMC4uNTcwYWQyMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdr Mi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVz dEV4cGVjdGF0aW9ucwpAQCAtNDcwLDIzICs0NzAsNDUgQEAgZmFzdC9mb3Jtcy9jb2xvci9pbnB1 dC1jb2xvci1vbmNoYW5nZS1ldmVudC5odG1sIFsgUGFzcyBdCiBmdWxsc2NyZWVuL2Fub255bW91 cy1ibG9jay1tZXJnZS1jcmFzaC5odG1sIFsgUGFzcyBdCiAKICMgQWxsIEluZGV4ZWREQiB0ZXN0 cyBhcmUgc2tpcHBlZCBpbiBXSzEuCi0jIFJlZW5hYmxlIGluZGl2aWR1YWwgdGVzdHMgaGVyZSB0 aGF0IGFyZSBrbm93biB0byBwYXNzLCB3aXRoIHRoZSBldmVudHVhbCBnb2FsIG9mIHJlLWVuYWJs aW5nIHRoZSBlbnRpcmUgZGlyZWN0b3J5LgotIyAoRXhjZXB0LCBza2lwIHRoZW0gZm9yIG5vdyBz aW5jZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MzQxIGlzIGdl dHRpbmcgaW4gdGhlIHdheSBvZiB0ZXN0aW5nIGluIGdlbmVyYWwpCisjIFVudGlsIHdlIGhhdmUg YSBXSzEgc3BlY2lmaWMgc2tpcHBlZCBmaWxlIHRoYXQgV0syIGRvZXNuJ3QgaW5oZXJpdCBmcm9t LAorIyB3ZSdsbCByZWVuYWJsZSBpbmRpdmlkdWFsIHRlc3RzIHRoYXQgYXJlIGtub3duIHRvIHBh c3MuCiBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2FkZC10d2ljZS1mYWlsdXJlLmh0bWwgWyBQ YXNzIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvYXV0b2luY3JlbWVudC1pbmRleGVzLmh0 bWwgWyBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvYmFkLWtleXBhdGguaHRtbCBb IFBhc3MgXQogc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jbGVhci5odG1sIFsgUGFzcyBdCitz dG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2NyZWF0ZS1pbmRleC11bmlxdWUuaHRtbCBbIFBhc3Mg XQogc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jcmVhdGUtaW5kZXgtd2l0aC1pbnRlZ2VyLWtl eXMuaHRtbCBbIFBhc3MgXQorc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jcmVhdGUtb2JqZWN0 c3RvcmUtYmFzaWNzLmh0bWwgWyBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvY3Jl YXRlLW9iamVjdHN0b3JlLW51bGwtbmFtZS5odG1sIFsgUGFzcyBdCiBzdG9yYWdlL2luZGV4ZWRk Yi9tb3ppbGxhL2N1cnNvci1tdXRhdGlvbi1vYmplY3RzdG9yZS1vbmx5Lmh0bWwgWyBQYXNzIF0K IHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvY3Vyc29yLW11dGF0aW9uLmh0bWwgWyBQYXNzIF0K IHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvY3Vyc29yLXVwZGF0ZS11cGRhdGVzLWluZGV4ZXMu aHRtbCBbIFBhc3MgXQogc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jdXJzb3JzLmh0bWwgWyBQ YXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvZGVsZXRlLXJlc3VsdC5odG1sIFsgUGFz cyBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2V2ZW50LXNvdXJjZS5odG1sIFsgUGFzcyBd CiBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2luZGV4LXByZXYtbm8tZHVwbGljYXRlLmh0bWwg WyBQYXNzIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvaW5kZXhlcy5odG1sIFsgUGFzcyBd CitzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2tleS1yZXF1aXJlbWVudHMtZGVsZXRlLW51bGwt a2V5Lmh0bWwgWyBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEva2V5LXJlcXVpcmVt ZW50cy1pbmxpbmUtYW5kLXBhc3NlZC5odG1sIFsgUGFzcyBdCitzdG9yYWdlL2luZGV4ZWRkYi9t b3ppbGxhL2tleS1yZXF1aXJlbWVudHMtcHV0LW5vLWtleS5odG1sIFsgUGFzcyBdCitzdG9yYWdl L2luZGV4ZWRkYi9tb3ppbGxhL2tleS1yZXF1aXJlbWVudHMtcHV0LW51bGwta2V5Lmh0bWwgWyBQ YXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEva2V5LXJlcXVpcmVtZW50cy5odG1sIFsg UGFzcyBdCiBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL29iamVjdC1jdXJzb3JzLmh0bWwgWyBQ YXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvb2JqZWN0LWlkZW50aXR5Lmh0bWwgWyBQ YXNzIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvb2JqZWN0LXN0b3JlLWlubGluZS1hdXRv aW5jcmVtZW50LWtleS1hZGRlZC1vbi1wdXQuaHRtbCBbIFBhc3MgXQogc3RvcmFnZS9pbmRleGVk ZGIvbW96aWxsYS9vYmplY3Qtc3RvcmUtcmVtb3ZlLXZhbHVlcy5odG1sIFsgUGFzcyBdCitzdG9y YWdlL2luZGV4ZWRkYi9tb3ppbGxhL29iamVjdHN0b3JlbmFtZXMuaHRtbCBbIFBhc3MgXQorc3Rv cmFnZS9pbmRleGVkZGIvbW96aWxsYS9vZGQtcmVzdWx0LW9yZGVyLmh0bWwgWyBQYXNzIF0KK3N0 b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvb3Blbi1kYXRhYmFzZS1udWxsLW5hbWUuaHRtbCBbIFBh c3MgXQorc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9wdXQtZ2V0LXZhbHVlcy5odG1sIFsgUGFz cyBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL3JlYWRvbmx5LXRyYW5zYWN0aW9ucy5odG1s IFsgUGFzcyBdCitzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL3JlYWR3cml0ZS10cmFuc2FjdGlv bnMuaHRtbCBbIFBhc3MgXQorc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9yZWFkeVN0YXRlLmh0 bWwgWyBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvcmVtb3ZlLWluZGV4Lmh0bWwg WyBQYXNzIF0KK3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvcmVtb3ZlLW9iamVjdHN0b3JlLmh0 bWwgWyBQYXNzIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvdmVyc2lvbmNoYW5nZS1hYm9y dC5odG1sIFsgUGFzcyBdCiAKKwogIyMjIEVORCBPRiAoNSkgRmVhdHVyZXMgdGhhdCBhcmUgbm90 IHN1cHBvcnRlZCBpbiBXZWJLaXQxLCBzbyBza2lwcGVkIGluIG1hYy9UZXN0RXhwZWN0YXRpb25z IHRoZW4gcmUtZW5hYmxlZCBoZXJlCiAjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkNzM4YTM2Li4xY2E2NzFmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTQtMDItMTEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29t PgorCisgICAgICAgIElEQjogVGhlIHRlc3QgYWZ0ZXIgc3RvcmFnZS9pbmRleGVkZGIvbW96aWxs YS9vYmplY3QtaWRlbnRpdHkuaHRtbCBmYWlscyBpbiBjbGVhbnVwIGNvZGUKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzE2MDQwNjYzPiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyODYyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENvdmVyZWQgYnkgc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9vYmplY3QtaWRl bnRpdHkuaHRtbC4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0aW9u QmFja2VuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJUcmFuc2FjdGlvbkJhY2tlbmQ6OmFi b3J0KTogQ2xlYXIgdGhlIG1fZGF0YWJhc2UgcG9pbnRlciBiZWZvcmUgY2FsbGluZyB0aGUgb25B Ym9ydCBjYWxsYmFjay4KKyAgICAgICAgKFdlYkNvcmU6OklEQlRyYW5zYWN0aW9uQmFja2VuZDo6 Y29tbWl0KTogRG9uJ3QgcnVuIHRoZSBhYm9ydCBjb2RlIGlmIHRoZXJlJ3Mgbm8gbV9kYXRhYmFz ZSBwb2ludGVyLgorCiAyMDE0LTAyLTExICBKYW1lcyBDcmFpZyAgPGpjcmFpZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQVg6IEFjY2Vzc2liaWxpdHkgTm9kZSBJbnNwZWN0 aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJUcmFu c2FjdGlvbkJhY2tlbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURC VHJhbnNhY3Rpb25CYWNrZW5kLmNwcAppbmRleCBkNTBkNjI5Li42OGQyY2E4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJUcmFuc2FjdGlvbkJhY2tlbmQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQlRyYW5zYWN0aW9u QmFja2VuZC5jcHAKQEAgLTE1OCwxMiArMTU4LDEyIEBAIHZvaWQgSURCVHJhbnNhY3Rpb25CYWNr ZW5kOjphYm9ydChQYXNzUmVmUHRyPElEQkRhdGFiYXNlRXJyb3I+IGVycm9yKQogICAgIEFTU0VS VCghbV9kYXRhYmFzZS0+dHJhbnNhY3Rpb25Db29yZGluYXRvcigpLT5pc0FjdGl2ZSh0aGlzKSk7 CiAgICAgbV9kYXRhYmFzZS0+dHJhbnNhY3Rpb25GaW5pc2hlZCh0aGlzKTsKIAorICAgIFJlZlB0 cjxJREJEYXRhYmFzZUJhY2tlbmQ+IGRhdGFiYXNlID0gbV9kYXRhYmFzZS5yZWxlYXNlKCk7CisK ICAgICBpZiAobV9jYWxsYmFja3MpCiAgICAgICAgIG1fY2FsbGJhY2tzLT5vbkFib3J0KGlkKCks IGVycm9yKTsKIAotICAgIG1fZGF0YWJhc2UtPnRyYW5zYWN0aW9uRmluaXNoZWRBbmRBYm9ydEZp cmVkKHRoaXMpOwotCi0gICAgbV9kYXRhYmFzZSA9IDA7CisgICAgZGF0YWJhc2UtPnRyYW5zYWN0 aW9uRmluaXNoZWRBbmRBYm9ydEZpcmVkKHRoaXMpOwogfQogCiBib29sIElEQlRyYW5zYWN0aW9u QmFja2VuZDo6aXNUYXNrUXVldWVFbXB0eSgpIGNvbnN0CkBAIC0yMzUsNiArMjM1LDE0IEBAIHZv aWQgSURCVHJhbnNhY3Rpb25CYWNrZW5kOjpjb21taXQoKQogICAgIGJvb2wgY29tbWl0dGVkID0g dW51c2VkOwogCiAgICAgbV9kYXRhYmFzZS0+c2VydmVyQ29ubmVjdGlvbigpLmNvbW1pdFRyYW5z YWN0aW9uKG1faWQsIFtiYWNrZW5kLCB0aGlzLCBjb21taXR0ZWQsIHVudXNlZF0oYm9vbCBzdWNj ZXNzKSBtdXRhYmxlIHsKKyAgICAgICAgLy8gVGhpcyBtaWdodCBiZSBjb21taXRUcmFuc2FjdGlv biByZXF1ZXN0IGFib3J0aW5nIGR1cmluZyBvciBhZnRlciBzeW5jaHJvbm91cyBJREJUcmFuc2Fj dGlvbkJhY2tlbmQ6OmFib3J0KCkgY2FsbC4KKyAgICAgICAgLy8gVGhpcyBjYW4gZWFzaWx5IGhh cHBlbiBpZiB0aGUgcGFnZSBpcyBuYXZpZ2F0ZWQgYmVmb3JlIGFsbCB0cmFuc2FjdGlvbnMgZmlu aXNoLgorICAgICAgICAvLyBJbiB0aGlzIGNhc2Ugd2UgaGF2ZSBubyBmdXJ0aGVyIGNsZWFudXAg YW5kIGRvbid0IG5lZWQgdG8gbWFrZSBhbnkgY2FsbGJhY2tzLgorICAgICAgICBpZiAoIW1fZGF0 YWJhc2UpIHsKKyAgICAgICAgICAgIEFTU0VSVCghc3VjY2Vzcyk7CisgICAgICAgICAgICByZXR1 cm47CisgICAgICAgIH0KKwogICAgICAgICBjb21taXR0ZWQgfD0gc3VjY2VzczsKIAogICAgICAg ICAvLyBCYWNraW5nIHN0b3JlIHJlc291cmNlcyAoaGVsZCB2aWEgY3Vyc29ycykgbXVzdCBiZSBy ZWxlYXNlZCBiZWZvcmUgc2NyaXB0IGNhbGxiYWNrcwo=