<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>128618</bug_id>
          
          <creation_ts>2014-02-11 13:22:29 -0800</creation_ts>
          <short_desc>check-for-webkit-framework-include-consistency script fails if header contains unicode</short_desc>
          <delta_ts>2014-02-11 14:07:49 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Anders Carlsson">andersca</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>mitz</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>979567</commentid>
    <comment_count>0</comment_count>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2014-02-11 13:22:29 -0800</bug_when>
    <thetext>If a header contains a unicode character (like – or “ or ” for example), check-for-webkit-framework-include-consistency fails :

../../Tools/Scripts/check-for-webkit-framework-include-consistency:93:in `match&apos;: invalid byte sequence in US-ASCII (ArgumentError)
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:93:in `block (2 levels) in verify_includes&apos;
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:92:in `each_line&apos;
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:92:in `block in verify_includes&apos;
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:91:in `open&apos;
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:91:in `verify_includes&apos;
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:105:in `block (2 levels) in &lt;main&gt;&apos;
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:104:in `each&apos;
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:104:in `block in &lt;main&gt;&apos;
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:102:in `each&apos;
	from ../../Tools/Scripts/check-for-webkit-framework-include-consistency:102:in `&lt;main&gt;&apos;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>