128597 2014-02-11 05:57:26 -0800 need to #include <libgen.h> for basename 2014-02-27 05:53:32 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128598 1 desrt webkit-unassigned berto cgarcia commit-queue landry oldest_to_newest 979375 0 223845 desrt 2014-02-11 05:57:26 -0800 Created attachment 223845 Be sure to #include <libgen.h> for basename Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp uses basename() but does not #include <libgen.h> according to POSIX, this is the correct header to use (and even the Linux manpages agree): http://pubs.opengroup.org/onlinepubs/007908775/xsh/libgen.h.html 981581 1 landry 2014-02-17 11:39:55 -0800 Same issue on OpenBSD, fixed by http://www.openbsd.org/cgi-bin/cvsweb/ports/www/webkit/patches/patch-Source_WebKit2_PluginProcess_unix_PluginProcessMainUnix_cpp?rev=1.1 Dunno if the #include has to be os-specific... 981586 2 desrt 2014-02-17 11:46:01 -0800 The header is POSIX-specified, so it should definitely not be made OS-specific. 983955 3 223845 ap 2014-02-24 11:06:57 -0800 Comment on attachment 223845 Be sure to #include <libgen.h> for basename Please add a ChangeLog, as described at <http://www.webkit.org/coding/contributing.html>. Either you or someone else has to make a ChangeLog entry for landing. 984028 4 225088 desrt 2014-02-24 13:20:26 -0800 Created attachment 225088 Patch 985104 5 berto 2014-02-27 05:05:57 -0800 (In reply to comment #4) > Created an attachment (id=225088) [details] > Patch Yeah, thinks looks good, thanks a lot! 985112 6 225359 desrt 2014-02-27 05:18:45 -0800 Created attachment 225359 Patch 985125 7 225359 commit-queue 2014-02-27 05:53:30 -0800 Comment on attachment 225359 Patch Clearing flags on attachment: 225359 Committed r164797: <http://trac.webkit.org/changeset/164797> 985126 8 commit-queue 2014-02-27 05:53:32 -0800 All reviewed patches have been landed. Closing bug. 223845 2014-02-11 05:57:26 -0800 2014-02-24 13:20:23 -0800 Be sure to #include <libgen.h> for basename 0003-Be-sure-to-include-libgen.h-for-basename.patch text/plain 827 desrt RnJvbSBhYmZmNmM0ZDI4YjJjZWY4ZDhkNDE2YjBiNjgxZDE1MzY0YWMyNjQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIExvcnRpZSA8ZGVzcnRAZGVzcnQuY2E+CkRhdGU6IFR1 ZSwgMTEgRmViIDIwMTQgMDg6NTQ6MDMgLTA1MDAKU3ViamVjdDogW1BBVENIIDMvNF0gQmUgc3Vy ZSB0byAjaW5jbHVkZSA8bGliZ2VuLmg+IGZvciBiYXNlbmFtZQoKVGhpcyBpcyB0aGUgY29ycmVj dCBoZWFkZXIgZmlsZSB0byBmaW5kIGJhc2VuYW1lKCksIHNvIG1ha2Ugc3VyZSB3ZQppbmNsdWRl IGl0LgotLS0KIFNvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvdW5peC9QbHVnaW5Qcm9jZXNz TWFpblVuaXguY3BwIHwgMiArKwogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvdW5peC9QbHVnaW5Qcm9jZXNz TWFpblVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblBy b2Nlc3NNYWluVW5peC5jcHAKaW5kZXggMDY3ZDVkMC4uNGRmOWQyOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nlc3NNYWluVW5peC5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nlc3NNYWlu VW5peC5jcHAKQEAgLTQ0LDYgKzQ0LDggQEAKICNpbmNsdWRlIDxFY29yZV9YLmg+CiAjZW5kaWYK IAorI2luY2x1ZGUgPGxpYmdlbi5oPgorCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFt ZXNwYWNlIFdlYktpdCB7Ci0tIAoxLjguNS4yCgo= 225088 2014-02-24 13:20:26 -0800 2014-02-27 05:18:41 -0800 Patch bug-128597-20140224162025.patch text/plain 1167 desrt U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODMzOTExNDA4MjAxMDlm MjljODU3NTRjMzY1MjdhY2M3MzFiYTJjOC4uZTE2MWZmY2Q1MjA2Y2ZkZDMyNzU2NDc0YzlmYjFl OTdiZDhiOWRhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAyLTI0ICBSeWFu IExvcnRpZSAgPGRlc3J0QGRlc3J0LmNhPgorCisgICAgICAgIG5lZWQgdG8gI2luY2x1ZGUgPGxp Ymdlbi5oPiBmb3IgYmFzZW5hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyODU5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nlc3NNYWluVW5peC5j cHA6IGluY2x1ZGUgPGxpYmdlbi5oPiBhcyByZXF1aXJlZCBieSBQT1NJWCBmb3IgYmFzZW5hbWUK KwogMjAxNC0wMi0yNCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSByZWR1bmRhbnQgc2V0dGluZyBpbiBGZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nl c3NNYWluVW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2lu UHJvY2Vzc01haW5Vbml4LmNwcAppbmRleCAwNjdkNWQwZjVmMzE0Y2IwMjlmMTYyZjY1ZDQ0NWY5 NTgyMmZmMmE0Li40ZGY5ZDI4MjIwMjUyNjFmYTM2OTE0ODZiNjcyMTExYzI2YzYwNjlmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2luUHJvY2Vzc01h aW5Vbml4LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2lu UHJvY2Vzc01haW5Vbml4LmNwcApAQCAtNDQsNiArNDQsOCBAQAogI2luY2x1ZGUgPEVjb3JlX1gu aD4KICNlbmRpZgogCisjaW5jbHVkZSA8bGliZ2VuLmg+CisKIHVzaW5nIG5hbWVzcGFjZSBXZWJD b3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsK 225359 2014-02-27 05:18:45 -0800 2014-02-27 05:53:30 -0800 Patch bug-128597-20140227081845.patch text/plain 1241 desrt U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODMzOTExNDA4MjAxMDlm MjljODU3NTRjMzY1MjdhY2M3MzFiYTJjOC4uZTE2MWZmY2Q1MjA2Y2ZkZDMyNzU2NDc0YzlmYjFl OTdiZDhiOWRhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAyLTI0ICBSeWFu IExvcnRpZSAgPGRlc3J0QGRlc3J0LmNhPgorCisgICAgICAgIG5lZWQgdG8gI2luY2x1ZGUgPGxp Ymdlbi5oPiBmb3IgYmFzZW5hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyODU5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nlc3NNYWluVW5peC5j cHA6IGluY2x1ZGUgPGxpYmdlbi5oPiBhcyByZXF1aXJlZCBieSBQT1NJWCBmb3IgYmFzZW5hbWUK KwogMjAxNC0wMi0yNCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSByZWR1bmRhbnQgc2V0dGluZyBpbiBGZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nl c3NNYWluVW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2lu UHJvY2Vzc01haW5Vbml4LmNwcAppbmRleCAwNjdkNWQwZjVmMzE0Y2IwMjlmMTYyZjY1ZDQ0NWY5 NTgyMmZmMmE0Li42YTRjMjZlZjJhOTRkOGMzY2RkNTcwODYzMTUxZmNmZjg2ODI0ZTAyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2luUHJvY2Vzc01h aW5Vbml4LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2lu UHJvY2Vzc01haW5Vbml4LmNwcApAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1ZGUgIk5ldHNjYXBl UGx1Z2luLmgiCiAjaW5jbHVkZSAiUGx1Z2luUHJvY2Vzcy5oIgogI2luY2x1ZGUgIldlYktpdDJJ bml0aWFsaXplLmgiCisjaW5jbHVkZSA8bGliZ2VuLmg+CiAjaW5jbHVkZSA8d3RmL1J1bkxvb3Au aD4KICNpZiBQTEFURk9STShHVEspCiAjaW5jbHVkZSA8Z3RrL2d0ay5oPgo=