128596 2014-02-11 05:29:18 -0800 'ar T' is not portable and breaks the build on FreeBSD 2014-02-17 12:23:15 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128598 1 desrt webkit-unassigned berto gustavo landry ryuan.choi sergio zan oldest_to_newest 979370 0 desrt 2014-02-11 05:29:18 -0800 Source/autotools/SetupLibtool.m4 has: if test -z "$AR_FLAGS"; then AR_FLAGS="cruT" fi AC_SUBST([AR_FLAGS]) GNU ar documents the 'T' flag like so: T Make the specified archive a thin archive. If it already exists and is a regular archive, the existing members must be present in the same directory as archive. FreeBSD ar documents the 'T' flag like so: -T Use only the first fifteen characters of the archive member name or command line file name argument when naming archive members. This fragment of Source/WebKit2/GNUmakefile.am: libWebCoreLayerGtk2.a: $(webcore_layer_gtk2_deps) $(AM_V_GEN) $(AM_V_at)$(shell rm -f $@) $(AM_V_at)$(shell find . -name "*.o" > objects_list) $(AM_V_at)$(foreach archive, $(webcore_layer_gtk2_archives), $(shell $(AR) t $(archive) | xargs -n1 basename | xargs -I obj_file grep -F obj_file objects_list | xargs -n50 $(AR) $(AR_FLAGS) $@)) $(AM_V_at)$(shell rm -f objects_list) results in a bunch of arguments like './Source/WebCore/platform/graphics/libPlatform_la-FloatRect.o' being passed to 'ar'. Of course, most of those arguments will share the same first 15 characters, and as a result, a large number of files are not included in the archive. Webkit should not use 'ar T' on systems with a non-GNU toolchain, or it should explicitly require a GNU toolchain and make sure it uses that. 979376 1 223846 desrt 2014-02-11 05:58:58 -0800 Created attachment 223846 SetupLibtool.m4: use 'ar T' only on GNU ar 979380 2 223848 berto 2014-02-11 06:16:38 -0800 Created attachment 223848 Patch The patch looks fine, here's the updated one with the changelog entry. Thanks! 979832 3 berto 2014-02-12 04:12:48 -0800 Committed r163954: <http://trac.webkit.org/changeset/163954> 981587 4 landry 2014-02-17 11:46:42 -0800 I know this has been fixed/commited, but as it was already sort-of fixed in https://bugs.webkit.org/show_bug.cgi?id=118732, couldnt you set AR_FLAGS=cru in the build environment to avoid having to patch autohell this way ? 981589 5 desrt 2014-02-17 11:52:07 -0800 I don't think it should be expected to have to set an environment variable to prevent it from containing non-POSIX values... If anything, it should be the other way around. I think having this check can make everyone happy. 981599 6 landry 2014-02-17 12:00:23 -0800 (In reply to comment #5) > I don't think it should be expected to have to set an environment variable to prevent it from containing non-POSIX values... > > If anything, it should be the other way around. > > I think having this check can make everyone happy. I totally agree (and i'm happy with the check for OpenBSD too!), was just wondering about the reasoning - usually it's not so easy to get non-linux fixes in :) 981616 7 berto 2014-02-17 12:23:15 -0800 (In reply to comment #6) > I totally agree (and i'm happy with the check for OpenBSD too!), was > just wondering about the reasoning - usually it's not so easy to get > non-linux fixes in :) The solution proposed by Ryan looked just fine to me. And I've been pushing non-linux fixes for a long time btw :) 223846 2014-02-11 05:58:58 -0800 2014-02-11 06:16:38 -0800 SetupLibtool.m4: use 'ar T' only on GNU ar 0004-SetupLibtool.m4-use-ar-T-only-on-GNU-ar.patch text/plain 907 desrt RnJvbSAxNjgyMzE2MmI5ZDA1NGZkY2QyNWQzMTg3N2I2Y2E4Y2JkZjExYTE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSeWFuIExvcnRpZSA8ZGVzcnRAZGVzcnQuY2E+CkRhdGU6IFR1 ZSwgMTEgRmViIDIwMTQgMDg6NTY6MTcgLTA1MDAKU3ViamVjdDogW1BBVENIIDQvNF0gU2V0dXBM aWJ0b29sLm00OiB1c2UgJ2FyIFQnIG9ubHkgb24gR05VIGFyCgonYXIgVCcgaXMgYSBHTlUgZXh0 ZW5zaW9uIGFuZCAtVCBtZWFucyBzb21ldGhpbmcgZW50aXJlbHkgZGlmZmVyZW50IG9uCkJTRCwg c28gbWFrZSBzdXJlIG91ciAnYXInIGlzIEdOVSBhci4KLS0tCiBTb3VyY2UvYXV0b3Rvb2xzL1Nl dHVwTGlidG9vbC5tNCB8IDYgKysrKystCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL2F1dG90b29scy9TZXR1cExpYnRv b2wubTQgYi9Tb3VyY2UvYXV0b3Rvb2xzL1NldHVwTGlidG9vbC5tNAppbmRleCAxYzhmZWIwLi4w NTU0NWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvYXV0b3Rvb2xzL1NldHVwTGlidG9vbC5tNAorKysg Yi9Tb3VyY2UvYXV0b3Rvb2xzL1NldHVwTGlidG9vbC5tNApAQCAtNiw3ICs2LDExIEBAIEFDX1NV QlNUKFtMSUJKQVZBU0NSSVBUQ09SRUdUS19WRVJTSU9OXSkKIEFDX1NVQlNUKFtMSUJXRUJLSVQy R1RLX1ZFUlNJT05dKQogCiBpZiB0ZXN0IC16ICIkQVJfRkxBR1MiOyB0aGVuCi0gICAgQVJfRkxB R1M9ImNydVQiCisgICAgaWYgIiR7QVI6LWFyfSIgLVYgfCBncmVwIC1xICdHTlUgYXInOyB0aGVu CisgICAgICAgIEFSX0ZMQUdTPSJjcnVUIgorICAgIGVsc2UKKyAgICAgICAgQVJfRkxBR1M9ImNy dSIKKyAgICBmaQogZmkKIEFDX1NVQlNUKFtBUl9GTEFHU10pCiAKLS0gCjEuOC41LjIKCg== 223848 2014-02-11 06:16:38 -0800 2014-02-12 04:08:28 -0800 Patch 128596.diff text/plain 1022 berto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwYmEzNjE0Li5hMGM2YTA2 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTQtMDItMTEgIFJ5YW4gTG9ydGllICA8ZGVzcnRAZGVzcnQuY2E+CisKKyAgICAgICAgJ2Fy IFQnIGlzIG5vdCBwb3J0YWJsZSBhbmQgYnJlYWtzIHRoZSBidWlsZCBvbiBGcmVlQlNECisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg1OTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDcmVhdGUgdGhpbiBh cmNoaXZlcyBvbmx5IGlmIHdlIGFyZSB1c2luZyBHTlUgYXIuCisKKyAgICAgICAgKiBTb3VyY2Uv YXV0b3Rvb2xzL1NldHVwTGlidG9vbC5tNDoKKwogMjAxNC0wMi0xMCAgS3J6eXN6dG9mIFdvbGFu c2tpICA8ay53b2xhbnNraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBBZGQgdGhlIENTU19TSEFQ RV9JTlNJREUgdG8gQ01ha2UgZmVhdHVyZSBsaXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rv b2xzL1NldHVwTGlidG9vbC5tNCBiL1NvdXJjZS9hdXRvdG9vbHMvU2V0dXBMaWJ0b29sLm00Cmlu ZGV4IDFjOGZlYjAuLjA1NTQ1Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9hdXRvdG9vbHMvU2V0dXBM aWJ0b29sLm00CisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvU2V0dXBMaWJ0b29sLm00CkBAIC02LDcg KzYsMTEgQEAgQUNfU1VCU1QoW0xJQkpBVkFTQ1JJUFRDT1JFR1RLX1ZFUlNJT05dKQogQUNfU1VC U1QoW0xJQldFQktJVDJHVEtfVkVSU0lPTl0pCiAKIGlmIHRlc3QgLXogIiRBUl9GTEFHUyI7IHRo ZW4KLSAgICBBUl9GTEFHUz0iY3J1VCIKKyAgICBpZiAiJHtBUjotYXJ9IiAtViB8IGdyZXAgLXEg J0dOVSBhcic7IHRoZW4KKyAgICAgICAgQVJfRkxBR1M9ImNydVQiCisgICAgZWxzZQorICAgICAg ICBBUl9GTEFHUz0iY3J1IgorICAgIGZpCiBmaQogQUNfU1VCU1QoW0FSX0ZMQUdTXSkKIAo=