128591 2014-02-11 02:27:31 -0800 [GTK] [Stable] Facebook images crash webkit 2014-02-18 03:50:35 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned cgarcia ossy oldest_to_newest 979348 0 berto 2014-02-11 02:27:31 -0800 I can reproduce this with 2.2.4, but it does not happen in trunk. This happens with any image from Facebook, here's one example that does not require an account: - Open https://www.facebook.com/thebeatles‎ - Click on the cover photo or the small photo with the logo. - The photo will open, with the comments, likes, etc, on a column on the right side. - Put the cursor on the center of the image and move it around a bit. 979371 1 223843 berto 2014-02-11 05:29:46 -0800 Created attachment 223843 Patch I think I found it, this was fixed in r155730 (bug 121330). I'm testing it and it seems to work fine so far, so it's another good candidate for the 2.2.x branch. 979373 2 cgarcia 2014-02-11 05:49:59 -0800 (In reply to comment #1) > Created an attachment (id=223843) [details] > Patch > > I think I found it, this was fixed in r155730 (bug 121330). > > I'm testing it and it seems to work fine so far, so it's another good candidate for the 2.2.x branch. Please, update the wiki 981875 3 cgarcia 2014-02-18 03:50:35 -0800 Merged in the stable branch. Thanks 223843 2014-02-11 05:29:46 -0800 2014-02-11 05:29:46 -0800 Patch 128591.diff text/plain 6362 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKaW5kZXggNDdh NjU5Mi4uMDg0M2UxNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L0NvZGVCbG9jay5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVC bG9jay5jcHAKQEAgLTEzOSw2ICsxMzksOCBAQCB2b2lkIENvZGVCbG9jazo6ZHVtcEFzc3VtaW5n SklUVHlwZShQcmludFN0cmVhbSYgb3V0LCBKSVRDb2RlOjpKSVRUeXBlIGppdFR5cGUpCiAgICAg ICAgIG91dC5wcmludCgiIChTQUJJKSIpOwogICAgIGlmIChvd25lckV4ZWN1dGFibGUoKS0+bmV2 ZXJJbmxpbmUoKSkKICAgICAgICAgb3V0LnByaW50KCIgKE5ldmVySW5saW5lKSIpOworICAgIGlm IChvd25lckV4ZWN1dGFibGUoKS0+aXNTdHJpY3RNb2RlKCkpCisgICAgICAgIG91dC5wcmludCgi IChTdHJpY3RNb2RlKSIpOwogICAgIG91dC5wcmludCgiXSIpOwogfQogCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZU9yaWdpbi5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZU9yaWdpbi5jcHAKaW5kZXggNTJhOTQ4My4uOTIzOWUw MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVPcmlnaW4u Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlT3JpZ2luLmNwcApA QCAtMTEwLDcgKzExMCwxMCBAQCB2b2lkIElubGluZUNhbGxGcmFtZTo6ZHVtcEJyaWVmRnVuY3Rp b25JbmZvcm1hdGlvbihQcmludFN0cmVhbSYgb3V0KSBjb25zdAogCiB2b2lkIElubGluZUNhbGxG cmFtZTo6ZHVtcEluQ29udGV4dChQcmludFN0cmVhbSYgb3V0LCBEdW1wQ29udGV4dCogY29udGV4 dCkgY29uc3QKIHsKLSAgICBvdXQucHJpbnQoYnJpZWZGdW5jdGlvbkluZm9ybWF0aW9uKCksICI6 PCIsIFJhd1BvaW50ZXIoZXhlY3V0YWJsZS5nZXQoKSksICIsIGJjIyIsIGNhbGxlci5ieXRlY29k ZUluZGV4LCAiLCAiLCBzcGVjaWFsaXphdGlvbktpbmQoKSk7CisgICAgb3V0LnByaW50KGJyaWVm RnVuY3Rpb25JbmZvcm1hdGlvbigpLCAiOjwiLCBSYXdQb2ludGVyKGV4ZWN1dGFibGUuZ2V0KCkp KTsKKyAgICBpZiAoZXhlY3V0YWJsZS0+aXNTdHJpY3RNb2RlKCkpCisgICAgICAgIG91dC5wcmlu dCgiIChTdHJpY3RNb2RlKSIpOworICAgIG91dC5wcmludCgiLCBiYyMiLCBjYWxsZXIuYnl0ZWNv ZGVJbmRleCwgIiwgIiwgc3BlY2lhbGl6YXRpb25LaW5kKCkpOwogICAgIGlmIChjYWxsZWUpCiAg ICAgICAgIG91dC5wcmludCgiLCBrbm93biBjYWxsZWU6ICIsIGluQ29udGV4dChKU1ZhbHVlKGNh bGxlZS5nZXQoKSksIGNvbnRleHQpKTsKICAgICBlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmggYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgKaW5kZXgg NmFkZGI2MC4uN2NkMDg0YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdBYnN0cmFjdEludGVycHJldGVySW5saW5lcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaApAQCAtMTA0NCw4ICsxMDQ0LDEy IEBAIGJvb2wgQWJzdHJhY3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRlVHlwZT46OmV4ZWN1dGVF ZmZlY3RzKHVuc2lnbmVkIGNsb2JiZXJMaW1pCiAgICAgICAgIEFic3RyYWN0VmFsdWUmIHNvdXJj ZSA9IGZvck5vZGUobm9kZS0+Y2hpbGQxKCkpOwogICAgICAgICBBYnN0cmFjdFZhbHVlJiBkZXN0 aW5hdGlvbiA9IGZvck5vZGUobm9kZSk7CiAgICAgICAgICAgICAKLSAgICAgICAgZGVzdGluYXRp b24gPSBzb3VyY2U7Ci0gICAgICAgIGRlc3RpbmF0aW9uLm1lcmdlKFNwZWNPYmplY3QpOworICAg ICAgICBpZiAobV9ncmFwaC5leGVjdXRhYmxlRm9yKG5vZGUtPmNvZGVPcmlnaW4pLT5pc1N0cmlj dE1vZGUoKSkKKyAgICAgICAgICAgIGRlc3RpbmF0aW9uLm1ha2VIZWFwVG9wKCk7CisgICAgICAg IGVsc2UgeworICAgICAgICAgICAgZGVzdGluYXRpb24gPSBzb3VyY2U7CisgICAgICAgICAgICBk ZXN0aW5hdGlvbi5tZXJnZShTcGVjT2JqZWN0KTsKKyAgICAgICAgfQogICAgICAgICBicmVhazsK ICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0 aW9ucy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCmlu ZGV4IGM0YTlhZmMuLjEyMDlkYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHT3BlcmF0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdP cGVyYXRpb25zLmNwcApAQCAtNDcxLDcgKzQ3MSwxNSBAQCBFbmNvZGVkSlNWYWx1ZSBERkdfT1BF UkFUSU9OIG9wZXJhdGlvblRvVGhpcyhFeGVjU3RhdGUqIGV4ZWMsIEVuY29kZWRKU1ZhbHVlIGVu YwogICAgIFZNKiB2bSA9ICZleGVjLT52bSgpOwogICAgIE5hdGl2ZUNhbGxGcmFtZVRyYWNlciB0 cmFjZXIodm0sIGV4ZWMpOwogCi0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShKU1ZhbHVlOjpk ZWNvZGUoZW5jb2RlZE9wKS50b1RoaXMoZXhlYywgZXhlYy0+Y29kZUJsb2NrKCktPmlzU3RyaWN0 TW9kZSgpID8gU3RyaWN0TW9kZSA6IE5vdFN0cmljdE1vZGUpKTsKKyAgICByZXR1cm4gSlNWYWx1 ZTo6ZW5jb2RlKEpTVmFsdWU6OmRlY29kZShlbmNvZGVkT3ApLnRvVGhpcyhleGVjLCBOb3RTdHJp Y3RNb2RlKSk7Cit9CisKK0VuY29kZWRKU1ZhbHVlIERGR19PUEVSQVRJT04gb3BlcmF0aW9uVG9U aGlzU3RyaWN0KEV4ZWNTdGF0ZSogZXhlYywgRW5jb2RlZEpTVmFsdWUgZW5jb2RlZE9wKQorewor ICAgIFZNKiB2bSA9ICZleGVjLT52bSgpOworICAgIE5hdGl2ZUNhbGxGcmFtZVRyYWNlciB0cmFj ZXIodm0sIGV4ZWMpOworCisgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShKU1ZhbHVlOjpkZWNv ZGUoZW5jb2RlZE9wKS50b1RoaXMoZXhlYywgU3RyaWN0TW9kZSkpOwogfQogCiBKU0NlbGwqIERG R19PUEVSQVRJT04gb3BlcmF0aW9uQ3JlYXRlVGhpcyhFeGVjU3RhdGUqIGV4ZWMsIEpTT2JqZWN0 KiBjb25zdHJ1Y3RvciwgaW50MzJfdCBpbmxpbmVDYXBhY2l0eSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdPcGVyYXRpb25zLmgKaW5kZXggODg2Njg2NC4uZjA3YTYxYSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmgKQEAgLTEzNiw2ICsxMzYsNyBAQCBK U0NlbGwqIERGR19PUEVSQVRJT04gb3BlcmF0aW9uU3RyaW5nRnJvbUNoYXJDb2RlKEV4ZWNTdGF0 ZSosIGludDMyX3QpICBXVEZfSU5URQogSlNDZWxsKiBERkdfT1BFUkFUSU9OIG9wZXJhdGlvbk5l d09iamVjdChFeGVjU3RhdGUqLCBTdHJ1Y3R1cmUqKSBXVEZfSU5URVJOQUw7CiBKU0NlbGwqIERG R19PUEVSQVRJT04gb3BlcmF0aW9uQ3JlYXRlVGhpcyhFeGVjU3RhdGUqLCBKU09iamVjdCogY29u c3RydWN0b3IsIGludDMyX3QgaW5saW5lQ2FwYWNpdHkpIFdURl9JTlRFUk5BTDsKIEVuY29kZWRK U1ZhbHVlIERGR19PUEVSQVRJT04gb3BlcmF0aW9uVG9UaGlzKEV4ZWNTdGF0ZSosIEVuY29kZWRK U1ZhbHVlIGVuY29kZWRPcDEpIFdURl9JTlRFUk5BTDsKK0VuY29kZWRKU1ZhbHVlIERGR19PUEVS QVRJT04gb3BlcmF0aW9uVG9UaGlzU3RyaWN0KEV4ZWNTdGF0ZSosIEVuY29kZWRKU1ZhbHVlIGVu Y29kZWRPcDEpIFdURl9JTlRFUk5BTDsKIEVuY29kZWRKU1ZhbHVlIERGR19PUEVSQVRJT04gb3Bl cmF0aW9uVmFsdWVBZGQoRXhlY1N0YXRlKiwgRW5jb2RlZEpTVmFsdWUgZW5jb2RlZE9wMSwgRW5j b2RlZEpTVmFsdWUgZW5jb2RlZE9wMikgV1RGX0lOVEVSTkFMOwogRW5jb2RlZEpTVmFsdWUgREZH X09QRVJBVElPTiBvcGVyYXRpb25WYWx1ZUFkZE5vdE51bWJlcihFeGVjU3RhdGUqLCBFbmNvZGVk SlNWYWx1ZSBlbmNvZGVkT3AxLCBFbmNvZGVkSlNWYWx1ZSBlbmNvZGVkT3AyKSBXVEZfSU5URVJO QUw7CiBFbmNvZGVkSlNWYWx1ZSBERkdfT1BFUkFUSU9OIG9wZXJhdGlvbkdldEJ5VmFsKEV4ZWNT dGF0ZSosIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRCYXNlLCBFbmNvZGVkSlNWYWx1ZSBlbmNvZGVk UHJvcGVydHkpIFdURl9JTlRFUk5BTDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCmluZGV4IDZjY2FhNzEuLjVmZWFlZTMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82 NC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMy XzY0LmNwcApAQCAtMzYxMSw5ICszNjExLDE0IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBp bGUoTm9kZSogbm9kZSkKICAgICAgICAgICAgIFRydXN0ZWRJbW0zMihGaW5hbE9iamVjdFR5cGUp KSk7CiAgICAgICAgIG1faml0Lm1vdmUodGhpc1ZhbHVlUGF5bG9hZEdQUiwgdGVtcEdQUik7CiAg ICAgICAgIG1faml0Lm1vdmUodGhpc1ZhbHVlVGFnR1BSLCB0ZW1wVGFnR1BSKTsKKyAgICAgICAg Sl9ERkdPcGVyYXRpb25fRUogZnVuY3Rpb247CisgICAgICAgIGlmIChtX2ppdC5ncmFwaCgpLmV4 ZWN1dGFibGVGb3Iobm9kZS0+Y29kZU9yaWdpbiktPmlzU3RyaWN0TW9kZSgpKQorICAgICAgICAg ICAgZnVuY3Rpb24gPSBvcGVyYXRpb25Ub1RoaXNTdHJpY3Q7CisgICAgICAgIGVsc2UKKyAgICAg ICAgICAgIGZ1bmN0aW9uID0gb3BlcmF0aW9uVG9UaGlzOwogICAgICAgICBhZGRTbG93UGF0aEdl bmVyYXRvcigKICAgICAgICAgICAgIHNsb3dQYXRoQ2FsbCgKLSAgICAgICAgICAgICAgICBzbG93 Q2FzZXMsIHRoaXMsIG9wZXJhdGlvblRvVGhpcywKKyAgICAgICAgICAgICAgICBzbG93Q2FzZXMs IHRoaXMsIGZ1bmN0aW9uLAogICAgICAgICAgICAgICAgIEpTVmFsdWVSZWdzKHRlbXBUYWdHUFIs IHRlbXBHUFIpLCB0aGlzVmFsdWVUYWdHUFIsIHRoaXNWYWx1ZVBheWxvYWRHUFIpKTsKIAogICAg ICAgICBqc1ZhbHVlUmVzdWx0KHRlbXBUYWdHUFIsIHRlbXBHUFIsIG5vZGUpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKaW5kZXggNDMw Nzg4Ni4uN2NlNTViYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdT cGVjdWxhdGl2ZUpJVDY0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklUNjQuY3BwCkBAIC0zNTE1LDggKzM1MTUsMTMgQEAgdm9pZCBTcGVjdWxhdGl2 ZUpJVDo6Y29tcGlsZShOb2RlKiBub2RlKQogICAgICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6OkFk ZHJlc3ModGVtcEdQUiwgU3RydWN0dXJlOjp0eXBlSW5mb1R5cGVPZmZzZXQoKSksCiAgICAgICAg ICAgICBUcnVzdGVkSW1tMzIoRmluYWxPYmplY3RUeXBlKSkpOwogICAgICAgICBtX2ppdC5tb3Zl KHRoaXNWYWx1ZUdQUiwgdGVtcEdQUik7CisgICAgICAgIEpfREZHT3BlcmF0aW9uX0VKIGZ1bmN0 aW9uOworICAgICAgICBpZiAobV9qaXQuZ3JhcGgoKS5leGVjdXRhYmxlRm9yKG5vZGUtPmNvZGVP cmlnaW4pLT5pc1N0cmljdE1vZGUoKSkKKyAgICAgICAgICAgIGZ1bmN0aW9uID0gb3BlcmF0aW9u VG9UaGlzU3RyaWN0OworICAgICAgICBlbHNlCisgICAgICAgICAgICBmdW5jdGlvbiA9IG9wZXJh dGlvblRvVGhpczsKICAgICAgICAgYWRkU2xvd1BhdGhHZW5lcmF0b3IoCi0gICAgICAgICAgICBz bG93UGF0aENhbGwoc2xvd0Nhc2VzLCB0aGlzLCBvcGVyYXRpb25Ub1RoaXMsIHRlbXBHUFIsIHRo aXNWYWx1ZUdQUikpOworICAgICAgICAgICAgc2xvd1BhdGhDYWxsKHNsb3dDYXNlcywgdGhpcywg ZnVuY3Rpb24sIHRlbXBHUFIsIHRoaXNWYWx1ZUdQUikpOwogCiAgICAgICAgIGpzVmFsdWVSZXN1 bHQodGVtcEdQUiwgbm9kZSk7CiAgICAgICAgIGJyZWFrOwo=