128581 2014-02-10 22:20:33 -0800 IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs 2014-02-11 08:22:48 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson andersca ap commit-queue sam thorton webkit-bug-importer oldest_to_newest 979278 0 beidson 2014-02-10 22:20:33 -0800 IDB: storage/indexeddb/mozilla/cursor-update-updates-indexes.html ASSERTs Index gets don't return the key path, triggering this assert. Simple fix. 979279 1 webkit-bug-importer 2014-02-10 22:21:07 -0800 <rdar://problem/16034112> 979286 2 223811 beidson 2014-02-10 22:36:58 -0800 Created attachment 223811 Patch v1 979293 3 223811 ap 2014-02-10 23:00:41 -0800 Comment on attachment 223811 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=223811&action=review > Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:936 > + // We must return it to know how to inject the result key into the result value object. s/it/a key path/ 979404 4 223862 beidson 2014-02-11 07:44:16 -0800 Created attachment 223862 Patch for landing 979419 5 223862 commit-queue 2014-02-11 08:22:45 -0800 Comment on attachment 223862 Patch for landing Clearing flags on attachment: 223862 Committed r163877: <http://trac.webkit.org/changeset/163877> 979420 6 commit-queue 2014-02-11 08:22:48 -0800 All reviewed patches have been landed. Closing bug. 223811 2014-02-10 22:36:58 -0800 2014-02-11 07:44:16 -0800 Patch v1 patch text/plain 3645 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxNjNiYTU2Li4zNGUyMzU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTQtMDIt MTAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIElEQjogc3Rv cmFnZS9pbmRleGVkZGIvbW96aWxsYS9jdXJzb3ItdXBkYXRlLXVwZGF0ZXMtaW5kZXhlcy5odG1s IEFTU0VSVHMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2MDM0MTEyPiBhbmQgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODU4MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhw ZWN0YXRpb25zOiBFbmFibGUgdGhlIHRlc3QuCisKKzIwMTQtMDItMTAgIEJyYWR5IEVpZHNvbiAg PGJlaWRzb25AYXBwbGUuY29tPgorCiAgICAgICAgIEluZGV4ZWREQiBhc3NlcnRpb24gYXQgSURC VHJhbnNhY3Rpb25CYWNrZW5kOjp+SURCVHJhbnNhY3Rpb25CYWNrZW5kKCkKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODM0MQogCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNjdjM2ZhMC4uYmEw ZGQ4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9u cwpAQCAtNDcxLDEzICs0NzEsMTMgQEAgZnVsbHNjcmVlbi9hbm9ueW1vdXMtYmxvY2stbWVyZ2Ut Y3Jhc2guaHRtbCBbIFBhc3MgXQogCiAjIEFsbCBJbmRleGVkREIgdGVzdHMgYXJlIHNraXBwZWQg aW4gV0sxLgogIyBSZWVuYWJsZSBpbmRpdmlkdWFsIHRlc3RzIGhlcmUgdGhhdCBhcmUga25vd24g dG8gcGFzcywgd2l0aCB0aGUgZXZlbnR1YWwgZ29hbCBvZiByZS1lbmFibGluZyB0aGUgZW50aXJl IGRpcmVjdG9yeS4KLSMgKEV4Y2VwdCwgc2tpcCB0aGVtIGZvciBub3cgc2luY2UgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODM0MSBpcyBnZXR0aW5nIGluIHRoZSB3 YXkgb2YgdGVzdGluZyBpbiBnZW5lcmFsKQogc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9hZGQt dHdpY2UtZmFpbHVyZS5odG1sIFsgUGFzcyBdCiBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2F1 dG9pbmNyZW1lbnQtaW5kZXhlcy5odG1sIFsgUGFzcyBdCiBzdG9yYWdlL2luZGV4ZWRkYi9tb3pp bGxhL2NsZWFyLmh0bWwgWyBQYXNzIF0KIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEvY3JlYXRl LWluZGV4LXdpdGgtaW50ZWdlci1rZXlzLmh0bWwgWyBQYXNzIF0KIHN0b3JhZ2UvaW5kZXhlZGRi L21vemlsbGEvY3Vyc29yLW11dGF0aW9uLW9iamVjdHN0b3JlLW9ubHkuaHRtbCBbIFBhc3MgXQog c3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jdXJzb3ItbXV0YXRpb24uaHRtbCBbIFBhc3MgXQor c3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jdXJzb3ItdXBkYXRlLXVwZGF0ZXMtaW5kZXhlcy5o dG1sIFsgUGFzcyBdCiBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2N1cnNvcnMuaHRtbCBbIFBh c3MgXQogc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9pbmRleC1wcmV2LW5vLWR1cGxpY2F0ZS5o dG1sIFsgUGFzcyBdCiBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2luZGV4ZXMuaHRtbCBbIFBh c3MgXQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCmluZGV4IGJiYzUxODUuLjljNDg0MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMyBAQAorMjAxNC0wMi0xMCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisK KyAgICAgICAgSURCOiBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2N1cnNvci11cGRhdGUtdXBk YXRlcy1pbmRleGVzLmh0bWwgQVNTRVJUcworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTYwMzQx MTI+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NTgxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEYXRhYmFz ZVByb2Nlc3MvSW5kZXhlZERCL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYktp dDo6VW5pcXVlSURCRGF0YWJhc2U6OmdldFJlY29yZEZyb21CYWNraW5nU3RvcmUpOiBBbHdheXMg c3RvcmUga2V5UGF0aCBmb3IgSW5kZXggZ2V0IHJlc3VsdHMuCisKIDIwMTQtMDItMTAgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGhvb2tzIGZvciB3 cmFwcGluZyBDcnlwdG9LZXlzIGluIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9VbmlxdWVJREJEYXRhYmFz ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL1VuaXF1ZUlE QkRhdGFiYXNlLmNwcAppbmRleCA3ZmJhYzdiLi5kODM5ZjYwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL1VuaXF1ZUlEQkRh dGFiYXNlLmNwcApAQCAtOTMzLDEwICs5MzMsOCBAQCB2b2lkIFVuaXF1ZUlEQkRhdGFiYXNlOjpn ZXRSZWNvcmRGcm9tQmFja2luZ1N0b3JlKHVpbnQ2NF90IHJlcXVlc3RJRCwgY29uc3QgSURCSQog ICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgLy8gQSBnZXQgcmVxdWVzdCB0aGF0IG1lZXRz IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBuZWVkcyB0byBrbm93IHRoZSBvYmplY3Qgc3RvcmUg a2V5cGF0aAotICAgIC8vIHRvIGluamVjdCB0aGUgcmVzdWx0IGtleSBpbnRvIHRoZSByZXN1bHQg dmFsdWUgb2JqZWN0LgotICAgIGlmIChvYmplY3RTdG9yZU1ldGFkYXRhLmF1dG9JbmNyZW1lbnQg JiYgIW9iamVjdFN0b3JlTWV0YWRhdGEua2V5UGF0aC5pc051bGwoKSkKLSAgICAgICAgcmVzdWx0 LmtleVBhdGggPSBvYmplY3RTdG9yZU1ldGFkYXRhLmtleVBhdGg7CisgICAgLy8gV2UgbXVzdCBy ZXR1cm4gaXQgdG8ga25vdyBob3cgdG8gaW5qZWN0IHRoZSByZXN1bHQga2V5IGludG8gdGhlIHJl c3VsdCB2YWx1ZSBvYmplY3QuCisgICAgcmVzdWx0LmtleVBhdGggPSBvYmplY3RTdG9yZU1ldGFk YXRhLmtleVBhdGg7CiAKICAgICBwb3N0TWFpblRocmVhZFRhc2soY3JlYXRlQXN5bmNUYXNrKCp0 aGlzLCAmVW5pcXVlSURCRGF0YWJhc2U6OmRpZEdldFJlY29yZEZyb21CYWNraW5nU3RvcmUsIHJl cXVlc3RJRCwgcmVzdWx0LCAwLCBTdHJpbmcoU3RyaW5nSW1wbDo6ZW1wdHkoKSkpKTsKIH0K 223862 2014-02-11 07:44:16 -0800 2014-02-11 08:22:45 -0800 Patch for landing patch text/plain 3124 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhZjI1YzM4Li45Yzc0OTYyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDIt MTEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIElEQjogc3Rv cmFnZS9pbmRleGVkZGIvbW96aWxsYS9jdXJzb3ItdXBkYXRlLXVwZGF0ZXMtaW5kZXhlcy5odG1s IEFTU0VSVHMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2MDM0MTEyPiBhbmQgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODU4MQorCisgICAgICAgIFJldmlld2Vk IGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL1Rl c3RFeHBlY3RhdGlvbnM6IEFkZCB0aGUgdGVzdCB0byB0aGUgZW5hYmxlZCBsaXN0LgorCiAyMDE0 LTAyLTExICBQaW90ciBHcmFkICA8cC5ncmFkQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtHU3Ry ZWFtZXJdIEhpZ2ggcGxheWJhY2sgcmF0ZSBjYXVzZXMgY3Jhc2gKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA0NDE5YjM3Li41NTQxOWFlIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC00 NzgsNiArNDc4LDcgQEAgZnVsbHNjcmVlbi9hbm9ueW1vdXMtYmxvY2stbWVyZ2UtY3Jhc2guaHRt bCBbIFBhc3MgXQogIyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2NyZWF0ZS1pbmRleC13aXRo LWludGVnZXIta2V5cy5odG1sIFsgUGFzcyBdCiAjIHN0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEv Y3Vyc29yLW11dGF0aW9uLW9iamVjdHN0b3JlLW9ubHkuaHRtbCBbIFBhc3MgXQogIyBzdG9yYWdl L2luZGV4ZWRkYi9tb3ppbGxhL2N1cnNvci1tdXRhdGlvbi5odG1sIFsgUGFzcyBdCisjIHN0b3Jh Z2UvaW5kZXhlZGRiL21vemlsbGEvY3Vyc29yLXVwZGF0ZS11cGRhdGVzLWluZGV4ZXMuaHRtbCBb IFBhc3MgXQogIyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2N1cnNvcnMuaHRtbCBbIFBhc3Mg XQogIyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2luZGV4LXByZXYtbm8tZHVwbGljYXRlLmh0 bWwgWyBQYXNzIF0KICMgc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9pbmRleGVzLmh0bWwgWyBQ YXNzIF0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwppbmRleCA4ZThhMjQ4Li5jNTMwMmJlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTQtMDItMTEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgor CisgICAgICAgIElEQjogc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9jdXJzb3ItdXBkYXRlLXVw ZGF0ZXMtaW5kZXhlcy5odG1sIEFTU0VSVHMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2MDM0 MTEyPiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODU4MQor CisgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAgKiBE YXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcDoKKyAgICAgICAg KFdlYktpdDo6VW5pcXVlSURCRGF0YWJhc2U6OmdldFJlY29yZEZyb21CYWNraW5nU3RvcmUpOiBB bHdheXMgc3RvcmUga2V5UGF0aCBmb3IgSW5kZXggZ2V0IHJlc3VsdHMuCisKIDIwMTQtMDItMTAg IENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNjM4NTYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9E YXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL1VuaXF1ZUlEQkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL0RhdGFiYXNlUHJvY2Vzcy9JbmRleGVkREIvVW5pcXVlSURCRGF0YWJhc2UuY3BwCmlu ZGV4IDdmYmFjN2IuLmM3NTc4YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0RhdGFiYXNl UHJvY2Vzcy9JbmRleGVkREIvVW5pcXVlSURCRGF0YWJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL0RhdGFiYXNlUHJvY2Vzcy9JbmRleGVkREIvVW5pcXVlSURCRGF0YWJhc2UuY3BwCkBAIC05 MzMsMTAgKzkzMyw4IEBAIHZvaWQgVW5pcXVlSURCRGF0YWJhc2U6OmdldFJlY29yZEZyb21CYWNr aW5nU3RvcmUodWludDY0X3QgcmVxdWVzdElELCBjb25zdCBJREJJCiAgICAgICAgIHJldHVybjsK ICAgICB9CiAKLSAgICAvLyBBIGdldCByZXF1ZXN0IHRoYXQgbWVldHMgdGhlIGZvbGxvd2luZyBj b25kaXRpb25zIG5lZWRzIHRvIGtub3cgdGhlIG9iamVjdCBzdG9yZSBrZXlwYXRoCi0gICAgLy8g dG8gaW5qZWN0IHRoZSByZXN1bHQga2V5IGludG8gdGhlIHJlc3VsdCB2YWx1ZSBvYmplY3QuCi0g ICAgaWYgKG9iamVjdFN0b3JlTWV0YWRhdGEuYXV0b0luY3JlbWVudCAmJiAhb2JqZWN0U3RvcmVN ZXRhZGF0YS5rZXlQYXRoLmlzTnVsbCgpKQotICAgICAgICByZXN1bHQua2V5UGF0aCA9IG9iamVj dFN0b3JlTWV0YWRhdGEua2V5UGF0aDsKKyAgICAvLyBXZSBtdXN0IHJldHVybiBhIGtleSBwYXRo IHRvIGtub3cgaG93IHRvIGluamVjdCB0aGUgcmVzdWx0IGtleSBpbnRvIHRoZSByZXN1bHQgdmFs dWUgb2JqZWN0LgorICAgIHJlc3VsdC5rZXlQYXRoID0gb2JqZWN0U3RvcmVNZXRhZGF0YS5rZXlQ YXRoOwogCiAgICAgcG9zdE1haW5UaHJlYWRUYXNrKGNyZWF0ZUFzeW5jVGFzaygqdGhpcywgJlVu aXF1ZUlEQkRhdGFiYXNlOjpkaWRHZXRSZWNvcmRGcm9tQmFja2luZ1N0b3JlLCByZXF1ZXN0SUQs IHJlc3VsdCwgMCwgU3RyaW5nKFN0cmluZ0ltcGw6OmVtcHR5KCkpKSk7CiB9Cg==