128571 2014-02-10 18:28:38 -0800 Make it possible to run tests with --llvmSimpleOpt=false 2014-02-10 18:41:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg mmirman msaboff nrotem oliver sam oldest_to_newest 979184 0 fpizlo 2014-02-10 18:28:38 -0800 This will give us coverage for when we run the full LLVM optimization pipeline. Running that full pipeline shouldn't break anything. It's good for us to know that there is no such thing as an LLVM optimization phase that breaks our assumptions. 979185 1 223783 fpizlo 2014-02-10 18:31:02 -0800 Created attachment 223783 the patch 979190 2 223783 mark.lam 2014-02-10 18:37:53 -0800 Comment on attachment 223783 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=223783&action=review > Tools/Scripts/run-jsc-stress-tests:582 > +def runFTLNoSimpleOpt > + run("ftl-no-simple-opt", "--enableConcurrentJIT=false", "--llvmSimpleOpt=false", *FTL_OPTIONS) if $enableFTL > +end I don’t see runFTLNoSimpleOpt referenced anywhere else. Is this intentional? 979191 3 fpizlo 2014-02-10 18:38:18 -0800 (In reply to comment #2) > (From update of attachment 223783 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223783&action=review > > > Tools/Scripts/run-jsc-stress-tests:582 > > +def runFTLNoSimpleOpt > > + run("ftl-no-simple-opt", "--enableConcurrentJIT=false", "--llvmSimpleOpt=false", *FTL_OPTIONS) if $enableFTL > > +end > > I don’t see runFTLNoSimpleOpt referenced anywhere else. Is this intentional? Yes. 979192 4 223783 mark.lam 2014-02-10 18:38:54 -0800 Comment on attachment 223783 the patch r=me 979194 5 fpizlo 2014-02-10 18:41:13 -0800 Landed in http://trac.webkit.org/changeset/163852 223783 2014-02-10 18:31:02 -0800 2014-02-10 18:38:54 -0800 the patch blah.patch text/plain 6384 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2Mzg0OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE0LTAyLTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgTWFrZSBpdCBwb3NzaWJsZSB0byBydW4gdGVzdHMgd2l0aCAtLWxsdm1TaW1wbGVP cHQ9ZmFsc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyODU3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAK KyAgICAgICAgVGhpcyBhbHNvIG1ha2VzIGl0IHNvIGFsbCBydW4gZnVuY3Rpb25zIGZvciB0aGUg RlRMIGFyZSBzYWZlIHRvIGNhbGwgd2l0aCBGVEwgZGlzYWJsZWQsCisgICAgICAgIGJlY2F1c2Ug dGhleSBkbyB0aGVpciBvd24gJGVuYWJsZUZUTCBjaGVjay4KKworICAgICAgICAqIFNjcmlwdHMv cnVuLWpzYy1zdHJlc3MtdGVzdHM6CisKIDIwMTQtMDItMTAgIEdhdmluIEJhcnJhY2xvdWdoICA8 YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBXS1BhZ2VTZXRWaXNpYmls aXR5U3RhdGUKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkocmV2aXNpb24gMTYz ODQ2KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkod29ya2luZyBjb3B5 KQpAQCAtNTM0LDE5ICs1MzQsMTkgQEAgZGVmIHJ1bk5vQ0pJVFZhbGlkYXRlUGhhc2VzCiBlbmQK IAogZGVmIHJ1bkRlZmF1bHRGVEwKLSAgICBydW4oImRlZmF1bHQtZnRsIiwgKkZUTF9PUFRJT05T KQorICAgIHJ1bigiZGVmYXVsdC1mdGwiLCAqRlRMX09QVElPTlMpIGlmICRlbmFibGVGVEwKIGVu ZAogCiBkZWYgcnVuRlRMTm9DSklUCi0gICAgcnVuKCJmdGwtbm8tY2ppdCIsICItLWVuYWJsZUNv bmN1cnJlbnRKSVQ9ZmFsc2UiLCAqRlRMX09QVElPTlMpCisgICAgcnVuKCJmdGwtbm8tY2ppdCIs ICItLWVuYWJsZUNvbmN1cnJlbnRKSVQ9ZmFsc2UiLCAqRlRMX09QVElPTlMpIGlmICRlbmFibGVG VEwKIGVuZAogCiBkZWYgcnVuRlRMTm9DSklUVmFsaWRhdGUKLSAgICBydW4oImZ0bC1uby1jaml0 LXZhbGlkYXRlIiwgIi0tZW5hYmxlQ29uY3VycmVudEpJVD1mYWxzZSIsICItLXZhbGlkYXRlR3Jh cGg9dHJ1ZSIsICpGVExfT1BUSU9OUykKKyAgICBydW4oImZ0bC1uby1jaml0LXZhbGlkYXRlIiwg Ii0tZW5hYmxlQ29uY3VycmVudEpJVD1mYWxzZSIsICItLXZhbGlkYXRlR3JhcGg9dHJ1ZSIsICpG VExfT1BUSU9OUykgaWYgJGVuYWJsZUZUTAogZW5kCiAKIGRlZiBydW5GVExOb0NKSVRPU1JWYWxp ZGF0aW9uCi0gICAgcnVuKCJmdGwtbm8tY2ppdC1vc3ItdmFsaWRhdGlvbiIsICItLWVuYWJsZUNv bmN1cnJlbnRKSVQ9ZmFsc2UiLCAiLS12YWxpZGF0ZUZUTE9TUkV4aXRMaXZlbmVzcz10cnVlIiwg KkZUTF9PUFRJT05TKQorICAgIHJ1bigiZnRsLW5vLWNqaXQtb3NyLXZhbGlkYXRpb24iLCAiLS1l bmFibGVDb25jdXJyZW50SklUPWZhbHNlIiwgIi0tdmFsaWRhdGVGVExPU1JFeGl0TGl2ZW5lc3M9 dHJ1ZSIsICpGVExfT1BUSU9OUykgaWYgJGVuYWJsZUZUTAogZW5kCiAKIGRlZiBydW5ERkdFYWdl cgpAQCAtNTU4LDE1ICs1NTgsMTUgQEAgZGVmIHJ1bkRGR0VhZ2VyTm9DSklUVmFsaWRhdGUKIGVu ZAogCiBkZWYgcnVuRlRMRWFnZXIKLSAgICBydW4oImZ0bC1lYWdlciIsICooRlRMX09QVElPTlMg KyBFQUdFUl9PUFRJT05TKSkKKyAgICBydW4oImZ0bC1lYWdlciIsICooRlRMX09QVElPTlMgKyBF QUdFUl9PUFRJT05TKSkgaWYgJGVuYWJsZUZUTAogZW5kCiAKIGRlZiBydW5GVExFYWdlck5vQ0pJ VFZhbGlkYXRlCi0gICAgcnVuKCJmdGwtZWFnZXItbm8tY2ppdCIsICItLWVuYWJsZUNvbmN1cnJl bnRKSVQ9ZmFsc2UiLCAiLS12YWxpZGF0ZUdyYXBoPXRydWUiLCAqKEZUTF9PUFRJT05TICsgRUFH RVJfT1BUSU9OUykpCisgICAgcnVuKCJmdGwtZWFnZXItbm8tY2ppdCIsICItLWVuYWJsZUNvbmN1 cnJlbnRKSVQ9ZmFsc2UiLCAiLS12YWxpZGF0ZUdyYXBoPXRydWUiLCAqKEZUTF9PUFRJT05TICsg RUFHRVJfT1BUSU9OUykpIGlmICRlbmFibGVGVEwKIGVuZAogCiBkZWYgcnVuRlRMRWFnZXJOb0NK SVRPU1JWYWxpZGF0aW9uCi0gICAgcnVuKCJmdGwtZWFnZXItbm8tY2ppdC1vc3ItdmFsaWRhdGlv biIsICItLWVuYWJsZUNvbmN1cnJlbnRKSVQ9ZmFsc2UiLCAiLS12YWxpZGF0ZUZUTE9TUkV4aXRM aXZlbmVzcz10cnVlIiwgKihGVExfT1BUSU9OUyArIEVBR0VSX09QVElPTlMpKQorICAgIHJ1bigi ZnRsLWVhZ2VyLW5vLWNqaXQtb3NyLXZhbGlkYXRpb24iLCAiLS1lbmFibGVDb25jdXJyZW50SklU PWZhbHNlIiwgIi0tdmFsaWRhdGVGVExPU1JFeGl0TGl2ZW5lc3M9dHJ1ZSIsICooRlRMX09QVElP TlMgKyBFQUdFUl9PUFRJT05TKSkgaWYgJGVuYWJsZUZUTAogZW5kCiAKIGRlZiBydW5BbHdheXNU cmlnZ2VyQ29weVBoYXNlCkBAIC01NzcsNiArNTc3LDEwIEBAIGRlZiBydW5Ob0NKSVROb0FTTwog ICAgIHJ1bigibm8tY2ppdC1uby1hc28iLCAiLS1lbmFibGVDb25jdXJyZW50SklUPWZhbHNlIiwg Ii0tZW5hYmxlQXJjaGl0ZWN0dXJlU3BlY2lmaWNPcHRpbWl6YXRpb25zPWZhbHNlIikKIGVuZAog CitkZWYgcnVuRlRMTm9TaW1wbGVPcHQKKyAgICBydW4oImZ0bC1uby1zaW1wbGUtb3B0IiwgIi0t ZW5hYmxlQ29uY3VycmVudEpJVD1mYWxzZSIsICItLWxsdm1TaW1wbGVPcHQ9ZmFsc2UiLCAqRlRM X09QVElPTlMpIGlmICRlbmFibGVGVEwKK2VuZAorCiBkZWYgZGVmYXVsdFJ1bgogICAgIHJ1bkRl ZmF1bHQKICAgICBydW5Ob0xMSW50CkBAIC01ODQsMjMgKzU4OCwxOSBAQCBkZWYgZGVmYXVsdFJ1 bgogICAgIHJ1bk5vQ0pJVFZhbGlkYXRlUGhhc2VzCiAgICAgcnVuREZHRWFnZXIKICAgICBydW5E RkdFYWdlck5vQ0pJVFZhbGlkYXRlCi0gICAgaWYgJGVuYWJsZUZUTAotICAgICAgICBydW5EZWZh dWx0RlRMCi0gICAgICAgIHJ1bkZUTE5vQ0pJVFZhbGlkYXRlCi0gICAgICAgIHJ1bkZUTE5vQ0pJ VE9TUlZhbGlkYXRpb24KLSAgICAgICAgcnVuRlRMRWFnZXIKLSAgICAgICAgcnVuRlRMRWFnZXJO b0NKSVRWYWxpZGF0ZQotICAgICAgICBydW5GVExFYWdlck5vQ0pJVE9TUlZhbGlkYXRpb24KLSAg ICBlbmQKKyAgICBydW5EZWZhdWx0RlRMCisgICAgcnVuRlRMTm9DSklUVmFsaWRhdGUKKyAgICBy dW5GVExOb0NKSVRPU1JWYWxpZGF0aW9uCisgICAgcnVuRlRMRWFnZXIKKyAgICBydW5GVExFYWdl ck5vQ0pJVFZhbGlkYXRlCisgICAgcnVuRlRMRWFnZXJOb0NKSVRPU1JWYWxpZGF0aW9uCiBlbmQK IAogZGVmIGRlZmF1bHRRdWlja1J1bgogICAgIHJ1bkRlZmF1bHQKICAgICBydW5Ob0NKSVRWYWxp ZGF0ZQotICAgIGlmICRlbmFibGVGVEwKLSAgICAgICAgcnVuRGVmYXVsdEZUTAotICAgICAgICBy dW5GVExOb0NKSVQKLSAgICBlbmQKKyAgICBydW5EZWZhdWx0RlRMCisgICAgcnVuRlRMTm9DSklU CiBlbmQKIAogIyBUaGlzIGlzIGV4cGVjdGVkIHRvIG5vdCBkbyBlYWdlciBydW5zIGJlY2F1c2Ug ZWFnZXIgcnVucyBjYW4gaGF2ZSBhIGxvdCBvZiByZWNvbXBpbGF0aW9ucwpAQCAtNjU2LDE1ICs2 NTYsMTUgQEAgZGVmIHJ1bkxheW91dFRlc3RERkdFYWdlck5vQ0pJVAogZW5kCiAKIGRlZiBydW5M YXlvdXRUZXN0RGVmYXVsdEZUTAotICAgIHJ1bkxheW91dFRlc3QoImZ0bCIsICItLXRlc3RUaGVG VEw9dHJ1ZSIsICpGVExfT1BUSU9OUykKKyAgICBydW5MYXlvdXRUZXN0KCJmdGwiLCAiLS10ZXN0 VGhlRlRMPXRydWUiLCAqRlRMX09QVElPTlMpIGlmICRlbmFibGVGVEwKIGVuZAogCiBkZWYgcnVu TGF5b3V0VGVzdEZUTE5vQ0pJVAotICAgIHJ1bkxheW91dFRlc3QoImZ0bC1uby1jaml0IiwgIi0t dGVzdFRoZUZUTD10cnVlIiwgIi0tZW5hYmxlQ29uY3VycmVudEpJVD1mYWxzZSIsICpGVExfT1BU SU9OUykKKyAgICBydW5MYXlvdXRUZXN0KCJmdGwtbm8tY2ppdCIsICItLXRlc3RUaGVGVEw9dHJ1 ZSIsICItLWVuYWJsZUNvbmN1cnJlbnRKSVQ9ZmFsc2UiLCAqRlRMX09QVElPTlMpIGlmICRlbmFi bGVGVEwKIGVuZAogCiBkZWYgcnVuTGF5b3V0VGVzdEZUTEVhZ2VyTm9DSklUCi0gICAgcnVuTGF5 b3V0VGVzdCgiZnRsLWVhZ2VyLW5vLWNqaXQiLCAiLS10ZXN0VGhlRlRMPXRydWUiLCAiLS1lbmFi bGVDb25jdXJyZW50SklUPWZhbHNlIiwgKihGVExfT1BUSU9OUyArIEVBR0VSX09QVElPTlMpKQor ICAgIHJ1bkxheW91dFRlc3QoImZ0bC1lYWdlci1uby1jaml0IiwgIi0tdGVzdFRoZUZUTD10cnVl IiwgIi0tZW5hYmxlQ29uY3VycmVudEpJVD1mYWxzZSIsICooRlRMX09QVElPTlMgKyBFQUdFUl9P UFRJT05TKSkgaWYgJGVuYWJsZUZUTAogZW5kCiAKIGRlZiBub0ZUTFJ1bkxheW91dFRlc3QKQEAg LTY3NiwxMSArNjc2LDkgQEAgZW5kCiAKIGRlZiBkZWZhdWx0UnVuTGF5b3V0VGVzdAogICAgIG5v RlRMUnVuTGF5b3V0VGVzdAotICAgIGlmICRlbmFibGVGVEwKLSAgICAgICAgcnVuTGF5b3V0VGVz dERlZmF1bHRGVEwKLSAgICAgICAgcnVuTGF5b3V0VGVzdEZUTE5vQ0pJVAotICAgICAgICBydW5M YXlvdXRUZXN0RlRMRWFnZXJOb0NKSVQKLSAgICBlbmQKKyAgICBydW5MYXlvdXRUZXN0RGVmYXVs dEZUTAorICAgIHJ1bkxheW91dFRlc3RGVExOb0NKSVQKKyAgICBydW5MYXlvdXRUZXN0RlRMRWFn ZXJOb0NKSVQKIGVuZAogCiBkZWYgcHJlcGFyZUV4dHJhUmVsYXRpdmVGaWxlcyhleHRyYUZpbGVz LCBkZXN0aW5hdGlvbikKQEAgLTczNyw3ICs3MzUsNyBAQCBkZWYgcnVuTW96aWxsYVRlc3REZWZh dWx0KG1vZGUsICpleHRyYUZpCiBlbmQKIAogZGVmIHJ1bk1vemlsbGFUZXN0RGVmYXVsdEZUTCht b2RlLCAqZXh0cmFGaWxlcykKLSAgICBydW5Nb3ppbGxhVGVzdCgiZnRsIiwgbW9kZSwgZXh0cmFG aWxlcywgKkZUTF9PUFRJT05TKQorICAgIHJ1bk1vemlsbGFUZXN0KCJmdGwiLCBtb2RlLCBleHRy YUZpbGVzLCAqRlRMX09QVElPTlMpIGlmICRlbmFibGVGVEwKIGVuZAogCiBkZWYgcnVuTW96aWxs YVRlc3RMTEludChtb2RlLCAqZXh0cmFGaWxlcykKQEAgLTc1Myw3ICs3NTEsNyBAQCBkZWYgcnVu TW96aWxsYVRlc3RERkdFYWdlck5vQ0pJVFZhbGlkYXRlCiBlbmQKIAogZGVmIHJ1bk1vemlsbGFU ZXN0RlRMRWFnZXJOb0NKSVRWYWxpZGF0ZVBoYXNlcyhtb2RlLCAqZXh0cmFGaWxlcykKLSAgICBy dW5Nb3ppbGxhVGVzdCgiZnRsLWVhZ2VyLW5vLWNqaXQtdmFsaWRhdGUtcGhhc2VzIiwgbW9kZSwg ZXh0cmFGaWxlcywgIi0tZW5hYmxlQ29uY3VycmVudEpJVD1mYWxzZSIsICItLXZhbGlkYXRlQnl0 ZWNvZGU9dHJ1ZSIsICItLXZhbGlkYXRlR3JhcGhBdEVhY2hQaGFzZT10cnVlIiwgKihGVExfT1BU SU9OUyArIEVBR0VSX09QVElPTlMpKQorICAgIHJ1bk1vemlsbGFUZXN0KCJmdGwtZWFnZXItbm8t Y2ppdC12YWxpZGF0ZS1waGFzZXMiLCBtb2RlLCBleHRyYUZpbGVzLCAiLS1lbmFibGVDb25jdXJy ZW50SklUPWZhbHNlIiwgIi0tdmFsaWRhdGVCeXRlY29kZT10cnVlIiwgIi0tdmFsaWRhdGVHcmFw aEF0RWFjaFBoYXNlPXRydWUiLCAqKEZUTF9PUFRJT05TICsgRUFHRVJfT1BUSU9OUykpIGlmICRl bmFibGVGVEwKIGVuZAogCiBkZWYgZGVmYXVsdFJ1bk1vemlsbGFUZXN0KG1vZGUsICpleHRyYUZp bGVzKQpAQCAtNzYxLDEwICs3NTksOCBAQCBkZWYgZGVmYXVsdFJ1bk1vemlsbGFUZXN0KG1vZGUs ICpleHRyYUZpCiAgICAgcnVuTW96aWxsYVRlc3RMTEludChtb2RlLCAqZXh0cmFGaWxlcykKICAg ICBydW5Nb3ppbGxhVGVzdEJhc2VsaW5lSklUKG1vZGUsICpleHRyYUZpbGVzKQogICAgIHJ1bk1v emlsbGFUZXN0REZHRWFnZXJOb0NKSVRWYWxpZGF0ZVBoYXNlcyhtb2RlLCAqZXh0cmFGaWxlcykK LSAgICBpZiAkZW5hYmxlRlRMCi0gICAgICAgIHJ1bk1vemlsbGFUZXN0RGVmYXVsdEZUTChtb2Rl LCAqZXh0cmFGaWxlcykKLSAgICAgICAgcnVuTW96aWxsYVRlc3RGVExFYWdlck5vQ0pJVFZhbGlk YXRlUGhhc2VzKG1vZGUsICpleHRyYUZpbGVzKQotICAgIGVuZAorICAgIHJ1bk1vemlsbGFUZXN0 RGVmYXVsdEZUTChtb2RlLCAqZXh0cmFGaWxlcykKKyAgICBydW5Nb3ppbGxhVGVzdEZUTEVhZ2Vy Tm9DSklUVmFsaWRhdGVQaGFzZXMobW9kZSwgKmV4dHJhRmlsZXMpCiBlbmQKIAogZGVmIHNraXAK