128565 2014-02-10 16:31:35 -0800 [WK2] Add support for image document viewport configuration 2014-02-10 17:05:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin simon.fraser oldest_to_newest 979137 0 benjamin 2014-02-10 16:31:35 -0800 [WK2] Add support for image document viewport configuration 979141 1 223768 benjamin 2014-02-10 16:33:16 -0800 Created attachment 223768 Patch 979142 2 223768 simon.fraser 2014-02-10 16:36:51 -0800 Comment on attachment 223768 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223768&action=review > Source/WebCore/page/ViewportConfiguration.h:87 > + static Parameters imageParameters(); I'd call these textDocumentParamters, imageDocumentParameters. > Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm:269 > IntPoint PageClientImpl::screenToWindow(const IntPoint& point) > { > - notImplemented(); > - return IntPoint(); > + return IntPoint([m_view convertPoint:point fromView:nil]); > } > > IntRect PageClientImpl::windowToScreen(const IntRect& rect) > { > - notImplemented(); > - return IntRect(); > + return enclosingIntRect([m_view convertRect:rect toView:nil]); > } Are these changes related to the patch? 979150 3 benjamin 2014-02-10 17:05:37 -0800 Committed r163839: <http://trac.webkit.org/changeset/163839> 223768 2014-02-10 16:33:16 -0800 2014-02-10 16:36:51 -0800 Patch bug-128565-20140210163315.patch text/plain 5795 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzODE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTRiZGE2MTkxNWYyMTBh MDhiN2E2NTU1YzM2Y2IxZDBhY2U4YjdkMi4uNzc5YzM4ZmZlYTE5MmZhMjA2MWE5YTAyMWIwMTRi ZmU0MjI3YmYwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAyLTEwICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIEFkZCBz dXBwb3J0IGZvciBpbWFnZSBkb2N1bWVudCB2aWV3cG9ydCBjb25maWd1cmF0aW9uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg1NjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcHJvcGVyIGRlZmF1 bHQgc2V0dGluZ3MgZm9yIGRpc3BsYXlpbmcgaW1hZ2VzLgorCisgICAgICAgICogV2ViQ29yZS5l eHAuaW46CisgICAgICAgICogcGFnZS9WaWV3cG9ydENvbmZpZ3VyYXRpb24uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Vmlld3BvcnRDb25maWd1cmF0aW9uOjppbWFnZVBhcmFtZXRlcnMpOgorICAg ICAgICAqIHBhZ2UvVmlld3BvcnRDb25maWd1cmF0aW9uLmg6CisKIDIwMTQtMDItMTAgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgdW51 c2VkIGZ1bmN0aW9ucyBmcm9tIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDc4 M2I4MzBjZTIwMzBjM2I4ZGU4NzY1ODRjYmE0NjM2YTJhN2Q5NjMuLjRiMzJlYmRiYjQ3NGI3YWY4 ZTVmNjc2NWEyMDQ1NzI4YzEyZTRiZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAx NC0wMi0xMCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAorICAgICAg ICBbV0syXSBBZGQgc3VwcG9ydCBmb3IgaW1hZ2UgZG9jdW1lbnQgdmlld3BvcnQgY29uZmlndXJh dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4 NTY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbToKKyAgICAgICAgKFdlYktpdDo6 UGFnZUNsaWVudEltcGw6OnNjcmVlblRvV2luZG93KToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNs aWVudEltcGw6OndpbmRvd1RvU2NyZWVuKToKKyAgICAgICAgQWRkIHRoZSBpbXBsZW1lbnRhdGlv biBmb3IgSW1hZ2VEb2N1bWVudC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6ZGlkQ29tbWl0TG9hZCk6CisgICAg ICAgIFVzZSB0aGUgcmlnaHQgZGVmYXVsdCBzZXR0aW5ncyB3aGVuIGRlYWxpbmcgd2l0aCBpbWFn ZSBkb2N1bWVudHMuCisKKzIwMTQtMDItMTAgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBh cHBsZS5jb20+CisKICAgICAgICAgW2lPU11bV0syXSBBZGQgZW1wdHkgZGVmaW5pdGlvbiBmb3Ig YW4gQVBJIGFsbG93aW5nIGNsaWVudHMgdG8gZGVmaW5lIG9ic2N1cmVkIGVkZ2VzIG92ZXIgdGhl IHNjcm9sbHZpZXcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyODM5NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbiBi L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCmluZGV4IGU5MTMzZWYwMTA0Mzc4ZTg0ZjBm YmI1ZmRiNzMyNTc1Y2I3ZTFkYzIuLjJjYjJiNzJhM2FkM2VlMWUzZWE0YTEwMDVhZDRkZTVlYTYy ZjhlODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCisrKyBiL1Nv dXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCkBAIC04NDgsNiArODQ4LDcgQEAgX19aTjdXZWJD b3JlMjFTZXJpYWxpemVkU2NyaXB0VmFsdWVDMUVSTjNXVEY2VmVjdG9ySWhMbTBFTlMxXzE1Q3Jh c2hPbk92ZXJmbG93RUUKIF9fWk43V2ViQ29yZTIxU2VyaWFsaXplZFNjcmlwdFZhbHVlRDFFdgog X19aTjdXZWJDb3JlMjFVUkxCeVJlbW92aW5nVXNlckluZm9FUDVOU1VSTAogX19aTjdXZWJDb3Jl MjFVc2VyQ29udGVudFVSTFBhdHRlcm41cGFyc2VFUktOM1dURjZTdHJpbmdFCitfX1pON1dlYkNv cmUyMVZpZXdwb3J0Q29uZmlndXJhdGlvbjE1aW1hZ2VQYXJhbWV0ZXJzRXYKIF9fWk43V2ViQ29y ZTIxVmlld3BvcnRDb25maWd1cmF0aW9uMTVzZXRDb250ZW50c1NpemVFUktOU183SW50U2l6ZUUK IF9fWk43V2ViQ29yZTIxVmlld3BvcnRDb25maWd1cmF0aW9uMTd3ZWJwYWdlUGFyYW1ldGVyc0V2 CiBfX1pON1dlYkNvcmUyMVZpZXdwb3J0Q29uZmlndXJhdGlvbjE5cGxhaW5UZXh0UGFyYW1ldGVy c0V2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1ZpZXdwb3J0Q29uZmlndXJhdGlv bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1ZpZXdwb3J0Q29uZmlndXJhdGlvbi5jcHAKaW5k ZXggMDJmMjc4MTI2ZGE1ZDE3OThhOTRkM2U1NzRmMzI4NDVlOGM5OGFiOC4uMDg2OWU2Nzg3ZTc3 OTU1ZmExMDdiOTFlNjQ3NTQ4MGIwNGEzYjU0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9WaWV3cG9ydENvbmZpZ3VyYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv Vmlld3BvcnRDb25maWd1cmF0aW9uLmNwcApAQCAtMTY5LDYgKzE2OSwxNyBAQCBWaWV3cG9ydENv bmZpZ3VyYXRpb246OlBhcmFtZXRlcnMgVmlld3BvcnRDb25maWd1cmF0aW9uOjpwbGFpblRleHRQ YXJhbWV0ZXJzKCkKICAgICByZXR1cm4gcGFyYW1ldGVyczsKIH0KIAorVmlld3BvcnRDb25maWd1 cmF0aW9uOjpQYXJhbWV0ZXJzIFZpZXdwb3J0Q29uZmlndXJhdGlvbjo6aW1hZ2VQYXJhbWV0ZXJz KCkKK3sKKyAgICBQYXJhbWV0ZXJzIHBhcmFtZXRlcnM7CisgICAgcGFyYW1ldGVycy53aWR0aCA9 IDk4MDsKKyAgICBwYXJhbWV0ZXJzLndpZHRoSXNTZXQgPSB0cnVlOworICAgIHBhcmFtZXRlcnMu YWxsb3dzVXNlclNjYWxpbmcgPSB0cnVlOworICAgIHBhcmFtZXRlcnMubWluaW11bVNjYWxlID0g MC4wMTsKKyAgICBwYXJhbWV0ZXJzLm1heGltdW1TY2FsZSA9IDU7CisgICAgcmV0dXJuIHBhcmFt ZXRlcnM7Cit9CisKIHN0YXRpYyBpbmxpbmUgYm9vbCB2aWV3cG9ydEFyZ3VtZW50VmFsdWVJc1Zh bGlkKGZsb2F0IHZhbHVlKQogewogICAgIHJldHVybiB2YWx1ZSA+IDA7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wYWdlL1ZpZXdwb3J0Q29uZmlndXJhdGlvbi5oIGIvU291cmNlL1dlYkNv cmUvcGFnZS9WaWV3cG9ydENvbmZpZ3VyYXRpb24uaAppbmRleCBhNzgzYjI0NTcxNDdiNDBiZjhj ZDRlYzc0MTE1ZjAxZGYwNDIzZjUyLi45ZDYxM2YwMTMxMjZmMjMwMDJlODA2MThhZjhkN2M3ZmM4 NTIzYjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1ZpZXdwb3J0Q29uZmlndXJh dGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVmlld3BvcnRDb25maWd1cmF0aW9uLmgK QEAgLTg0LDYgKzg0LDcgQEAgcHVibGljOgogCiAgICAgc3RhdGljIFBhcmFtZXRlcnMgd2VicGFn ZVBhcmFtZXRlcnMoKTsKICAgICBzdGF0aWMgUGFyYW1ldGVycyBwbGFpblRleHRQYXJhbWV0ZXJz KCk7CisgICAgc3RhdGljIFBhcmFtZXRlcnMgaW1hZ2VQYXJhbWV0ZXJzKCk7CiAKIHByaXZhdGU6 CiAgICAgdm9pZCB1cGRhdGVDb25maWd1cmF0aW9uKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbSBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLm1tCmluZGV4IGE2MzM4NDk3 MWZkZjg4NThkNTE4YzNlN2JiNmQxYTI1ODZiMzhmYjMuLjdhOGNiNDM3MzI1NTU5YjY2M2Y5YTdm YzQzZDYwZTA1YTViMjQ4MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLm1tCkBAIC0yNjAsMTQgKzI2MCwxMiBAQCBGbG9h dFJlY3QgUGFnZUNsaWVudEltcGw6OmNvbnZlcnRUb1VzZXJTcGFjZShjb25zdCBGbG9hdFJlY3Qm IHJlY3QpCiAKIEludFBvaW50IFBhZ2VDbGllbnRJbXBsOjpzY3JlZW5Ub1dpbmRvdyhjb25zdCBJ bnRQb2ludCYgcG9pbnQpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gSW50 UG9pbnQoKTsKKyAgICByZXR1cm4gSW50UG9pbnQoW21fdmlldyBjb252ZXJ0UG9pbnQ6cG9pbnQg ZnJvbVZpZXc6bmlsXSk7CiB9CiAKIEludFJlY3QgUGFnZUNsaWVudEltcGw6OndpbmRvd1RvU2Ny ZWVuKGNvbnN0IEludFJlY3QmIHJlY3QpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICBy ZXR1cm4gSW50UmVjdCgpOworICAgIHJldHVybiBlbmNsb3NpbmdJbnRSZWN0KFttX3ZpZXcgY29u dmVydFJlY3Q6cmVjdCB0b1ZpZXc6bmlsXSk7CiB9CiAKIHZvaWQgUGFnZUNsaWVudEltcGw6OmRv bmVXaXRoS2V5RXZlbnQoY29uc3QgTmF0aXZlV2ViS2V5Ym9hcmRFdmVudCYsIGJvb2wpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggNzg0N2Ri NjUzYWRiYTMxZDdlOWFjNmZjZGFkN2YzYjBmMTVkNDI0MC4uMDk3ZDI5ZWU1NzVmZjZmOWY4YWM4 NDNhZTA3NDUxMDVlNTk4MGE1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcApAQCAtMzk1OSw3ICszOTU5LDEwIEBAIHZvaWQgV2ViUGFnZTo6ZGlk Q29tbWl0TG9hZChXZWJGcmFtZSogZnJhbWUpCiAjaWYgUExBVEZPUk0oSU9TKQogICAgIG1fdXNl ckhhc0NoYW5nZWRQYWdlU2NhbGVGYWN0b3IgPSBmYWxzZTsKIAotICAgIGlmIChmcmFtZS0+Y29y ZUZyYW1lKCktPmRvY3VtZW50KCktPmlzVGV4dERvY3VtZW50KCkpCisgICAgRG9jdW1lbnQqIGRv Y3VtZW50ID0gZnJhbWUtPmNvcmVGcmFtZSgpLT5kb2N1bWVudCgpOworICAgIGlmIChkb2N1bWVu dC0+aXNJbWFnZURvY3VtZW50KCkpCisgICAgICAgIG1fdmlld3BvcnRDb25maWd1cmF0aW9uLnNl dERlZmF1bHRDb25maWd1cmF0aW9uKFZpZXdwb3J0Q29uZmlndXJhdGlvbjo6aW1hZ2VQYXJhbWV0 ZXJzKCkpOworICAgIGVsc2UgaWYgKGRvY3VtZW50LT5pc1RleHREb2N1bWVudCgpKQogICAgICAg ICBtX3ZpZXdwb3J0Q29uZmlndXJhdGlvbi5zZXREZWZhdWx0Q29uZmlndXJhdGlvbihWaWV3cG9y dENvbmZpZ3VyYXRpb246OnBsYWluVGV4dFBhcmFtZXRlcnMoKSk7CiAgICAgZWxzZQogICAgICAg ICBtX3ZpZXdwb3J0Q29uZmlndXJhdGlvbi5zZXREZWZhdWx0Q29uZmlndXJhdGlvbihWaWV3cG9y dENvbmZpZ3VyYXRpb246OndlYnBhZ2VQYXJhbWV0ZXJzKCkpOwo=