12856 2007-02-22 10:48:38 -0800 REGRESSION (r13685): Canceling the suggestion popup does not revert the change 2007-02-23 19:07:27 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 mitz webkit-unassigned ap justin.garcia oldest_to_newest 22260 0 mitz 2007-02-22 10:48:38 -0800 In editable HTML (including form controls), if you type a prefix such as "thr" and press F5 to bring up the completions popup, then press Esc to cancel, the chosen completion is not reverted and remains in the text. Moreover, if one of the completions is the empty string (e.g. if the prefix is "the") and you choose a non-empty completion in the popup then choose the empty completion, the last chosen completion isn't erased. This bug was introduced in <http://trac.webkit.org/projects/webkit/changeset/13685>. 22259 1 13317 mitz 2007-02-22 10:56:45 -0800 Created attachment 13317 Patch The change affects one editing test in an insignificant way. 22035 2 13317 mjs 2007-02-22 19:24:16 -0800 Comment on attachment 13317 Patch r=me (would be nice to add a manual test) 21874 3 sam 2007-02-23 19:07:27 -0800 Landed in r19837. 13317 2007-02-22 10:56:45 -0800 2007-02-22 19:24:16 -0800 Patch 12856_r1.patch text/plain 2883 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5Nzk0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDItMjIgIE1pdHogUGV0dGVsICA8bWl0 ekB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIC0gdXBkYXRlZCB0ZXN0IHJlc3VsdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI4NTYKKyAgICAgICAgICBSRUdSRVNTSU9OIChyMTM2ODUpOiBDYW5j ZWxpbmcgdGhlIHN1Z2dlc3Rpb24gcG9wdXAgZG9lcyBub3QgcmV2ZXJ0IHRoZSBjaGFuZ2UKKwor ICAgICAgICAqIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLTM4MDA4MzQtZml4LWV4cGVjdGVkLnR4 dDoKKwogMjAwNy0wMi0yMSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5n L2RlbGV0aW5nL2RlbGV0ZS0zODAwODM0LWZpeC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvZWRpdGluZy9kZWxldGluZy9kZWxldGUtMzgwMDgzNC1maXgtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAxOTc5MCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZGVsZXRpbmcvZGVs ZXRlLTM4MDA4MzQtZml4LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMzgsNSArMzgs NCBAQCBsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKICAgICAgICAgUmVuZGVyQmxvY2sgKGFu b255bW91cykgYXQgKDE0LDQyKSBzaXplIDc1NngwCiAgICAgICAgIFJlbmRlckJsb2NrIChhbm9u eW1vdXMpIGF0ICgxNCw0Mikgc2l6ZSA3NTZ4MAogICAgICAgICAgIFJlbmRlcklubGluZSB7U1BB Tn0gYXQgKDAsMCkgc2l6ZSAweDAKLSAgICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAs MCkgc2l6ZSAweDAKIGNhcmV0OiBwb3NpdGlvbiAzIG9mIGNoaWxkIDAgeyN0ZXh0fSBvZiBjaGls ZCAxIHtTUEFOfSBvZiBjaGlsZCAxIHtESVZ9IG9mIGNoaWxkIDEge0JPRFl9IG9mIGNoaWxkIDAg e0hUTUx9IG9mIGRvY3VtZW50CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk3OTQpCisrKyBXZWJDb3JlL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDA3LTAyLTIyICBNaXR6IFBldHRl bCAgPG1pdHpAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAtIGZpeCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjg1NgorICAgICAgICAgIFJFR1JFU1NJT04gKHIxMzY4NSk6IENhbmNlbGluZyB0aGUgc3Vn Z2VzdGlvbiBwb3B1cCBkb2VzIG5vdCByZXZlcnQgdGhlIGNoYW5nZQorCisgICAgICAgICogZWRp dGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXBs YWNlU2VsZWN0aW9uQ29tbWFuZDo6ZG9BcHBseSk6IElmIHRoZSBmcmFnbWVudCB0byBiZSBpbnNl cnRlZAorICAgICAgICBpcyBlbXB0eSwgZmlyc3QgZGVsZXRlIHRoZSBzZWxlY3Rpb24sIGFuZCBv bmx5IHRoZW4gYmFpbCBvdXQuIAorCiAyMDA3LTAyLTIyICBaYWNrIFJ1c2luICA8enJ1c2luQHRy b2xsdGVjaC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFycwpJbmRleDogV2ViQ29yZS9l ZGl0aW5nL1JlcGxhY2VTZWxlY3Rpb25Db21tYW5kLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQuY3BwCShyZXZpc2lvbiAxOTc5MCkKKysr IFdlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQ3OSw5ICs0NzksNiBAQCB2b2lkIFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjpkb0Fw cGx5KCkKICAgICBFbGVtZW50KiBjdXJyZW50Um9vdCA9IHNlbGVjdGlvbi5yb290RWRpdGFibGVF bGVtZW50KCk7CiAgICAgUmVwbGFjZW1lbnRGcmFnbWVudCBmcmFnbWVudChkb2N1bWVudCgpLCBt X2RvY3VtZW50RnJhZ21lbnQuZ2V0KCksIG1fbWF0Y2hTdHlsZSwgc2VsZWN0aW9uKTsKICAgICAK LSAgICBpZiAoZnJhZ21lbnQuaXNFbXB0eSgpKQotICAgICAgICByZXR1cm47Ci0gICAgCiAgICAg aWYgKG1fbWF0Y2hTdHlsZSkKICAgICAgICAgbV9pbnNlcnRpb25TdHlsZSA9IHN0eWxlQXRQb3Np dGlvbihzZWxlY3Rpb24uc3RhcnQoKSk7CiAgICAgCkBAIC01NzQsNyArNTcxLDcgQEAgdm9pZCBS ZXBsYWNlU2VsZWN0aW9uQ29tbWFuZDo6ZG9BcHBseSgpCiAgICAgc2V0VHlwaW5nU3R5bGUoMCk7 ICAgIAogICAgIAogICAgIC8vIFdlJ3JlIGZpbmlzaGVkIGlmIHRoZXJlIGlzIG5vdGhpbmcgdG8g YWRkLgotICAgIGlmICghZnJhZ21lbnQuZmlyc3RDaGlsZCgpKQorICAgIGlmIChmcmFnbWVudC5p c0VtcHR5KCkgfHwgIWZyYWdtZW50LmZpcnN0Q2hpbGQoKSkKICAgICAgICAgcmV0dXJuOwogICAg IAogICAgIC8vIDEpIEluc2VydCB0aGUgY29udGVudC4K